[{"id":29724,"web_url":"https://patchwork.libcamera.org/comment/29724/","msgid":"<585c95cf-8047-40b7-a8b0-ce25eec2afd8@ideasonboard.com>","date":"2024-06-01T22:14:53","subject":"Re: [PATCH v2 4/6] test: fence: Increase timeout for fence test","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"On 29/05/2024 16:43, Laurent Pinchart wrote:\n> On slower machines, a 1s timeout to capture frames with vimc can be too\n> short and cause test failures. Make the timeout proportional to the\n> number of frames expected to be captured, using a conservative low\n> estimate of the frame rate at 2fps.\n>\n> By itself, that change could increase the test time quite substantially\n> on fast platforms, so break from the capture loop as soon as we capture\n> enough frames.\n>\n> Signed-off-by: Laurent Pinchart \nReviewed-by: Daniel Scally \n> ---\n> Changes since v1:\n>\n> - Update comment\n> ---\n> test/fence.cpp | 10 +++++++---\n> 1 file changed, 7 insertions(+), 3 deletions(-)\n>\n> diff --git a/test/fence.cpp b/test/fence.cpp\n> index a8fba7284d82..8095b22895c7 100644\n> --- a/test/fence.cpp\n> +++ b/test/fence.cpp\n> @@ -327,10 +327,14 @@ int FenceTest::run()\n> \tTimer fenceTimer;\n> \tfenceTimer.timeout.connect(this, &FenceTest::signalFence);\n> \n> -\t/* Loop for one second. */\n> +\t/*\n> +\t * Loop long enough for all requests to complete, allowing 500ms per\n> +\t * request.\n> +\t */\n> \tTimer timer;\n> -\ttimer.start(1000ms);\n> -\twhile (timer.isRunning() && expectedCompletionResult_) {\n> +\ttimer.start(500ms * (signalledRequestId_ + 1));\n> +\twhile (timer.isRunning() && expectedCompletionResult_ &&\n> +\t completedRequestId_ <= signalledRequestId_ + 1) {\n> \t\tif (completedRequestId_ == signalledRequestId_ - 1 && setFence_)\n> \t\t\t/*\n> \t\t\t * The request just before signalledRequestId_ has just","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 967B1BD87C\n\tfor ;\n\tSat, 1 Jun 2024 22:14:59 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EE26F634BA;\n\tSun, 2 Jun 2024 00:14:58 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EB4AE61A46\n\tfor ;\n\tSun, 2 Jun 2024 00:14:56 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C0584CC\n\tfor ;\n\tSun, 2 Jun 2024 00:14:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"kUaGfnvH\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717280091;\n\tbh=Z6LhYT+WtbizkViz8Ek16D3gUC7grI996n+SyiZtK78=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=kUaGfnvHm1up+iPBQpOLCU8rbjx5IPi/0zTuy31bchAbcc/VLLtS1xIQ6+RtJRio0\n\t53cw0FEHHOqm9+32BLrKSHOUuV60wdsE3f3//IQ5tZosA4TRq/uSvrJmUnvAn1W5u2\n\tyTHI4ZF+EzyXM3HFjPARi3Xrff4k5TvkVXRWRk50=","Message-ID":"<585c95cf-8047-40b7-a8b0-ce25eec2afd8@ideasonboard.com>","Date":"Sat, 1 Jun 2024 23:14:53 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 4/6] test: fence: Increase timeout for fence test","To":"libcamera-devel@lists.libcamera.org","References":"<20240529154341.10426-1-laurent.pinchart@ideasonboard.com>\n\t<20240529154341.10426-5-laurent.pinchart@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240529154341.10426-5-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29739,"web_url":"https://patchwork.libcamera.org/comment/29739/","msgid":"<171740470669.1000377.4890076366494745307@ping.linuxembedded.co.uk>","date":"2024-06-03T08:51:46","subject":"Re: [PATCH v2 4/6] test: fence: Increase timeout for fence test","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-05-29 16:43:39)\n> On slower machines, a 1s timeout to capture frames with vimc can be too\n> short and cause test failures. Make the timeout proportional to the\n> number of frames expected to be captured, using a conservative low\n> estimate of the frame rate at 2fps.\n> \n> By itself, that change could increase the test time quite substantially\n> on fast platforms, so break from the capture loop as soon as we capture\n> enough frames.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> Changes since v1:\n> \n> - Update comment\n> ---\n> test/fence.cpp | 10 +++++++---\n> 1 file changed, 7 insertions(+), 3 deletions(-)\n> \n> diff --git a/test/fence.cpp b/test/fence.cpp\n> index a8fba7284d82..8095b22895c7 100644\n> --- a/test/fence.cpp\n> +++ b/test/fence.cpp\n> @@ -327,10 +327,14 @@ int FenceTest::run()\n> Timer fenceTimer;\n> fenceTimer.timeout.connect(this, &FenceTest::signalFence);\n> \n> - /* Loop for one second. */\n> + /*\n> + * Loop long enough for all requests to complete, allowing 500ms per\n> + * request.\n> + */\n\nReviewed-by: Kieran Bingham \n\n> Timer timer;\n> - timer.start(1000ms);\n> - while (timer.isRunning() && expectedCompletionResult_) {\n> + timer.start(500ms * (signalledRequestId_ + 1));\n> + while (timer.isRunning() && expectedCompletionResult_ &&\n> + completedRequestId_ <= signalledRequestId_ + 1) {\n> if (completedRequestId_ == signalledRequestId_ - 1 && setFence_)\n> /*\n> * The request just before signalledRequestId_ has just\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 26AA4BD87C\n\tfor ;\n\tMon, 3 Jun 2024 08:51:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 21419634CA;\n\tMon, 3 Jun 2024 10:51:51 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 23C8F61A3B\n\tfor ;\n\tMon, 3 Jun 2024 10:51:50 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 174C4B53;\n\tMon, 3 Jun 2024 10:51:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cjrM6RkM\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1717404703;\n\tbh=9ZXMdooIISTd/12D7tqEFEVGC2cx9YBIg4uVg8kS6w4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=cjrM6RkMJgatrWuIbLTKx2ePpfYfgAzaKSGIY+vsL2M/ariuPNoAK2pPDPAWAZO3Y\n\tC03OTzxuvbmaqR35BgomTsrBT39yr8EGCTWHomwN/HJq6Mm3+hkgDhujniwGuu0Flk\n\to71akyjQ5EELptVkttFB/oP5a9XAMblNnWPfVhHY=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240529154341.10426-5-laurent.pinchart@ideasonboard.com>","References":"<20240529154341.10426-1-laurent.pinchart@ideasonboard.com>\n\t<20240529154341.10426-5-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH v2 4/6] test: fence: Increase timeout for fence test","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 03 Jun 2024 09:51:46 +0100","Message-ID":"<171740470669.1000377.4890076366494745307@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]