[{"id":29631,"web_url":"https://patchwork.libcamera.org/comment/29631/","msgid":"<171690668829.2248009.3553455254246847045@ping.linuxembedded.co.uk>","date":"2024-05-28T14:31:28","subject":"Re: [CI] [PATCH 1/2] Enable compilation of the Android camera HAL","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-05-27 18:40:15)\n> Expend compilation test coverage by enabling the Android camera HAL in\n\nExtend? Expand?\n\n> test builds. This requires adding the cmake package to the container\n> images, as it is needed to build the libyuv subproject. Debian buster\n> ships a too old cmake version, so disable the Android HAL compilation\n> there.\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> .gitlab-ci/setup-container.sh | 1 +\n> gitlab-ci.yml | 10 +++++++---\n> 2 files changed, 8 insertions(+), 3 deletions(-)\n> \n> diff --git a/.gitlab-ci/setup-container.sh b/.gitlab-ci/setup-container.sh\n> index 6f75c3209eb7..fc3c0568bf7c 100755\n> --- a/.gitlab-ci/setup-container.sh\n> +++ b/.gitlab-ci/setup-container.sh\n> @@ -34,6 +34,7 @@ PKGS_LIBCAMERA_CBUILD=(\n> PKGS_LIBCAMERA_RUNTIME=(\n> clang\n> clang-format\n> + cmake\n> doxygen\n> g++\n> ghostscript\n> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> index 60e52deac520..465931a761fc 100644\n> --- a/gitlab-ci.yml\n> +++ b/gitlab-ci.yml\n> @@ -12,6 +12,7 @@ variables:\n> GIT_DEPTH: 1\n> KERNEL_VERSION: '6.6'\n> MESON_ALL_OPTIONS: >-\n> + -D android=enabled\n> -D cam=enabled\n> -D documentation=enabled\n> -D gstreamer=enabled\n> @@ -58,17 +59,17 @@ include:\n> .libcamera-ci.debian:11:\n> variables:\n> FDO_DISTRIBUTION_VERSION: 'bullseye'\n> - FDO_DISTRIBUTION_TAG: '2024-05-07.1'\n> + FDO_DISTRIBUTION_TAG: '2024-05-27.0'\n> \n> .libcamera-ci.debian:12:\n> variables:\n> FDO_DISTRIBUTION_VERSION: 'bookworm'\n> - FDO_DISTRIBUTION_TAG: '2024-04-18.0'\n> + FDO_DISTRIBUTION_TAG: '2024-05-27.0'\n> \n> .libcamera-ci.debian:13:\n> variables:\n> FDO_DISTRIBUTION_VERSION: 'trixie'\n> - FDO_DISTRIBUTION_TAG: '2024-04-18.0'\n> + FDO_DISTRIBUTION_TAG: '2024-05-27.0'\n> \n> .container-debian:\n> extends:\n> @@ -159,6 +160,9 @@ build-full:debian:10:\n> ARCH: amd64\n> CC: gcc-8\n> CXX: g++-8\n> + MESON_OPTIONS: >-\n> + ${MESON_ALL_OPTIONS}\n> + -D android=disabled\n\nI would suggest we add a comment above build-full:debian:10: to say\n\"Android is disabled as the packaged cmake is too old\"\n\nBut we don't have comments on these two either\n\n - build-full:debian:12: # Ensure documentation builds warning free\n - build-full:debian:13: # Provide compile testing for C++20\n\nwhich also modify the MESON_OPTIONS so I think it's probably fine as is.\n\nReviewed-by: Kieran Bingham \n\n> \n> build-full:debian:11:\n> extends:\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DD8B6BDE6B\n\tfor ;\n\tTue, 28 May 2024 14:31:33 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D5B76634B0;\n\tTue, 28 May 2024 16:31:32 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57CF861A41\n\tfor ;\n\tTue, 28 May 2024 16:31:31 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 44FE7B53;\n\tTue, 28 May 2024 16:31:28 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Zw7X/52A\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716906688;\n\tbh=cvBKARDnRtR1j9VBvHr+zdbmccE1rHwnHEB4e4B9dvQ=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=Zw7X/52ADh+aWk+3xx9bq4cCe3QNSjMEF9hAqSpt5F2w5+sGJUZwZSQlWhwwE/tHw\n\tj5Y2uFglnEWBo3Zl5ZiHJIxndb7kdyuLORL3h2nf08nqOUWZFhtSgSMJ7KsnTKtPWX\n\t9WO+ArzSr4gmcEl52f0QKDb3UqIweGPLR5XDywzo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240527174016.11415-2-laurent.pinchart@ideasonboard.com>","References":"<20240527174016.11415-1-laurent.pinchart@ideasonboard.com>\n\t<20240527174016.11415-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [CI] [PATCH 1/2] Enable compilation of the Android camera HAL","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 28 May 2024 15:31:28 +0100","Message-ID":"<171690668829.2248009.3553455254246847045@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]