{"id":20084,"url":"https://patchwork.libcamera.org/api/patches/20084/?format=json","web_url":"https://patchwork.libcamera.org/patch/20084/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240522145438.436688-3-stefan.klug@ideasonboard.com>","date":"2024-05-22T14:54:36","name":"[v2,2/4] libcamera: Add gamma control id","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"8c2942eb3bd3f6dbff3e33e08ec402c5e233c2c7","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20084/mbox/","series":[{"id":4321,"url":"https://patchwork.libcamera.org/api/series/4321/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4321","date":"2024-05-22T14:54:34","name":"libcamera: Add gamma control for rkisp1","version":2,"mbox":"https://patchwork.libcamera.org/series/4321/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20084/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20084/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DB856BD87C\n\tfor ;\n\tWed, 22 May 2024 14:55:03 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 91D9363490;\n\tWed, 22 May 2024 16:55:03 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4523D63492\n\tfor ;\n\tWed, 22 May 2024 16:55:01 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:9beb:c30d:4413:8c99])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 630EAABE;\n\tWed, 22 May 2024 16:54:48 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"n/ZViwQ9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716389688;\n\tbh=RFEDvH9SP97LtiGrQ4eBonFrHzcEbaVasLfGJIl/zJs=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=n/ZViwQ9wH2R2z4kdB4yWEc72dGXL7AVIRwflPo7BErFFXEFg/0ZWEDv0oQSYh2X7\n\tChudlANVgXLHt1x+YmlHKv7/jJrGbEG3+abO9Aipin8NS5zL2d0Mdmd4zj6KqRFBnl\n\tKbeunsAxdIT+1VU0ufBN2ohAvmFAC/Ru+qIq4F1k=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ,\n\tDaniel Scally ","Subject":"[PATCH v2 2/4] libcamera: Add gamma control id","Date":"Wed, 22 May 2024 16:54:36 +0200","Message-Id":"<20240522145438.436688-3-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.40.1","In-Reply-To":"<20240522145438.436688-1-stefan.klug@ideasonboard.com>","References":"<20240522145438.436688-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"A camera gamma of roughly 2.2 is necessary to produce correct output\nimages on a standard monitor. Add a control for that.\n\nFurther information is available here:\nhttps://en.wikipedia.org/wiki/SRGB\nhttps://www.cambridgeincolour.com/tutorials/gamma-correction.htm\n\nSigned-off-by: Stefan Klug \nReviewed-by: Daniel Scally \n---\n\nv1 -> v2:\n- small change in description\n\n src/libcamera/control_ids_core.yaml | 7 +++++++\n 1 file changed, 7 insertions(+)","diff":"diff --git a/src/libcamera/control_ids_core.yaml b/src/libcamera/control_ids_core.yaml\nindex bf1f1a83..303b0d32 100644\n--- a/src/libcamera/control_ids_core.yaml\n+++ b/src/libcamera/control_ids_core.yaml\n@@ -243,6 +243,13 @@ controls:\n Specify a fixed contrast parameter. Normal contrast is given by the\n value 1.0; larger values produce images with more contrast.\n \n+ - Gamma:\n+ type: float\n+ description: |\n+ Specify a fixed gamma value. Default must be 2.2 which closely mimics \n+ sRGB gamma. Note that this is camera gamma, so it is applied as \n+ 1.0/gamma\n+\n - Lux:\n type: float\n description: |\n","prefixes":["v2","2/4"]}