[{"id":29559,"web_url":"https://patchwork.libcamera.org/comment/29559/","msgid":"<171619908682.2248009.11779472249403713957@ping.linuxembedded.co.uk>","date":"2024-05-20T09:58:06","subject":"Re: [PATCH v1] ipa: rpi: awb: Fix incorrect parameter retrieval","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Barnabás Pőcze (2024-05-20 04:50:22)\n> During the refactoring in the mentioned commit the quotation\n> marks around the word *fast* were missed. Unfortunately there\n> was a variable named *fast* and an suitable overload for `operator[]`\n> for things to compile fine.\n\nOuch!\n\n> Fixes: c1597f98965461 (\"ipa: raspberrypi: Use YamlParser to replace dependency on boost\")\n\nAnd this has been in for quite some time, Great find!\n\n\nReviewed-by: Kieran Bingham \n\n\n> Signed-off-by: Barnabás Pőcze \n> ---\n> src/ipa/rpi/controller/rpi/awb.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\n> index abe5906e..94ecbfc2 100644\n> --- a/src/ipa/rpi/controller/rpi/awb.cpp\n> +++ b/src/ipa/rpi/controller/rpi/awb.cpp\n> @@ -161,7 +161,7 @@ int AwbConfig::read(const libcamera::YamlObject ¶ms)\n> bayes = false;\n> }\n> }\n> - fast = params[fast].get(bayes); /* default to fast for Bayesian, otherwise slow */\n> + fast = params[\"fast\"].get(bayes); /* default to fast for Bayesian, otherwise slow */\n> whitepointR = params[\"whitepoint_r\"].get(0.0);\n> whitepointB = params[\"whitepoint_b\"].get(0.0);\n> if (bayes == false)\n> -- \n> 2.45.1\n> \n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 77729BD78E\n\tfor ;\n\tMon, 20 May 2024 09:58:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C12B16347E;\n\tMon, 20 May 2024 11:58:13 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 551F161A55\n\tfor ;\n\tMon, 20 May 2024 11:58:10 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C1BBEE39;\n\tMon, 20 May 2024 11:57:58 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BImfVqPo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716199078;\n\tbh=/bWTu0PqNF5wjNotOvfCAdzAQP7Co1WYHGy16ESZaq4=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=BImfVqPodL7MLNihpcIlUfqeSdlKrYaOVc9CqbopkrqY9QMT5Plnm4PYJjL4qVKYJ\n\tmPJ24kPhJ/Tjta/+EtAndE849mG+Qb44DX6tD5jLvJ9/FkfiG1rRMroWlb3m7zPiZ7\n\tYnp82KYCjbacMMKRe6CN1ySDz2FTn2J8o6kh+zyo=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240520035021.205171-1-pobrn@protonmail.com>","References":"<20240520035021.205171-1-pobrn@protonmail.com>","Subject":"Re: [PATCH v1] ipa: rpi: awb: Fix incorrect parameter retrieval","From":"Kieran Bingham ","To":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ,\n\tlibcamera-devel@lists.libcamera.org,\n\tNaushir Patuck , david.plowman@raspberrypi.com, ","Date":"Mon, 20 May 2024 10:58:06 +0100","Message-ID":"<171619908682.2248009.11779472249403713957@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29566,"web_url":"https://patchwork.libcamera.org/comment/29566/","msgid":"<810b834e-3239-4a76-bf12-6ca498dc4e5a@ideasonboard.com>","date":"2024-05-20T10:57:51","subject":"Re: [PATCH v1] ipa: rpi: awb: Fix incorrect parameter retrieval","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"On 20/05/2024 10:58, Kieran Bingham wrote:\n> Quoting Barnabás Pőcze (2024-05-20 04:50:22)\n>> During the refactoring in the mentioned commit the quotation\n>> marks around the word *fast* were missed. Unfortunately there\n>> was a variable named *fast* and an suitable overload for `operator[]`\n>> for things to compile fine.\n> Ouch!\n>\n>> Fixes: c1597f98965461 (\"ipa: raspberrypi: Use YamlParser to replace dependency on boost\")\n> And this has been in for quite some time, Great find!\n>\n>\n> Reviewed-by: Kieran Bingham \n\nGreat spot indeed.\n\n\nReviewed-by: Daniel Scally \n\n>\n>\n>> Signed-off-by: Barnabás Pőcze \n>> ---\n>> src/ipa/rpi/controller/rpi/awb.cpp | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\n>> index abe5906e..94ecbfc2 100644\n>> --- a/src/ipa/rpi/controller/rpi/awb.cpp\n>> +++ b/src/ipa/rpi/controller/rpi/awb.cpp\n>> @@ -161,7 +161,7 @@ int AwbConfig::read(const libcamera::YamlObject ¶ms)\n>> bayes = false;\n>> }\n>> }\n>> - fast = params[fast].get(bayes); /* default to fast for Bayesian, otherwise slow */\n>> + fast = params[\"fast\"].get(bayes); /* default to fast for Bayesian, otherwise slow */\n>> whitepointR = params[\"whitepoint_r\"].get(0.0);\n>> whitepointB = params[\"whitepoint_b\"].get(0.0);\n>> if (bayes == false)\n>> -- \n>> 2.45.1\n>>\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9FB7BBD78E\n\tfor ;\n\tMon, 20 May 2024 10:57:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2ADED63482;\n\tMon, 20 May 2024 12:57:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5989563471\n\tfor ;\n\tMon, 20 May 2024 12:57:54 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE07D581\n\tfor ;\n\tMon, 20 May 2024 12:57:42 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FFnNj12/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716202663;\n\tbh=k5OzqsaP4mmTy6puPyUMdQQMYWqUEzy2f0xCczGJhkE=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=FFnNj12/5jPikXdxLn9vPvdAtdd6HziHWiPuvAfj+eYyVryJ5x8DzuWQuOGa47igB\n\tfqX8Hhz2OZCqM80ClNLZUv8D6BBqAtMYWan7/m8r+hLOJnXahwJKHJATsjANpfW2w3\n\tYyffln/1XFF/34Cf3/M8w4pNamuHm1eyZFN2bkn0=","Message-ID":"<810b834e-3239-4a76-bf12-6ca498dc4e5a@ideasonboard.com>","Date":"Mon, 20 May 2024 11:57:51 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v1] ipa: rpi: awb: Fix incorrect parameter retrieval","To":"libcamera-devel@lists.libcamera.org","References":"<20240520035021.205171-1-pobrn@protonmail.com>\n\t<171619908682.2248009.11779472249403713957@ping.linuxembedded.co.uk>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<171619908682.2248009.11779472249403713957@ping.linuxembedded.co.uk>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29569,"web_url":"https://patchwork.libcamera.org/comment/29569/","msgid":"<171620804646.2248009.14088333873531001350@ping.linuxembedded.co.uk>","date":"2024-05-20T12:27:26","subject":"Re: [PATCH v1] ipa: rpi: awb: Fix incorrect parameter retrieval","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Dan Scally (2024-05-20 11:57:51)\n> \n> On 20/05/2024 10:58, Kieran Bingham wrote:\n> > Quoting Barnabás Pőcze (2024-05-20 04:50:22)\n> >> During the refactoring in the mentioned commit the quotation\n> >> marks around the word *fast* were missed. Unfortunately there\n> >> was a variable named *fast* and an suitable overload for `operator[]`\n> >> for things to compile fine.\n> > Ouch!\n> >\n> >> Fixes: c1597f98965461 (\"ipa: raspberrypi: Use YamlParser to replace dependency on boost\")\n> > And this has been in for quite some time, Great find!\n> >\n> >\n> > Reviewed-by: Kieran Bingham \n> \n> Great spot indeed.\n> \n> \n> Reviewed-by: Daniel Scally \n\nhttps://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1181634 : success : patchwork/4317\n\nCI passes here, but I'll hold off to give RPi time to check here before\nmerging, but I believe this is good to go already.\n\n--\nKieran\n\n\n\n\n> \n> >\n> >\n> >> Signed-off-by: Barnabás Pőcze \n> >> ---\n> >> src/ipa/rpi/controller/rpi/awb.cpp | 2 +-\n> >> 1 file changed, 1 insertion(+), 1 deletion(-)\n> >>\n> >> diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\n> >> index abe5906e..94ecbfc2 100644\n> >> --- a/src/ipa/rpi/controller/rpi/awb.cpp\n> >> +++ b/src/ipa/rpi/controller/rpi/awb.cpp\n> >> @@ -161,7 +161,7 @@ int AwbConfig::read(const libcamera::YamlObject ¶ms)\n> >> bayes = false;\n> >> }\n> >> }\n> >> - fast = params[fast].get(bayes); /* default to fast for Bayesian, otherwise slow */\n> >> + fast = params[\"fast\"].get(bayes); /* default to fast for Bayesian, otherwise slow */\n> >> whitepointR = params[\"whitepoint_r\"].get(0.0);\n> >> whitepointB = params[\"whitepoint_b\"].get(0.0);\n> >> if (bayes == false)\n> >> -- \n> >> 2.45.1\n> >>\n> >>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A82F9BD78E\n\tfor ;\n\tMon, 20 May 2024 12:27:31 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B94D163480;\n\tMon, 20 May 2024 14:27:30 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0956A6346B\n\tfor ;\n\tMon, 20 May 2024 14:27:30 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91FA9593;\n\tMon, 20 May 2024 14:27:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"crNQPck4\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716208038;\n\tbh=JhjpzAKIQHS8+FU/DDE7dUCw3pKzOIAMC56EKurk7EE=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=crNQPck4DKBdBM919AJ2A/59qE9DM9XnawS4vSRAjIYjdOysFbivr/cnkDADVwlxH\n\tCqdvJMCV8AK6qUBhPXyordZHlFdJxjI+HkBlMu9FXf35sWQ5FJQR5nBjkXab7qSjP+\n\tatEEFy36uLvyYrcW7qyCoPpp45h4DG/4HO/X0Vtk=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<810b834e-3239-4a76-bf12-6ca498dc4e5a@ideasonboard.com>","References":"<20240520035021.205171-1-pobrn@protonmail.com>\n\t<171619908682.2248009.11779472249403713957@ping.linuxembedded.co.uk>\n\t<810b834e-3239-4a76-bf12-6ca498dc4e5a@ideasonboard.com>","Subject":"Re: [PATCH v1] ipa: rpi: awb: Fix incorrect parameter retrieval","From":"Kieran Bingham ","To":"Dan Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 20 May 2024 13:27:26 +0100","Message-ID":"<171620804646.2248009.14088333873531001350@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29573,"web_url":"https://patchwork.libcamera.org/comment/29573/","msgid":"","date":"2024-05-20T12:57:59","subject":"Re: [PATCH v1] ipa: rpi: awb: Fix incorrect parameter retrieval","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi all,\n\nOn Mon, 20 May 2024 at 13:27, Kieran Bingham\n wrote:\n>\n> Quoting Dan Scally (2024-05-20 11:57:51)\n> >\n> > On 20/05/2024 10:58, Kieran Bingham wrote:\n> > > Quoting Barnabás Pőcze (2024-05-20 04:50:22)\n> > >> During the refactoring in the mentioned commit the quotation\n> > >> marks around the word *fast* were missed. Unfortunately there\n> > >> was a variable named *fast* and an suitable overload for `operator[]`\n> > >> for things to compile fine.\n> > > Ouch!\n> > >\n> > >> Fixes: c1597f98965461 (\"ipa: raspberrypi: Use YamlParser to replace dependency on boost\")\n> > > And this has been in for quite some time, Great find!\n> > >\n> > >\n> > > Reviewed-by: Kieran Bingham \n> >\n> > Great spot indeed.\n\nIndeed, good find. In fact, it took a few minutes to understand what\nthat statement was actually doing. It turns out, the fast config\nparam is never ever used in our algorithm. So while this fix is\ncorrect, we probably will actually remove the statement entirely.\n\nRegards,\nNaush\n\n\n> >\n> >\n> > Reviewed-by: Daniel Scally \n>\n> https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1181634 : success : patchwork/4317\n>\n> CI passes here, but I'll hold off to give RPi time to check here before\n> merging, but I believe this is good to go already.\n>\n> --\n> Kieran\n>\n>\n>\n>\n> >\n> > >\n> > >\n> > >> Signed-off-by: Barnabás Pőcze \n> > >> ---\n> > >> src/ipa/rpi/controller/rpi/awb.cpp | 2 +-\n> > >> 1 file changed, 1 insertion(+), 1 deletion(-)\n> > >>\n> > >> diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\n> > >> index abe5906e..94ecbfc2 100644\n> > >> --- a/src/ipa/rpi/controller/rpi/awb.cpp\n> > >> +++ b/src/ipa/rpi/controller/rpi/awb.cpp\n> > >> @@ -161,7 +161,7 @@ int AwbConfig::read(const libcamera::YamlObject ¶ms)\n> > >> bayes = false;\n> > >> }\n> > >> }\n> > >> - fast = params[fast].get(bayes); /* default to fast for Bayesian, otherwise slow */\n> > >> + fast = params[\"fast\"].get(bayes); /* default to fast for Bayesian, otherwise slow */\n> > >> whitepointR = params[\"whitepoint_r\"].get(0.0);\n> > >> whitepointB = params[\"whitepoint_b\"].get(0.0);\n> > >> if (bayes == false)\n> > >> --\n> > >> 2.45.1\n> > >>\n> > >>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0BA83BD78E\n\tfor ;\n\tMon, 20 May 2024 12:58:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F358963480;\n\tMon, 20 May 2024 14:58:39 +0200 (CEST)","from mail-yw1-x1134.google.com (mail-yw1-x1134.google.com\n\t[IPv6:2607:f8b0:4864:20::1134])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 4E7476346B\n\tfor ;\n\tMon, 20 May 2024 14:58:37 +0200 (CEST)","by mail-yw1-x1134.google.com with SMTP id\n\t00721157ae682-61ae4743d36so23814987b3.2\n\tfor ;\n\tMon, 20 May 2024 05:58:37 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"ifaXh7dg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1716209916; x=1716814716;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=CeNFLK0IKZcr+3vceI7Lb8wdTsiaUQK4u/h0YXYt+1s=;\n\tb=ifaXh7dg2+Hx8Fsn26yweeFZU5GVLDYGjGppTmGsr2Noh2EUrZUIHex68b12HpJruT\n\tF+i4xp2pnptRt4VoDCnM6akD8RApzt6cHCS9RcaQAFj5SQr69f7gXc2iZSaV2Ax8Vocg\n\tE3i8Sf8bJvCvw07xc6jBN099XP4FYjJq8WrEwyxKpVA9OzUgaoxWAm52GhCAjxz02tzt\n\t9o4uS4DwJpYj1r6oVnecx+jNubnJTYpA9C0JYU3YLMdwjShqQHKxUBi22YNhjgLMJ5MX\n\tgI/mwMfIwnrk0T4i+NtCyqt+KZjdHZ2ZI7XezC9LEZ0Lg76n+1v2XbLQJW+jES57sfHT\n\tw1tw==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1716209916; x=1716814716;\n\th=content-transfer-encoding:cc:to:subject:message-id:date:from\n\t:in-reply-to:references:mime-version:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=CeNFLK0IKZcr+3vceI7Lb8wdTsiaUQK4u/h0YXYt+1s=;\n\tb=nXRESKa0DS7f31dF6piVKWSiXNRVwghbfDHornUVN/9jaA37eAl44gAuQMB4rsQUfI\n\tIFKlPBNiRW8ofqcB7XezrbbAQaNkVBS6eY+RyYiZM40sSnkx9SScffDNCMQR9i+wpvUL\n\tat6IFiEDVCAC/GR68rF6Px4oIcFF3qFkG12L34g626qlzTV2oGKDNuvtg2ZeYRGK3biu\n\t/g6vLcZhNX31fPS31xvSXbXbX++olt7rqJLFFEKt81iC3fsAZrYX/dTbeXS27Pq9QkSj\n\t/je2Q4V9cA1wMRsj9AZGlFHAZEgED5QaADgh7Ls3q5A923wxwwma7VsXd7Yiaf5i0b/v\n\thjuA==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCUcbZNH+Mfjz+yBV6r5SGKzdyT5x/TqW5uhKKLHHGRVtvca2fwjQPIGI1FixTtMB0IqL28ar1Wg5VcKR7bDWwiNnr91qMHSEmJRg1X7m6UlwaCLpQ==","X-Gm-Message-State":"AOJu0YxNIR9rP/xTIvk7SuOGS9V0J3uwQ2qYGsMpt0Sn2UE514V88Tug\n\tVYqIte5UngtPRg8A2/BUNRl3Pf7RHz3zaYD4rYxPirSA0iPSGbTwQMRPIfy0jER++UJTFXL66GX\n\tMEOwAREbfod0BO8GyKpNxowvvD2scARjZ3Q6TQzqLSI0WncPL","X-Google-Smtp-Source":"AGHT+IGNjytTGncJlPD3Lkv5M/MvtCgiU6Vly0eCwYXEDjLA4/lll8GrMf0aB/0Y9PXcuW3AfsBYaMwHUIDZMjCBPgw=","X-Received":"by 2002:a0d:d603:0:b0:620:34a3:da1 with SMTP id\n\t00721157ae682-622b0147ed4mr266312267b3.39.1716209915771;\n\tMon, 20 May 2024 05:58:35 -0700 (PDT)","MIME-Version":"1.0","References":"<20240520035021.205171-1-pobrn@protonmail.com>\n\t<171619908682.2248009.11779472249403713957@ping.linuxembedded.co.uk>\n\t<810b834e-3239-4a76-bf12-6ca498dc4e5a@ideasonboard.com>\n\t<171620804646.2248009.14088333873531001350@ping.linuxembedded.co.uk>","In-Reply-To":"<171620804646.2248009.14088333873531001350@ping.linuxembedded.co.uk>","From":"Naushir Patuck ","Date":"Mon, 20 May 2024 13:57:59 +0100","Message-ID":"","Subject":"Re: [PATCH v1] ipa: rpi: awb: Fix incorrect parameter retrieval","To":"Kieran Bingham ","Cc":"Dan Scally ,\n\tlibcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29577,"web_url":"https://patchwork.libcamera.org/comment/29577/","msgid":"","date":"2024-05-20T13:20:35","subject":"Re: [PATCH v1] ipa: rpi: awb: Fix incorrect parameter retrieval","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"content":"2024. május 20., hétfő 14:57 keltezéssel, Naushir Patuck írta:\n\n> Hi all,\n> \n> On Mon, 20 May 2024 at 13:27, Kieran Bingham\n> wrote:\n> >\n> > Quoting Dan Scally (2024-05-20 11:57:51)\n> > >\n> > > On 20/05/2024 10:58, Kieran Bingham wrote:\n> > > > Quoting Barnabás Pőcze (2024-05-20 04:50:22)\n> > > >> During the refactoring in the mentioned commit the quotation\n> > > >> marks around the word *fast* were missed. Unfortunately there\n> > > >> was a variable named *fast* and an suitable overload for `operator[]`\n> > > >> for things to compile fine.\n> > > > Ouch!\n> > > >\n> > > >> Fixes: c1597f98965461 (\"ipa: raspberrypi: Use YamlParser to replace dependency on boost\")\n> > > > And this has been in for quite some time, Great find!\n> > > >\n> > > >\n> > > > Reviewed-by: Kieran Bingham \n> > >\n> > > Great spot indeed.\n> \n> Indeed, good find. In fact, it took a few minutes to understand what\n> that statement was actually doing. It turns out, the fast config\n> param is never ever used in our algorithm. So while this fix is\n> correct, we probably will actually remove the statement entirely.\n\nAh, I didn't even check that but you're right; it's probably better\nto just remove it at once then instead of this change.\n\n\nRegards,\nBarnabás Pőcze\n\n> \n> Regards,\n> Naush\n> \n> \n> > >\n> > >\n> > > Reviewed-by: Daniel Scally \n> >\n> > https://gitlab.freedesktop.org/camera/libcamera/-/pipelines/1181634 : success : patchwork/4317\n> >\n> > CI passes here, but I'll hold off to give RPi time to check here before\n> > merging, but I believe this is good to go already.\n> >\n> > --\n> > Kieran\n> >\n> >\n> >\n> >\n> > >\n> > > >\n> > > >\n> > > >> Signed-off-by: Barnabás Pőcze \n> > > >> ---\n> > > >> src/ipa/rpi/controller/rpi/awb.cpp | 2 +-\n> > > >> 1 file changed, 1 insertion(+), 1 deletion(-)\n> > > >>\n> > > >> diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\n> > > >> index abe5906e..94ecbfc2 100644\n> > > >> --- a/src/ipa/rpi/controller/rpi/awb.cpp\n> > > >> +++ b/src/ipa/rpi/controller/rpi/awb.cpp\n> > > >> @@ -161,7 +161,7 @@ int AwbConfig::read(const libcamera::YamlObject ¶ms)\n> > > >> bayes = false;\n> > > >> }\n> > > >> }\n> > > >> - fast = params[fast].get(bayes); /* default to fast for Bayesian, otherwise slow */\n> > > >> + fast = params[\"fast\"].get(bayes); /* default to fast for Bayesian, otherwise slow */\n> > > >> whitepointR = params[\"whitepoint_r\"].get(0.0);\n> > > >> whitepointB = params[\"whitepoint_b\"].get(0.0);\n> > > >> if (bayes == false)\n> > > >> --\n> > > >> 2.45.1\n> > > >>\n> > > >>\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6A755BDE6B\n\tfor ;\n\tMon, 20 May 2024 13:20:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id ECAEE63481;\n\tMon, 20 May 2024 15:20:40 +0200 (CEST)","from mail-40131.protonmail.ch (mail-40131.protonmail.ch\n\t[185.70.40.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D546D63471\n\tfor ;\n\tMon, 20 May 2024 15:20:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"TnLoyut8\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1716211239; x=1716470439;\n\tbh=N0P7MsU1CeZDxjhQkpRUBeu6LJS6NjhL1Xh0HMOTSzg=;\n\th=Date:To:From:Cc:Subject:Message-ID:In-Reply-To:References:\n\tFeedback-ID:From:To:Cc:Date:Subject:Reply-To:Feedback-ID:\n\tMessage-ID:BIMI-Selector;\n\tb=TnLoyut8rW4ENFD49V6svrq5di/T2NdluWh7ARqqHb0ommC1X3At8li3+rSk5jZjc\n\tmYBtkffHU6WDSsy0/DG2cd+PHpid+mlNvFv1B0Q+PRzgrTMP8mgCpBUPAGe7QrVsVb\n\tr/o87ixNNsUbCi+ZVDTrqBSDfb8E61oHbrfvM9/mrKixg9NZD3mwKA2UufaKaasmeK\n\tXBPC1W1zn4+wbPEHl7bdd2VSaTD6pEmbbO/qLkXH1YrG6VNiXpD8k3EN98T7Eid1gq\n\th8wfhWLHMj+MGDb7CWIkXqaTW94aFJHRR/fQXRX5nVPHN5kh9tl3tizDSciuNhS4ud\n\tShNWwxRKW2t5g==","Date":"Mon, 20 May 2024 13:20:35 +0000","To":"Naushir Patuck ","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Cc":"Kieran Bingham ,\n\tDan Scally ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1] ipa: rpi: awb: Fix incorrect parameter retrieval","Message-ID":"","In-Reply-To":"","References":"<20240520035021.205171-1-pobrn@protonmail.com>\n\t<171619908682.2248009.11779472249403713957@ping.linuxembedded.co.uk>\n\t<810b834e-3239-4a76-bf12-6ca498dc4e5a@ideasonboard.com>\n\t<171620804646.2248009.14088333873531001350@ping.linuxembedded.co.uk>\n\t","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"37b5c9c24c5a8effb683413d9de49b3b0ea6970e","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]