{"id":20076,"url":"https://patchwork.libcamera.org/api/patches/20076/?format=json","web_url":"https://patchwork.libcamera.org/patch/20076/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240520035021.205171-1-pobrn@protonmail.com>","date":"2024-05-20T03:50:22","name":"[v1] ipa: rpi: awb: Fix incorrect parameter retrieval","commit_ref":null,"pull_url":null,"state":"deferred","archived":false,"hash":"07b67e6b96e952018ce83e544a68c322c0bd0826","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20076/mbox/","series":[{"id":4317,"url":"https://patchwork.libcamera.org/api/series/4317/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4317","date":"2024-05-20T03:50:22","name":"[v1] ipa: rpi: awb: Fix incorrect parameter retrieval","version":1,"mbox":"https://patchwork.libcamera.org/series/4317/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20076/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20076/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id DA6CDBD78E\n\tfor ;\n\tMon, 20 May 2024 03:50:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E36526347E;\n\tMon, 20 May 2024 05:50:27 +0200 (CEST)","from mail-4316.protonmail.ch (mail-4316.protonmail.ch\n\t[185.70.43.16])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2016361A4D\n\tfor ;\n\tMon, 20 May 2024 05:50:26 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"TurtHWxA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1716177025; x=1716436225;\n\tbh=FuETyjbQ0n7ycsn9XFfBiLRImrrCUmn3+QRUE8Rg0XM=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;\n\tb=TurtHWxAKTqsVY46FWFgPk0ES+ggV7NZU7K3VkHN8JSrcMliSJ3Ff96EVXl7gNZP7\n\t90lGUDfRHVVL2SB36MmbY2KSAuZTWpzBQfSaOz6WrzMmPafboMhjuVHAkJ9dVVfhG8\n\t6s9RlXNYk+gVdyfmLhSJ+nIhYZ7LkobEq5cb2XUQTXhO0zk3eMZPj6uTq5G4pN14H/\n\touTEpeZlE08kFLadm3Rlvw0GCHcI6U5c6S1Fp/SRClbnN1ICm3/KmhQpuDrGkL0ED8\n\tMPWCm+5jEYEjRrS9Bi/oKLLQTt+bZrEHMsVJ6pt7hMOtmDeI7f0E4BWGfA19s38ueh\n\tye884xisUi0Ag==","Date":"Mon, 20 May 2024 03:50:22 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH v1] ipa: rpi: awb: Fix incorrect parameter retrieval","Message-ID":"<20240520035021.205171-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"446d80cc64650abe79c9bfdefa598bb852ee8ff8","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"During the refactoring in the mentioned commit the quotation\nmarks around the word *fast* were missed. Unfortunately there\nwas a variable named *fast* and an suitable overload for `operator[]`\nfor things to compile fine.\n\nFixes: c1597f98965461 (\"ipa: raspberrypi: Use YamlParser to replace dependency on boost\")\nSigned-off-by: Barnabás Pőcze \n---\n src/ipa/rpi/controller/rpi/awb.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/ipa/rpi/controller/rpi/awb.cpp b/src/ipa/rpi/controller/rpi/awb.cpp\nindex abe5906e..94ecbfc2 100644\n--- a/src/ipa/rpi/controller/rpi/awb.cpp\n+++ b/src/ipa/rpi/controller/rpi/awb.cpp\n@@ -161,7 +161,7 @@ int AwbConfig::read(const libcamera::YamlObject ¶ms)\n \t\t\tbayes = false;\n \t\t}\n \t}\n-\tfast = params[fast].get(bayes); /* default to fast for Bayesian, otherwise slow */\n+\tfast = params[\"fast\"].get(bayes); /* default to fast for Bayesian, otherwise slow */\n \twhitepointR = params[\"whitepoint_r\"].get(0.0);\n \twhitepointB = params[\"whitepoint_b\"].get(0.0);\n \tif (bayes == false)\n","prefixes":["v1"]}