[{"id":29560,"web_url":"https://patchwork.libcamera.org/comment/29560/","msgid":"<171619915860.2248009.14501981315361664929@ping.linuxembedded.co.uk>","date":"2024-05-20T09:59:18","subject":"Re: [PATCH] ipa: rpi: Make monoSensor() accessor const","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-05-19 18:56:50)\n> The ipa::RPi::IpaBase::monoSensor() function doesn't modify the class.\n> Make it const.\n> \n> Fixes: 2031e2f29014 (\"ipa: rpi: Add accessor function for monoSensor_\")\n> Signed-off-by: Laurent Pinchart \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/rpi/common/ipa_base.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\n> index a95cda1ffe51..1a811beb31f2 100644\n> --- a/src/ipa/rpi/common/ipa_base.h\n> +++ b/src/ipa/rpi/common/ipa_base.h\n> @@ -49,7 +49,7 @@ public:\n> void processStats(const ProcessParams ¶ms) override;\n> \n> protected:\n> - bool monoSensor()\n> + bool monoSensor() const\n> {\n> return monoSensor_;\n> }\n> \n> base-commit: aee16c06913422a0ac84ee3217f87a9795e3c2d9\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4BC94BD78E\n\tfor ;\n\tMon, 20 May 2024 09:59:24 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D528D63480;\n\tMon, 20 May 2024 11:59:23 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DA5A161A55\n\tfor ;\n\tMon, 20 May 2024 11:59:21 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BA601E39;\n\tMon, 20 May 2024 11:59:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"QU5Rfr9R\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716199150;\n\tbh=FGqQyxXzQ2r+u4SzGdF+BKkjaZXXGXTz7DzN8ZaUIX8=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=QU5Rfr9RJTldASrzcH53xRywiWx0PRoqT3L4dMe0wvatihbfGacioQSHybOJhIuI2\n\tNTZyRH3zdVX8lU3i+9PZ89uSb6OumyuhRv6C24zCh+uVt7T8tCXV6qkwHAdJkithZJ\n\t9q0q8LS5gyOTKYxOcw3yO8SaDpjWE2SnO5q2yXqc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240519175650.17316-1-laurent.pinchart@ideasonboard.com>","References":"<20240519175650.17316-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] ipa: rpi: Make monoSensor() accessor const","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Mon, 20 May 2024 10:59:18 +0100","Message-ID":"<171619915860.2248009.14501981315361664929@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29608,"web_url":"https://patchwork.libcamera.org/comment/29608/","msgid":"","date":"2024-05-23T08:36:28","subject":"Re: [PATCH] ipa: rpi: Make monoSensor() accessor const","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi think this got from review when applying patches ?\n\nOn Sun, May 19, 2024 at 08:56:50PM GMT, Laurent Pinchart wrote:\n> The ipa::RPi::IpaBase::monoSensor() function doesn't modify the class.\n> Make it const.\n>\n> Fixes: 2031e2f29014 (\"ipa: rpi: Add accessor function for monoSensor_\")\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Jacopo Mondi \n\n> ---\n> src/ipa/rpi/common/ipa_base.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\n> index a95cda1ffe51..1a811beb31f2 100644\n> --- a/src/ipa/rpi/common/ipa_base.h\n> +++ b/src/ipa/rpi/common/ipa_base.h\n> @@ -49,7 +49,7 @@ public:\n> \tvoid processStats(const ProcessParams ¶ms) override;\n>\n> protected:\n> -\tbool monoSensor()\n> +\tbool monoSensor() const\n> \t{\n> \t\treturn monoSensor_;\n> \t}\n>\n> base-commit: aee16c06913422a0ac84ee3217f87a9795e3c2d9\n> --\n> Regards,\n>\n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14E82BD87C\n\tfor ;\n\tThu, 23 May 2024 08:36:35 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0F3CE63499;\n\tThu, 23 May 2024 10:36:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 5987A63482\n\tfor ;\n\tThu, 23 May 2024 10:36:32 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2001:b07:5d2e:52c9:cc1e:e404:491f:e6ea])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id D253321D;\n\tThu, 23 May 2024 10:36:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"nOaCNnn3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716453378;\n\tbh=ooGPmMn1pei11Aq/xFCDbnhmmiBMv7SJ3pJocevs4LY=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=nOaCNnn35S38XugHiYQLn0FXEhV0NLxEOkw8tCsVTgj5SAUv3BqLJ5I7yNNUc+U1D\n\teQirKYQgWJNIYe5jI7mkLGYNXmJUDZkscLmIHTJWV0lnoBLM3EphDD27eCCjHGuyBh\n\td5xmI2ANYd9OvF1u1+2jqgfuugbGnebDU0MUvAME=","Date":"Thu, 23 May 2024 10:36:28 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] ipa: rpi: Make monoSensor() accessor const","Message-ID":"","References":"<20240519175650.17316-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240519175650.17316-1-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]