[{"id":29554,"web_url":"https://patchwork.libcamera.org/comment/29554/","msgid":"<20240517103122.5v4jtaq4y7ffiwls@jasper>","date":"2024-05-17T10:31:22","subject":"Re: [PATCH v3 1/3] ipa: rkisp1: agc: Read histogram weights from\n\ttuning file","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Paul,\n\nthanks for the patch.\n\nOn Fri, May 17, 2024 at 05:07:59PM +0900, Paul Elder wrote:\n> Add support to the rkisp1 AGC to read histogram weights from the tuning\n> file. As controls for selecting the metering mode are not yet supported,\n> for now hardcode the matrix metering mode, which is the same as what the\n> AGC previously hardcoded.\n> \n> Signed-off-by: Paul Elder \n> \n> ---\n> Changes in v3:\n> - support the new tuning file layout for interpolated matrices\n> - support both v10 and v12\n> \n> Changes in v2:\n> - add default metering mode if none are read successfully from the\n> tuning file\n> - compute the predivider instead of using a table\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 94 ++++++++++++++++++++++++++++++-\n> src/ipa/rkisp1/algorithms/agc.h | 6 ++\n> 2 files changed, 97 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 5aad5c7c2..4af397bdc 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -17,6 +17,8 @@\n> #include \n> #include \n> \n> +#include \"libcamera/internal/yaml_parser.h\"\n> +\n> #include \"libipa/histogram.h\"\n> \n> /**\n> @@ -36,6 +38,76 @@ namespace ipa::rkisp1::algorithms {\n> \n> LOG_DEFINE_CATEGORY(RkISP1Agc)\n> \n> +int Agc::parseMeteringModes(IPAContext &context, const YamlObject &tuningData,\n> +\t\t\t const char *prop)\n> +{\n> +\tconst YamlObject &yamlMeteringModes = tuningData[prop];\n> +\tif (!yamlMeteringModes.isDictionary()) {\n> +\t\tLOG(RkISP1Agc, Error)\n> +\t\t\t<< \"'\" << prop << \"' parameter not found in tuning file\";\n> +\t\treturn -EINVAL;\n> +\t}\n> +\n> +\tfor (const auto &[key, value] : yamlMeteringModes.asDict()) {\n> +\t\tif (controls::AeMeteringModeNameValueMap.find(key) ==\n> +\t\t controls::AeMeteringModeNameValueMap.end()) {\n> +\t\t\tLOG(RkISP1Agc, Warning)\n> +\t\t\t\t<< \"Skipping unknown metering mode '\" << key << \"'\";\n> +\t\t\tcontinue;\n> +\t\t}\n> +\n> +\t\tfor (const auto &[version, matrix] : value.asDict()) {\n> +\t\t\tstd::vector weights =\n> +\t\t\t\tmatrix.getList().value_or(std::vector{});\n> +\t\t\tif (weights.size() != context.hw->numHistogramWeights)\n> +\t\t\t\tcontinue;\n> +\n> +\t\t\tLOG(RkISP1Agc, Debug)\n> +\t\t\t\t<< \"Matched metering matrix mode \"\n> +\t\t\t\t<< key << \", version \" << version;\n> +\n> +\t\t\tmeteringModes_[controls::AeMeteringModeNameValueMap.at(key)] = weights;\n> +\t\t}\n> +\t}\n> +\n> +\tif (meteringModes_.empty()) {\n> +\t\tint32_t meteringModeId = controls::AeMeteringModeNameValueMap.at(\"MeteringMatrix\");\n> +\t\tstd::vector weights(context.hw->numHistogramWeights, 1);\n> +\n> +\t\tmeteringModes_[meteringModeId] = weights;\n> +\t}\n> +\n> +\treturn 0;\n> +}\n> +\n> +uint8_t Agc::predivider(Size &size)\n> +{\n> +\t/*\n> +\t * The maximum number of pixels that could potentially be in one bin is\n> +\t * if all the pixels of the image are in it, multiplied by 3 for the\n> +\t * three color channels. The counter for each bin is 16 bits wide, so\n> +\t * `factor` thus contains the number of times we'd wrap around. This is\n> +\t * obviously the number of pixels that we need to skip to make sure\n> +\t * that we don't wrap around, but we compute the square root of it\n> +\t * instead, as the skip that we need to program is for both the x and y\n> +\t * directions.\n> +\t *\n> +\t * There's a bit of extra rounding math to make sure the rounding goes\n> +\t * the correct direction so that the square of the step is big enough\n> +\t * to encompass the `factor` number of pixels that we need to skip.\n> +\t */\n\nI like that...\n\nTHe rest look also good to me.\n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> +\tdouble factor = size.width * size.height * 3 / 65535.0;\n> +\tdouble root = std::sqrt(factor);\n> +\tuint8_t ret;\n> +\n> +\tif (std::pow(std::floor(root), 2) + 0.01 < factor)\n> +\t\tret = static_cast(std::ceil(root));\n> +\telse\n> +\t\tret = static_cast(std::floor(root));\n> +\n> +\treturn std::clamp(ret, 3, 127);\n> +}\n> +\n> Agc::Agc()\n> {\n> \tsupportsRaw_ = true;\n> @@ -59,6 +131,10 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)\n> \tif (ret)\n> \t\treturn ret;\n> \n> +\tret = parseMeteringModes(context, tuningData, \"AeMeteringMode\");\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n> \tcontext.ctrlMap.merge(controls());\n> \n> \treturn 0;\n> @@ -160,6 +236,7 @@ void Agc::prepare(IPAContext &context, const uint32_t frame,\n> \t\tframeContext.agc.gain = context.activeState.agc.automatic.gain;\n> \t}\n> \n> +\t/* \\todo Remove this when we can set the below with controls */\n> \tif (frame > 0)\n> \t\treturn;\n> \n> @@ -178,14 +255,25 @@ void Agc::prepare(IPAContext &context, const uint32_t frame,\n> \tparams->meas.hst_config.meas_window = context.configuration.agc.measureWindow;\n> \t/* Produce the luminance histogram. */\n> \tparams->meas.hst_config.mode = RKISP1_CIF_ISP_HISTOGRAM_MODE_Y_HISTOGRAM;\n> +\n> \t/* Set an average weighted histogram. */\n> \tSpan weights{\n> \t\tparams->meas.hst_config.hist_weight,\n> \t\tcontext.hw->numHistogramWeights\n> \t};\n> -\tstd::fill(weights.begin(), weights.end(), 1);\n> -\t/* Step size can't be less than 3. */\n> -\tparams->meas.hst_config.histogram_predivider = 4;\n> +\t/* \\todo Get this from control */\n> +\tstd::vector &modeWeights = meteringModes_.at(controls::MeteringMatrix);\n> +\tstd::copy(modeWeights.begin(), modeWeights.end(), weights.begin());\n> +\n> +\tstd::stringstream str;\n> +\tstr << \"Histogram weights : \";\n> +\tfor (size_t i = 0; i < context.hw->numHistogramWeights; i++)\n> +\t\tstr << (int)params->meas.hst_config.hist_weight[i] << \" \";\n> +\tLOG(RkISP1Agc, Debug) << str.str();\n> +\n> +\t/* \\todo Add a control for this? */\n> +\tparams->meas.hst_config.histogram_predivider =\n> +\t\tpredivider(context.configuration.sensor.size);\n> \n> \t/* Update the configuration for histogram. */\n> \tparams->module_cfg_update |= RKISP1_CIF_ISP_MODULE_HST;\n> diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\n> index f2f5b59d0..77d944237 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.h\n> +++ b/src/ipa/rkisp1/algorithms/agc.h\n> @@ -44,11 +44,17 @@ public:\n> \t\t ControlList &metadata) override;\n> \n> private:\n> +\tint parseMeteringModes(IPAContext &context, const YamlObject &tuningData,\n> +\t\t\t const char *prop);\n> +\tuint8_t predivider(Size &size);\n> +\n> \tvoid fillMetadata(IPAContext &context, IPAFrameContext &frameContext,\n> \t\t\t ControlList &metadata);\n> \tdouble estimateLuminance(double gain) const override;\n> \n> \tSpan expMeans_;\n> +\n> +\tstd::map> meteringModes_;\n> };\n> \n> } /* namespace ipa::rkisp1::algorithms */\n> -- \n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 28578BD78E\n\tfor ;\n\tFri, 17 May 2024 10:31:28 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2199B63481;\n\tFri, 17 May 2024 12:31:27 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 71F5363471\n\tfor ;\n\tFri, 17 May 2024 12:31:25 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:d572:8aa2:3e8e:5b99])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B45C82E;\n\tFri, 17 May 2024 12:31:16 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JCFYcic0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715941876;\n\tbh=cXF/abmujTsdScRn8Ey/4YFQm+eVSO4T9LP/7fhFyT8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=JCFYcic0wYHJOkqipHxER6NZVqJgDzRDUeardKp7CF/Z7j0d7LiUIDP4vy/BunCi4\n\tLv0o9xS5G6PvSMK06hH6bVTtFtvobBbbZ/EQ4CMWRcMCWluatGJ2nqgKhh1dmafDyb\n\tW3Mb9VK+ZU2uuxvxCfvh4VoOh5CYVeJrvnsoOpX8=","Date":"Fri, 17 May 2024 12:31:22 +0200","From":"Stefan Klug ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 1/3] ipa: rkisp1: agc: Read histogram weights from\n\ttuning file","Message-ID":"<20240517103122.5v4jtaq4y7ffiwls@jasper>","References":"<20240517080802.3896531-1-paul.elder@ideasonboard.com>\n\t<20240517080802.3896531-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240517080802.3896531-2-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29572,"web_url":"https://patchwork.libcamera.org/comment/29572/","msgid":"<7ce6f091-57e8-4411-8e4e-e163c3afb5b9@ideasonboard.com>","date":"2024-05-20T12:56:45","subject":"Re: [PATCH v3 1/3] ipa: rkisp1: agc: Read histogram weights from\n\ttuning file","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Paul\n\nOn 17/05/2024 09:07, Paul Elder wrote:\n> Add support to the rkisp1 AGC to read histogram weights from the tuning\n> file. As controls for selecting the metering mode are not yet supported,\n> for now hardcode the matrix metering mode, which is the same as what the\n> AGC previously hardcoded.\n>\n> Signed-off-by: Paul Elder \n>\n> ---\n> Changes in v3:\n> - support the new tuning file layout for interpolated matrices\n> - support both v10 and v12\n>\n> Changes in v2:\n> - add default metering mode if none are read successfully from the\n> tuning file\n> - compute the predivider instead of using a table\n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 94 ++++++++++++++++++++++++++++++-\n> src/ipa/rkisp1/algorithms/agc.h | 6 ++\n> 2 files changed, 97 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index 5aad5c7c2..4af397bdc 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -17,6 +17,8 @@\n> #include \n> #include \n> \n> +#include \"libcamera/internal/yaml_parser.h\"\n> +\n> #include \"libipa/histogram.h\"\n> \n> /**\n> @@ -36,6 +38,76 @@ namespace ipa::rkisp1::algorithms {\n> \n> LOG_DEFINE_CATEGORY(RkISP1Agc)\n> \n> +int Agc::parseMeteringModes(IPAContext &context, const YamlObject &tuningData,\n> +\t\t\t const char *prop)\nI think a comment with an example of the format that it'll parse would be good. Also; is there a \nparticular reason to have the property name as a parameter instead of just hardcoding it in here \n(rather than the caller)? Doesn't particularly matter, just curious.\n> +{\n> +\tconst YamlObject &yamlMeteringModes = tuningData[prop];\n> +\tif (!yamlMeteringModes.isDictionary()) {\n> +\t\tLOG(RkISP1Agc, Error)\n> +\t\t\t<< \"'\" << prop << \"' parameter not found in tuning file\";\n> +\t\treturn -EINVAL;\n> +\t}\n> +\n> +\tfor (const auto &[key, value] : yamlMeteringModes.asDict()) {\n> +\t\tif (controls::AeMeteringModeNameValueMap.find(key) ==\n> +\t\t controls::AeMeteringModeNameValueMap.end()) {\n> +\t\t\tLOG(RkISP1Agc, Warning)\n> +\t\t\t\t<< \"Skipping unknown metering mode '\" << key << \"'\";\n> +\t\t\tcontinue;\n> +\t\t}\n> +\n> +\t\tfor (const auto &[version, matrix] : value.asDict()) {\n> +\t\t\tstd::vector weights =\n> +\t\t\t\tmatrix.getList().value_or(std::vector{});\n> +\t\t\tif (weights.size() != context.hw->numHistogramWeights)\n> +\t\t\t\tcontinue;\n\nWorth a debug printout imo - took me a little while to figure out that this was skipping arrays of \nweights for the other hardware revision.\n\n\nWith those: Reviewed-by: Daniel Scally \n\n> +\n> +\t\t\tLOG(RkISP1Agc, Debug)\n> +\t\t\t\t<< \"Matched metering matrix mode \"\n> +\t\t\t\t<< key << \", version \" << version;\n> +\n> +\t\t\tmeteringModes_[controls::AeMeteringModeNameValueMap.at(key)] = weights;\n> +\t\t}\n> +\t}\n> +\n> +\tif (meteringModes_.empty()) {\n> +\t\tint32_t meteringModeId = controls::AeMeteringModeNameValueMap.at(\"MeteringMatrix\");\n> +\t\tstd::vector weights(context.hw->numHistogramWeights, 1);\n> +\n> +\t\tmeteringModes_[meteringModeId] = weights;\n> +\t}\n> +\n> +\treturn 0;\n> +}\n> +\n> +uint8_t Agc::predivider(Size &size)\n> +{\n> +\t/*\n> +\t * The maximum number of pixels that could potentially be in one bin is\n> +\t * if all the pixels of the image are in it, multiplied by 3 for the\n> +\t * three color channels. The counter for each bin is 16 bits wide, so\n> +\t * `factor` thus contains the number of times we'd wrap around. This is\n> +\t * obviously the number of pixels that we need to skip to make sure\n> +\t * that we don't wrap around, but we compute the square root of it\n> +\t * instead, as the skip that we need to program is for both the x and y\n> +\t * directions.\n> +\t *\n> +\t * There's a bit of extra rounding math to make sure the rounding goes\n> +\t * the correct direction so that the square of the step is big enough\n> +\t * to encompass the `factor` number of pixels that we need to skip.\n> +\t */\n> +\tdouble factor = size.width * size.height * 3 / 65535.0;\n> +\tdouble root = std::sqrt(factor);\n> +\tuint8_t ret;\n> +\n> +\tif (std::pow(std::floor(root), 2) + 0.01 < factor)\n> +\t\tret = static_cast(std::ceil(root));\n> +\telse\n> +\t\tret = static_cast(std::floor(root));\n> +\n> +\treturn std::clamp(ret, 3, 127);\n> +}\n> +\n> Agc::Agc()\n> {\n> \tsupportsRaw_ = true;\n> @@ -59,6 +131,10 @@ int Agc::init(IPAContext &context, const YamlObject &tuningData)\n> \tif (ret)\n> \t\treturn ret;\n> \n> +\tret = parseMeteringModes(context, tuningData, \"AeMeteringMode\");\n> +\tif (ret)\n> +\t\treturn ret;\n> +\n> \tcontext.ctrlMap.merge(controls());\n> \n> \treturn 0;\n> @@ -160,6 +236,7 @@ void Agc::prepare(IPAContext &context, const uint32_t frame,\n> \t\tframeContext.agc.gain = context.activeState.agc.automatic.gain;\n> \t}\n> \n> +\t/* \\todo Remove this when we can set the below with controls */\n> \tif (frame > 0)\n> \t\treturn;\n> \n> @@ -178,14 +255,25 @@ void Agc::prepare(IPAContext &context, const uint32_t frame,\n> \tparams->meas.hst_config.meas_window = context.configuration.agc.measureWindow;\n> \t/* Produce the luminance histogram. */\n> \tparams->meas.hst_config.mode = RKISP1_CIF_ISP_HISTOGRAM_MODE_Y_HISTOGRAM;\n> +\n> \t/* Set an average weighted histogram. */\n> \tSpan weights{\n> \t\tparams->meas.hst_config.hist_weight,\n> \t\tcontext.hw->numHistogramWeights\n> \t};\n> -\tstd::fill(weights.begin(), weights.end(), 1);\n> -\t/* Step size can't be less than 3. */\n> -\tparams->meas.hst_config.histogram_predivider = 4;\n> +\t/* \\todo Get this from control */\n> +\tstd::vector &modeWeights = meteringModes_.at(controls::MeteringMatrix);\n> +\tstd::copy(modeWeights.begin(), modeWeights.end(), weights.begin());\n> +\n> +\tstd::stringstream str;\n> +\tstr << \"Histogram weights : \";\n> +\tfor (size_t i = 0; i < context.hw->numHistogramWeights; i++)\n> +\t\tstr << (int)params->meas.hst_config.hist_weight[i] << \" \";\n> +\tLOG(RkISP1Agc, Debug) << str.str();\n> +\n> +\t/* \\todo Add a control for this? */\n> +\tparams->meas.hst_config.histogram_predivider =\n> +\t\tpredivider(context.configuration.sensor.size);\n> \n> \t/* Update the configuration for histogram. */\n> \tparams->module_cfg_update |= RKISP1_CIF_ISP_MODULE_HST;\n> diff --git a/src/ipa/rkisp1/algorithms/agc.h b/src/ipa/rkisp1/algorithms/agc.h\n> index f2f5b59d0..77d944237 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.h\n> +++ b/src/ipa/rkisp1/algorithms/agc.h\n> @@ -44,11 +44,17 @@ public:\n> \t\t ControlList &metadata) override;\n> \n> private:\n> +\tint parseMeteringModes(IPAContext &context, const YamlObject &tuningData,\n> +\t\t\t const char *prop);\n> +\tuint8_t predivider(Size &size);\n> +\n> \tvoid fillMetadata(IPAContext &context, IPAFrameContext &frameContext,\n> \t\t\t ControlList &metadata);\n> \tdouble estimateLuminance(double gain) const override;\n> \n> \tSpan expMeans_;\n> +\n> +\tstd::map> meteringModes_;\n> };\n> \n> } /* namespace ipa::rkisp1::algorithms */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 992F3BD78E\n\tfor ;\n\tMon, 20 May 2024 12:56:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 75A8C6347C;\n\tMon, 20 May 2024 14:56:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8600A61A58\n\tfor ;\n\tMon, 20 May 2024 14:56:48 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 20BC8593\n\tfor ;\n\tMon, 20 May 2024 14:56:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Z9R/EL5Y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716209797;\n\tbh=Y1hootrmsWJRXndUiQkWcpS5VL5hhqtZXNtICiM58Ok=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=Z9R/EL5Yk3PmThGlCUYQpcWQ+o+ZtOmTughBF9GZrDDMHCG70pvbYHveg7winNzZN\n\tURZMnr1FwxWoVaLLcrL8VbuXGq1v4aizjgF9wvM852KraS9hhvGb68LNMPNere3mVA\n\t8pAsfmEwye/NO0EkE4UdxVPYVg4zhnv6ZZawvT3U=","Message-ID":"<7ce6f091-57e8-4411-8e4e-e163c3afb5b9@ideasonboard.com>","Date":"Mon, 20 May 2024 13:56:45 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v3 1/3] ipa: rkisp1: agc: Read histogram weights from\n\ttuning file","To":"libcamera-devel@lists.libcamera.org","References":"<20240517080802.3896531-1-paul.elder@ideasonboard.com>\n\t<20240517080802.3896531-2-paul.elder@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240517080802.3896531-2-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]