[{"id":29550,"web_url":"https://patchwork.libcamera.org/comment/29550/","msgid":"<20240517095919.vxdzczzprb4264yp@jasper>","date":"2024-05-17T09:59:19","subject":"Re: [PATCH v4 2/3] ipa: libipa: Add MatrixInterpolator class","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Paul,\n\nthanks for the patch.\n\nOn Fri, May 17, 2024 at 05:01:28PM +0900, Paul Elder wrote:\n> Add a class to encapsulate the functionality of fetching a matrix based\n> on an integer key, and interpolating if there is no exact match. This is\n> expected to be used by both color correction matrices / crosstalk\n> correction as well as lens shading correction.\n> \n> Signed-off-by: Paul Elder \n\nI thinks we should merge that in now.\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> \n> ---\n> Changes in v4:\n> - remove stray semicolons\n> - read from the new yaml layout (which mirrors what we have at the\n> moment for lsc), and add keys to make it more flexible\n> \n> Changes in v3:\n> - add a constructor that takes a map of unsigned int -> matrix\n> - s/unit/identity\n> - clear matrices on reset and when reading from yaml\n> - add assert at get()\n> \n> Changes in v2:\n> - initialize to identity matrix\n> - add a function to reset to identity matrix\n> - other minor fixes\n> ---\n> src/ipa/libipa/matrix_interpolator.cpp | 54 +++++++++++\n> src/ipa/libipa/matrix_interpolator.h | 119 +++++++++++++++++++++++++\n> src/ipa/libipa/meson.build | 2 +\n> 3 files changed, 175 insertions(+)\n> create mode 100644 src/ipa/libipa/matrix_interpolator.cpp\n> create mode 100644 src/ipa/libipa/matrix_interpolator.h\n> \n> diff --git a/src/ipa/libipa/matrix_interpolator.cpp b/src/ipa/libipa/matrix_interpolator.cpp\n> new file mode 100644\n> index 000000000..fc1837e75\n> --- /dev/null\n> +++ b/src/ipa/libipa/matrix_interpolator.cpp\n> @@ -0,0 +1,54 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> +/*\n> + * Copyright (C) 2019, Raspberry Pi Ltd\n> + * Copyright (C) 2024, Paul Elder \n> + *\n> + * matrix_interpolator.cpp - Helper class for interpolating maps of matrices\n> + */\n> +#include \"matrix_interpolator.h\"\n> +\n> +#include \n> +#include \n> +\n> +#include \n> +\n> +#include \"libcamera/internal/yaml_parser.h\"\n> +\n> +#include \"matrix.h\"\n> +\n> +/**\n> + * \\file ccm.h\n> + * \\brief Helper class for interpolating maps of matrices\n> + */\n> +\n> +namespace libcamera {\n> +\n> +LOG_DEFINE_CATEGORY(MatrixInterpolator)\n> +\n> +namespace ipa {\n> +\n> +/**\n> + * \\class MatrixInterpolator\n> + * \\brief Class for storing, retrieving, and interpolating matrices\n> + */\n> +\n> +/**\n> + * \\fn int MatrixInterpolator::readYaml(const libcamera::YamlObject &yaml)\n> + * \\brief Initialize an MatrixInterpolator instance from yaml\n> + * \\tparam T Type of data stored in the matrices\n> + * \\tparam R Number of rows of the matrices\n> + * \\tparam C Number of columns of the matrices\n> + * \\param[in] yaml The yaml object that contains the map of unsigned integers to matrices\n> + * \\return Zero on success, negative error code otherwise\n> + */\n> +\n> +/**\n> + * \\fn Matrix MatrixInterpolator::get(unsigned int key)\n> + * \\brief Retrieve a matrix from the list of matrices, interpolating if necessary\n> + * \\param[in] key The unsigned integer key of the matrix to retrieve\n> + * \\return The matrix corresponding to the color temperature\n> + */\n> +\n> +} /* namespace ipa */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/libipa/matrix_interpolator.h b/src/ipa/libipa/matrix_interpolator.h\n> new file mode 100644\n> index 000000000..fb017889d\n> --- /dev/null\n> +++ b/src/ipa/libipa/matrix_interpolator.h\n> @@ -0,0 +1,119 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> +/*\n> + * Copyright (C) 2019, Raspberry Pi Ltd\n> + * Copyright (C) 2024, Paul Elder \n> + *\n> + * matrix_interpolator.h - Helper class for interpolating maps of matrices\n> + */\n> +\n> +#pragma once\n> +\n> +#include \n> +#include \n> +#include \n> +#include \n> +\n> +#include \n> +\n> +#include \"libcamera/internal/yaml_parser.h\"\n> +\n> +#include \"matrix.h\"\n> +\n> +namespace libcamera {\n> +\n> +LOG_DECLARE_CATEGORY(MatrixInterpolator)\n> +\n> +namespace ipa {\n> +\n> +template +\t std::enable_if_t> * = nullptr>\n> +class MatrixInterpolator\n> +{\n> +public:\n> +\tMatrixInterpolator()\n> +\t{\n> +\t\treset();\n> +\t}\n> +\n> +\tMatrixInterpolator(const std::map> &matrices)\n> +\t{\n> +\t\tfor (const auto &pair : matrices)\n> +\t\t\tmatrices_[pair.first] = pair.second;\n> +\t}\n> +\n> +\t~MatrixInterpolator() {}\n> +\n> +\tvoid reset()\n> +\t{\n> +\t\tMatrix identity;\n> +\t\tmatrices_.clear();\n> +\t\tmatrices_[0] = identity;\n> +\t}\n> +\n> +\tint readYaml(const libcamera::YamlObject &yaml,\n> +\t\t const std::string &key_name,\n> +\t\t const std::string &matrix_name)\n> +\t{\n> +\t\tint ret;\n> +\n> +\t\tmatrices_.clear();\n> +\n> +\t\tif (!yaml.isList()) {\n> +\t\t\tLOG(MatrixInterpolator, Error) << \"yaml object must be a list\";\n> +\t\t\treturn -EINVAL;\n> +\t\t}\n> +\n> +\t\tfor (const auto &value : yaml.asList()) {\n> +\t\t\tunsigned int ct = std::stoul(value[key_name].get(\"\"));\n> +\t\t\tMatrix matrix;\n> +\t\t\tif ((ret = matrix.readYaml(value[matrix_name])) < 0) {\n> +\t\t\t\tLOG(MatrixInterpolator, Error) << \"Failed to read matrix\";\n> +\t\t\t\treturn ret;\n> +\t\t\t}\n> +\n> +\t\t\tmatrices_[ct] = matrix;\n> +\n> +\t\t\tLOG(MatrixInterpolator, Debug)\n> +\t\t\t\t<< \"Read matrix '\" << matrix_name << \"' for key '\"\n> +\t\t\t\t<< key_name << \"' \" << ct << \": \"\n> +\t\t\t\t<< matrices_[ct].toString();\n> +\t\t}\n> +\n> +\t\tif (matrices_.size() < 1) {\n> +\t\t\tLOG(MatrixInterpolator, Error) << \"Need at least one matrix\";\n> +\t\t\treturn -EINVAL;\n> +\t\t}\n> +\n> +\t\treturn 0;\n> +\t}\n> +\n> +\tMatrix get(unsigned int ct)\n> +\t{\n> +\t\tASSERT(matrices_.size() > 0);\n> +\n> +\t\tif (matrices_.size() == 1 ||\n> +\t\t ct <= matrices_.begin()->first)\n> +\t\t\treturn matrices_.begin()->second;\n> +\n> +\t\tif (ct >= matrices_.rbegin()->first)\n> +\t\t\treturn matrices_.rbegin()->second;\n> +\n> +\t\tif (matrices_.count(ct))\n> +\t\t\treturn matrices_[ct];\n> +\n> +\t\t/* The above four guarantee that this will succeed */\n> +\t\tauto iter = matrices_.upper_bound(ct);\n> +\t\tunsigned int ctUpper = iter->first;\n> +\t\tunsigned int ctLower = (--iter)->first;\n> +\n> +\t\tdouble lambda = (ct - ctLower) / static_cast(ctUpper - ctLower);\n> +\t\treturn lambda * matrices_[ctUpper] + (1.0 - lambda) * matrices_[ctLower];\n> +\t}\n> +\n> +private:\n> +\tstd::map> matrices_;\n> +};\n> +\n> +} /* namespace ipa */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\n> index 1e34355fe..305acf641 100644\n> --- a/src/ipa/libipa/meson.build\n> +++ b/src/ipa/libipa/meson.build\n> @@ -8,6 +8,7 @@ libipa_headers = files([\n> 'fc_queue.h',\n> 'histogram.h',\n> 'matrix.h',\n> + 'matrix_interpolator.h',\n> 'module.h',\n> 'pwl.h',\n> ])\n> @@ -20,6 +21,7 @@ libipa_sources = files([\n> 'fc_queue.cpp',\n> 'histogram.cpp',\n> 'matrix.cpp',\n> + 'matrix_interpolator.cpp',\n> 'module.cpp',\n> 'pwl.cpp'\n> ])\n> -- \n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7093ABD78E\n\tfor ;\n\tFri, 17 May 2024 09:59:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7033F6347F;\n\tFri, 17 May 2024 11:59:25 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C278C61A5A\n\tfor ;\n\tFri, 17 May 2024 11:59:23 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:d572:8aa2:3e8e:5b99])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8A06482E;\n\tFri, 17 May 2024 11:59:14 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ejh03c9y\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715939954;\n\tbh=bSlEffWF8DmppXQHgZgg7DBEdLrygdDuuoSY+4qwWEs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ejh03c9yXx8HnuFjH8WAR9/iInPc2Y3VXnGlNyKHDl5h+/+kAmFdQyFfXRN7s3m+m\n\tVjZoGHevK2mvcwz2UQmfqQgi7O3OHeHcFffWw73gb40WuWmJoq5viFfuPDQYY2Y9hC\n\t6vaMQnhypOeUPhYZiG0eFgF8kxlDY5BlvEliW1BQ=","Date":"Fri, 17 May 2024 11:59:19 +0200","From":"Stefan Klug ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v4 2/3] ipa: libipa: Add MatrixInterpolator class","Message-ID":"<20240517095919.vxdzczzprb4264yp@jasper>","References":"<20240517080129.3876981-1-paul.elder@ideasonboard.com>\n\t<20240517080129.3876981-3-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240517080129.3876981-3-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29582,"web_url":"https://patchwork.libcamera.org/comment/29582/","msgid":"<99016b10-a182-4227-b319-6d219185096a@ideasonboard.com>","date":"2024-05-20T14:42:45","subject":"Re: [PATCH v4 2/3] ipa: libipa: Add MatrixInterpolator class","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Paul\n\nOn 17/05/2024 09:01, Paul Elder wrote:\n> Add a class to encapsulate the functionality of fetching a matrix based\n> on an integer key, and interpolating if there is no exact match. This is\n> expected to be used by both color correction matrices / crosstalk\n> correction as well as lens shading correction.\n>\n> Signed-off-by: Paul Elder \nThanks for the class - I think this is really useful. A few comments but only on the documentation - \nthe code itself looks good to me.\n>\n> ---\n> Changes in v4:\n> - remove stray semicolons\n> - read from the new yaml layout (which mirrors what we have at the\n> moment for lsc), and add keys to make it more flexible\n>\n> Changes in v3:\n> - add a constructor that takes a map of unsigned int -> matrix\n> - s/unit/identity\n> - clear matrices on reset and when reading from yaml\n> - add assert at get()\n>\n> Changes in v2:\n> - initialize to identity matrix\n> - add a function to reset to identity matrix\n> - other minor fixes\n> ---\n> src/ipa/libipa/matrix_interpolator.cpp | 54 +++++++++++\n> src/ipa/libipa/matrix_interpolator.h | 119 +++++++++++++++++++++++++\n> src/ipa/libipa/meson.build | 2 +\n> 3 files changed, 175 insertions(+)\n> create mode 100644 src/ipa/libipa/matrix_interpolator.cpp\n> create mode 100644 src/ipa/libipa/matrix_interpolator.h\n>\n> diff --git a/src/ipa/libipa/matrix_interpolator.cpp b/src/ipa/libipa/matrix_interpolator.cpp\n> new file mode 100644\n> index 000000000..fc1837e75\n> --- /dev/null\n> +++ b/src/ipa/libipa/matrix_interpolator.cpp\n> @@ -0,0 +1,54 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> +/*\n> + * Copyright (C) 2019, Raspberry Pi Ltd\n> + * Copyright (C) 2024, Paul Elder \n> + *\n> + * matrix_interpolator.cpp - Helper class for interpolating maps of matrices\n> + */\n> +#include \"matrix_interpolator.h\"\n> +\n> +#include \n> +#include \n> +\n> +#include \n> +\n> +#include \"libcamera/internal/yaml_parser.h\"\n> +\n> +#include \"matrix.h\"\n> +\n> +/**\n> + * \\file ccm.h\nWrong file name?\n> + * \\brief Helper class for interpolating maps of matrices\n> + */\nI would just say \"interpolating matrices\" and expand the class docu-comment a bit.\n> +\n> +namespace libcamera {\n> +\n> +LOG_DEFINE_CATEGORY(MatrixInterpolator)\n> +\n> +namespace ipa {\n> +\n> +/**\n> + * \\class MatrixInterpolator\n> + * \\brief Class for storing, retrieving, and interpolating matrices\nI think this could do with a bit of expansion - making it clear that you can pass a bunch of \nmatrices for defined colour temperatures and then asking for a matrix for a particular colour \ntemperature will give you a linear interpolation of the matrices for the adjacent cts.\n> + */\n> +\n> +/**\n> + * \\fn int MatrixInterpolator::readYaml(const libcamera::YamlObject &yaml)\n> + * \\brief Initialize an MatrixInterpolator instance from yaml\n> + * \\tparam T Type of data stored in the matrices\n> + * \\tparam R Number of rows of the matrices\n> + * \\tparam C Number of columns of the matrices\n> + * \\param[in] yaml The yaml object that contains the map of unsigned integers to matrices\n\n\nI think a code block showing the expected format would be helpful. The documentation here also \ndoesn't mention the key_name and matrix_name parameters from the actual function definition.\n\n> + * \\return Zero on success, negative error code otherwise\n> + */\n> +\n> +/**\n> + * \\fn Matrix MatrixInterpolator::get(unsigned int key)\n> + * \\brief Retrieve a matrix from the list of matrices, interpolating if necessary\n> + * \\param[in] key The unsigned integer key of the matrix to retrieve\n> + * \\return The matrix corresponding to the color temperature\n> + */\n> +\n> +} /* namespace ipa */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/libipa/matrix_interpolator.h b/src/ipa/libipa/matrix_interpolator.h\n> new file mode 100644\n> index 000000000..fb017889d\n> --- /dev/null\n> +++ b/src/ipa/libipa/matrix_interpolator.h\n> @@ -0,0 +1,119 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> +/*\n> + * Copyright (C) 2019, Raspberry Pi Ltd\n> + * Copyright (C) 2024, Paul Elder \n> + *\n> + * matrix_interpolator.h - Helper class for interpolating maps of matrices\n> + */\n\nWe dropped the filenames from the top-of-file comment.\n\n> +\n> +#pragma once\n> +\n> +#include \n> +#include \n> +#include \n> +#include \n> +\n> +#include \n> +\n> +#include \"libcamera/internal/yaml_parser.h\"\n> +\n> +#include \"matrix.h\"\n> +\n> +namespace libcamera {\n> +\n> +LOG_DECLARE_CATEGORY(MatrixInterpolator)\n> +\n> +namespace ipa {\n> +\n> +template +\t std::enable_if_t> * = nullptr>\n> +class MatrixInterpolator\n> +{\n> +public:\n> +\tMatrixInterpolator()\n> +\t{\n> +\t\treset();\n> +\t}\n> +\n> +\tMatrixInterpolator(const std::map> &matrices)\n> +\t{\n> +\t\tfor (const auto &pair : matrices)\n> +\t\t\tmatrices_[pair.first] = pair.second;\n> +\t}\n> +\n> +\t~MatrixInterpolator() {}\n> +\n> +\tvoid reset()\n> +\t{\n> +\t\tMatrix identity;\n> +\t\tmatrices_.clear();\n> +\t\tmatrices_[0] = identity;\n> +\t}\n> +\n> +\tint readYaml(const libcamera::YamlObject &yaml,\n> +\t\t const std::string &key_name,\n> +\t\t const std::string &matrix_name)\n> +\t{\n> +\t\tint ret;\n> +\n> +\t\tmatrices_.clear();\n> +\n> +\t\tif (!yaml.isList()) {\n> +\t\t\tLOG(MatrixInterpolator, Error) << \"yaml object must be a list\";\n> +\t\t\treturn -EINVAL;\n> +\t\t}\n> +\n> +\t\tfor (const auto &value : yaml.asList()) {\n> +\t\t\tunsigned int ct = std::stoul(value[key_name].get(\"\"));\n> +\t\t\tMatrix matrix;\n> +\t\t\tif ((ret = matrix.readYaml(value[matrix_name])) < 0) {\n> +\t\t\t\tLOG(MatrixInterpolator, Error) << \"Failed to read matrix\";\n> +\t\t\t\treturn ret;\n> +\t\t\t}\n> +\n> +\t\t\tmatrices_[ct] = matrix;\n> +\n> +\t\t\tLOG(MatrixInterpolator, Debug)\n> +\t\t\t\t<< \"Read matrix '\" << matrix_name << \"' for key '\"\n> +\t\t\t\t<< key_name << \"' \" << ct << \": \"\n> +\t\t\t\t<< matrices_[ct].toString();\n> +\t\t}\n> +\n> +\t\tif (matrices_.size() < 1) {\n> +\t\t\tLOG(MatrixInterpolator, Error) << \"Need at least one matrix\";\n> +\t\t\treturn -EINVAL;\n> +\t\t}\n> +\n> +\t\treturn 0;\n> +\t}\n> +\n> +\tMatrix get(unsigned int ct)\n> +\t{\n> +\t\tASSERT(matrices_.size() > 0);\n> +\n> +\t\tif (matrices_.size() == 1 ||\n> +\t\t ct <= matrices_.begin()->first)\n> +\t\t\treturn matrices_.begin()->second;\n> +\n> +\t\tif (ct >= matrices_.rbegin()->first)\n> +\t\t\treturn matrices_.rbegin()->second;\n> +\n> +\t\tif (matrices_.count(ct))\n> +\t\t\treturn matrices_[ct];\n> +\n> +\t\t/* The above four guarantee that this will succeed */\n> +\t\tauto iter = matrices_.upper_bound(ct);\n> +\t\tunsigned int ctUpper = iter->first;\n> +\t\tunsigned int ctLower = (--iter)->first;\n> +\n> +\t\tdouble lambda = (ct - ctLower) / static_cast(ctUpper - ctLower);\n> +\t\treturn lambda * matrices_[ctUpper] + (1.0 - lambda) * matrices_[ctLower];\n> +\t}\n> +\n> +private:\n> +\tstd::map> matrices_;\n> +};\n> +\n> +} /* namespace ipa */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\n> index 1e34355fe..305acf641 100644\n> --- a/src/ipa/libipa/meson.build\n> +++ b/src/ipa/libipa/meson.build\n> @@ -8,6 +8,7 @@ libipa_headers = files([\n> 'fc_queue.h',\n> 'histogram.h',\n> 'matrix.h',\n> + 'matrix_interpolator.h',\n> 'module.h',\n> 'pwl.h',\n> ])\n> @@ -20,6 +21,7 @@ libipa_sources = files([\n> 'fc_queue.cpp',\n> 'histogram.cpp',\n> 'matrix.cpp',\n> + 'matrix_interpolator.cpp',\n> 'module.cpp',\n> 'pwl.cpp'\n> ])","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 42D80BD78E\n\tfor ;\n\tMon, 20 May 2024 14:42:51 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 15CD563483;\n\tMon, 20 May 2024 16:42:50 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 95F4861A57\n\tfor ;\n\tMon, 20 May 2024 16:42:48 +0200 (CEST)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 24C7FD01\n\tfor ;\n\tMon, 20 May 2024 16:42:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"muETSVKc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1716216157;\n\tbh=tzsXO5xIdcloLhAOAy1eBKu6CgeRJYVSxm22P4dN5G8=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=muETSVKcNXJqiDPZMcvOyvw5XaPbZCyTW3mvnbISllSmcRutm4/DqP+z3Vmn4o5yz\n\tb9P0iP3QqxiXbfIbujOaKCO+11uvlrc7EX2dmzr/bDKGN5ZXdhULedU1YT6/e1xru+\n\tWMy6zfb8jqiSE1i5hJPgJxhRA7ztG4/vxkYH4VRI=","Message-ID":"<99016b10-a182-4227-b319-6d219185096a@ideasonboard.com>","Date":"Mon, 20 May 2024 15:42:45 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v4 2/3] ipa: libipa: Add MatrixInterpolator class","To":"libcamera-devel@lists.libcamera.org","References":"<20240517080129.3876981-1-paul.elder@ideasonboard.com>\n\t<20240517080129.3876981-3-paul.elder@ideasonboard.com>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<20240517080129.3876981-3-paul.elder@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]