{"id":20046,"url":"https://patchwork.libcamera.org/api/patches/20046/?format=json","web_url":"https://patchwork.libcamera.org/patch/20046/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240514180206.198938-1-pobrn@protonmail.com>","date":"2024-05-14T18:02:07","name":"[v1] gstreamer: Use copied camera name","commit_ref":"e43d2a35fa671c18dd8bae39ab21df9671b5f0a1","pull_url":null,"state":"accepted","archived":false,"hash":"928be474d3bd545d221057b9c54fa2220684d1f0","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20046/mbox/","series":[{"id":4309,"url":"https://patchwork.libcamera.org/api/series/4309/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4309","date":"2024-05-14T18:02:07","name":"[v1] gstreamer: Use copied camera name","version":1,"mbox":"https://patchwork.libcamera.org/series/4309/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20046/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20046/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5EF0BDE6B\n\tfor ;\n\tTue, 14 May 2024 18:02:14 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C17D96347E;\n\tTue, 14 May 2024 20:02:13 +0200 (CEST)","from mail-40131.protonmail.ch (mail-40131.protonmail.ch\n\t[185.70.40.131])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C982963469\n\tfor ;\n\tTue, 14 May 2024 20:02:12 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"L0XBuO9l\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1715709732; x=1715968932;\n\tbh=81fQnMoOXMbrheRcEvLXSXz2KSHxhazfMAT5iS6lImM=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;\n\tb=L0XBuO9lDRhO13UrBe3Ai/8BnWwAa02qyulPFKuSYCOl2oC98tXBdUJdWQ2j2WHui\n\tfSc9rBvTZyVGjzb1j9pG3HtU33JZ3XC4RtaUPhZIvFQ3r72f00cFGc3NbWzK74Pb5F\n\tSvJLvLkZCPFRRI0Rap4xSNpi4i2172LIocjVR8rx1BvYfrwvUApfFrAJtg/iiZRkFl\n\tEvSsRSdpxwiRMAxToFg6oOE1+bjWLmeno1vZ0D3nNC1lckZovXa9jFxZMck32lpDgB\n\tSnkaYKEUbgmZysxLUReIYfJ13lsLr1+nMQcsj6H6SeO5DOIkxU6If7JPt8n4zHvGeV\n\t7WQ7/0GnaV+hw==","Date":"Tue, 14 May 2024 18:02:07 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH v1] gstreamer: Use copied camera name","Message-ID":"<20240514180206.198938-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"81c8ef6027cd6d9ac5e817ffb6c764a416249441","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"It seems the intent is to use the copied camera name to avoid\nconcurrency problems related to `gst_libcamera_src_set_property()`.\n\nHowever, the current code makes the copy, but does not actually\nuse it. So fix that.\n\nFixes: 58feb69f852289 (\"gst: libcamerasrc: Implement selection and acquisition\")\nSigned-off-by: Barnabás Pőcze \n---\n src/gstreamer/gstlibcamerasrc.cpp | 4 ++--\n 1 file changed, 2 insertions(+), 2 deletions(-)","diff":"diff --git a/src/gstreamer/gstlibcamerasrc.cpp b/src/gstreamer/gstlibcamerasrc.cpp\nindex a284110b..9680d809 100644\n--- a/src/gstreamer/gstlibcamerasrc.cpp\n+++ b/src/gstreamer/gstlibcamerasrc.cpp\n@@ -377,10 +377,10 @@ gst_libcamera_src_open(GstLibcameraSrc *self)\n \t}\n \n \tif (camera_name) {\n-\t\tcam = cm->get(self->camera_name);\n+\t\tcam = cm->get(camera_name);\n \t\tif (!cam) {\n \t\t\tGST_ELEMENT_ERROR(self, RESOURCE, NOT_FOUND,\n-\t\t\t\t\t (\"Could not find a camera named '%s'.\", self->camera_name),\n+\t\t\t\t\t (\"Could not find a camera named '%s'.\", camera_name),\n \t\t\t\t\t (\"libcamera::CameraMananger::get() returned nullptr\"));\n \t\t\treturn false;\n \t\t}\n","prefixes":["v1"]}