{"id":20045,"url":"https://patchwork.libcamera.org/api/patches/20045/?format=json","web_url":"https://patchwork.libcamera.org/patch/20045/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240514174538.195350-1-pobrn@protonmail.com>","date":"2024-05-14T17:45:39","name":"[v1] gstreamer: Fix string memory leak","commit_ref":"f113464b3481d76dee158a00c790b44671b382b7","pull_url":null,"state":"accepted","archived":false,"hash":"c125fa11d7b0559a096373d8219e08540a66c93b","submitter":{"id":133,"url":"https://patchwork.libcamera.org/api/people/133/?format=json","name":"Pőcze Barnabás","email":"pobrn@protonmail.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20045/mbox/","series":[{"id":4308,"url":"https://patchwork.libcamera.org/api/series/4308/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4308","date":"2024-05-14T17:45:39","name":"[v1] gstreamer: Fix string memory leak","version":1,"mbox":"https://patchwork.libcamera.org/series/4308/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20045/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20045/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9BBC9BD78E\n\tfor ;\n\tTue, 14 May 2024 17:45:49 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 767BD6347E;\n\tTue, 14 May 2024 19:45:48 +0200 (CEST)","from mail-4322.protonmail.ch (mail-4322.protonmail.ch\n\t[185.70.43.22])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id B53F963469\n\tfor ;\n\tTue, 14 May 2024 19:45:47 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=protonmail.com header.i=@protonmail.com\n\theader.b=\"gAMOqpOG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=protonmail.com;\n\ts=protonmail3; t=1715708747; x=1715967947;\n\tbh=IgQ4rxu368NL6s5AEkAi/0jrwR2z5uX4GIH+urt9Y0w=;\n\th=Date:To:From:Subject:Message-ID:Feedback-ID:From:To:Cc:Date:\n\tSubject:Reply-To:Feedback-ID:Message-ID:BIMI-Selector;\n\tb=gAMOqpOGtAH6dSQ7FpxR5boVZmc+OrgRNU6k+6nzgInfYXa8UjIfPSlaiWFb2duKq\n\t2ujpjp+cwHgcjvZa7bG7NdyuqGp6Yt+0flxCZ3b35ax/EcYzyGFXpDIvFd2hJiSJGB\n\tekhXhK26YKrUH7MC00Ir9vBfgchh3c9l7B+5SYXV6SjRmYotsv0hrTVLjJmNTT75EF\n\t7PauuuoWDF6fZd+4f17t0dnuJtF57MMncuBYC4/+4zYHeR4pOC56rLqREiIjf5T/lI\n\tCnYfUnFiexDSeIk0Tj6/Fdyx6eo3WiILyqIfVek4X2iSMuDswg0BQWZrX/RwaEP+2M\n\tHgcXccOcspdbw==","Date":"Tue, 14 May 2024 17:45:39 +0000","To":"libcamera-devel@lists.libcamera.org","From":"=?utf-8?q?Barnab=C3=A1s_P=C5=91cze?= ","Subject":"[PATCH v1] gstreamer: Fix string memory leak","Message-ID":"<20240514174538.195350-1-pobrn@protonmail.com>","Feedback-ID":"20568564:user:proton","X-Pm-Message-ID":"7264eecf5c3b52db2a90d0817b292d409cddd2b2","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Transfer-Encoding":"quoted-printable","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The string returned by `gst_video_colorimetry_to_string()`\nhas to be freed, this was missing.\n\nFixes: fc9783acc6083a (\"gstreamer: Provide colorimetry <> ColorSpace mappings\")\nSigned-off-by: Barnabás Pőcze \n---\n src/gstreamer/gstlibcamera-utils.cpp | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)","diff":"diff --git a/src/gstreamer/gstlibcamera-utils.cpp b/src/gstreamer/gstlibcamera-utils.cpp\nindex e163ce41..ec4da435 100644\n--- a/src/gstreamer/gstlibcamera-utils.cpp\n+++ b/src/gstreamer/gstlibcamera-utils.cpp\n@@ -385,7 +385,7 @@ gst_libcamera_stream_configuration_to_caps(const StreamConfiguration &stream_cfg\n \n \tif (stream_cfg.colorSpace) {\n \t\tGstVideoColorimetry colorimetry = colorimetry_from_colorspace(stream_cfg.colorSpace.value());\n-\t\tgchar *colorimetry_str = gst_video_colorimetry_to_string(&colorimetry);\n+\t\tg_autofree gchar *colorimetry_str = gst_video_colorimetry_to_string(&colorimetry);\n \n \t\tif (colorimetry_str)\n \t\t\tgst_structure_set(s, \"colorimetry\", G_TYPE_STRING, colorimetry_str, nullptr);\n","prefixes":["v1"]}