[{"id":29515,"web_url":"https://patchwork.libcamera.org/comment/29515/","msgid":"<171534065853.1857112.799960254429237759@ping.linuxembedded.co.uk>","date":"2024-05-10T11:30:58","subject":"Re: [PATCH v3 7/7] ipa: rpi: Add accessor function for monoSensor_","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2024-05-10 11:02:08)\n> The monoSensor_ member variable will be used by the derived IPAs in an\n> upcoming commit, so add an accessor function for it.\n> \n> Signed-off-by: Naushir Patuck \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/ipa/rpi/common/ipa_base.h | 5 +++++\n> 1 file changed, 5 insertions(+)\n> \n> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\n> index 074b304e9fd8..a95cda1ffe51 100644\n> --- a/src/ipa/rpi/common/ipa_base.h\n> +++ b/src/ipa/rpi/common/ipa_base.h\n> @@ -49,6 +49,11 @@ public:\n> void processStats(const ProcessParams ¶ms) override;\n> \n> protected:\n> + bool monoSensor()\n> + {\n> + return monoSensor_;\n> + }\n> +\n> /* Raspberry Pi controller specific defines. */\n> std::unique_ptr helper_;\n> RPiController::Controller controller_;\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA991C3226\n\tfor ;\n\tFri, 10 May 2024 11:31:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1EB8C6343B;\n\tFri, 10 May 2024 13:31:04 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D28A763415\n\tfor ;\n\tFri, 10 May 2024 13:31:01 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8738CA9A;\n\tFri, 10 May 2024 13:30:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"FjTPJ6KW\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715340657;\n\tbh=wFRBZqXCaDRoRYAXt/0fc68D/jqu8q372T7cD169fXs=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=FjTPJ6KWtOUipSm5cpZPyyqVWfIub+iMpXQ38LCZTs8746yteQuQQpPe7mF1LCbkt\n\twFc1LNisFWWT6rMvtP0AakqmcDQZgTGuNsuKC2BsBNRKDIp5U2QMLH4xvQLBs8Ek7g\n\t3oXFjDBFsJd/0zWPhfr6+Rfe7Fl+1zA/GI0Xowp0=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240510100208.12188-8-naush@raspberrypi.com>","References":"<20240510100208.12188-1-naush@raspberrypi.com>\n\t<20240510100208.12188-8-naush@raspberrypi.com>","Subject":"Re: [PATCH v3 7/7] ipa: rpi: Add accessor function for monoSensor_","From":"Kieran Bingham ","Cc":"Naushir Patuck ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Fri, 10 May 2024 12:30:58 +0100","Message-ID":"<171534065853.1857112.799960254429237759@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29544,"web_url":"https://patchwork.libcamera.org/comment/29544/","msgid":"","date":"2024-05-15T12:15:08","subject":"Re: [PATCH v3 7/7] ipa: rpi: Add accessor function for monoSensor_","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naushir\n\nOn Fri, May 10, 2024 at 11:02:08AM GMT, Naushir Patuck wrote:\n> The monoSensor_ member variable will be used by the derived IPAs in an\n> upcoming commit, so add an accessor function for it.\n>\n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/rpi/common/ipa_base.h | 5 +++++\n> 1 file changed, 5 insertions(+)\n>\n> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\n> index 074b304e9fd8..a95cda1ffe51 100644\n> --- a/src/ipa/rpi/common/ipa_base.h\n> +++ b/src/ipa/rpi/common/ipa_base.h\n> @@ -49,6 +49,11 @@ public:\n> \tvoid processStats(const ProcessParams ¶ms) override;\n>\n> protected:\n> +\tbool monoSensor()\n\n bool monoSensor() const\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> +\t{\n> +\t\treturn monoSensor_;\n> +\t}\n> +\n> \t/* Raspberry Pi controller specific defines. */\n> \tstd::unique_ptr helper_;\n> \tRPiController::Controller controller_;\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 6C366BD78E\n\tfor ;\n\tWed, 15 May 2024 12:16:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6353F63469;\n\tWed, 15 May 2024 14:16:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77E1063461\n\tfor ;\n\tWed, 15 May 2024 14:16:15 +0200 (CEST)","from ideasonboard.com (unknown [149.14.240.163])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 940B9471;\n\tWed, 15 May 2024 14:16:07 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EkSZQSdp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715775367;\n\tbh=j1+VZr0pzp71vVhLfYExZLMRUR4GBR+OywnPgVuY0Bc=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=EkSZQSdpLZyx3Ffnzd08YPnTNMb8iPLCkwQb6MkY4nXJgwOeJ9w4DGHKtaisjBCAJ\n\tKNc0ynQoN54WUbDtDrzhbEuCIjBrjzIgLh5YH7iV8Z8lQWUaqrHxnKy9j8kkNaKdH2\n\tVL6wazGmYX7oJsr00eKld887ox8u0cXQSAMG8C/w=","Date":"Wed, 15 May 2024 14:15:08 +0200","From":"Jacopo Mondi ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v3 7/7] ipa: rpi: Add accessor function for monoSensor_","Message-ID":"","References":"<20240510100208.12188-1-naush@raspberrypi.com>\n\t<20240510100208.12188-8-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240510100208.12188-8-naush@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]