[{"id":29456,"web_url":"https://patchwork.libcamera.org/comment/29456/","msgid":"<20240508152828.GE19625@pendragon.ideasonboard.com>","date":"2024-05-08T15:28:28","subject":"Re: [PATCH] ipa: libipa: camera_sensor_helper: Remove stray\n\tsemicolon","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, May 08, 2024 at 11:51:49PM +0900, Paul Elder wrote:\n> Remove a stray semicolon that was apparently causing compilation\n> problems on clang 17.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/ipa/libipa/camera_sensor_helper.h | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.h b/src/ipa/libipa/camera_sensor_helper.h\n> index dcdbe82b..72024afc 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.h\n> +++ b/src/ipa/libipa/camera_sensor_helper.h\n> @@ -68,7 +68,7 @@ public:\n> \n> \tstatic std::vector &factories();\n> \n> -\tconst std::string &name() const { return name_; };\n> +\tconst std::string &name() const { return name_; }\n\nI think you're not basing this patch on upstream libcamera.\n\n> \n> private:\n> \tLIBCAMERA_DISABLE_COPY_AND_MOVE(CameraSensorHelperFactoryBase)","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 5EB18C3226\n\tfor ;\n\tWed, 8 May 2024 15:28:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14A656343A;\n\tWed, 8 May 2024 17:28:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8FD2362C9F\n\tfor ;\n\tWed, 8 May 2024 17:28:36 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 76361B3;\n\tWed, 8 May 2024 17:28:33 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"or0B92fu\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715182113;\n\tbh=i86gslxDbR/5eCBXaGfq8FtC6RAL4mDukQUBzt5xvK8=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=or0B92fue/8GAmd169YRLo+bn06KBnLrn6C/pnsbg7WcLg9A5bpmu81lloU7WRgge\n\tMPU7umjrxI8GEgRr0N8xHwYpEhAp6BtRa/WSKRim0mW8iEv17bp3dK4WbMM8ToXGGo\n\tWwZE64tswA4NqcJl1DCHM/7a6LT5OkeRIZdIJ92c=","Date":"Wed, 8 May 2024 18:28:28 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] ipa: libipa: camera_sensor_helper: Remove stray\n\tsemicolon","Message-ID":"<20240508152828.GE19625@pendragon.ideasonboard.com>","References":"<20240508145149.1453199-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240508145149.1453199-1-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]