[{"id":29455,"web_url":"https://patchwork.libcamera.org/comment/29455/","msgid":"<20240508152727.GD19625@pendragon.ideasonboard.com>","date":"2024-05-08T15:27:27","subject":"Re: [PATCH] pipeline: rkisp1: rkisp1_source: Minor fixes for clang\n\t17","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, May 08, 2024 at 11:51:31PM +0900, Paul Elder wrote:\n> Remove a stray semicolon and fix the declaration of V4L2SubdeviceFormat\n> from class to struct as it should be, to fix compilation errors on clang\n> 17.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/libcamera/pipeline/rkisp1/rkisp1_source.h | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_source.h b/src/libcamera/pipeline/rkisp1/rkisp1_source.h\n> index 5a49e9d3..67bc287f 100644\n> --- a/src/libcamera/pipeline/rkisp1/rkisp1_source.h\n> +++ b/src/libcamera/pipeline/rkisp1/rkisp1_source.h\n> @@ -24,7 +24,7 @@ class DelayedControls;\n> class MediaEntity;\n> class SensorConfiguration;\n> class V4L2Subdevice;\n> -class V4L2SubdeviceFormat;\n> +struct V4L2SubdeviceFormat;\n> \n> class RkISP1Source\n> {\n> @@ -35,7 +35,7 @@ public:\n> \tint init();\n> \tstd::unique_ptr initDelayedControls();\n> \n> -\tbool isTPG() const { return !!tpg_; };\n> +\tbool isTPG() const { return !!tpg_; }\n\nThere's no isTPG() upstream.\n\n> \n> \tconst std::string &model() const { return model_; }\n> \tconst std::string &id() const { return id_; }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3005EC3226\n\tfor ;\n\tWed, 8 May 2024 15:27:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 70FE662C9F;\n\tWed, 8 May 2024 17:27:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 485BD61A73\n\tfor ;\n\tWed, 8 May 2024 17:27:36 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 11B5BFD6;\n\tWed, 8 May 2024 17:27:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ORLQM+Wi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715182053;\n\tbh=ANJTD/uiQ2AL11X44pvuzpRNWz40ZWiaZZDqcqYJLy4=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ORLQM+WiXHhpIDXGJPUoF/JMnm4uPI42pCwPOmWYn0fTnhtfeZihCPX4fOM62IYGh\n\tfOc95w7eJ8qjNqJC+ztmQZ6G8u7UaVNwGmPzffv1QdONWoUbDkw95j3Xz3hgVXT2Ye\n\ty+nKgcmW/VPMcE12pa0+Tm+TA/eqJNdXuuyrfH7c=","Date":"Wed, 8 May 2024 18:27:27 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] pipeline: rkisp1: rkisp1_source: Minor fixes for clang\n\t17","Message-ID":"<20240508152727.GD19625@pendragon.ideasonboard.com>","References":"<20240508145131.1452305-1-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240508145131.1452305-1-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29465,"web_url":"https://patchwork.libcamera.org/comment/29465/","msgid":"","date":"2024-05-09T05:24:53","subject":"Re: [PATCH] pipeline: rkisp1: rkisp1_source: Minor fixes for clang\n\t17","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, May 08, 2024 at 06:27:27PM +0300, Laurent Pinchart wrote:\n> On Wed, May 08, 2024 at 11:51:31PM +0900, Paul Elder wrote:\n> > Remove a stray semicolon and fix the declaration of V4L2SubdeviceFormat\n> > from class to struct as it should be, to fix compilation errors on clang\n> > 17.\n> > \n> > Signed-off-by: Paul Elder \n> > ---\n> > src/libcamera/pipeline/rkisp1/rkisp1_source.h | 4 ++--\n> > 1 file changed, 2 insertions(+), 2 deletions(-)\n> > \n> > diff --git a/src/libcamera/pipeline/rkisp1/rkisp1_source.h b/src/libcamera/pipeline/rkisp1/rkisp1_source.h\n> > index 5a49e9d3..67bc287f 100644\n> > --- a/src/libcamera/pipeline/rkisp1/rkisp1_source.h\n> > +++ b/src/libcamera/pipeline/rkisp1/rkisp1_source.h\n> > @@ -24,7 +24,7 @@ class DelayedControls;\n> > class MediaEntity;\n> > class SensorConfiguration;\n> > class V4L2Subdevice;\n> > -class V4L2SubdeviceFormat;\n> > +struct V4L2SubdeviceFormat;\n> > \n> > class RkISP1Source\n> > {\n> > @@ -35,7 +35,7 @@ public:\n> > \tint init();\n> > \tstd::unique_ptr initDelayedControls();\n> > \n> > -\tbool isTPG() const { return !!tpg_; };\n> > +\tbool isTPG() const { return !!tpg_; }\n> \n> There's no isTPG() upstream.\n\n...there's no RkISP1Source at all upstream...\n\noops\n\n\nPaul\n\n> \n> > \n> > \tconst std::string &model() const { return model_; }\n> > \tconst std::string &id() const { return id_; }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 0CD49C3226\n\tfor ;\n\tThu, 9 May 2024 05:25:02 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BE3D163461;\n\tThu, 9 May 2024 07:25:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0571F61A6B\n\tfor ;\n\tThu, 9 May 2024 07:24:59 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8B54B904;\n\tThu, 9 May 2024 07:24:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Bm0CgyHA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715232296;\n\tbh=bbsQhPm0kg2Ip9HCfZRhLNsarjmZDuakm3HgU4UUfUM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Bm0CgyHAtOM1te46We4icExwyoNuK9FreShR9BG36hmQWS3fFGoV5vh9GkdP6iNfB\n\t6JYpQmCXEN+Jj4jDbm/q6XYgzA3uFITEPuW9Yqrz/LBdjXceXWdUtQRnBwVydfdkpm\n\tvucwL3UwitI6C3l4H8kYnIsv4RIHAvHA2ixD0TZg=","Date":"Thu, 9 May 2024 14:24:53 +0900","From":"Paul Elder ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] pipeline: rkisp1: rkisp1_source: Minor fixes for clang\n\t17","Message-ID":"","References":"<20240508145131.1452305-1-paul.elder@ideasonboard.com>\n\t<20240508152727.GD19625@pendragon.ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240508152727.GD19625@pendragon.ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]