{"id":20020,"url":"https://patchwork.libcamera.org/api/patches/20020/?format=json","web_url":"https://patchwork.libcamera.org/patch/20020/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240508115351.4183582-1-kieran.bingham@ideasonboard.com>","date":"2024-05-08T11:53:51","name":"[2/2] fixup! ipa: ipu3: Remove bespoke AGC functions from IPU3","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"7616b643c07e1c3e10232e857e71bf9714ba8b57","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/?format=json","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20020/mbox/","series":[{"id":4295,"url":"https://patchwork.libcamera.org/api/series/4295/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4295","date":"2024-05-08T11:52:49","name":"[1/2] fixup! ipa: libipa: Add AgcMeanLuminance base class","version":1,"mbox":"https://patchwork.libcamera.org/series/4295/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20020/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20020/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 04EA4BDE6B\n\tfor ;\n\tWed, 8 May 2024 11:53:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A39FC63437;\n\tWed, 8 May 2024 13:53:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7C9C061A73\n\tfor ;\n\tWed, 8 May 2024 13:53:55 +0200 (CEST)","from Monstersaurus.local\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ADCE4B0B;\n\tWed, 8 May 2024 13:53:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JrBGnYtL\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715169232;\n\tbh=J9GP34UxqPjW2V4xeSI0HhSYhpMNcTNacPnyr2Si8ko=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=JrBGnYtL276gU7a2kIXG2kwP12S/sq/JbTzPauOvgUVglbiPe2SGcLuiMNhLsh3p3\n\tGzNxYuVJodbTli6B/ZRUTmZFsYZ1jPZoSXCCgP48nXPPaexiI1CvHQN+wmvjL+QUm0\n\tuo+nnBW59Faa28maiBj33YONEW5FC8gmGngOiPCo=","From":"Kieran Bingham ","To":"libcamera devel ,\n\tDaniel Scally ","Cc":"Kieran Bingham ","Subject":"[PATCH 2/2] fixup! ipa: ipu3: Remove bespoke AGC functions from IPU3","Date":"Wed, 8 May 2024 12:53:51 +0100","Message-Id":"<20240508115351.4183582-1-kieran.bingham@ideasonboard.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20240502133046.1976565-7-dan.scally@ideasonboard.com>","References":"<20240502133046.1976565-7-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"I will apply the series with the following fixup.\n\nFixes:\nFAILED: src/ipa/ipu3/ipa_ipu3.so.p/algorithms_agc.cpp.o \nclang++ -Isrc/ipa/ipu3/ipa_ipu3.so.p -Isrc/ipa/ipu3 -I../src/ipa/ipu3 -Iinclude -I../include -Isrc/ipa -I../src/ipa -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -O0 -g -stdlib=libc++ -Wextra-semi -Wthread-safety -Wshadow -include /builds/camera/libcamera/build/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/ipu3/ipa_ipu3.so.p/algorithms_agc.cpp.o -MF src/ipa/ipu3/ipa_ipu3.so.p/algorithms_agc.cpp.o.d -o src/ipa/ipu3/ipa_ipu3.so.p/algorithms_agc.cpp.o -c ../src/ipa/ipu3/algorithms/agc.cpp\n../src/ipa/ipu3/algorithms/agc.cpp:60:25: error: unused variable 'kEvGainTarget' [-Werror,-Wunused-const-variable]\nstatic constexpr double kEvGainTarget = 0.5;\n ^\n../src/ipa/ipu3/algorithms/agc.cpp:63:27: error: unused variable 'kNumStartupFrames' [-Werror,-Wunused-const-variable]\nstatic constexpr uint32_t kNumStartupFrames = 10;\n ^\n../src/ipa/ipu3/algorithms/agc.cpp:71:25: error: unused variable 'kRelativeLuminanceTarget' [-Werror,-Wunused-const-variable]\nstatic constexpr double kRelativeLuminanceTarget = 0.16;\n ^\n3 errors generated.\n\n\nSigned-off-by: Kieran Bingham \n---\n src/ipa/ipu3/algorithms/agc.cpp | 14 --------------\n 1 file changed, 14 deletions(-)","diff":"diff --git a/src/ipa/ipu3/algorithms/agc.cpp b/src/ipa/ipu3/algorithms/agc.cpp\nindex e1bca07f7646..c9b5548c4548 100644\n--- a/src/ipa/ipu3/algorithms/agc.cpp\n+++ b/src/ipa/ipu3/algorithms/agc.cpp\n@@ -56,20 +56,6 @@ static constexpr utils::Duration kMaxShutterSpeed = 60ms;\n /* Histogram constants */\n static constexpr uint32_t knumHistogramBins = 256;\n \n-/* Target value to reach for the top 2% of the histogram */\n-static constexpr double kEvGainTarget = 0.5;\n-\n-/* Number of frames to wait before calculating stats on minimum exposure */\n-static constexpr uint32_t kNumStartupFrames = 10;\n-\n-/*\n- * Relative luminance target.\n- *\n- * It's a number that's chosen so that, when the camera points at a grey\n- * target, the resulting image brightness is considered right.\n- */\n-static constexpr double kRelativeLuminanceTarget = 0.16;\n-\n Agc::Agc()\n \t: minShutterSpeed_(0s), maxShutterSpeed_(0s)\n {\n","prefixes":["2/2"]}