[{"id":29470,"web_url":"https://patchwork.libcamera.org/comment/29470/","msgid":"","date":"2024-05-09T09:48:55","subject":"Re: [PATCH v2 5/6] ipa: rpi: Move variables from private to\n\tprotected","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Wed, May 08, 2024 at 09:04:00AM GMT, Naushir Patuck wrote:\n> The following member variable will be used by the derived IPAs in an\n> upcoming commit, so make them protected:\n>\n> lensPresent_\n> monoSensor_\n>\n> Signed-off-by: Naushir Patuck \n> Signed-off-by: Naushir Patuck \n\nYou really wanted to sign this off!\n:)\n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/rpi/common/ipa_base.h | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\n> index 512d7e8fe778..ebdc4d297abb 100644\n> --- a/src/ipa/rpi/common/ipa_base.h\n> +++ b/src/ipa/rpi/common/ipa_base.h\n> @@ -71,6 +71,9 @@ protected:\n> \t/* Whether the stitch block (if available) needs to swap buffers. */\n> \tbool stitchSwapBuffers_;\n>\n> +\tbool monoSensor_;\n> +\tbool lensPresent_;\n> +\n> private:\n> \t/* Number of metadata objects available in the context list. */\n> \tstatic constexpr unsigned int numMetadataContexts = 16;\n> @@ -96,9 +99,6 @@ private:\n>\n> \tstd::map buffers_;\n>\n> -\tbool lensPresent_;\n> -\tbool monoSensor_;\n> -\n> \tstd::array rpiMetadata_;\n>\n> \t/*\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3C8C4BDE6B\n\tfor ;\n\tThu, 9 May 2024 09:49:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EA96763463;\n\tThu, 9 May 2024 11:49:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A619D63461\n\tfor ;\n\tThu, 9 May 2024 11:48:58 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4037A524;\n\tThu, 9 May 2024 11:48:55 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"ewlfncfm\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715248135;\n\tbh=zbK0jcm471wslGEMhYPjnQnHZQWGv16avtLZ6ISVg+U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=ewlfncfmaEyCtQ4VPb4x+lS6xv0rYfMqyFikuigSNt0MSYZtuMDbeg5HN8gBSf13T\n\tAFdEKu4xtryr7LHQYeRqr0jD4PuOZsIMACPSLsmXxwGtagJ2HxAFBCP+rOLHCRMKYg\n\t6aQosw/NYi2FGCdq15mzMEf6eGWD0puepuJDXYUc=","Date":"Thu, 9 May 2024 11:48:55 +0200","From":"Jacopo Mondi ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 5/6] ipa: rpi: Move variables from private to\n\tprotected","Message-ID":"","References":"<20240508080401.14850-1-naush@raspberrypi.com>\n\t<20240508080401.14850-6-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240508080401.14850-6-naush@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29486,"web_url":"https://patchwork.libcamera.org/comment/29486/","msgid":"<171525332161.1857112.510080919521858634@ping.linuxembedded.co.uk>","date":"2024-05-09T11:15:21","subject":"Re: [PATCH v2 5/6] ipa: rpi: Move variables from private to\n\tprotected","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2024-05-08 09:04:00)\n> The following member variable will be used by the derived IPAs in an\n> upcoming commit, so make them protected:\n> \n> lensPresent_\n> monoSensor_\n> \n> Signed-off-by: Naushir Patuck \n> Signed-off-by: Naushir Patuck \n\n\nReviewed-by: Kieran Bingham \nReviewed-by: Kieran Bingham \n\n;-)\n\n> ---\n> src/ipa/rpi/common/ipa_base.h | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\n> index 512d7e8fe778..ebdc4d297abb 100644\n> --- a/src/ipa/rpi/common/ipa_base.h\n> +++ b/src/ipa/rpi/common/ipa_base.h\n> @@ -71,6 +71,9 @@ protected:\n> /* Whether the stitch block (if available) needs to swap buffers. */\n> bool stitchSwapBuffers_;\n> \n> + bool monoSensor_;\n> + bool lensPresent_;\n> +\n> private:\n> /* Number of metadata objects available in the context list. */\n> static constexpr unsigned int numMetadataContexts = 16;\n> @@ -96,9 +99,6 @@ private:\n> \n> std::map buffers_;\n> \n> - bool lensPresent_;\n> - bool monoSensor_;\n> -\n> std::array rpiMetadata_;\n> \n> /*\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7CFC5C3226\n\tfor ;\n\tThu, 9 May 2024 11:15:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2B72A6346B;\n\tThu, 9 May 2024 13:15:26 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A916E63460\n\tfor ;\n\tThu, 9 May 2024 13:15:24 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 379F6904;\n\tThu, 9 May 2024 13:15:21 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"EJOQL8J2\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715253321;\n\tbh=grhJLl81gCytbuxGir0lYLOG3+nYfk1kBbDwgugKULw=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=EJOQL8J2wrfs8M8czCGClQWAFP1tGyTXEHijHzkL0ykUzM9bJ52zoBxooBCDtyd5D\n\tDaFAun9lQuNzyNUhcZSdR6yMjb9ZQHzmEC+fxlkxyFtQw6qqI30+XRzTCOHEenkgf8\n\tRL6QccVRkXPQvj6GfRuUCdNcmezotpOyXUDg9H9w=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240508080401.14850-6-naush@raspberrypi.com>","References":"<20240508080401.14850-1-naush@raspberrypi.com>\n\t<20240508080401.14850-6-naush@raspberrypi.com>","Subject":"Re: [PATCH v2 5/6] ipa: rpi: Move variables from private to\n\tprotected","From":"Kieran Bingham ","Cc":"Naushir Patuck ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 09 May 2024 12:15:21 +0100","Message-ID":"<171525332161.1857112.510080919521858634@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29493,"web_url":"https://patchwork.libcamera.org/comment/29493/","msgid":"","date":"2024-05-09T11:35:36","subject":"Re: [PATCH v2 5/6] ipa: rpi: Move variables from private to\n\tprotected","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"On Thu, 9 May 2024 at 12:15, Kieran Bingham \nwrote:\n\n> Quoting Naushir Patuck (2024-05-08 09:04:00)\n> > The following member variable will be used by the derived IPAs in an\n> > upcoming commit, so make them protected:\n> >\n> > lensPresent_\n> > monoSensor_\n> >\n> > Signed-off-by: Naushir Patuck \n> > Signed-off-by: Naushir Patuck \n>\n>\n> Reviewed-by: Kieran Bingham \n> Reviewed-by: Kieran Bingham \n>\n> ;-)\n>\n\nI hope to see these duplicated in the merged commit!\n\n\n>\n> > ---\n> > src/ipa/rpi/common/ipa_base.h | 6 +++---\n> > 1 file changed, 3 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/ipa/rpi/common/ipa_base.h\n> b/src/ipa/rpi/common/ipa_base.h\n> > index 512d7e8fe778..ebdc4d297abb 100644\n> > --- a/src/ipa/rpi/common/ipa_base.h\n> > +++ b/src/ipa/rpi/common/ipa_base.h\n> > @@ -71,6 +71,9 @@ protected:\n> > /* Whether the stitch block (if available) needs to swap\n> buffers. */\n> > bool stitchSwapBuffers_;\n> >\n> > + bool monoSensor_;\n> > + bool lensPresent_;\n> > +\n> > private:\n> > /* Number of metadata objects available in the context list. */\n> > static constexpr unsigned int numMetadataContexts = 16;\n> > @@ -96,9 +99,6 @@ private:\n> >\n> > std::map buffers_;\n> >\n> > - bool lensPresent_;\n> > - bool monoSensor_;\n> > -\n> > std::array\n> rpiMetadata_;\n> >\n> > /*\n> > --\n> > 2.34.1\n> >\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 329A8C3226\n\tfor ;\n\tThu, 9 May 2024 11:36:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4D097633FA;\n\tThu, 9 May 2024 13:36:08 +0200 (CEST)","from mail-yw1-x112d.google.com (mail-yw1-x112d.google.com\n\t[IPv6:2607:f8b0:4864:20::112d])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A92CE633FA\n\tfor ;\n\tThu, 9 May 2024 13:36:06 +0200 (CEST)","by mail-yw1-x112d.google.com with SMTP id\n\t00721157ae682-620314aa1d7so7685317b3.2\n\tfor ;\n\tThu, 09 May 2024 04:36:06 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"G5+l1Q+9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1715254565; x=1715859365;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=u3nXaoXS7ix5Xvvt6l6Ys7f9lnShU9cUW58qSUFTS1s=;\n\tb=G5+l1Q+94IdKKizdooIwKZsrAAPJkSIaruBAYqaNNoRgE9IpJvuGPlsC+hir5Q5noW\n\tyWkiWBUjvcyfDmylPidwauLuyc9YjUUwT1+KYIHSW5arg4H/oEhOgFGDjhesjwo84Krk\n\tenZ+cxp7MUTwo/5vhwFYmj1OcFjTmkUy33NvAkx6/pLhUiR19vd4cdONXdAI6MdHty2U\n\t8ZR/VTc6YEcjF4EmCrEwbomEx6nxcmZyZU6MAxAKCYPaUx0YCHOX4oVgPNhna/TqomqD\n\t2snr7pt0MEGw69XvKxSCP0tPxc6OS0VF2zfwzZ5p6xpv8VMHy67SthU0mCmXZ+vM1vmu\n\tH3EA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1715254565; x=1715859365;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=u3nXaoXS7ix5Xvvt6l6Ys7f9lnShU9cUW58qSUFTS1s=;\n\tb=pHtK108O3V3xP3PP5vsCN6jyxETKGR4dwgtmKNC20sAjGcrHsczNn/vkXGYAga/S74\n\tC2cC39sD5iu2j/zA35of7tOFL9cS4ckUaeXHeRO55dfroLghsQZ6Lce6dyJQJynGpUCc\n\t5cNw6kml+6bmLo3I6m0fy6wTuzzsQ2kGcJD0awoCgoA1M0cpuyfI5FTn2d49oWPKjU4r\n\tgSDGiQNItViO6s8gJEhRCF05OB5eVAFn5Fo/MZfRfwJNIWmQPxA0EzgjM23uLnIWKX6P\n\tw/Tjkq4uzHRF3E13EEkWWUIXft8YO1SHo/F/+wLVZRWyGhLdd8D6DqqCLn/ErSZsiGtt\n\taOJQ==","X-Gm-Message-State":"AOJu0YyBzKTwN8QRbBghyEyPcIpORhAiGr9Ojw903mq3hEedc7QZL4TO\n\tRaS8lv9LbsIEPrnB6GNboiaW+kogncoI3wAxlnH6lIyk1dTFjqGb0MctadEhUlFnlsOrPpkGQ1T\n\tWYDerbdblxxUCJ8in/XE8m4HqflNPx9rS3D6rUBMArc/W5Hz0","X-Google-Smtp-Source":"AGHT+IEBMZEYLtP5WMsTPYa5CiW2UuM+4w7tUkacHSEhKo0p2tx2bvxHULQJYLrleip3UczaQgGdSdUWQbk5pEjpubI=","X-Received":"by 2002:a0d:d783:0:b0:615:41a4:1a8a with SMTP id\n\t00721157ae682-62085a747c7mr58993737b3.25.1715254565491;\n\tThu, 09 May 2024 04:36:05 -0700 (PDT)","MIME-Version":"1.0","References":"<20240508080401.14850-1-naush@raspberrypi.com>\n\t<20240508080401.14850-6-naush@raspberrypi.com>\n\t<171525332161.1857112.510080919521858634@ping.linuxembedded.co.uk>","In-Reply-To":"<171525332161.1857112.510080919521858634@ping.linuxembedded.co.uk>","From":"Naushir Patuck ","Date":"Thu, 9 May 2024 12:35:36 +0100","Message-ID":"","Subject":"Re: [PATCH v2 5/6] ipa: rpi: Move variables from private to\n\tprotected","To":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"multipart/alternative; boundary=\"000000000000136df9061803d336\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29494,"web_url":"https://patchwork.libcamera.org/comment/29494/","msgid":"<20240509113859.GK14520@pendragon.ideasonboard.com>","date":"2024-05-09T11:38:59","subject":"Re: [PATCH v2 5/6] ipa: rpi: Move variables from private to\n\tprotected","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Wed, May 08, 2024 at 09:04:00AM +0100, Naushir Patuck wrote:\n> The following member variable will be used by the derived IPAs in an\n> upcoming commit, so make them protected:\n> \n> lensPresent_\n> monoSensor_\n\nWill the derived classes only need to read them, or write them as well ?\nIn the former case, you may want to provide read-only accessors instead.\nUp to you.\n\n> Signed-off-by: Naushir Patuck \n> Signed-off-by: Naushir Patuck \n> ---\n> src/ipa/rpi/common/ipa_base.h | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\n> index 512d7e8fe778..ebdc4d297abb 100644\n> --- a/src/ipa/rpi/common/ipa_base.h\n> +++ b/src/ipa/rpi/common/ipa_base.h\n> @@ -71,6 +71,9 @@ protected:\n> \t/* Whether the stitch block (if available) needs to swap buffers. */\n> \tbool stitchSwapBuffers_;\n> \n> +\tbool monoSensor_;\n> +\tbool lensPresent_;\n> +\n> private:\n> \t/* Number of metadata objects available in the context list. */\n> \tstatic constexpr unsigned int numMetadataContexts = 16;\n> @@ -96,9 +99,6 @@ private:\n> \n> \tstd::map buffers_;\n> \n> -\tbool lensPresent_;\n> -\tbool monoSensor_;\n> -\n> \tstd::array rpiMetadata_;\n> \n> \t/*","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3954CBDE6B\n\tfor ;\n\tThu, 9 May 2024 11:39:11 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2F95D63460;\n\tThu, 9 May 2024 13:39:10 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9F326633FA\n\tfor ;\n\tThu, 9 May 2024 13:39:08 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DEBAD904;\n\tThu, 9 May 2024 13:39:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Du5hU+v6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715254745;\n\tbh=Ne9i/wSSBtcmmpsngJS0HeA0fv7L4HAQW1qUbDvJpe0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Du5hU+v6TeWJhdO9IiZGdjkPwrXQFYohYaval1S4LJh5iRw1QHFf4aiGVt6POSztR\n\t4tBSuvOD8W1G6bjfSEhtUFfrEOg44f8Pqe5KgUO8og9oD+/G7v4qrDJ/ftAbCmZ4SR\n\tg4lTQygPMbHK/cl6DYK0DVAPJuTnnqRcu7t3PUqo=","Date":"Thu, 9 May 2024 14:38:59 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 5/6] ipa: rpi: Move variables from private to\n\tprotected","Message-ID":"<20240509113859.GK14520@pendragon.ideasonboard.com>","References":"<20240508080401.14850-1-naush@raspberrypi.com>\n\t<20240508080401.14850-6-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240508080401.14850-6-naush@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29514,"web_url":"https://patchwork.libcamera.org/comment/29514/","msgid":"","date":"2024-05-10T08:17:43","subject":"Re: [PATCH v2 5/6] ipa: rpi: Move variables from private to\n\tprotected","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"content":"Hi Laurent,\n\nOn Thu, 9 May 2024 at 12:39, Laurent Pinchart\n wrote:\n>\n> Hi Naush,\n>\n> Thank you for the patch.\n>\n> On Wed, May 08, 2024 at 09:04:00AM +0100, Naushir Patuck wrote:\n> > The following member variable will be used by the derived IPAs in an\n> > upcoming commit, so make them protected:\n> >\n> > lensPresent_\n> > monoSensor_\n>\n> Will the derived classes only need to read them, or write them as well ?\n> In the former case, you may want to provide read-only accessors instead.\n> Up to you.\n\nAck. Turns out, I don't need lensPresent_ any more, so I'll add a\ngetter for monoSensor_ only.\n\nNaush\n\n>\n> > Signed-off-by: Naushir Patuck \n> > Signed-off-by: Naushir Patuck \n> > ---\n> > src/ipa/rpi/common/ipa_base.h | 6 +++---\n> > 1 file changed, 3 insertions(+), 3 deletions(-)\n> >\n> > diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\n> > index 512d7e8fe778..ebdc4d297abb 100644\n> > --- a/src/ipa/rpi/common/ipa_base.h\n> > +++ b/src/ipa/rpi/common/ipa_base.h\n> > @@ -71,6 +71,9 @@ protected:\n> > /* Whether the stitch block (if available) needs to swap buffers. */\n> > bool stitchSwapBuffers_;\n> >\n> > + bool monoSensor_;\n> > + bool lensPresent_;\n> > +\n> > private:\n> > /* Number of metadata objects available in the context list. */\n> > static constexpr unsigned int numMetadataContexts = 16;\n> > @@ -96,9 +99,6 @@ private:\n> >\n> > std::map buffers_;\n> >\n> > - bool lensPresent_;\n> > - bool monoSensor_;\n> > -\n> > std::array rpiMetadata_;\n> >\n> > /*\n>\n> --\n> Regards,\n>\n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 09073C3226\n\tfor ;\n\tFri, 10 May 2024 08:18:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2BC7863425;\n\tFri, 10 May 2024 10:18:15 +0200 (CEST)","from mail-yb1-xb32.google.com (mail-yb1-xb32.google.com\n\t[IPv6:2607:f8b0:4864:20::b32])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2B83D63425\n\tfor ;\n\tFri, 10 May 2024 10:18:13 +0200 (CEST)","by mail-yb1-xb32.google.com with SMTP id\n\t3f1490d57ef6-dbed0710c74so1562624276.1\n\tfor ;\n\tFri, 10 May 2024 01:18:13 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"FdykS+Vb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1715329092; x=1715933892;\n\tdarn=lists.libcamera.org; \n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:from:to:cc:subject:date:message-id:reply-to;\n\tbh=D+HSo1y/CN7fccFqVHQz5UeAvvv8SIL/qtHAeBjQiLU=;\n\tb=FdykS+Vbk5leGvS1bQmTKKZEDZF/DL5Mi6JSAk5RiAz0JZasqoh9eiFIgGzQ8FZdQZ\n\tR0Xt4THAsezbRxqvXb9qeHemO58zViPh5m06bDy+jZXTiC8RfuQg3BaS0CLmsEf8AUkX\n\tBDOSkpsXpiK1huSswuT8xhHbLUVnwkttdDKEdWIGADJG1sojtChPEpIUlEZ00ysSFY2z\n\t+ncW6u1Ndf3OBZsX/a/ekkT1x2fX2YiAkptCcaKViUhSfvcWbXgr8LjF9GdLGKODe5UE\n\tGQJ0z/03/6qzy20kxFEFt/xNMSlCbjUQN+7Qc+9bnKuGBTTdkajmSpA2XTdxzs0zkapx\n\tVc0g==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1715329092; x=1715933892;\n\th=cc:to:subject:message-id:date:from:in-reply-to:references\n\t:mime-version:x-gm-message-state:from:to:cc:subject:date:message-id\n\t:reply-to;\n\tbh=D+HSo1y/CN7fccFqVHQz5UeAvvv8SIL/qtHAeBjQiLU=;\n\tb=qyMRTWsS4DX+ZFmctatpMfj/ib+ynJVhilNyUivwp4qdZbhqYJgghYbpqMwUVDz5RD\n\t7bMRBoJzM39k/Nb1sTbODZgjbGQBTpIsF6QEsMwa8g+f23ADWbpmwg0tq6GGBmrZ6LjK\n\tZ3lO9/QIsLIN8TfVof9TC6WntSj7/aZz2TSDMwIyPnAkFF+T/2A0vRmMMCciXzSRCgLs\n\tFVaWGv70eza9WHlcr1OV7zggYiONav/NKQEy6TeE31csM5j1ezqbePNXWbirsRjERqAH\n\twmDV/mkAZss4U8uYnc9AANSytSZmKLVh5S4zg9N2DCVGGuku652iiCop1tzs8JqEp3za\n\tr3Pg==","X-Gm-Message-State":"AOJu0YyvbDOzld1xS8VddAwmIiGfFl0wix8QsDFtlNhH7cVEPn0vgwkJ\n\twudqcXlUIHv41UZtn/jtelKdpgooreI1yhT9dko0G/ezPpqMqhiDp6CAabDhzCtMGQGcpO5MDXq\n\tYBv1PQ9eaD4rjOxxMMOWpebFSTiE6xxRWbjcWfBrb/e1l+kBN","X-Google-Smtp-Source":"AGHT+IGW7SuavlFjvL6w1xtYfsZsP8LdCaEOtFQb/bBWeWRp68uvInKIG9KCMtfYi3KDC0jI6rYiW45JPL6MewWGCHU=","X-Received":"by 2002:a25:848a:0:b0:de4:1825:508f with SMTP id\n\t3f1490d57ef6-dee4f3519d9mr1664227276.39.1715329091963;\n\tFri, 10 May 2024 01:18:11 -0700 (PDT)","MIME-Version":"1.0","References":"<20240508080401.14850-1-naush@raspberrypi.com>\n\t<20240508080401.14850-6-naush@raspberrypi.com>\n\t<20240509113859.GK14520@pendragon.ideasonboard.com>","In-Reply-To":"<20240509113859.GK14520@pendragon.ideasonboard.com>","From":"Naushir Patuck ","Date":"Fri, 10 May 2024 09:17:43 +0100","Message-ID":"","Subject":"Re: [PATCH v2 5/6] ipa: rpi: Move variables from private to\n\tprotected","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Content-Type":"text/plain; charset=\"UTF-8\"","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]