{"id":20015,"url":"https://patchwork.libcamera.org/api/patches/20015/?format=json","web_url":"https://patchwork.libcamera.org/patch/20015/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240508080401.14850-6-naush@raspberrypi.com>","date":"2024-05-08T08:04:00","name":"[v2,5/6] ipa: rpi: Move variables from private to protected","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f211671212282cc3f2671835a5356c2bd9b02006","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/20015/mbox/","series":[{"id":4293,"url":"https://patchwork.libcamera.org/api/series/4293/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4293","date":"2024-05-08T08:03:55","name":"Pre Raspberry Pi 5 support changes","version":2,"mbox":"https://patchwork.libcamera.org/series/4293/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/20015/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/20015/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8CB27BDE6B\n\tfor ;\n\tWed, 8 May 2024 08:04:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id DE59263440;\n\tWed, 8 May 2024 10:04:10 +0200 (CEST)","from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com\n\t[IPv6:2a00:1450:4864:20::32e])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 793E66342D\n\tfor ;\n\tWed, 8 May 2024 10:04:04 +0200 (CEST)","by mail-wm1-x32e.google.com with SMTP id\n\t5b1f17b1804b1-41b782405bbso28319995e9.1\n\tfor ;\n\tWed, 08 May 2024 01:04:04 -0700 (PDT)","from localhost.localdomain ([188.39.149.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tw16-20020a05600c475000b0041c14061c71sm1351944wmo.15.2024.05.08.01.04.03\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tWed, 08 May 2024 01:04:03 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"Z3eonQvg\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1715155444; x=1715760244;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=Jm5/HVAZRKYn81evUSPhEi4s4e/rvffsxRQpv6ayiLM=;\n\tb=Z3eonQvgnUOgFZPcbvdzCEZAosda8oJaSkQgZbF7BpoD0n+iSLCZSFALTbOoeo7sw6\n\t7qPJP3t8f99U8bb+QLLVvyfhv7/gQ45311RPAaEbcGVLZi4NKuQZmqnwXhAwGERfPQYe\n\th61jRfe3qiLSM8FfvFs5lPC0xBSB+xIYtizaoBfgV7J9kpbl4Eg6t+1QdYCZ+0HZm7vz\n\tFb+F9K5fvxb83buIzjrieozMZmiADtdPARkXdIy7kNjyMydNGsEdlUDtXQXm/ekR7nSF\n\th0HPpSkWo7ssdf8enJTmfTUQN7V/DLTUUtrZGzR0VzH486aQX1o/aL1KNfLw3Du5FhRL\n\twgWg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1715155444; x=1715760244;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=Jm5/HVAZRKYn81evUSPhEi4s4e/rvffsxRQpv6ayiLM=;\n\tb=RgE1A7o5Qpy6cc+W3Pt0YSaANhTwQLjAt/PP8LszvkWqOaiIY9Ltnl2DPgKeJK+dL9\n\t/+NogCDSfOoDbC1jkbPcQToYlZmmpcwXsY4T6/CZIvwOW2rXpr47u9z43q0yEPzcpOjX\n\tzbwH3PEXpD4sbTWn+BySA4brqI9MyK4PDUa5pqcY9tzxR+9X1AF7uzTLSv1OUR1K28ay\n\tI3vvi0FVthZjdFf3r8NqNiNDS0K88dUuiRgkEQXvcAdaAodHUWgTeWxdyaw0LJeAtRiX\n\t1hjGV1jYUf/rndH5QsBnZ25111y68DY7kw+kgsFmdgOMf24IfTmUyXv9WUdX3SC3mRy1\n\toKKQ==","X-Gm-Message-State":"AOJu0YzkJfE2JIdL5simSIzcJ/VBp+i7Cf4fepvL/F/nXDMO02E3srDR\n\tiDye0rYmHbfBInB4V2OcY6MTszs8xs6Y7a7MmgCJuh0tIESz0AzetMwq0s2OdqAYjatq+AwpTbC\n\tL","X-Google-Smtp-Source":"AGHT+IE8mhWhhKiBt5b2l85To8UzaLvWG0AAD4FvKUliLTdv55JNVrtqxj5jCEhdthUjcPGaFi+KZw==","X-Received":"by 2002:a05:600c:3552:b0:41b:f30a:41f1 with SMTP id\n\t5b1f17b1804b1-41f71302a9dmr13711545e9.7.1715155443920; \n\tWed, 08 May 2024 01:04:03 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ","Subject":"[PATCH v2 5/6] ipa: rpi: Move variables from private to protected","Date":"Wed, 8 May 2024 09:04:00 +0100","Message-Id":"<20240508080401.14850-6-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20240508080401.14850-1-naush@raspberrypi.com>","References":"<20240508080401.14850-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The following member variable will be used by the derived IPAs in an\nupcoming commit, so make them protected:\n\nlensPresent_\nmonoSensor_\n\nSigned-off-by: Naushir Patuck \nSigned-off-by: Naushir Patuck \n---\n src/ipa/rpi/common/ipa_base.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\nindex 512d7e8fe778..ebdc4d297abb 100644\n--- a/src/ipa/rpi/common/ipa_base.h\n+++ b/src/ipa/rpi/common/ipa_base.h\n@@ -71,6 +71,9 @@ protected:\n \t/* Whether the stitch block (if available) needs to swap buffers. */\n \tbool stitchSwapBuffers_;\n \n+\tbool monoSensor_;\n+\tbool lensPresent_;\n+\n private:\n \t/* Number of metadata objects available in the context list. */\n \tstatic constexpr unsigned int numMetadataContexts = 16;\n@@ -96,9 +99,6 @@ private:\n \n \tstd::map buffers_;\n \n-\tbool lensPresent_;\n-\tbool monoSensor_;\n-\n \tstd::array rpiMetadata_;\n \n \t/*\n","prefixes":["v2","5/6"]}