[{"id":29469,"web_url":"https://patchwork.libcamera.org/comment/29469/","msgid":"","date":"2024-05-09T09:48:12","subject":"Re: [PATCH v2 3/6] libcamera: v4l2_subdevice: Add missing\n\tMEDIA_BUS_FMT_xxxx16_1X16 info","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Wed, May 08, 2024 at 09:03:58AM GMT, Naushir Patuck wrote:\n> Add the missing 16-bit MEDIA_BUS_FMT_xxxx16_1X16 definitions to the\n> mediaBusFormatInfo table.\n>\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/libcamera/v4l2_subdevice.cpp | 28 ++++++++++++++++++++++++++++\n> 1 file changed, 28 insertions(+)\n>\n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 1076b7006b0b..ca01ea3fe455 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -651,6 +651,34 @@ const std::map mediaBusFormatInfo{\n> \t\t.bitsPerPixel = 14,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> \t} },\n> +\t{ MEDIA_BUS_FMT_SBGGR16_1X16, {\n> +\t\t.name = \"SBGGR16_1X16\",\n> +\t\t.code = MEDIA_BUS_FMT_SBGGR16_1X16,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> +\t{ MEDIA_BUS_FMT_SGBRG16_1X16, {\n> +\t\t.name = \"SGBRG16_1X16\",\n> +\t\t.code = MEDIA_BUS_FMT_SGBRG16_1X16,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> +\t{ MEDIA_BUS_FMT_SGRBG16_1X16, {\n> +\t\t.name = \"SGRBG16_1X16\",\n> +\t\t.code = MEDIA_BUS_FMT_SGRBG16_1X16,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> +\t{ MEDIA_BUS_FMT_SRGGB16_1X16, {\n> +\t\t.name = \"SRGGB16_1X16\",\n> +\t\t.code = MEDIA_BUS_FMT_SRGGB16_1X16,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> \t/* \\todo Clarify colour encoding for HSV formats */\n> \t{ MEDIA_BUS_FMT_AHSV8888_1X32, {\n> \t\t.name = \"AHSV8888_1X32\",\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9B343BDE6B\n\tfor ;\n\tThu, 9 May 2024 09:48:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5D9B563461;\n\tThu, 9 May 2024 11:48:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C57A1633FA\n\tfor ;\n\tThu, 9 May 2024 11:48:14 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 59DD3524;\n\tThu, 9 May 2024 11:48:11 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"daiBYtJl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715248091;\n\tbh=O1ElSlJX7PVBxc4iabx3Cl4nyRk9WQOIzzghwbVu6QU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=daiBYtJlgQUiiX7qJPHqSAqNPaaUUToQmDbmudG8oeRF0HLus1e9FPlphvWAopukn\n\t3ZaRLQqYF5XeKhny5r9KH3k2BqinDjks+7Pa517v/vBlYP6xBzFGcc9Exlsntn+f9G\n\t++ku6OMIxBEOOhSpFBwLFDO9rfxdi8z8g7ZunYXE=","Date":"Thu, 9 May 2024 11:48:12 +0200","From":"Jacopo Mondi ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 3/6] libcamera: v4l2_subdevice: Add missing\n\tMEDIA_BUS_FMT_xxxx16_1X16 info","Message-ID":"","References":"<20240508080401.14850-1-naush@raspberrypi.com>\n\t<20240508080401.14850-4-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240508080401.14850-4-naush@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29483,"web_url":"https://patchwork.libcamera.org/comment/29483/","msgid":"<171525299161.1857112.17941890425817412528@ping.linuxembedded.co.uk>","date":"2024-05-09T11:09:51","subject":"Re: [PATCH v2 3/6] libcamera: v4l2_subdevice: Add missing\n\tMEDIA_BUS_FMT_xxxx16_1X16 info","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Naushir Patuck (2024-05-08 09:03:58)\n> Add the missing 16-bit MEDIA_BUS_FMT_xxxx16_1X16 definitions to the\n> mediaBusFormatInfo table.\n> \n> Signed-off-by: Naushir Patuck \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> src/libcamera/v4l2_subdevice.cpp | 28 ++++++++++++++++++++++++++++\n> 1 file changed, 28 insertions(+)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 1076b7006b0b..ca01ea3fe455 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -651,6 +651,34 @@ const std::map mediaBusFormatInfo{\n> .bitsPerPixel = 14,\n> .colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> } },\n> + { MEDIA_BUS_FMT_SBGGR16_1X16, {\n> + .name = \"SBGGR16_1X16\",\n> + .code = MEDIA_BUS_FMT_SBGGR16_1X16,\n> + .type = MediaBusFormatInfo::Type::Image,\n> + .bitsPerPixel = 16,\n> + .colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> + } },\n> + { MEDIA_BUS_FMT_SGBRG16_1X16, {\n> + .name = \"SGBRG16_1X16\",\n> + .code = MEDIA_BUS_FMT_SGBRG16_1X16,\n> + .type = MediaBusFormatInfo::Type::Image,\n> + .bitsPerPixel = 16,\n> + .colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> + } },\n> + { MEDIA_BUS_FMT_SGRBG16_1X16, {\n> + .name = \"SGRBG16_1X16\",\n> + .code = MEDIA_BUS_FMT_SGRBG16_1X16,\n> + .type = MediaBusFormatInfo::Type::Image,\n> + .bitsPerPixel = 16,\n> + .colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> + } },\n> + { MEDIA_BUS_FMT_SRGGB16_1X16, {\n> + .name = \"SRGGB16_1X16\",\n> + .code = MEDIA_BUS_FMT_SRGGB16_1X16,\n> + .type = MediaBusFormatInfo::Type::Image,\n> + .bitsPerPixel = 16,\n> + .colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> + } },\n> /* \\todo Clarify colour encoding for HSV formats */\n> { MEDIA_BUS_FMT_AHSV8888_1X32, {\n> .name = \"AHSV8888_1X32\",\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A1314BDE6B\n\tfor ;\n\tThu, 9 May 2024 11:09:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6384A63460;\n\tThu, 9 May 2024 13:09:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A45B163433\n\tfor ;\n\tThu, 9 May 2024 13:09:54 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2FF13904;\n\tThu, 9 May 2024 13:09:51 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Ijv6EhkY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715252991;\n\tbh=Xgw4hFYHlJTFZMH3YjOt1FA6QKII1dsGD3+O4+Aa7hY=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=Ijv6EhkYovleVvNbLrHRcYy9y8V8orzVj5dj1mi8m7TISz0GuOH0In6rpn63/fj+i\n\tWb7dVpLrNrEUJkgpomworLxuGQqBQeqPd3K4v9PSqAI7Is0UYfbfZREQIEfRqmjQs5\n\tSUwKu0ywX/TyNZXZooD+w+XXYUFChEV9rwQpsNlc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240508080401.14850-4-naush@raspberrypi.com>","References":"<20240508080401.14850-1-naush@raspberrypi.com>\n\t<20240508080401.14850-4-naush@raspberrypi.com>","Subject":"Re: [PATCH v2 3/6] libcamera: v4l2_subdevice: Add missing\n\tMEDIA_BUS_FMT_xxxx16_1X16 info","From":"Kieran Bingham ","Cc":"Naushir Patuck ","To":"Naushir Patuck ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 09 May 2024 12:09:51 +0100","Message-ID":"<171525299161.1857112.17941890425817412528@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29492,"web_url":"https://patchwork.libcamera.org/comment/29492/","msgid":"<20240509113331.GJ14520@pendragon.ideasonboard.com>","date":"2024-05-09T11:33:31","subject":"Re: [PATCH v2 3/6] libcamera: v4l2_subdevice: Add missing\n\tMEDIA_BUS_FMT_xxxx16_1X16 info","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Naush,\n\nThank you for the patch.\n\nOn Wed, May 08, 2024 at 09:03:58AM +0100, Naushir Patuck wrote:\n> Add the missing 16-bit MEDIA_BUS_FMT_xxxx16_1X16 definitions to the\n> mediaBusFormatInfo table.\n> \n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/v4l2_subdevice.cpp | 28 ++++++++++++++++++++++++++++\n> 1 file changed, 28 insertions(+)\n> \n> diff --git a/src/libcamera/v4l2_subdevice.cpp b/src/libcamera/v4l2_subdevice.cpp\n> index 1076b7006b0b..ca01ea3fe455 100644\n> --- a/src/libcamera/v4l2_subdevice.cpp\n> +++ b/src/libcamera/v4l2_subdevice.cpp\n> @@ -651,6 +651,34 @@ const std::map mediaBusFormatInfo{\n> \t\t.bitsPerPixel = 14,\n> \t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW,\n> \t} },\n> +\t{ MEDIA_BUS_FMT_SBGGR16_1X16, {\n> +\t\t.name = \"SBGGR16_1X16\",\n> +\t\t.code = MEDIA_BUS_FMT_SBGGR16_1X16,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> +\t{ MEDIA_BUS_FMT_SGBRG16_1X16, {\n> +\t\t.name = \"SGBRG16_1X16\",\n> +\t\t.code = MEDIA_BUS_FMT_SGBRG16_1X16,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> +\t{ MEDIA_BUS_FMT_SGRBG16_1X16, {\n> +\t\t.name = \"SGRBG16_1X16\",\n> +\t\t.code = MEDIA_BUS_FMT_SGRBG16_1X16,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> +\t{ MEDIA_BUS_FMT_SRGGB16_1X16, {\n> +\t\t.name = \"SRGGB16_1X16\",\n> +\t\t.code = MEDIA_BUS_FMT_SRGGB16_1X16,\n> +\t\t.type = MediaBusFormatInfo::Type::Image,\n> +\t\t.bitsPerPixel = 16,\n> +\t\t.colourEncoding = PixelFormatInfo::ColourEncodingRAW\n> +\t} },\n> \t/* \\todo Clarify colour encoding for HSV formats */\n> \t{ MEDIA_BUS_FMT_AHSV8888_1X32, {\n> \t\t.name = \"AHSV8888_1X32\",","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BB5BBC3226\n\tfor ;\n\tThu, 9 May 2024 11:33:42 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C74346345F;\n\tThu, 9 May 2024 13:33:41 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC97C633FA\n\tfor ;\n\tThu, 9 May 2024 13:33:40 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1918DB3;\n\tThu, 9 May 2024 13:33:37 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"d1pJVL4j\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715254417;\n\tbh=h/VktupDYgVuYCAE2ayWhxbwdrXbp3XTG2jDZDNegDU=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=d1pJVL4jOjFU4c0vTmKYq0rh5LoLzLxtv06VE21TWra5yi/2+o0VdktqWQR3UO/jB\n\tG1b7O4M4/bqfVtNN0AptDi3ZrBAuP3MvsNQsTQx/sQv5zu57VlQyUCADqvIhNy5eTA\n\tJ9RK+E5askmeGmK4jtxsgrVmVMUZIwRH2r/MIRVQ=","Date":"Thu, 9 May 2024 14:33:31 +0300","From":"Laurent Pinchart ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 3/6] libcamera: v4l2_subdevice: Add missing\n\tMEDIA_BUS_FMT_xxxx16_1X16 info","Message-ID":"<20240509113331.GJ14520@pendragon.ideasonboard.com>","References":"<20240508080401.14850-1-naush@raspberrypi.com>\n\t<20240508080401.14850-4-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240508080401.14850-4-naush@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]