[{"id":29441,"web_url":"https://patchwork.libcamera.org/comment/29441/","msgid":"<171511341906.3440081.4627785444260155637@ping.linuxembedded.co.uk>","date":"2024-05-07T20:23:39","subject":"Re: [CI] [PATCH v1 2/2] Add compilation tests on Debian 10","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-05-07 19:17:56)\n> A recent compilation breakage was introduced in the libcamera master\n> branch, and wasn't detected in CI due to missing compilation tests with\n> Debian 10. Fix this, and test both gcc 9 and gcc 10 as we support both\n> versions.\n\nSeems like filling in the gaps here is worthwhile.\n\nReviewed-by: Kieran Bingham \n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> .gitlab-ci/setup-container.sh | 5 +++++\n> gitlab-ci.yml | 26 ++++++++++++++++++++++++++\n> 2 files changed, 31 insertions(+)\n> \n> diff --git a/.gitlab-ci/setup-container.sh b/.gitlab-ci/setup-container.sh\n> index 7ed00c58a177..6f75c3209eb7 100755\n> --- a/.gitlab-ci/setup-container.sh\n> +++ b/.gitlab-ci/setup-container.sh\n> @@ -92,6 +92,11 @@ archs=( amd64 )\n> \n> declare -A components\n> \n> +# On Debian bullseye, install gcc 9 in addition to the default gcc 10.\n> +if [[ $FDO_DISTRIBUTION_VERSION == 'bullseye' ]] ; then\n> + PKGS_LIBCAMERA_RUNTIME+=( g++-9 )\n> +fi\n> +\n> # We use Debian bookworm containers to produce ARM binaries and run unit tests\n> # with virtme, and other Debian versions for compilation-testing on amd64 only.\n> if [[ $FDO_DISTRIBUTION_VERSION == 'bookworm' ]] ; then\n> diff --git a/gitlab-ci.yml b/gitlab-ci.yml\n> index 225d929bd2ed..dc8d6bba3672 100644\n> --- a/gitlab-ci.yml\n> +++ b/gitlab-ci.yml\n> @@ -55,6 +55,11 @@ include:\n> FDO_DISTRIBUTION_VERSION: 'buster'\n> FDO_DISTRIBUTION_TAG: '2024-04-18.0'\n> \n> +.libcamera-ci.debian:11:\n> + variables:\n> + FDO_DISTRIBUTION_VERSION: 'bullseye'\n> + FDO_DISTRIBUTION_TAG: '2024-05-07.1'\n> +\n> .libcamera-ci.debian:12:\n> variables:\n> FDO_DISTRIBUTION_VERSION: 'bookworm'\n> @@ -85,6 +90,11 @@ container-debian:10:\n> - .container-debian\n> - .libcamera-ci.debian:10\n> \n> +container-debian:11:\n> + extends:\n> + - .container-debian\n> + - .libcamera-ci.debian:11\n> +\n> container-debian:12:\n> extends:\n> - .container-debian\n> @@ -150,6 +160,22 @@ build-full:debian:10:\n> CC: gcc-8\n> CXX: g++-8\n> \n> +build-full:debian:11:\n> + extends:\n> + - .libcamera-ci.debian:11\n> + - .build-full:debian\n> + needs:\n> + - job: container-debian:11\n> + artifacts: false\n> + parallel:\n> + matrix:\n> + - ARCH: amd64\n> + CC: gcc-9\n> + CXX: g++-9\n> + - ARCH: amd64\n> + CC: gcc-10\n> + CXX: g++-10\n> +\n> build-full:debian:12:\n> extends:\n> - .libcamera-ci.debian:12\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B2466BDE6B\n\tfor ;\n\tTue, 7 May 2024 20:23:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CAE0E63425;\n\tTue, 7 May 2024 22:23:43 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id ECB65633E4\n\tfor ;\n\tTue, 7 May 2024 22:23:41 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 82B34DFB;\n\tTue, 7 May 2024 22:23:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"HwoQqfBc\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715113419;\n\tbh=NdkzW7nBNOM1hHxO+/rBe2cVSPh7NhhZDN5Rx4W8FE0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=HwoQqfBc2AP7JhVJc9d2F0+LdIP4bVvuy/6WSpjV05AbqaytrfLa7Jvittc2ArtjI\n\t9ygH1wzn62M/XjX0jRHykQF7Khknlod+G+S6lUifQtXOxXrjRHrP5xb/a6PVs4GBat\n\til7ib3bgxLJ2GzolIxI2p/P6RaoLm/QUIgDUK4XI=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240507181756.32635-3-laurent.pinchart@ideasonboard.com>","References":"<20240507181756.32635-1-laurent.pinchart@ideasonboard.com>\n\t<20240507181756.32635-3-laurent.pinchart@ideasonboard.com>","Subject":"Re: [CI] [PATCH v1 2/2] Add compilation tests on Debian 10","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 07 May 2024 21:23:39 +0100","Message-ID":"<171511341906.3440081.4627785444260155637@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]