[{"id":29439,"web_url":"https://patchwork.libcamera.org/comment/29439/","msgid":"<171511175071.3440081.9112916556384786052@ping.linuxembedded.co.uk>","date":"2024-05-07T19:55:50","subject":"Re: [PATCH] Revert \"meson: Deprecate bitwise operations between\n\tdifferent enumeration type\"","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-05-07 19:16:07)\n> Enabling -Wdeprecated-enum-enum-conversion by default turned out to be a\n> too hasty decision. It causes compilation failures with Qt headers prior\n> to Qt v5.15.8. As the previous LTS versions of Debian and Ubuntu ship\n> older Qt versions, those errors cause real inconvenience to users.\n> \n> This reverts commit bf4695266bfca8cc21bcf10a3281e874ebce0d27.\n> \n> The original goal of avoiding C++20 compilation regressions is still\n> handled through a test in CI.\n> \n> Signed-off-by: Laurent Pinchart \n\nThanks,\n\nEven my normal local build is broken with bf469526.\n\nThis fixes it.\n\nReviewed-by: Kieran Bingham \n\n> ---\n> meson.build | 9 ---------\n> 1 file changed, 9 deletions(-)\n> \n> diff --git a/meson.build b/meson.build\n> index 89320adbde1f..39e4947f8c97 100644\n> --- a/meson.build\n> +++ b/meson.build\n> @@ -178,15 +178,6 @@ if cc.has_argument('-Wno-c99-designator')\n> ]\n> endif\n> \n> -# Enable the C++20 deprecated enum-enum conversion warning if the compiler\n> -# supports it. This helps avoiding C++20 regressions, and should be removed\n> -# when switching to C++20 as the warning will then be enabled by default.\n> -if cxx.has_argument('-Wdeprecated-enum-enum-conversion')\n> - cpp_arguments += [\n> - '-Wdeprecated-enum-enum-conversion',\n> - ]\n> -endif\n> -\n> c_arguments += common_arguments\n> cpp_arguments += common_arguments\n> \n> \n> base-commit: bf4695266bfca8cc21bcf10a3281e874ebce0d27\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4E255BDE6B\n\tfor ;\n\tTue, 7 May 2024 19:55:56 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 21B8C6342D;\n\tTue, 7 May 2024 21:55:55 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 52E43633E4\n\tfor ;\n\tTue, 7 May 2024 21:55:53 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C9B4F9CE;\n\tTue, 7 May 2024 21:55:50 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I3TmAWeO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715111750;\n\tbh=/JIIi65wL5LkPIjJwbdtpJBG/0NMmVeqk9ZaOchVqsw=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=I3TmAWeORr+Bbc3uUm+IHmzEn+qaP8CPO9UiJcjvwCU6VdppYJKpuNoqYriFDVM0O\n\t0BM8rBFrVlb6xcyR+ffly0sqFVy8DogKfBN+BDuzjdzk9FX9GSzHazUa6sRxXLr/UL\n\t0DMLKgnE9+WZWl6oQCoOfm8gAunJKumvj1K/3n5M=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240507181607.32538-1-laurent.pinchart@ideasonboard.com>","References":"<20240507181607.32538-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH] Revert \"meson: Deprecate bitwise operations between\n\tdifferent enumeration type\"","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 07 May 2024 20:55:50 +0100","Message-ID":"<171511175071.3440081.9112916556384786052@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]