[{"id":29407,"web_url":"https://patchwork.libcamera.org/comment/29407/","msgid":"<315941fc-759b-4cfb-a65b-31c84978d1b7@ideasonboard.com>","date":"2024-05-03T06:06:37","subject":"Re: [PATCH 3/4] apps: qcam: Use standard key sequence for quit\n\taction","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent\n\nThank you for the patch\n\nOn 03/05/24 8:22 am, Laurent Pinchart wrote:\n> Replace the manual CTRL+Q key sequence with QKeySequence::Quit. This\n> automatically maps to the native shortcut for the quit action,\n> regardless of the platform. Even though we don't expect qcam to run on\n> non-Linux platform, using a QKeySequence is still a good practice when\n> one exists.\n>\n> This doesn't change qcam's behaviour, as the native quit key sequence is\n> CTRL+Q on Linux systems.\n>\n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Umang Jain \n> ---\n> src/apps/qcam/main_window.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\n> index 0f16c038d516..361d582532d5 100644\n> --- a/src/apps/qcam/main_window.cpp\n> +++ b/src/apps/qcam/main_window.cpp\n> @@ -190,7 +190,7 @@ int MainWindow::createToolbars()\n> \taction = toolbar_->addAction(QIcon::fromTheme(\"application-exit\",\n> \t\t\t\t\t\t QIcon(\":x-circle.svg\")),\n> \t\t\t\t \"Quit\");\n> -\taction->setShortcut(Qt::CTRL | Qt::Key_Q);\n> +\taction->setShortcut(QKeySequence::Quit);\n> \tconnect(action, &QAction::triggered, this, &MainWindow::quit);\n> \n> \t/* Camera selector. */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 14DEAC3220\n\tfor ;\n\tFri, 3 May 2024 06:06:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A70E663418;\n\tFri, 3 May 2024 08:06:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0D3FD63416\n\tfor ;\n\tFri, 3 May 2024 08:06:38 +0200 (CEST)","from [192.168.1.105] (unknown [103.251.226.40])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A1B212E7;\n\tFri, 3 May 2024 08:05:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"WyAJYpCo\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714716340;\n\tbh=+ApINokwrdw3pWbl8oRh0AqWbEVhuFchckL+n+inaik=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=WyAJYpCo1XXB3TC9WIBLQnsJQ3Lz/eY8RRyVyg/9t10a+PMWR6beUopV+alTQK8o4\n\tZO5y33CTvVFJMtVLITdkhYtuNzUwn8JfnmTCgaD/6e9ZcLSbXGAJjFC36iDOOaSesi\n\tWhoA+oggKR+//oZmnq9bM+vtNf7GhiQFESxkCx08=","Message-ID":"<315941fc-759b-4cfb-a65b-31c84978d1b7@ideasonboard.com>","Date":"Fri, 3 May 2024 11:36:37 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 3/4] apps: qcam: Use standard key sequence for quit\n\taction","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20240503025205.2814-1-laurent.pinchart@ideasonboard.com>\n\t<20240503025205.2814-4-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","In-Reply-To":"<20240503025205.2814-4-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29418,"web_url":"https://patchwork.libcamera.org/comment/29418/","msgid":"<20240503144341.wdh3fagms3o4q7dk@jasper>","date":"2024-05-03T14:43:41","subject":"Re: [PATCH 3/4] apps: qcam: Use standard key sequence for quit\n\taction","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nthanks for the patch.\n\nOn Fri, May 03, 2024 at 05:52:04AM +0300, Laurent Pinchart wrote:\n> Replace the manual CTRL+Q key sequence with QKeySequence::Quit. This\n> automatically maps to the native shortcut for the quit action,\n> regardless of the platform. Even though we don't expect qcam to run on\n> non-Linux platform, using a QKeySequence is still a good practice when\n> one exists.\n> \n> This doesn't change qcam's behaviour, as the native quit key sequence is\n> CTRL+Q on Linux systems.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> ---\n> src/apps/qcam/main_window.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/apps/qcam/main_window.cpp b/src/apps/qcam/main_window.cpp\n> index 0f16c038d516..361d582532d5 100644\n> --- a/src/apps/qcam/main_window.cpp\n> +++ b/src/apps/qcam/main_window.cpp\n> @@ -190,7 +190,7 @@ int MainWindow::createToolbars()\n> \taction = toolbar_->addAction(QIcon::fromTheme(\"application-exit\",\n> \t\t\t\t\t\t QIcon(\":x-circle.svg\")),\n> \t\t\t\t \"Quit\");\n> -\taction->setShortcut(Qt::CTRL | Qt::Key_Q);\n> +\taction->setShortcut(QKeySequence::Quit);\n> \tconnect(action, &QAction::triggered, this, &MainWindow::quit);\n> \n> \t/* Camera selector. */\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E830BDE6B\n\tfor ;\n\tFri, 3 May 2024 14:43:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7A8AF6341C;\n\tFri, 3 May 2024 16:43:46 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AC8B461A8A\n\tfor ;\n\tFri, 3 May 2024 16:43:44 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:723:3164:ef7b:46ca])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 46953675;\n\tFri, 3 May 2024 16:42:46 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"X50dmotI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714747366;\n\tbh=IsMtlb4kqmJjRKe4SWAxanffZe3iKPZdP7Ghe+yeBgw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=X50dmotIVypSGm+Ty8xJX1ML2/8jTthm/AHLfPbjrn9yubPKQa7AjvO7yE6RszjQ0\n\t9HlS/cEISAB6SwJRPwxrnMe0r0ZQ/irDCjg9/wjJaObo1VZnOi7yWfQ/1hsLuf5BVx\n\tQr67v/DqN3N873axONVjXDBprgsSsYYoYkSM09Rg=","Date":"Fri, 3 May 2024 16:43:41 +0200","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 3/4] apps: qcam: Use standard key sequence for quit\n\taction","Message-ID":"<20240503144341.wdh3fagms3o4q7dk@jasper>","References":"<20240503025205.2814-1-laurent.pinchart@ideasonboard.com>\n\t<20240503025205.2814-4-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240503025205.2814-4-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]