[{"id":29406,"web_url":"https://patchwork.libcamera.org/comment/29406/","msgid":"<708a5be2-a6d5-495d-bf32-8d03c0d37d81@ideasonboard.com>","date":"2024-05-03T06:05:45","subject":"Re: [PATCH 1/4] libcamera: utils: Avoid infinite recursion with\n\tstrtod()","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 03/05/24 8:22 am, Laurent Pinchart wrote:\n> When the C library doesn't provide local object support, the\n> utils::strtod() function simply calls strtod() from the C library. The\n> current implementation does so incorrectly, and calls utils::strtod()\n> instead, resulting in infinite recursion. Fix it with a proper namespace\n> qualifier.\n>\n> Signed-off-by: Laurent Pinchart \n\nSeems quite a serious issue,\n\nReviewed-by: Umang Jain \n> ---\n> src/libcamera/base/utils.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/src/libcamera/base/utils.cpp b/src/libcamera/base/utils.cpp\n> index 2f4c3177ac13..96023f992e03 100644\n> --- a/src/libcamera/base/utils.cpp\n> +++ b/src/libcamera/base/utils.cpp\n> @@ -517,7 +517,7 @@ double strtod(const char *__restrict nptr, char **__restrict endptr)\n> \t * If the libc implementation doesn't provide locale object support,\n> \t * assume that strtod() is locale-independent.\n> \t */\n> -\treturn strtod(nptr, endptr);\n> +\treturn ::strtod(nptr, endptr);\n> #endif\n> }\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D9280C3220\n\tfor ;\n\tFri, 3 May 2024 06:05:52 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0C95E63419;\n\tFri, 3 May 2024 08:05:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E7BFF6340B\n\tfor ;\n\tFri, 3 May 2024 08:05:50 +0200 (CEST)","from [192.168.1.105] (unknown [103.251.226.40])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4EFE12E7;\n\tFri, 3 May 2024 08:04:52 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"lPMFJB9q\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714716292;\n\tbh=HXZEWynWZ7LjRHqQpGouN61C24zk5/Br59E7JAXX2lE=;\n\th=Date:Subject:To:References:From:In-Reply-To:From;\n\tb=lPMFJB9qA83hAMCSClCNazKwuBzM6V3pPVZ0cnurLyPdOeUngdD997WxVKselYktj\n\tAp+qtEkOdcVt6ImxW45rp3o1ifTUL3+yKXz0GNMYDnrZB4AL8Vd3teD9BsaPGJHNYe\n\tXIefxqENA3tsrZKxZrt2fkWgkH/G94hft1f4gqwo=","Message-ID":"<708a5be2-a6d5-495d-bf32-8d03c0d37d81@ideasonboard.com>","Date":"Fri, 3 May 2024 11:35:45 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 1/4] libcamera: utils: Avoid infinite recursion with\n\tstrtod()","Content-Language":"en-US","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","References":"<20240503025205.2814-1-laurent.pinchart@ideasonboard.com>\n\t<20240503025205.2814-2-laurent.pinchart@ideasonboard.com>","From":"Umang Jain ","In-Reply-To":"<20240503025205.2814-2-laurent.pinchart@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29415,"web_url":"https://patchwork.libcamera.org/comment/29415/","msgid":"<20240503143755.lbpp3nzvvohsfhwl@jasper>","date":"2024-05-03T14:37:55","subject":"Re: [PATCH 1/4] libcamera: utils: Avoid infinite recursion with\n\tstrtod()","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Laurent,\n\nthanks for the patch.\n\nOn Fri, May 03, 2024 at 05:52:02AM +0300, Laurent Pinchart wrote:\n> When the C library doesn't provide local object support, the\n> utils::strtod() function simply calls strtod() from the C library. The\n> current implementation does so incorrectly, and calls utils::strtod()\n> instead, resulting in infinite recursion. Fix it with a proper namespace\n> qualifier.\n\nMakes me curious which clib that was.\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> \n> Signed-off-by: Laurent Pinchart \n> ---\n> src/libcamera/base/utils.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/base/utils.cpp b/src/libcamera/base/utils.cpp\n> index 2f4c3177ac13..96023f992e03 100644\n> --- a/src/libcamera/base/utils.cpp\n> +++ b/src/libcamera/base/utils.cpp\n> @@ -517,7 +517,7 @@ double strtod(const char *__restrict nptr, char **__restrict endptr)\n> \t * If the libc implementation doesn't provide locale object support,\n> \t * assume that strtod() is locale-independent.\n> \t */\n> -\treturn strtod(nptr, endptr);\n> +\treturn ::strtod(nptr, endptr);\n> #endif\n> }\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 049A7C3220\n\tfor ;\n\tFri, 3 May 2024 14:38:01 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F125C6340B;\n\tFri, 3 May 2024 16:38:00 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EC6E861A8A\n\tfor ;\n\tFri, 3 May 2024 16:37:58 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:723:3164:ef7b:46ca])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 718B5675;\n\tFri, 3 May 2024 16:37:00 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I2ULVgEn\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714747020;\n\tbh=LiQqjKNGlpNwpCmB/Yvzxjq8NDU7HkrTbkzUMN1Hibs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=I2ULVgEn75RyjBJwmka69CQ+J20yquAhGl+oL9ZWXMiD23R+N8SN5wYRjEPh74iYE\n\ttS0/zhYcYi5g2VDIoqLmsZHZXF/P1VMkZreYKXfX3Rpl22jeNnb08uho5L6bF6aheO\n\ttwLBAqVTfvQ3F2PRV/PeW6aANsSLSXkAv9SQQ99o=","Date":"Fri, 3 May 2024 16:37:55 +0200","From":"Stefan Klug ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/4] libcamera: utils: Avoid infinite recursion with\n\tstrtod()","Message-ID":"<20240503143755.lbpp3nzvvohsfhwl@jasper>","References":"<20240503025205.2814-1-laurent.pinchart@ideasonboard.com>\n\t<20240503025205.2814-2-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240503025205.2814-2-laurent.pinchart@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29416,"web_url":"https://patchwork.libcamera.org/comment/29416/","msgid":"<20240503143933.GA6657@pendragon.ideasonboard.com>","date":"2024-05-03T14:39:33","subject":"Re: [PATCH 1/4] libcamera: utils: Avoid infinite recursion with\n\tstrtod()","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, May 03, 2024 at 04:37:55PM +0200, Stefan Klug wrote:\n> Hi Laurent,\n> \n> thanks for the patch.\n> \n> On Fri, May 03, 2024 at 05:52:02AM +0300, Laurent Pinchart wrote:\n> > When the C library doesn't provide local object support, the\n> > utils::strtod() function simply calls strtod() from the C library. The\n> > current implementation does so incorrectly, and calls utils::strtod()\n> > instead, resulting in infinite recursion. Fix it with a proper namespace\n> > qualifier.\n> \n> Makes me curious which clib that was.\n> Reviewed-by: Stefan Klug \n\nI noticed this with uclibc.\n\n> > \n> > Signed-off-by: Laurent Pinchart \n> > ---\n> > src/libcamera/base/utils.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/base/utils.cpp b/src/libcamera/base/utils.cpp\n> > index 2f4c3177ac13..96023f992e03 100644\n> > --- a/src/libcamera/base/utils.cpp\n> > +++ b/src/libcamera/base/utils.cpp\n> > @@ -517,7 +517,7 @@ double strtod(const char *__restrict nptr, char **__restrict endptr)\n> > \t * If the libc implementation doesn't provide locale object support,\n> > \t * assume that strtod() is locale-independent.\n> > \t */\n> > -\treturn strtod(nptr, endptr);\n> > +\treturn ::strtod(nptr, endptr);\n> > #endif\n> > }\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 48C77BDE6B\n\tfor ;\n\tFri, 3 May 2024 14:39:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C8B7563418;\n\tFri, 3 May 2024 16:39:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D174661A8A\n\tfor ;\n\tFri, 3 May 2024 16:39:41 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 68934675;\n\tFri, 3 May 2024 16:38:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UqbIp5fe\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714747123;\n\tbh=c9whcmbG74m9j0hyecoIwUqoqoSCUIeQ/JW3vblxCnI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=UqbIp5fevvmv4zaYKNeV6at0BUXQtTsHZxpv/KNC0VqRPBh1Pxapx8EymfDsbWubt\n\twMC2jmTPfwXHXWwSmW7Vr/CNssItFBIfKSd69zJRF+8kW7qo7XkcIxEClIHVnel74B\n\t+4EjXe9P4ebbIuJiygrqIFhdVQSZ2me5kV/uOAGU=","Date":"Fri, 3 May 2024 17:39:33 +0300","From":"Laurent Pinchart ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 1/4] libcamera: utils: Avoid infinite recursion with\n\tstrtod()","Message-ID":"<20240503143933.GA6657@pendragon.ideasonboard.com>","References":"<20240503025205.2814-1-laurent.pinchart@ideasonboard.com>\n\t<20240503025205.2814-2-laurent.pinchart@ideasonboard.com>\n\t<20240503143755.lbpp3nzvvohsfhwl@jasper>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240503143755.lbpp3nzvvohsfhwl@jasper>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]