[{"id":29443,"web_url":"https://patchwork.libcamera.org/comment/29443/","msgid":"<171516015778.1857112.10397047260086189387@ping.linuxembedded.co.uk>","date":"2024-05-08T09:22:37","subject":"Re: [PATCH v4 4/8] ipa: libipa: Add AgcMeanLuminance base class","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Daniel Scally (2024-05-02 14:30:42)\n> The Agc algorithms for the RkIsp1 and IPU3 IPAs do the same thing in\n> very large part; following the Rpi IPA's algorithm in spirit with a\n> few tunable values in that IPA being hardcoded in the libipa ones.\n> Add a new base class for AgcMeanLuminance which implements the same\n> algorithm and additionally parses yaml tuning files to inform an IPA\n> module's Agc algorithm about valid constraint and exposure modes and\n> their associated bounds.\n> \n> Reviewed-by: Jacopo Mondi \n> Reviewed-by: Stefan Klug \n> Reviewed-by: Paul Elder \n> Signed-off-by: Daniel Scally \n> ---\n\n...\n\n> +}\n> +\n> +/**\n> + * \\fn AgcMeanLuminance::resetFrameCount()\n> + * \\brief Reset the frame counter\n> + *\n> + * This function resets the internal frame counter, which exists to help the\n> + * algorithm decide whether it should respond instantly or not. The expectation\n> + * is for derived classes to call this function before each camera start call in\n> + * their configure() function.\n> + */\n> +\n> +}; /* namespace ipa */\n> +\n> +}; /* namespace libcamera */\n\nBoth of these namespaces fail the CI.\n- https://gitlab.freedesktop.org/camera/libcamera/-/jobs/58479980\n\nFAILED: src/ipa/libipa/libipa.a.p/agc_mean_luminance.cpp.o\nclang++ -Isrc/ipa/libipa/libipa.a.p -Isrc/ipa/libipa -I../src/ipa/libipa -Iinclude -I../include -Iinclude/libcamera/ipa -Iinclude/libcamera -fcolor-diagnostics -D_FILE_OFFSET_BITS=64 -Wall -Winvalid-pch -Wextra -Werror -std=c++17 -O0 -g -stdlib=libc++ -Wextra-semi -Wthread-safety -Wshadow -include /builds/camera/libcamera/build/config.h -Wno-c99-designator -fPIC -DLIBCAMERA_BASE_PRIVATE -MD -MQ src/ipa/libipa/libipa.a.p/agc_mean_luminance.cpp.o -MF src/ipa/libipa/libipa.a.p/agc_mean_luminance.cpp.o.d -o src/ipa/libipa/libipa.a.p/agc_mean_luminance.cpp.o -c ../src/ipa/libipa/agc_mean_luminance.cpp\nIn file included from ../src/ipa/libipa/agc_mean_luminance.cpp:8:\n../src/ipa/libipa/agc_mean_luminance.h:94:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]\n}; /* namespace ipa */\n ^\n../src/ipa/libipa/agc_mean_luminance.h:96:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]\n}; /* namespace libcamera */\n ^\n../src/ipa/libipa/agc_mean_luminance.cpp:575:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]\n}; /* namespace ipa */\n ^\n../src/ipa/libipa/agc_mean_luminance.cpp:577:2: error: extra ';' outside of a function is incompatible with C++98 [-Werror,-Wc++98-compat-extra-semi]\n}; /* namespace libcamera */\n ^\n4 errors generated.\n\n\nAs this is just a removal of an unwanted semi-colon, I'll fix these\nlocally and retry the CI.\n\n\n\n...\n> +};\n> +\n> +}; /* namespace ipa */\n> +\n> +}; /* namespace libcamera */\n\n\nAnd these two ...\n\n--\nKieran","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 9075CC3226\n\tfor ;\n\tWed, 8 May 2024 09:22:43 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 5DB3163437;\n\tWed, 8 May 2024 11:22:42 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1CE7663415\n\tfor ;\n\tWed, 8 May 2024 11:22:41 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 28A9B16C5;\n\tWed, 8 May 2024 11:22:38 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UKC+/HgP\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1715160158;\n\tbh=jCEvmVzB59Tm67HFivmi5/jcQJyFOMjD1vBXxuGaz+k=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=UKC+/HgPCsdHQgBJ++cJV2296Q2tVyp35CzqUOPEcYCmZmpbUMBa9dkdvLyuHbMzm\n\tPPKqBuBeSSfb/icE6Esrr9b4zKG3XkAFj6m6aQap02gEf46wDcGdWUIIstlF8dlHvr\n\tsH6JNOvosGV4URJmyoISdvN3uFTmq0EtP2XQNYHQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240502133046.1976565-5-dan.scally@ideasonboard.com>","References":"<20240502133046.1976565-1-dan.scally@ideasonboard.com>\n\t<20240502133046.1976565-5-dan.scally@ideasonboard.com>","Subject":"Re: [PATCH v4 4/8] ipa: libipa: Add AgcMeanLuminance base class","From":"Kieran Bingham ","Cc":"Daniel Scally ,\n\tJacopo Mondi ,\n\tStefan Klug ,\n\tPaul Elder ","To":"Daniel Scally ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Wed, 08 May 2024 10:22:37 +0100","Message-ID":"<171516015778.1857112.10397047260086189387@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]