[{"id":29383,"web_url":"https://patchwork.libcamera.org/comment/29383/","msgid":"","date":"2024-05-02T10:05:51","subject":"Re: [PATCH v1 4/5] ipa: rpi: Move variables from private to\n\tprotected","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Naush\n\nOn Thu, May 02, 2024 at 09:09:24AM GMT, Naushir Patuck wrote:\n> The following member variable will be used by the derived IPAs in an\n> upcoming commit, so make them protected:\n>\n> lensPresent_\n> monoSensor_\n>\n> Signed-off-by: Naushir Patuck \n\nReviewed-by: Jacopo Mondi \n\nThanks\n j\n\n> ---\n> src/ipa/rpi/common/ipa_base.h | 6 +++---\n> 1 file changed, 3 insertions(+), 3 deletions(-)\n>\n> diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\n> index 512d7e8fe778..ebdc4d297abb 100644\n> --- a/src/ipa/rpi/common/ipa_base.h\n> +++ b/src/ipa/rpi/common/ipa_base.h\n> @@ -71,6 +71,9 @@ protected:\n> \t/* Whether the stitch block (if available) needs to swap buffers. */\n> \tbool stitchSwapBuffers_;\n>\n> +\tbool monoSensor_;\n> +\tbool lensPresent_;\n> +\n> private:\n> \t/* Number of metadata objects available in the context list. */\n> \tstatic constexpr unsigned int numMetadataContexts = 16;\n> @@ -96,9 +99,6 @@ private:\n>\n> \tstd::map buffers_;\n>\n> -\tbool lensPresent_;\n> -\tbool monoSensor_;\n> -\n> \tstd::array rpiMetadata_;\n>\n> \t/*\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 409EEBDE6B\n\tfor ;\n\tThu, 2 May 2024 10:05:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4451C63419;\n\tThu, 2 May 2024 12:05:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A3C506340B\n\tfor ;\n\tThu, 2 May 2024 12:05:54 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A1E93A3;\n\tThu, 2 May 2024 12:04:57 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"i39XtEEq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714644297;\n\tbh=W4LwO1ziphpiCrE1yLRKATF234A1ybDJPygxr28pJqQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=i39XtEEq85o9Qy+3EFhcp42MUdmmfK4ONQIOS0YUeiIjxfALLEMi6nLqTY8MmInux\n\tEgo1juhyOy0JJkbXFS/aTJ6/7Rclz/DBLUPND130j8cDKF68mXRZzbX6R/Vbqo3urk\n\tV9trHy7U6UFjqBUgb+nYCvNurjtiaZOKDBleC1rg=","Date":"Thu, 2 May 2024 12:05:51 +0200","From":"Jacopo Mondi ","To":"Naushir Patuck ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v1 4/5] ipa: rpi: Move variables from private to\n\tprotected","Message-ID":"","References":"<20240502080925.31730-1-naush@raspberrypi.com>\n\t<20240502080925.31730-5-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240502080925.31730-5-naush@raspberrypi.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]