{"id":19979,"url":"https://patchwork.libcamera.org/api/patches/19979/?format=json","web_url":"https://patchwork.libcamera.org/patch/19979/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240502080925.31730-5-naush@raspberrypi.com>","date":"2024-05-02T08:09:24","name":"[v1,4/5] ipa: rpi: Move variables from private to protected","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"f211671212282cc3f2671835a5356c2bd9b02006","submitter":{"id":34,"url":"https://patchwork.libcamera.org/api/people/34/?format=json","name":"Naushir Patuck","email":"naush@raspberrypi.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19979/mbox/","series":[{"id":4283,"url":"https://patchwork.libcamera.org/api/series/4283/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4283","date":"2024-05-02T08:09:20","name":"Pre Raspberry Pi 5 support changes","version":1,"mbox":"https://patchwork.libcamera.org/series/4283/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19979/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19979/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B01A2C32C9\n\tfor ;\n\tThu, 2 May 2024 08:09:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 100F46341B;\n\tThu, 2 May 2024 10:09:40 +0200 (CEST)","from mail-wm1-x32a.google.com (mail-wm1-x32a.google.com\n\t[IPv6:2a00:1450:4864:20::32a])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 22D046340B\n\tfor ;\n\tThu, 2 May 2024 10:09:37 +0200 (CEST)","by mail-wm1-x32a.google.com with SMTP id\n\t5b1f17b1804b1-41a72f3a20dso53129825e9.0\n\tfor ;\n\tThu, 02 May 2024 01:09:37 -0700 (PDT)","from localhost.localdomain ([188.39.149.98])\n\tby smtp.gmail.com with ESMTPSA id\n\tp12-20020a05600c1d8c00b0041bcb898984sm1049970wms.31.2024.05.02.01.09.36\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tThu, 02 May 2024 01:09:36 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=raspberrypi.com header.i=@raspberrypi.com\n\theader.b=\"h8KKUuxY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=raspberrypi.com; s=google; t=1714637376; x=1715242176;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=nxXm2ChhWGkIUK/b0RakYTICcoi5twMYP1Qaj6ksUZc=;\n\tb=h8KKUuxYQPQ3Suu3hTh6jriPkhT03FsiZaXnjEqIvwX4L3phnitWXWo1P7QNJ5Jw7W\n\tawF7yLpRLg+JGiNTAab4DWKmIMyZcTYr9pjUXQhtdtWzUoYV+X2XP8ZsNP8jMPOJk8oM\n\tl7/cJXcla8aS+DmvMEl/diZH2flBE23Ld93V1zLrBXhBYIO9hETdbHIRSE6Rc4faJxr2\n\t9aPkn8DP51c0PYFofoCZHzVa00i9bS2mWaS4gHuqYLYgIgxIK3cQTYcgIBEhmesXmaIi\n\tQ6yfimlRJuWYgV0kK+k0dAYSb1QfmLM3cS9t3UziLGmKEaHY3NQO2PPFfcJHBKRdv+cw\n\tNnXA==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1714637376; x=1715242176;\n\th=content-transfer-encoding:mime-version:references:in-reply-to\n\t:message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc\n\t:subject:date:message-id:reply-to;\n\tbh=nxXm2ChhWGkIUK/b0RakYTICcoi5twMYP1Qaj6ksUZc=;\n\tb=iMkZqWa5A1hiTu8PxfKWJ9y7CWdscBuWldfNOZc7hY6NN8eyQyD8kvtLlVdVF7LD93\n\tiWzRU/0za8FNSP6vc01qX2qtfzlxvgnISB8GImmeVMFR11eZw6p7UuktNEgDNJFxa0LE\n\tBSHPo8KKCt+lJyovDj5LEwxFQUGgMdeheNvOYyNZHpgYgxjiq4tg4+d5fS5HGRzu2+JV\n\tiJS/ONe5YPC1oYw0lvQkMIkNac1wn9iBHuMGLBKZyyyM+yaqhH6wWvSaaujzsE986foq\n\tvbAopDb1xdRF4UK9SEXSlKp+zWMj8qcvniPfSVH4HHuKqk9mfL1LqaP/dS0cHYJZoF2p\n\twjIw==","X-Gm-Message-State":"AOJu0YwTHxrLZtSK38bRStz8XRn67U1EALAWiGuFN/OwWhn9OnNLqBJa\n\tT+fi3yLPW0+V7WqtyIW9kiQTVoyRL5I4+U1kPXD6SxGycEDO/23EQaWH2kUAXpnXH4XHybJJMTa\n\ti","X-Google-Smtp-Source":"AGHT+IH4cYEHmmFJUZj2/MffIgbN3JF64DgDtm8DG0CGp01ghhAuNtHkEoHuiZufC1ozOdGpqzizpA==","X-Received":"by 2002:a05:600c:4446:b0:41b:a4bd:af26 with SMTP id\n\tv6-20020a05600c444600b0041ba4bdaf26mr881282wmn.13.1714637376545; \n\tThu, 02 May 2024 01:09:36 -0700 (PDT)","From":"Naushir Patuck ","To":"libcamera-devel@lists.libcamera.org","Cc":"Naushir Patuck ","Subject":"[PATCH v1 4/5] ipa: rpi: Move variables from private to protected","Date":"Thu, 2 May 2024 09:09:24 +0100","Message-Id":"<20240502080925.31730-5-naush@raspberrypi.com>","X-Mailer":"git-send-email 2.34.1","In-Reply-To":"<20240502080925.31730-1-naush@raspberrypi.com>","References":"<20240502080925.31730-1-naush@raspberrypi.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"The following member variable will be used by the derived IPAs in an\nupcoming commit, so make them protected:\n\nlensPresent_\nmonoSensor_\n\nSigned-off-by: Naushir Patuck \n---\n src/ipa/rpi/common/ipa_base.h | 6 +++---\n 1 file changed, 3 insertions(+), 3 deletions(-)","diff":"diff --git a/src/ipa/rpi/common/ipa_base.h b/src/ipa/rpi/common/ipa_base.h\nindex 512d7e8fe778..ebdc4d297abb 100644\n--- a/src/ipa/rpi/common/ipa_base.h\n+++ b/src/ipa/rpi/common/ipa_base.h\n@@ -71,6 +71,9 @@ protected:\n \t/* Whether the stitch block (if available) needs to swap buffers. */\n \tbool stitchSwapBuffers_;\n \n+\tbool monoSensor_;\n+\tbool lensPresent_;\n+\n private:\n \t/* Number of metadata objects available in the context list. */\n \tstatic constexpr unsigned int numMetadataContexts = 16;\n@@ -96,9 +99,6 @@ private:\n \n \tstd::map buffers_;\n \n-\tbool lensPresent_;\n-\tbool monoSensor_;\n-\n \tstd::array rpiMetadata_;\n \n \t/*\n","prefixes":["v1","4/5"]}