[{"id":29592,"web_url":"https://patchwork.libcamera.org/comment/29592/","msgid":"","date":"2024-05-22T09:45:06","subject":"Re: [PATCH v2 1/5] libcamera: software_isp: Use a specific integer\n\ttype for black level","submitter":{"id":179,"url":"https://patchwork.libcamera.org/api/people/179/","name":"Andrei Konovalov","email":"andrey.konovalov.ynk@gmail.com"},"content":"Hi Milan,\n\nThank you for the patch!\n\nReviewed-by: Andrei Konovalov \n\nOn 30.04.2024 20:34, Milan Zamazal wrote:\n> The documented range of values corresponds to uint8_t, so let's use that\n> type.\n> \n> Signed-off-by: Milan Zamazal \n> Reviewed-by: Laurent Pinchart \n> ---\n> src/ipa/simple/black_level.cpp | 2 +-\n> src/ipa/simple/black_level.h | 5 +++--\n> 2 files changed, 4 insertions(+), 3 deletions(-)\n> \n> diff --git a/src/ipa/simple/black_level.cpp b/src/ipa/simple/black_level.cpp\n> index c7e8d8b7..410dc17b 100644\n> --- a/src/ipa/simple/black_level.cpp\n> +++ b/src/ipa/simple/black_level.cpp\n> @@ -43,7 +43,7 @@ BlackLevel::BlackLevel()\n> * \\return The black level, in the range from 0 (minimum) to 255 (maximum).\n> * If the black level couldn't be determined yet, return 0.\n> */\n> -unsigned int BlackLevel::get() const\n> +uint8_t BlackLevel::get() const\n> {\n> \treturn blackLevelSet_ ? blackLevel_ : 0;\n> }\n> diff --git a/src/ipa/simple/black_level.h b/src/ipa/simple/black_level.h\n> index 7e37757e..e6cfa7ed 100644\n> --- a/src/ipa/simple/black_level.h\n> +++ b/src/ipa/simple/black_level.h\n> @@ -8,6 +8,7 @@\n> #pragma once\n> \n> #include \n> +#include \n> \n> #include \"libcamera/internal/software_isp/swisp_stats.h\"\n> \n> @@ -17,11 +18,11 @@ class BlackLevel\n> {\n> public:\n> \tBlackLevel();\n> -\tunsigned int get() const;\n> +\tuint8_t get() const;\n> \tvoid update(SwIspStats::Histogram &yHistogram);\n> \n> private:\n> -\tunsigned int blackLevel_;\n> +\tuint8_t blackLevel_;\n> \tbool blackLevelSet_;\n> };\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 80996BD78E\n\tfor ;\n\tWed, 22 May 2024 09:45:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 204F96348E;\n\tWed, 22 May 2024 11:45:12 +0200 (CEST)","from mail-qv1-xf2f.google.com (mail-qv1-xf2f.google.com\n\t[IPv6:2607:f8b0:4864:20::f2f])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F3A5161A50\n\tfor ;\n\tWed, 22 May 2024 11:45:09 +0200 (CEST)","by mail-qv1-xf2f.google.com with SMTP id\n\t6a1803df08f44-6ab20178a78so8502546d6.3\n\tfor ;\n\tWed, 22 May 2024 02:45:09 -0700 (PDT)","from [192.168.118.26] ([87.116.162.89])\n\tby smtp.gmail.com with ESMTPSA id\n\t6a1803df08f44-6a15f1cd3f4sm130389136d6.102.2024.05.22.02.45.07\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 22 May 2024 02:45:08 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (2048-bit key;\n\tunprotected) header.d=gmail.com header.i=@gmail.com\n\theader.b=\"SxMruo31\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=gmail.com; s=20230601; t=1716371109; x=1716975909;\n\tdarn=lists.libcamera.org; \n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:from:to:cc:subject:date:message-id:reply-to;\n\tbh=PPg9ROGcJET/vENT6V6MtIJIgg4mQkrurmLuIE0days=;\n\tb=SxMruo31MXSE+R7QvTbH+FOER5EylLVDLGSr0FEUicWKB6cVe72uEJ5pUCVSe1fR5A\n\tYGNbBaa89p1X630mfyKRm4tgMzkviRWpD44IA3SFDYfJGgxRkre40Ej5Pp3X4Fb8yDRe\n\teFW6SxA+OqiIpwIqFfp7EnWZwyoS+DGxtzwHSYMb+YpjCEP3t7R/jP0MJXLUjKzwYCo2\n\tscJ8meiN9iSsFtqcGgefiaafljMAOwTXSG42mV5DkNU87a5WEAIHEHKZqgfn6NX1XIBj\n\tCYO28Qyg4/rGfTeAxyr6sK6N0Q0hRUErSoRUOOto095dW1WfSy5pGWkh5b2H+j5pstIU\n\tFbcg==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1716371109; x=1716975909;\n\th=content-transfer-encoding:in-reply-to:from:content-language\n\t:references:cc:to:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=PPg9ROGcJET/vENT6V6MtIJIgg4mQkrurmLuIE0days=;\n\tb=El2x3kq7NGr4SWcvONUzz/Y2Wotseapr0T+NiS7zca4189977GlCHF3ZsL4QXJeI+V\n\tDB46Ylow+dWWsyuDgwAMIyJJDxF/rjRWfuYUigCV+aR2JVa+3HeYVMKQcUEdlIH5hCFl\n\tBtMmkwaQgNMxyzsYTcYCQ0JUe1kCfmtkPltkGO4oJmFwxd76XnCOBOcQ8uz9qaLBLKK+\n\ti0ETc35B9BB59e57Z9Mai1Xkjpsw2OGENsJ/JSDIeuqSbvAM51BlD4b4sugDLud2SoYF\n\tbnk3i2kzDwpTopbSDnXog5m703bSCynSCPWqVXF06LoPTWB98nkUOJihyTd5PKKm+/9c\n\tvKkA==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCWC2yMoO+fVSMnOU0wMWDzt8/7Gv3qGkRptctAN39qBg21f+I/G/DCVjYeA2iphinEZiMnGQYq8syLU+Ghtb7lw+uLgsPGKRlDBSOrvK8kB56DTBw==","X-Gm-Message-State":"AOJu0Yyz/uMtPQHTHwF8kMqq5ol8TV9DiM56YtiFJ0lqwkGWZmi/S3Wj\n\tPXqVKgV8T6M1NS5dhvygxWNV503Gfw/LK9WQ+w1J5vYofXkXt1A/","X-Google-Smtp-Source":"AGHT+IEdmwold4+OIds746jKOVDK7pATrbC1gnAraCfG7u1ooVDBSEZKpjVvflqGLAF+NkSXH37DfA==","X-Received":"by 2002:a05:6214:418e:b0:6ab:6cd6:bbf4 with SMTP id\n\t6a1803df08f44-6ab7f331310mr13512356d6.11.1716371108773; \n\tWed, 22 May 2024 02:45:08 -0700 (PDT)","Message-ID":"","Date":"Wed, 22 May 2024 12:45:06 +0300","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 1/5] libcamera: software_isp: Use a specific integer\n\ttype for black level","To":"Milan Zamazal , libcamera-devel@lists.libcamera.org","Cc":"Laurent Pinchart ","References":"<20240430173430.200392-1-mzamazal@redhat.com>\n\t<20240430173430.200392-2-mzamazal@redhat.com>","Content-Language":"en-US","From":"Andrei Konovalov ","In-Reply-To":"<20240430173430.200392-2-mzamazal@redhat.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]