[{"id":29364,"web_url":"https://patchwork.libcamera.org/comment/29364/","msgid":"<20240429092635.sj5xofnlvloyujhk@jasper>","date":"2024-04-29T09:26:35","subject":"Re: [PATCH v2 2/2] libcamera: libipa: camera_sensor: Add Sony IMX335\n\tsensor properties","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Umang,\n\nthanks for the patch.\n\nOn Fri, Apr 26, 2024 at 06:55:16PM +0530, Umang Jain wrote:\n> From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> Provide the Sony IMX335 camera sensor properties and registration\n> with libipa for the gain code helpers.\n> \n> The test patterns exposed by the IMX335 do not map well to the current\n> set of test pattern controls supplied by libcamera. These are left\n> inentionally unimplemented.\n\ns/inentionally/intentionally/\n\nOtherwise looks good to me.\nReviewed-by: Stefan Klug <stefan.klug@ideasonboard.com> \n\nCheers,\nStefan\n\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>\n> ---\n>  src/ipa/libipa/camera_sensor_helper.cpp           | 11 +++++++++++\n>  src/libcamera/sensor/camera_sensor_properties.cpp |  4 ++++\n>  2 files changed, 15 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index f70d898f..84d52d10 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -455,6 +455,17 @@ class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n>  \n> +class CameraSensorHelperImx335 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperImx335()\n> +\t{\n> +\t\tgainType_ = AnalogueGainExponential;\n> +\t\tgainConstants_.exp = { 1.0, expGainDb(0.3) };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx335\", CameraSensorHelperImx335)\n> +\n>  class CameraSensorHelperImx477 : public CameraSensorHelper\n>  {\n>  public:\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index 4eabbbda..895bf967 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -115,6 +115,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n>  \t\t\t.unitCellSize = { 2900, 2900 },\n>  \t\t\t.testPatternModes = {},\n>  \t\t} },\n> +\t\t{ \"imx335\", {\n> +\t\t\t.unitCellSize = { 2000, 2000 },\n> +\t\t\t.testPatternModes = {},\n> +\t\t} },\n>  \t\t{ \"imx477\", {\n>  \t\t\t.unitCellSize = { 1550, 1550 },\n>  \t\t\t.testPatternModes = {},\n> -- \n> 2.44.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 33D16C3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tMon, 29 Apr 2024 09:26:40 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 44F906341A;\n\tMon, 29 Apr 2024 11:26:39 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A694063416\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tMon, 29 Apr 2024 11:26:38 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:68ce:fe8f:55aa:adfe])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 492FD4AB;\n\tMon, 29 Apr 2024 11:25:43 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"I7NxEQB/\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714382743;\n\tbh=llrFurZ9d8M+bjeY5S0+A2tKaT3LA9xY/ntmxyoIa5U=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=I7NxEQB/uCKSf21yHR7rC5mpHrdcASfLjdzuGf49LoWKsUGEEox3fj0Kr2zsl0JU5\n\tnm9I4AYm2ANHTVxPAwPxFj0NmKT/rYzkA6GayYtT6tEbDMeGd1s/il5mUb/pwEy2mR\n\t1XArJL9a+PNpbzgFgoGXX+VryVcgqlVLed/2QVeI=","Date":"Mon, 29 Apr 2024 11:26:35 +0200","From":"Stefan Klug <stefan.klug@ideasonboard.com>","To":"Umang Jain <umang.jain@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH v2 2/2] libcamera: libipa: camera_sensor: Add Sony IMX335\n\tsensor properties","Message-ID":"<20240429092635.sj5xofnlvloyujhk@jasper>","References":"<20240426132516.11085-1-umang.jain@ideasonboard.com>\n\t<20240426132516.11085-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240426132516.11085-3-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":29390,"web_url":"https://patchwork.libcamera.org/comment/29390/","msgid":"<ecqmgodxtictpl33bsoxnzta6h5qbwt54t4wphxu7ah3aiqikf@slrhxnf3jk57>","date":"2024-05-02T15:30:04","subject":"Re: [PATCH v2 2/2] libcamera: libipa: camera_sensor: Add Sony IMX335\n\tsensor properties","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Umang\n\nOn Fri, Apr 26, 2024 at 06:55:16PM +0530, Umang Jain wrote:\n> From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>\n> Provide the Sony IMX335 camera sensor properties and registration\n> with libipa for the gain code helpers.\n>\n> The test patterns exposed by the IMX335 do not map well to the current\n> set of test pattern controls supplied by libcamera. These are left\n> inentionally unimplemented.\n\nintentionally\n\nDo we have dumps of these test patterns (for this and the imx283) as\nthe datahseet doesn't report them ?\n\n\n>\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>\n\nReviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n\nThanks\n  j\n\n> ---\n>  src/ipa/libipa/camera_sensor_helper.cpp           | 11 +++++++++++\n>  src/libcamera/sensor/camera_sensor_properties.cpp |  4 ++++\n>  2 files changed, 15 insertions(+)\n>\n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index f70d898f..84d52d10 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -455,6 +455,17 @@ class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n>\n> +class CameraSensorHelperImx335 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperImx335()\n> +\t{\n> +\t\tgainType_ = AnalogueGainExponential;\n> +\t\tgainConstants_.exp = { 1.0, expGainDb(0.3) };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx335\", CameraSensorHelperImx335)\n> +\n>  class CameraSensorHelperImx477 : public CameraSensorHelper\n>  {\n>  public:\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index 4eabbbda..895bf967 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -115,6 +115,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n>  \t\t\t.unitCellSize = { 2900, 2900 },\n>  \t\t\t.testPatternModes = {},\n>  \t\t} },\n> +\t\t{ \"imx335\", {\n> +\t\t\t.unitCellSize = { 2000, 2000 },\n> +\t\t\t.testPatternModes = {},\n> +\t\t} },\n>  \t\t{ \"imx477\", {\n>  \t\t\t.unitCellSize = { 1550, 1550 },\n>  \t\t\t.testPatternModes = {},\n> --\n> 2.44.0\n>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AB257C3220\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  2 May 2024 15:30:09 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CC19163418;\n\tThu,  2 May 2024 17:30:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 356FF633EB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  2 May 2024 17:30:08 +0200 (CEST)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 677853A3;\n\tThu,  2 May 2024 17:29:10 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"aS/RTkpb\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714663750;\n\tbh=x/nf8RvXGFECY5Poy4qe2GE0DGdhiwVim+ZvWduwX7A=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=aS/RTkpbN9yCTtyQoTQETPaJGHOnOfID6/Wclk5ylv6uX5X7JJnID6RBDmpB4n3Qi\n\tP9iSbPgjG3t801hLzRLUUsA7g2doEUD3ZOPllCBtuHr+7JttKtZmFls9X/LGtpwoiN\n\t+DO2QQMtxgYjInU1Qlj0N1pUB4wYkjWdeyBcpTeE=","Date":"Thu, 2 May 2024 17:30:04 +0200","From":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","To":"Umang Jain <umang.jain@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org, \n\tKieran Bingham <kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH v2 2/2] libcamera: libipa: camera_sensor: Add Sony IMX335\n\tsensor properties","Message-ID":"<ecqmgodxtictpl33bsoxnzta6h5qbwt54t4wphxu7ah3aiqikf@slrhxnf3jk57>","References":"<20240426132516.11085-1-umang.jain@ideasonboard.com>\n\t<20240426132516.11085-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240426132516.11085-3-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":29391,"web_url":"https://patchwork.libcamera.org/comment/29391/","msgid":"<20240502153906.GB15807@pendragon.ideasonboard.com>","date":"2024-05-02T15:39:06","subject":"Re: [PATCH v2 2/2] libcamera: libipa: camera_sensor: Add Sony IMX335\n\tsensor properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Umang,\n\nThank you for the patch.\n\nOn Fri, Apr 26, 2024 at 06:55:16PM +0530, Umang Jain wrote:\n> From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> \n> Provide the Sony IMX335 camera sensor properties and registration\n> with libipa for the gain code helpers.\n> \n> The test patterns exposed by the IMX335 do not map well to the current\n> set of test pattern controls supplied by libcamera. These are left\n> inentionally unimplemented.\n\ns/inentionally/intentionally/\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>\n> ---\n>  src/ipa/libipa/camera_sensor_helper.cpp           | 11 +++++++++++\n>  src/libcamera/sensor/camera_sensor_properties.cpp |  4 ++++\n>  2 files changed, 15 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index f70d898f..84d52d10 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -455,6 +455,17 @@ class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n>  };\n>  REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n>  \n> +class CameraSensorHelperImx335 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperImx335()\n> +\t{\n> +\t\tgainType_ = AnalogueGainExponential;\n> +\t\tgainConstants_.exp = { 1.0, expGainDb(0.3) };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx335\", CameraSensorHelperImx335)\n> +\n>  class CameraSensorHelperImx477 : public CameraSensorHelper\n>  {\n>  public:\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index 4eabbbda..895bf967 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -115,6 +115,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n>  \t\t\t.unitCellSize = { 2900, 2900 },\n>  \t\t\t.testPatternModes = {},\n>  \t\t} },\n> +\t\t{ \"imx335\", {\n> +\t\t\t.unitCellSize = { 2000, 2000 },\n> +\t\t\t.testPatternModes = {},\n> +\t\t} },\n>  \t\t{ \"imx477\", {\n>  \t\t\t.unitCellSize = { 1550, 1550 },\n>  \t\t\t.testPatternModes = {},","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 2272FBDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tThu,  2 May 2024 15:39:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3016B63416;\n\tThu,  2 May 2024 17:39:15 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 30B96633EB\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu,  2 May 2024 17:39:13 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 597773A3;\n\tThu,  2 May 2024 17:38:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"bbPbbQnG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714664295;\n\tbh=s/XCJEft1NEHupQ4JmuAp+nWP8u++ZEsm5/SflQgUGs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=bbPbbQnGfT1UoHHNgQ8C6MekiN481YENWna/l2XzTdittp3uxxQ6ypMaMXGY2I8Aa\n\tpCC70i6nQQDS2dqnVKQNAAyo1waSwvFKLMsQyE9HgxMPz5zOlIbfvhVVBlZj8aDdoH\n\te58LHp1uR9aNUrTgZDKkHUJAPpse98HD5F4yDdy8=","Date":"Thu, 2 May 2024 18:39:06 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Umang Jain <umang.jain@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>","Subject":"Re: [PATCH v2 2/2] libcamera: libipa: camera_sensor: Add Sony IMX335\n\tsensor properties","Message-ID":"<20240502153906.GB15807@pendragon.ideasonboard.com>","References":"<20240426132516.11085-1-umang.jain@ideasonboard.com>\n\t<20240426132516.11085-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240426132516.11085-3-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}},{"id":29405,"web_url":"https://patchwork.libcamera.org/comment/29405/","msgid":"<889601be-cd68-4f5e-aa9a-60af647a8214@ideasonboard.com>","date":"2024-05-03T05:57:11","subject":"Re: [PATCH v2 2/2] libcamera: libipa: camera_sensor: Add Sony IMX335\n\tsensor properties","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 02/05/24 9:00 pm, Jacopo Mondi wrote:\n> Hi Umang\n>\n> On Fri, Apr 26, 2024 at 06:55:16PM +0530, Umang Jain wrote:\n>> From: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>>\n>> Provide the Sony IMX335 camera sensor properties and registration\n>> with libipa for the gain code helpers.\n>>\n>> The test patterns exposed by the IMX335 do not map well to the current\n>> set of test pattern controls supplied by libcamera. These are left\n>> inentionally unimplemented.\n> intentionally\n>\n> Do we have dumps of these test patterns (for this and the imx283) as\n> the datahseet doesn't report them ?\n\nwe do have dumps of them and the latest imx335 driver does exposes them \ncorrectly.\n\nSee:\nhttps://git.linuxtv.org/media_stage.git/commit/?id=37e83782f9dd7bb830ef4714f04fae6605e43221\n\nWe need appropriate mapping of libcamera test pattern modes that needs \nto be introduced (for both IMX283 and IMX335).\n\n>\n>\n>> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n>> Signed-off-by: Umang Jain <umang.jain@ideasonboard.com>\n> Reviewed-by: Jacopo Mondi <jacopo.mondi@ideasonboard.com>\n>\n> Thanks\n>    j\n>\n>> ---\n>>   src/ipa/libipa/camera_sensor_helper.cpp           | 11 +++++++++++\n>>   src/libcamera/sensor/camera_sensor_properties.cpp |  4 ++++\n>>   2 files changed, 15 insertions(+)\n>>\n>> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n>> index f70d898f..84d52d10 100644\n>> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n>> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n>> @@ -455,6 +455,17 @@ class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n>>   };\n>>   REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n>>\n>> +class CameraSensorHelperImx335 : public CameraSensorHelper\n>> +{\n>> +public:\n>> +\tCameraSensorHelperImx335()\n>> +\t{\n>> +\t\tgainType_ = AnalogueGainExponential;\n>> +\t\tgainConstants_.exp = { 1.0, expGainDb(0.3) };\n>> +\t}\n>> +};\n>> +REGISTER_CAMERA_SENSOR_HELPER(\"imx335\", CameraSensorHelperImx335)\n>> +\n>>   class CameraSensorHelperImx477 : public CameraSensorHelper\n>>   {\n>>   public:\n>> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n>> index 4eabbbda..895bf967 100644\n>> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n>> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n>> @@ -115,6 +115,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n>>   \t\t\t.unitCellSize = { 2900, 2900 },\n>>   \t\t\t.testPatternModes = {},\n>>   \t\t} },\n>> +\t\t{ \"imx335\", {\n>> +\t\t\t.unitCellSize = { 2000, 2000 },\n>> +\t\t\t.testPatternModes = {},\n>> +\t\t} },\n>>   \t\t{ \"imx477\", {\n>>   \t\t\t.unitCellSize = { 1550, 1550 },\n>>   \t\t\t.testPatternModes = {},\n>> --\n>> 2.44.0\n>>","headers":{"Return-Path":"<libcamera-devel-bounces@lists.libcamera.org>","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BD70BBDE6B\n\tfor <parsemail@patchwork.libcamera.org>;\n\tFri,  3 May 2024 05:57:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9E36463418;\n\tFri,  3 May 2024 07:57:18 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 2735B62C9F\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tFri,  3 May 2024 07:57:17 +0200 (CEST)","from [192.168.1.105] (unknown [103.251.226.40])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C9C2675;\n\tFri,  3 May 2024 07:56:17 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"UpYfAf7N\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714715779;\n\tbh=CIHjMF8L3r66H/rDeYYXLupBCp0WA9/rU+wiFL86QMs=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=UpYfAf7N0iL/z9X7W/blCkGEXXEznnQbefHwEl6AsPB3+8p6hFb73qvMsYQY/z5F6\n\tDlBPINvGWae4tZd3La50dlfcBcizYiOF4xEzsWFErFUKYGN0VorMItLClVYf9bipHe\n\tNsdSUG8v+0DwhNC26OPpfuho9k3DS+PFR+3U6Qbs=","Message-ID":"<889601be-cd68-4f5e-aa9a-60af647a8214@ideasonboard.com>","Date":"Fri, 3 May 2024 11:27:11 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v2 2/2] libcamera: libipa: camera_sensor: Add Sony IMX335\n\tsensor properties","To":"Jacopo Mondi <jacopo.mondi@ideasonboard.com>","Cc":"libcamera-devel@lists.libcamera.org,\n\tKieran Bingham <kieran.bingham@ideasonboard.com>","References":"<20240426132516.11085-1-umang.jain@ideasonboard.com>\n\t<20240426132516.11085-3-umang.jain@ideasonboard.com>\n\t<ecqmgodxtictpl33bsoxnzta6h5qbwt54t4wphxu7ah3aiqikf@slrhxnf3jk57>","Content-Language":"en-US","From":"Umang Jain <umang.jain@ideasonboard.com>","In-Reply-To":"<ecqmgodxtictpl33bsoxnzta6h5qbwt54t4wphxu7ah3aiqikf@slrhxnf3jk57>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" <libcamera-devel-bounces@lists.libcamera.org>"}}]