{"id":19963,"url":"https://patchwork.libcamera.org/api/patches/19963/?format=json","web_url":"https://patchwork.libcamera.org/patch/19963/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240426132516.11085-3-umang.jain@ideasonboard.com>","date":"2024-04-26T13:25:16","name":"[v2,2/2] libcamera: libipa: camera_sensor: Add Sony IMX335 sensor properties","commit_ref":"6b1b2bd7ea7f36e7819109c1019f80b1953b2c96","pull_url":null,"state":"accepted","archived":false,"hash":"2d1ce5ffbc01e48818f3ee884d122ca7689b583b","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19963/mbox/","series":[{"id":4277,"url":"https://patchwork.libcamera.org/api/series/4277/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4277","date":"2024-04-26T13:25:14","name":"libipa: Add IMX283 and IMx335 sensor helpers","version":2,"mbox":"https://patchwork.libcamera.org/series/4277/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19963/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19963/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id B4C36C32A2\n\tfor ;\n\tFri, 26 Apr 2024 13:25:30 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 81FA46341C;\n\tFri, 26 Apr 2024 15:25:29 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D9F4F633ED\n\tfor ;\n\tFri, 26 Apr 2024 15:25:26 +0200 (CEST)","from fedora.local (unknown [103.251.226.119])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8DF47CC8;\n\tFri, 26 Apr 2024 15:24:32 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"v8v0LV2U\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714137873;\n\tbh=TdHfMff+GcsZM9+Y7fLjqLDfV2EkU8gZ30Yc/7y5j6c=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=v8v0LV2U9z7BCID8QEPALbe/LA5nvWUng7vI40aSNvDFHttIDqKWRbmExzl6sD3TN\n\tfwNItcpg5YUbpF9n31BR3IuW2olHAg4rtHeCFT/dIsRWyUI1cqI7/yJVFsiURLaX3n\n\t/5YYIbKIhgGFqeJ1cp0PnmyN9z0TK24KKb/oljsU=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ,\n\tUmang Jain ","Subject":"[PATCH v2 2/2] libcamera: libipa: camera_sensor: Add Sony IMX335\n\tsensor properties","Date":"Fri, 26 Apr 2024 18:55:16 +0530","Message-ID":"<20240426132516.11085-3-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.44.0","In-Reply-To":"<20240426132516.11085-1-umang.jain@ideasonboard.com>","References":"<20240426132516.11085-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Kieran Bingham \n\nProvide the Sony IMX335 camera sensor properties and registration\nwith libipa for the gain code helpers.\n\nThe test patterns exposed by the IMX335 do not map well to the current\nset of test pattern controls supplied by libcamera. These are left\ninentionally unimplemented.\n\nSigned-off-by: Kieran Bingham \nSigned-off-by: Umang Jain \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++\n 2 files changed, 15 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex f70d898f..84d52d10 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -455,6 +455,17 @@ class CameraSensorHelperImx327 : public CameraSensorHelperImx290\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx327\", CameraSensorHelperImx327)\n \n+class CameraSensorHelperImx335 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperImx335()\n+\t{\n+\t\tgainType_ = AnalogueGainExponential;\n+\t\tgainConstants_.exp = { 1.0, expGainDb(0.3) };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx335\", CameraSensorHelperImx335)\n+\n class CameraSensorHelperImx477 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 4eabbbda..895bf967 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -115,6 +115,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t.unitCellSize = { 2900, 2900 },\n \t\t\t.testPatternModes = {},\n \t\t} },\n+\t\t{ \"imx335\", {\n+\t\t\t.unitCellSize = { 2000, 2000 },\n+\t\t\t.testPatternModes = {},\n+\t\t} },\n \t\t{ \"imx477\", {\n \t\t\t.unitCellSize = { 1550, 1550 },\n \t\t\t.testPatternModes = {},\n","prefixes":["v2","2/2"]}