{"id":19962,"url":"https://patchwork.libcamera.org/api/patches/19962/?format=json","web_url":"https://patchwork.libcamera.org/patch/19962/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240426132516.11085-2-umang.jain@ideasonboard.com>","date":"2024-04-26T13:25:15","name":"[v2,1/2] libcamera: libipa: camera_sensor: Add Sony IMX283 sensor properties","commit_ref":"2ac544cfd653809d513c8100a28962852279eb01","pull_url":null,"state":"accepted","archived":false,"hash":"3781622109f78208fcd97935b26a150973a347e0","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/?format=json","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19962/mbox/","series":[{"id":4277,"url":"https://patchwork.libcamera.org/api/series/4277/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4277","date":"2024-04-26T13:25:14","name":"libipa: Add IMX283 and IMx335 sensor helpers","version":2,"mbox":"https://patchwork.libcamera.org/series/4277/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19962/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19962/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 086DFBE08B\n\tfor ;\n\tFri, 26 Apr 2024 13:25:29 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9109B6341B;\n\tFri, 26 Apr 2024 15:25:28 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id A62A961A9B\n\tfor ;\n\tFri, 26 Apr 2024 15:25:25 +0200 (CEST)","from fedora.local (unknown [103.251.226.119])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id B0BDCD7E;\n\tFri, 26 Apr 2024 15:24:30 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"dUYFvkUX\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714137872;\n\tbh=2TNOfJyyaEGsLn760PXMR1nVjxvW/PW1nrboV868MwY=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=dUYFvkUXP8MNVukA7elLt6cFV5dsuSOQp3o46pt0ZbIXgC30F+oJ9NUjmWfUlBWoE\n\tRYs+axdjgln/4cQOU9gx7EBEshwoJUkhMN/wGZtA3/rmTY52G7mz5bcaol8bn2AGEp\n\tdhmjkqkm3fGsqV9sdB2OqW/RUbXf0DvdRtWBBMos=","From":"Umang Jain ","To":"libcamera-devel@lists.libcamera.org","Cc":"Kieran Bingham ,\n\tLaurent Pinchart ,\n\tUmang Jain ","Subject":"[PATCH v2 1/2] libcamera: libipa: camera_sensor: Add Sony IMX283\n\tsensor properties","Date":"Fri, 26 Apr 2024 18:55:15 +0530","Message-ID":"<20240426132516.11085-2-umang.jain@ideasonboard.com>","X-Mailer":"git-send-email 2.44.0","In-Reply-To":"<20240426132516.11085-1-umang.jain@ideasonboard.com>","References":"<20240426132516.11085-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"From: Kieran Bingham \n\nProvide the IMX283 camera sensor properties and registration\nwith libipa for the gain code helpers.\n\nThe test patterns exposed by the IMX283 do not map well to the current\nset of test pattern controls supplied by libcamera. These are left\ninentionally unimplemented.\n\nSigned-off-by: Kieran Bingham \nReviewed-by: Laurent Pinchart \nSigned-off-by: Umang Jain \n---\n src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++\n 2 files changed, 15 insertions(+)","diff":"diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\nindex ce29f423..f70d898f 100644\n--- a/src/ipa/libipa/camera_sensor_helper.cpp\n+++ b/src/ipa/libipa/camera_sensor_helper.cpp\n@@ -417,6 +417,17 @@ public:\n };\n REGISTER_CAMERA_SENSOR_HELPER(\"imx258\", CameraSensorHelperImx258)\n \n+class CameraSensorHelperImx283 : public CameraSensorHelper\n+{\n+public:\n+\tCameraSensorHelperImx283()\n+\t{\n+\t\tgainType_ = AnalogueGainLinear;\n+\t\tgainConstants_.linear = { 0, 2048, -1, 2048 };\n+\t}\n+};\n+REGISTER_CAMERA_SENSOR_HELPER(\"imx283\", CameraSensorHelperImx283)\n+\n class CameraSensorHelperImx290 : public CameraSensorHelper\n {\n public:\ndiff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\nindex 6e28b09e..4eabbbda 100644\n--- a/src/libcamera/sensor/camera_sensor_properties.cpp\n+++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n@@ -99,6 +99,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n \t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n \t\t\t},\n \t\t} },\n+\t\t{ \"imx283\", {\n+\t\t\t.unitCellSize = { 2400, 2400 },\n+\t\t\t.testPatternModes = {},\n+\t\t} },\n \t\t{ \"imx290\", {\n \t\t\t.unitCellSize = { 2900, 2900 },\n \t\t\t.testPatternModes = {},\n","prefixes":["v2","1/2"]}