[{"id":2697,"web_url":"https://patchwork.libcamera.org/comment/2697/","msgid":"<20190924172325.bpdex2dpa5rbtcrx@uno.localdomain>","date":"2019-09-24T17:23:25","subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: Create DataValue\n\tand DataInfo","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hello,\n\nOn Tue, Sep 24, 2019 at 07:14:36PM +0200, Jacopo Mondi wrote:\n> +/**\n> + * \\brief Assemble and return a string describing the value\n> + * \\return A string describing the DataValue\n> + */\n> +std::string DataValue::toString() const\n> +{\n> +\tswitch (type_) {\n> +\tcase DataTypeBool:\n> +\t\treturn bool_ ? \"True\" : \"False\";\n> +\tcase DataTypeInteger:\n> +\t\treturn std::to_string(integer_);\n> +\tcase DataTypeInteger64:\n> +\t\treturn std::to_string(integer64_);\n> +\tcase DataTypeNone:\n> +\t\treturn \"\";\n> +\t}\n> +}\n\nGcc complains there, clang does not. I just noticed after sending this\nout... Will fix","headers":{"Return-Path":"","Received":["from relay6-d.mail.gandi.net (relay6-d.mail.gandi.net\n\t[217.70.183.198])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BAC4960BCF\n\tfor ;\n\tTue, 24 Sep 2019 19:21:45 +0200 (CEST)","from uno.localdomain\n\t(host89-248-dynamic.45-213-r.retail.telecomitalia.it [213.45.248.89])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay6-d.mail.gandi.net (Postfix) with ESMTPSA id 56893C0007\n\tfor ;\n\tTue, 24 Sep 2019 17:21:45 +0000 (UTC)"],"X-Originating-IP":"213.45.248.89","Date":"Tue, 24 Sep 2019 19:23:25 +0200","From":"Jacopo Mondi ","To":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190924172325.bpdex2dpa5rbtcrx@uno.localdomain>","References":"<20190924171440.29758-1-jacopo@jmondi.org>\n\t<20190924171440.29758-2-jacopo@jmondi.org>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"5zadpmrjwqdcqhxe\"","Content-Disposition":"inline","In-Reply-To":"<20190924171440.29758-2-jacopo@jmondi.org>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: Create DataValue\n\tand DataInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 24 Sep 2019 17:21:45 -0000"}},{"id":2698,"web_url":"https://patchwork.libcamera.org/comment/2698/","msgid":"","date":"2019-09-26T15:17:09","subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: Create DataValue\n\tand DataInfo","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Jacopo,\n\nOn 24/09/2019 18:14, Jacopo Mondi wrote:\n> Add the data_value.[h|c] files that provide an abstracted polymorphic\n> data value type and a generic data info type that represent static\n> information associated with a data value.\n> \n> DataValue is a slightly re-worked copy of the ControlValue type defined\n> in controls.h, provided in a generic header to be used a foundation for\n> both Controls and V4L2Controls classes that will be re-worked in the\n> next patches in the series.\n> \n> Add a test for data value which is an adapted copy of the control value\n> test, that will be removed in the next patch.\n> \n> Signed-off-by: Jacopo Mondi \n> ---\n> include/libcamera/data_value.h | 82 +++++++++++\n> include/libcamera/meson.build | 1 +\n> src/libcamera/data_value.cpp | 259 +++++++++++++++++++++++++++++++++\n> src/libcamera/meson.build | 1 +\n> test/data_value.cpp | 59 ++++++++\n> test/meson.build | 1 +\n> 6 files changed, 403 insertions(+)\n> create mode 100644 include/libcamera/data_value.h\n> create mode 100644 src/libcamera/data_value.cpp\n> create mode 100644 test/data_value.cpp\n> \n> diff --git a/include/libcamera/data_value.h b/include/libcamera/data_value.h\n> new file mode 100644\n> index 000000000000..c2c95d28b0f2\n> --- /dev/null\n> +++ b/include/libcamera/data_value.h\n> @@ -0,0 +1,82 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * data_value.h - Polymorphic data value type\n> + */\n> +#ifndef __LIBCAMERA_DATA_VALUE_H__\n> +#define __LIBCAMERA_DATA_VALUE_H__\n> +\n> +#include \n> +#include \n> +\n> +namespace libcamera {\n> +\n> +enum DataType {\n> +\tDataTypeNone,\n> +\tDataTypeBool,\n> +\tDataTypeInteger,\n> +\tDataTypeInteger64,\n> +};\n> +\n> +static constexpr size_t DataSize[] = {\n> +\t[DataTypeNone]\t\t= 1,\n> +\t[DataTypeBool]\t\t= sizeof(bool),\n> +\t[DataTypeInteger]\t= sizeof(int32_t),\n> +\t[DataTypeInteger64]\t= sizeof(int64_t),\n> +};\n> +\n> +class DataValue\n> +{\n> +public:\n> +\tDataValue();\n> +\tDataValue(bool value);\n> +\tDataValue(int value);\n> +\tDataValue(int64_t value);\n> +\n> +\tDataValue &operator=(const DataValue &other);\n> +\n> +\tenum DataType type() const { return type_; }\n> +\tsize_t size() const { return size_; }\n> +\n> +\tvoid set(bool value);\n> +\tvoid set(int value);\n> +\tvoid set(int64_t value);\n> +\n> +\tbool getBool() const;\n> +\tint getInt() const;\n> +\tint64_t getInt64() const;\n> +\n> +\tstd::string toString() const;\n> +\n> +private:\n> +\tDataType type_;\n> +\tsize_t size_;\n> +\n> +\tunion {\n> +\t\tbool bool_;\n> +\t\tint integer_;\n> +\t\tint64_t integer64_;\n> +\t};\n> +};\n> +\n> +class DataInfo\n> +{\n> +public:\n> +\tDataInfo(const DataValue &min = 0, const DataValue &max = 0)\n> +\t{\n> +\t\tmin_ = min;\n> +\t\tmax_ = max;\n> +\t}\n> +\n> +\tconst DataValue &min() const { return min_; }\n> +\tconst DataValue &max() const { return max_; }\n> +\n> +private:\n> +\tDataValue min_;\n> +\tDataValue max_;\n> +};\n> +\n> +} /* namespace libcamera */\n> +\n> +#endif /* __LIBCAMERA_DATA_VALUE_H__ */\n> diff --git a/include/libcamera/meson.build b/include/libcamera/meson.build\n> index 868f1a6bf1ab..e3f3ad504446 100644\n> --- a/include/libcamera/meson.build\n> +++ b/include/libcamera/meson.build\n> @@ -5,6 +5,7 @@ libcamera_api = files([\n> 'camera_manager.h',\n> 'control_ids.h',\n> 'controls.h',\n> + 'data_value.h',\n> 'event_dispatcher.h',\n> 'event_notifier.h',\n> 'geometry.h',\n> diff --git a/src/libcamera/data_value.cpp b/src/libcamera/data_value.cpp\n> new file mode 100644\n> index 000000000000..2d90100116ab\n> --- /dev/null\n> +++ b/src/libcamera/data_value.cpp\n> @@ -0,0 +1,259 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * data_value.cpp - Polymorphic data value type\n> + */\n> +\n> +#include \n> +\n> +#include \n> +#include \n> +#include \n> +\n> +#include \"utils.h\"\n> +#include \"log.h\"\n> +\n> +/**\n> + * \\file data_value.h\n> + * \\brief Polymorphic data type\n> + */\n> +\n> +namespace libcamera {\n> +\n> +/**\n> + * \\enum DataType\n> + * \\brief Define the supported data types\n> + * \\var DataTypeNone\n> + * Identifies an unset value\n> + * \\var DataTypeBool\n> + * Identifies DataType storing a boolean value\n> + * \\var DataTypeInteger\n> + * Identifies DataType storing an integer value\n> + * \\var DataTypeInteger64\n> + * Identifies DataType storing a 64-bit integer value\n> + */\n> +\n> +/**\n> + * \\var DataSize\n> + * \\brief Associate to each data type the memory size in bytes\n> + */\n> +\n> +/**\n> + * \\class DataValue\n> + * \\brief Polymorphic data value\n> + *\n> + * DataValue holds values of different types, defined by DataType providing\n> + * a unified interface to access and modify the data content.\n> + *\n> + * DataValue instances are used by classes that need to represent and store\n> + * numerical values of different types.\n> + *\n> + * \\todo Add support for compound data types, such as arrays.\n> + */\n> +\n> +/**\n> + * \\brief Construct an empty DataValue\n> + */\n> +DataValue::DataValue()\n> +\t: type_(DataTypeNone), size_(DataSize[type_])\n\nDo we need to initialise the value to zero or anything here?\nIf so - I'd just set the integer64_(0)\n\n\n> +{\n> +}\n> +\n> +/**\n> + * \\brief Construct a boolean DataValue\n> + * \\param[in] value Boolean value to store\n> + */\n> +DataValue::DataValue(bool value)\n> +\t: type_(DataTypeBool), size_(DataSize[type_]), bool_(value)\n> +{\n> +}\n> +\n> +/**\n> + * \\brief Construct an integer DataValue\n> + * \\param[in] value Integer value to store\n> + */\n> +DataValue::DataValue(int value)\n> +\t: type_(DataTypeInteger), size_(DataSize[type_]), integer_(value)\n> +{\n> +}\n> +\n> +/**\n> + * \\brief Construct a 64 bit integer DataValue\n> + * \\param[in] value 64-bits integer value to store\n> + */\n> +DataValue::DataValue(int64_t value)\n> +\t: type_(DataTypeInteger64), size_(DataSize[type_]), integer64_(value)\n> +{\n> +}\n> +\n> +/**\n> + * \\brief Assign the DataValue type and value using the ones from \\a other\n> + * \\param[in] other The DataValue to copy type and value from\n> + *\n> + * DataValue assignment operator.\n> + *\n> + * \\return The DataValue with fields updated using the ones from \\a other\n> + */\n> +DataValue &DataValue::operator=(const DataValue &other)\n> +{\n> +\tDataType newType = other.type();\n> +\ttype_ = newType;\n> +\tsize_ = DataSize[type_];\n> +\n> +\tswitch (newType) {\n> +\tcase DataTypeBool:\n> +\t\tbool_ = other.getBool();\n> +\t\tbreak;\n> +\tcase DataTypeInteger:\n> +\t\tinteger_ = other.getInt();\n> +\t\tbreak;\n> +\tcase DataTypeInteger64:\n> +\t\tinteger64_ = other.getInt64();\n> +\t\tbreak;\n> +\tcase DataTypeNone:\n> +\t\tbool_ = 0;\n> +\t\tinteger_ = 0;\n> +\t\tinteger64_ = 0;\n\nAs these are all members of a union, I think we only need to set the\nbiggest.\n\nBut as it's DataTypeNone, the actual value is undefined, and you are\nsimply initialising (so perhaps the DataTypeNone constructor should also\ninitialise a value?, see above)\n\nTechnically, I think setting\n\t\tinteger64_ = other.getInt64();\nfor the TypeNone case would be more accurate - but I don't expect this\nto be used really.\n\nPerhaps could just do a fallthrough:\n\n + case DataTypeNone:\n +\tcase DataTypeInteger64:\n +\t\tinteger64_ = other.getInt64();\n +\t\tbreak;\n\nor just not set it at all.\n\n\n> +\t\tbreak;\n> +\t}\n> +\n> +\treturn *this;\n> +}\n> +\n> +/**\n> + * \\fn DataValue::type()\n> + * \\brief Retrieve the data type of the data\n> + * \\return The type of the data\n> + */\n> +\n> +/**\n> + * \\fn DataValue::size()\n> + * \\brief Retrieve the size in bytes of the data\n> + * \\return The size in bytes of the data\n> + */\n> +\n> +/**\n> + * \\brief Set the value with a boolean\n> + * \\param[in] value Boolean value to store\n> + */\n> +void DataValue::set(bool value)\n> +{\n> +\ttype_ = DataTypeBool;\n> +\tsize_ = DataSize[type_];\n> +\tbool_ = value;\n> +}\n> +\n> +/**\n> + * \\brief Set the value with an integer\n> + * \\param[in] value Integer value to store\n> + */\n> +void DataValue::set(int value)\n> +{\n> +\ttype_ = DataTypeInteger;\n> +\tsize_ = DataSize[type_];\n> +\tinteger_ = value;\n> +}\n> +\n> +/**\n> + * \\brief Set the value with a 64 bit integer\n> + * \\param[in] value 64 bit integer value to store\n> + */\n> +void DataValue::set(int64_t value)\n> +{\n> +\ttype_ = DataTypeInteger64;\n> +\tsize_ = DataSize[type_];\n> +\tinteger64_ = value;\n> +}\n\nShould we support setting from a DataValue too?\n\nEssentially with just a call to the copy constructor...?\n\n> +\n> +/**\n> + * \\brief Get the boolean value\n> + *\n> + * The value type must be Boolean.\n> + *\n> + * \\return The boolean value\n> + */\n> +bool DataValue::getBool() const\n> +{\n> +\tASSERT(type_ == DataTypeBool);\n> +\n> +\treturn bool_;\n> +}\n> +\n> +/**\n> + * \\brief Get the integer value\n> + *\n> + * The value type must be Integer or Integer64.\n> + *\n> + * \\return The integer value\n> + */\n> +int DataValue::getInt() const\n> +{\n> +\tASSERT(type_ == DataTypeInteger || type_ == DataTypeInteger64);\n> +\n> +\treturn integer_;\n> +}\n> +\n> +/**\n> + * \\brief Get the 64-bit integer value\n> + *\n> + * The value type must be Integer or Integer64.\n> + *\n> + * \\return The 64-bit integer value\n> + */\n> +int64_t DataValue::getInt64() const\n> +{\n> +\tASSERT(type_ == DataTypeInteger || type_ == DataTypeInteger64);\n> +\n> +\treturn integer64_;\n> +}\n> +\n> +/**\n> + * \\brief Assemble and return a string describing the value\n> + * \\return A string describing the DataValue\n> + */\n> +std::string DataValue::toString() const\n> +{\n> +\tswitch (type_) {\n> +\tcase DataTypeBool:\n> +\t\treturn bool_ ? \"True\" : \"False\";\n> +\tcase DataTypeInteger:\n> +\t\treturn std::to_string(integer_);\n> +\tcase DataTypeInteger64:\n> +\t\treturn std::to_string(integer64_);\n> +\tcase DataTypeNone:\n> +\t\treturn \"\";\n> +\t}\n\n\nIs the compiler happy with no return statement outside of this switch,\neven with no default: ? I guess it knows that all the DataType enums are\nused (which is good).\n\n\n> +}\n> +\n> +/**\n> + * \\class DataInfo\n> + * \\brief Validation informations associated with a data value\n\n\ns/informations/information/\n\n> + *\n> + * The DataInfo class represents static information associated with data\n> + * types that represent polymorphic values abstracted by the DataValue class.\n> + *\n> + * DataInfo stores static informations such as the value minimum and maximum\n\ns/informations/information/\n\nInformation is an 'uncountable noun'\n\thttps://blog.harwardcommunications.com/2010/11/09/information/\n\n\n> + * values and for compound values the maximum and minimum number of elements.\n> + */\n> +\n> +/**\n> + * \\fn DataInfo::DataInfo\n> + * \\brief Construct a data info with \\a min and \\a max values\n> + * \\param[in] min The minimum allowed value\n> + * \\param[in] max The maximum allowed value\n> + */\n> +\n> +/**\n> + * \\fn DataInfo::min()\n> + * \\brief Retrieve the DataInfo minimum allowed value\n> + * \\return A DataValue representing the minimum allowed value\n> + */\n> +\n> +/**\n> + * \\fn DataInfo::max()\n> + * \\brief Retrieve the DataInfo maximum allowed value\n> + * \\return A DataValue representing the maximum allowed value\n> + */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> index 755149c55c7b..c3100a1709e0 100644\n> --- a/src/libcamera/meson.build\n> +++ b/src/libcamera/meson.build\n> @@ -5,6 +5,7 @@ libcamera_sources = files([\n> 'camera_manager.cpp',\n> 'camera_sensor.cpp',\n> 'controls.cpp',\n> + 'data_value.cpp',\n> 'device_enumerator.cpp',\n> 'device_enumerator_sysfs.cpp',\n> 'event_dispatcher.cpp',\n> diff --git a/test/data_value.cpp b/test/data_value.cpp\n> new file mode 100644\n> index 000000000000..64061000c1e4\n> --- /dev/null\n> +++ b/test/data_value.cpp\n> @@ -0,0 +1,59 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2019, Google Inc.\n> + *\n> + * data_value.cpp - DataValue tests\n> + */\n> +\n> +#include \n> +\n> +#include \n> +\n> +#include \"test.h\"\n> +\n> +using namespace std;\n> +using namespace libcamera;\n> +\n> +class DataValueTest : public Test\n> +{\n> +protected:\n> +\tint run()\n> +\t{\n> +\t\tDataValue integer(1234);\n> +\t\tDataValue boolean(true);\n> +\n> +\t\t/* Just a string conversion output test... no validation */\n> +\t\tcout << \"Int: \" << integer.toString()\n> +\t\t << \" Bool: \" << boolean.toString()\n> +\t\t << endl;\n\nI think Laurent suggested changing this in the original test.\n\nSomething like :\n\n \tstringstream ss;\n\n\tss.str(integer.toString());\n\tif (ss.str() != \"1234\")\n\t\treturn TestFail;\n\n\tss.str(boolean.toString());\n\tif (ss.str() != \"True\")\n\t\treturn TestFail;\n\nor such.\n\nSeems like a good time to fix it.\n\n\n> +\n> +\t\tif (integer.getInt() != 1234) {\n> +\t\t\tcerr << \"Failed to get Integer\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tif (boolean.getBool() != true) {\n> +\t\t\tcerr << \"Failed to get Boolean\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\t/* Test an uninitialised value, and updating it. */\n> +\n> +\t\tDataValue value;\n> +\t\tvalue.set(true);\n> +\t\tif (value.getBool() != true) {\n> +\t\t\tcerr << \"Failed to get Booleans\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\tvalue.set(10);\n> +\t\tif (value.getInt() != 10) {\n> +\t\t\tcerr << \"Failed to get Integer\" << endl;\n> +\t\t\treturn TestFail;\n> +\t\t}\n> +\n> +\t\treturn TestPass;\n> +\t}\n> +};\n> +\n> +TEST_REGISTER(DataValueTest)\n> diff --git a/test/meson.build b/test/meson.build\n> index 84722cceb35d..19e3031244a3 100644\n> --- a/test/meson.build\n> +++ b/test/meson.build\n> @@ -13,6 +13,7 @@ subdir('v4l2_subdevice')\n> subdir('v4l2_videodevice')\n> \n> public_tests = [\n> + ['data_value', 'data_value.cpp'],\n> ['geometry', 'geometry.cpp'],\n> ['list-cameras', 'list-cameras.cpp'],\n> ['signal', 'signal.cpp'],\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9DF4C60BB6\n\tfor ;\n\tThu, 26 Sep 2019 17:17:12 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DF8AE9BF;\n\tThu, 26 Sep 2019 17:17:11 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1569511032;\n\tbh=nbNpalumT58DNV33FyAKjnf6aockZCgjOpJ4a8cP7kw=;\n\th=Reply-To:Subject:To:References:From:Date:In-Reply-To:From;\n\tb=VUrnUQn6SPVmKt/rePZvnnbXvk5GzNC0ql6ZWH57iFMbHmCUu6MJOrrGZtL7Zc1oh\n\txTQAT+ZQRtsv3hS/2efpNHm3H2lX0rMlzN6d5QK54oNIvH3K5mSYYNiFx0oyZnQL3L\n\t5LdPrA954Rz2NEgCVuSIUdA0zHA/fb03Nk8ti1Gg=","Reply-To":"kieran.bingham@ideasonboard.com","To":"Jacopo Mondi , libcamera-devel@lists.libcamera.org","References":"<20190924171440.29758-1-jacopo@jmondi.org>\n\t<20190924171440.29758-2-jacopo@jmondi.org>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCJQQYAQoADwIbDAUCWcOUawUJ\n\tB4D+AgAKCRChHkZyEKRh/XJhEACr5iidt/0MZ0rWRMCbZFMWD7D2g6nZeOp+F2zY8CEUW+sd\n\tCDVd9BH9QX9KN5SZo6YtJzMzSzpcx45VwTvtQW0n/6Eujg9EUqblfU9xqvqDmbjEapr5d/OL\n\t21GTALb0owKhA5qDUGEcKGCphpQffKhTNo/BP99jvmJUj7IPSKH97qPypi8/ym8bAxB+uY31\n\tgHTMHf1jMJJ1pRo2tYYPeIIHGDqXBI4sp5GHHF+JcIhgR/e/A6w/dgzHYmQPl2ix5eZYEZbV\n\tTRP+gkX4NV8oHqa/lR+xPOlWElGB57viOSOoWriqxQbFy8XbG1GR8cWlkNtGBGVWaJaSoORP\n\tiowD7irXL91bCyFIqL+7BVk3Jy4uzP744PzE80KwxOp5SQAp9sPzFbgsJrLev90PZySjFHG0\n\twP144DK7nBjOj/J0g9OHVASP1JjK+nw7SDoKnETDIdRC0XmiHXk7TXzPdkvO0UkpHdEPjZUp\n\tWyuc0MqehjR/hTTPt4m/Y14XzEcy6JREIjOrFfUZVho2QpOdv9CNryGdieRTNjUtz463CIaZ\n\tdPBiw9mOMBoNffkn9FIoCjLnAaj9gUAnEHWBZOEviQ5NuyqpeP0YtzI4iaRbSUkYZHej99X3\n\tVmHrdLlMqd/ZgYYbPGSL4AN3FVACb5CxuxEHwo029VcE5U3CSjzqtCoX12tm7A==","Organization":"Ideas on Board","Message-ID":"","Date":"Thu, 26 Sep 2019 16:17:09 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.8.0","MIME-Version":"1.0","In-Reply-To":"<20190924171440.29758-2-jacopo@jmondi.org>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH v2 1/5] libcamera: Create DataValue\n\tand DataInfo","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Thu, 26 Sep 2019 15:17:12 -0000"}}]