[{"id":29300,"web_url":"https://patchwork.libcamera.org/comment/29300/","msgid":"<20240422191606.62gck644lw6bbbhg@jasper>","date":"2024-04-22T19:16:06","subject":"Re: [PATCH v2 1/3] ipa: libipa: Add Matrix class","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Paul,\n\nthanks for the patch.\n\nOn Fri, Apr 19, 2024 at 04:18:17PM +0900, Paul Elder wrote:\n> Add a class to represent a Matrix object and operations for adding\n> matrices, multipling a matrix by a scalar, and multiplying two matrices.\n> \n> Signed-off-by: Paul Elder \n> ---\n> Changes in second v2 (v1 was a lone patch so we have two v2s of this\n> specific patch):\n> - make rows and columns into template arguments\n> - initialize to identity matrix on construction\n> - add getter and setter\n> - change from struct to class\n> - fix matrix multiplication\n> \n> Changes in v2:\n> - clean up unused includes\n> - avoid dereferencing an absent std::optional\n> ---\n> src/ipa/libipa/matrix.cpp | 17 +++++\n> src/ipa/libipa/matrix.h | 144 +++++++++++++++++++++++++++++++++++++\n> src/ipa/libipa/meson.build | 2 +\n> 3 files changed, 163 insertions(+)\n> create mode 100644 src/ipa/libipa/matrix.cpp\n> create mode 100644 src/ipa/libipa/matrix.h\n> \n> diff --git a/src/ipa/libipa/matrix.cpp b/src/ipa/libipa/matrix.cpp\n> new file mode 100644\n> index 00000000..c222c3f0\n> --- /dev/null\n> +++ b/src/ipa/libipa/matrix.cpp\n> @@ -0,0 +1,17 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> +/*\n> + * Copyright (C) 2019, Raspberry Pi Ltd\n> + * Copyright (C) 2024, Paul Elder \n> + *\n> + * matrix.cpp - Matrix and related operations\n> + */\n> +\n> +#include \"matrix.h\"\n> +\n> +#include \n> +\n> +namespace libcamera {\n> +\n> +LOG_DEFINE_CATEGORY(Matrix)\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/libipa/matrix.h b/src/ipa/libipa/matrix.h\n> new file mode 100644\n> index 00000000..ec41fb57\n> --- /dev/null\n> +++ b/src/ipa/libipa/matrix.h\n> @@ -0,0 +1,144 @@\n> +/* SPDX-License-Identifier: BSD-2-Clause */\n> +/*\n> + * Copyright (C) 2019, Raspberry Pi Ltd\n> + * Copyright (C) 2024, Paul Elder \n> + *\n> + * matrix.cpp - Matrix and related operations\n> + */\n> +#pragma once\n> +\n> +#include \n> +#include \n> +#include \n> +#include \n> +\n> +#include \n> +\n> +#include \"libcamera/internal/yaml_parser.h\"\n> +\n> +namespace libcamera {\n> +\n> +LOG_DECLARE_CATEGORY(Matrix)\n> +\n> +namespace ipa {\n> +\n> +template +\t std::enable_if_t> * = nullptr>\n> +class Matrix\n> +{\n> +public:\n> +\tMatrix()\n> +\t{\n> +\t\tfor (unsigned int i = 0; i < R; i++)\n> +\t\t\tfor (unsigned int j = 0; j < C; j++)\n> +\t\t\t\tdata_.push_back(static_cast(i == j));\n> +\t};\n> +\n> +\tMatrix(const std::vector &data)\n> +\t{\n> +\t\tASSERT(data_.size() == R * C);\n\nI think you wanted to check datainstead of data_ here.\n\n> +\n> +\t\tfor (const T &x : data)\n> +\t\t\tdata_.push_back(x);\n\nWithout some reset, this will only append to data_.\nA small testcase would be nice to catch this.\n\n> +\t}\n> +\n> +\t~Matrix(){};\n> +\n> +\tint readYaml(const libcamera::YamlObject &yaml)\n> +\t{\n> +\t\tif (yaml.size() != R * C) {\n> +\t\t\tLOG(Matrix, Error)\n> +\t\t\t\t<< \"Wrong number of values in matrix: expected \"\n> +\t\t\t\t<< R * C << \", got \" << yaml.size();\n> +\t\t\treturn -EINVAL;\n> +\t\t}\n> +\n> +\t\tunsigned int i = 0;\n> +\t\tfor (const auto &x : yaml.asList()) {\n> +\t\t\tauto value = x.get();\n> +\t\t\tif (!value) {\n> +\t\t\t\tLOG(Matrix, Error) << \"Failed to read matrix value\";\n> +\t\t\t\treturn -EINVAL;\n> +\t\t\t}\n> +\n> +\t\t\tdata_[i++] = *value;\n> +\t\t}\n> +\n> +\t\treturn 0;\n> +\t}\n> +\n> +\tconst std::string toString() const\n> +\t{\n> +\t\tstd::stringstream ss;\n> +\t\tss << \"Matrix { \";\n> +\t\tfor (unsigned int i = 0; i < R; i++) {\n> +\t\t\tss << \"[ \";\n> +\t\t\tfor (unsigned int j = 0; j < C; j++) {\n> +\t\t\t\tss << get(i, j);\n> +\t\t\t\tss << ((j + 1 < C) ? \", \" : \" \");\n> +\t\t\t}\n> +\t\t\tss << ((i + 1 < R) ? \"], \" : \"]\");\n> +\t\t}\n> +\t\tss << \" }\";\n> +\n> +\t\treturn ss.str();\n> +\t}\n> +\n> +\tconst T &get(unsigned int i, unsigned int j) const { return data_.at(i * C + j); }\n> +\tvoid set(unsigned int i, unsigned int j, T value) { data_[i * C + j] = value; }\n> +\n> +private:\n> +\tstd::vector data_;\n> +};\n> +\n> +template +\t std::enable_if_t> * = nullptr>\n> +Matrix operator*(T d, const Matrix &m)\n> +{\n> +\tMatrix result;\n> +\n> +\tfor (unsigned int i = 0; i < R; i++)\n> +\t\tfor (unsigned int j = 0; j < C; j++)\n> +\t\t\tresult.set(i, j, d * m.get(i, j));\n> +\n> +\treturn result;\n> +}\n> +\n> +template +\t unsigned int R1, unsigned int C1,\n> +\t unsigned int R2, unsigned int C2,\n> +\t std::enable_if_t && C1 == R2> * = nullptr>\n> +Matrix operator*(const Matrix &m1, const Matrix &m2)\n> +{\n\nOut of curiousity: Why the four template params and not three (C1 and\nR2 as a single one). I see that the enable_if serves the same purpose.\n\nCheers,\nStefan\n\n> +\tMatrix result;\n> +\n> +\tfor (unsigned int i = 0; i < R1; i++) {\n> +\t\tfor (unsigned int j = 0; j < C2; j++) {\n> +\t\t\tT sum = 0;\n> +\n> +\t\t\tfor (unsigned int k = 0; k < C1; k++)\n> +\t\t\t\tsum += m1.get(i, k) * m2.get(k, j);\n> +\n> +\t\t\tresult.set(i, j, sum);\n> +\t\t}\n> +\t}\n> +\n> +\treturn result;\n> +}\n> +\n> +template +\t std::enable_if_t> * = nullptr>\n> +Matrix operator+(const Matrix &m1, const Matrix &m2)\n> +{\n> +\tMatrix result;\n> +\n> +\tfor (unsigned int i = 0; i < R; i++)\n> +\t\tfor (unsigned int j = 0; j < C; j++)\n> +\t\t\tresult.set(i, j, m1.get(i, j) + m2.get(i, j));\n> +\n> +\treturn result;\n> +}\n> +\n> +} /* namespace ipa */\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\n> index 1b3faf8d..1e34355f 100644\n> --- a/src/ipa/libipa/meson.build\n> +++ b/src/ipa/libipa/meson.build\n> @@ -7,6 +7,7 @@ libipa_headers = files([\n> 'exposure_mode_helper.h',\n> 'fc_queue.h',\n> 'histogram.h',\n> + 'matrix.h',\n> 'module.h',\n> 'pwl.h',\n> ])\n> @@ -18,6 +19,7 @@ libipa_sources = files([\n> 'exposure_mode_helper.cpp',\n> 'fc_queue.cpp',\n> 'histogram.cpp',\n> + 'matrix.cpp',\n> 'module.cpp',\n> 'pwl.cpp'\n> ])\n> -- \n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 3A17EC3200\n\tfor ;\n\tMon, 22 Apr 2024 19:16:12 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 634386340C;\n\tMon, 22 Apr 2024 21:16:11 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 91E6363408\n\tfor ;\n\tMon, 22 Apr 2024 21:16:09 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:8cc8:e8af:967f:28a5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C7A338CC;\n\tMon, 22 Apr 2024 21:15:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"tSavId6K\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713813318;\n\tbh=mfUeBwxFudCTRtLQJKpTKOQWGiEEMzF/u+SRlacUx70=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=tSavId6KGqWFjHL5WjgtzsDyXOrnj5l2v68FyElOdu+Zpt/JCJPKscQ0PEg/Pb9C7\n\t1v8QwObbrTmPjwuPL1qxclSd6YXc0ApsQiAssifjf3nMeRfjIJCtZLqFxMI0nPfhf9\n\t7/yIxkmJ712OMNjei7NU3gMJIm7qGvaVBZn8v9DA=","Date":"Mon, 22 Apr 2024 21:16:06 +0200","From":"Stefan Klug ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 1/3] ipa: libipa: Add Matrix class","Message-ID":"<20240422191606.62gck644lw6bbbhg@jasper>","References":"<20240419071819.1325791-1-paul.elder@ideasonboard.com>\n\t<20240419071819.1325791-2-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240419071819.1325791-2-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29382,"web_url":"https://patchwork.libcamera.org/comment/29382/","msgid":"","date":"2024-05-02T09:38:48","subject":"Re: [PATCH v2 1/3] ipa: libipa: Add Matrix class","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Stefan,\n\nThanks for the review.\n\nOn Mon, Apr 22, 2024 at 09:16:06PM +0200, Stefan Klug wrote:\n> Hi Paul,\n> \n> thanks for the patch.\n> \n> On Fri, Apr 19, 2024 at 04:18:17PM +0900, Paul Elder wrote:\n> > Add a class to represent a Matrix object and operations for adding\n> > matrices, multipling a matrix by a scalar, and multiplying two matrices.\n> > \n> > Signed-off-by: Paul Elder \n> > ---\n> > Changes in second v2 (v1 was a lone patch so we have two v2s of this\n> > specific patch):\n> > - make rows and columns into template arguments\n> > - initialize to identity matrix on construction\n> > - add getter and setter\n> > - change from struct to class\n> > - fix matrix multiplication\n> > \n> > Changes in v2:\n> > - clean up unused includes\n> > - avoid dereferencing an absent std::optional\n> > ---\n> > src/ipa/libipa/matrix.cpp | 17 +++++\n> > src/ipa/libipa/matrix.h | 144 +++++++++++++++++++++++++++++++++++++\n> > src/ipa/libipa/meson.build | 2 +\n> > 3 files changed, 163 insertions(+)\n> > create mode 100644 src/ipa/libipa/matrix.cpp\n> > create mode 100644 src/ipa/libipa/matrix.h\n> > \n> > diff --git a/src/ipa/libipa/matrix.cpp b/src/ipa/libipa/matrix.cpp\n> > new file mode 100644\n> > index 00000000..c222c3f0\n> > --- /dev/null\n> > +++ b/src/ipa/libipa/matrix.cpp\n> > @@ -0,0 +1,17 @@\n> > +/* SPDX-License-Identifier: BSD-2-Clause */\n> > +/*\n> > + * Copyright (C) 2019, Raspberry Pi Ltd\n> > + * Copyright (C) 2024, Paul Elder \n> > + *\n> > + * matrix.cpp - Matrix and related operations\n> > + */\n> > +\n> > +#include \"matrix.h\"\n> > +\n> > +#include \n> > +\n> > +namespace libcamera {\n> > +\n> > +LOG_DEFINE_CATEGORY(Matrix)\n> > +\n> > +} /* namespace libcamera */\n> > diff --git a/src/ipa/libipa/matrix.h b/src/ipa/libipa/matrix.h\n> > new file mode 100644\n> > index 00000000..ec41fb57\n> > --- /dev/null\n> > +++ b/src/ipa/libipa/matrix.h\n> > @@ -0,0 +1,144 @@\n> > +/* SPDX-License-Identifier: BSD-2-Clause */\n> > +/*\n> > + * Copyright (C) 2019, Raspberry Pi Ltd\n> > + * Copyright (C) 2024, Paul Elder \n> > + *\n> > + * matrix.cpp - Matrix and related operations\n> > + */\n> > +#pragma once\n> > +\n> > +#include \n> > +#include \n> > +#include \n> > +#include \n> > +\n> > +#include \n> > +\n> > +#include \"libcamera/internal/yaml_parser.h\"\n> > +\n> > +namespace libcamera {\n> > +\n> > +LOG_DECLARE_CATEGORY(Matrix)\n> > +\n> > +namespace ipa {\n> > +\n> > +template > +\t std::enable_if_t> * = nullptr>\n> > +class Matrix\n> > +{\n> > +public:\n> > +\tMatrix()\n> > +\t{\n> > +\t\tfor (unsigned int i = 0; i < R; i++)\n> > +\t\t\tfor (unsigned int j = 0; j < C; j++)\n> > +\t\t\t\tdata_.push_back(static_cast(i == j));\n> > +\t};\n> > +\n> > +\tMatrix(const std::vector &data)\n> > +\t{\n> > +\t\tASSERT(data_.size() == R * C);\n> \n> I think you wanted to check datainstead of data_ here.\n\nYes.\n\n> \n> > +\n> > +\t\tfor (const T &x : data)\n> > +\t\t\tdata_.push_back(x);\n> \n> Without some reset, this will only append to data_.\n> A small testcase would be nice to catch this.\n\nThis is a constructor so I don't think that would be the case...\n\nBut still I suppose better just in case? I added a clear() to this and\nthe above.\n\n> \n> > +\t}\n> > +\n> > +\t~Matrix(){};\n> > +\n> > +\tint readYaml(const libcamera::YamlObject &yaml)\n> > +\t{\n> > +\t\tif (yaml.size() != R * C) {\n> > +\t\t\tLOG(Matrix, Error)\n> > +\t\t\t\t<< \"Wrong number of values in matrix: expected \"\n> > +\t\t\t\t<< R * C << \", got \" << yaml.size();\n> > +\t\t\treturn -EINVAL;\n> > +\t\t}\n> > +\n> > +\t\tunsigned int i = 0;\n> > +\t\tfor (const auto &x : yaml.asList()) {\n> > +\t\t\tauto value = x.get();\n> > +\t\t\tif (!value) {\n> > +\t\t\t\tLOG(Matrix, Error) << \"Failed to read matrix value\";\n> > +\t\t\t\treturn -EINVAL;\n> > +\t\t\t}\n> > +\n> > +\t\t\tdata_[i++] = *value;\n> > +\t\t}\n> > +\n> > +\t\treturn 0;\n> > +\t}\n> > +\n> > +\tconst std::string toString() const\n> > +\t{\n> > +\t\tstd::stringstream ss;\n> > +\t\tss << \"Matrix { \";\n> > +\t\tfor (unsigned int i = 0; i < R; i++) {\n> > +\t\t\tss << \"[ \";\n> > +\t\t\tfor (unsigned int j = 0; j < C; j++) {\n> > +\t\t\t\tss << get(i, j);\n> > +\t\t\t\tss << ((j + 1 < C) ? \", \" : \" \");\n> > +\t\t\t}\n> > +\t\t\tss << ((i + 1 < R) ? \"], \" : \"]\");\n> > +\t\t}\n> > +\t\tss << \" }\";\n> > +\n> > +\t\treturn ss.str();\n> > +\t}\n> > +\n> > +\tconst T &get(unsigned int i, unsigned int j) const { return data_.at(i * C + j); }\n> > +\tvoid set(unsigned int i, unsigned int j, T value) { data_[i * C + j] = value; }\n> > +\n> > +private:\n> > +\tstd::vector data_;\n> > +};\n> > +\n> > +template > +\t std::enable_if_t> * = nullptr>\n> > +Matrix operator*(T d, const Matrix &m)\n> > +{\n> > +\tMatrix result;\n> > +\n> > +\tfor (unsigned int i = 0; i < R; i++)\n> > +\t\tfor (unsigned int j = 0; j < C; j++)\n> > +\t\t\tresult.set(i, j, d * m.get(i, j));\n> > +\n> > +\treturn result;\n> > +}\n> > +\n> > +template > +\t unsigned int R1, unsigned int C1,\n> > +\t unsigned int R2, unsigned int C2,\n> > +\t std::enable_if_t && C1 == R2> * = nullptr>\n> > +Matrix operator*(const Matrix &m1, const Matrix &m2)\n> > +{\n> \n> Out of curiousity: Why the four template params and not three (C1 and\n> R2 as a single one). I see that the enable_if serves the same purpose.\n\nI thought it was clearer.\n\n\nPaul\n\n> \n> > +\tMatrix result;\n> > +\n> > +\tfor (unsigned int i = 0; i < R1; i++) {\n> > +\t\tfor (unsigned int j = 0; j < C2; j++) {\n> > +\t\t\tT sum = 0;\n> > +\n> > +\t\t\tfor (unsigned int k = 0; k < C1; k++)\n> > +\t\t\t\tsum += m1.get(i, k) * m2.get(k, j);\n> > +\n> > +\t\t\tresult.set(i, j, sum);\n> > +\t\t}\n> > +\t}\n> > +\n> > +\treturn result;\n> > +}\n> > +\n> > +template > +\t std::enable_if_t> * = nullptr>\n> > +Matrix operator+(const Matrix &m1, const Matrix &m2)\n> > +{\n> > +\tMatrix result;\n> > +\n> > +\tfor (unsigned int i = 0; i < R; i++)\n> > +\t\tfor (unsigned int j = 0; j < C; j++)\n> > +\t\t\tresult.set(i, j, m1.get(i, j) + m2.get(i, j));\n> > +\n> > +\treturn result;\n> > +}\n> > +\n> > +} /* namespace ipa */\n> > +\n> > +} /* namespace libcamera */\n> > diff --git a/src/ipa/libipa/meson.build b/src/ipa/libipa/meson.build\n> > index 1b3faf8d..1e34355f 100644\n> > --- a/src/ipa/libipa/meson.build\n> > +++ b/src/ipa/libipa/meson.build\n> > @@ -7,6 +7,7 @@ libipa_headers = files([\n> > 'exposure_mode_helper.h',\n> > 'fc_queue.h',\n> > 'histogram.h',\n> > + 'matrix.h',\n> > 'module.h',\n> > 'pwl.h',\n> > ])\n> > @@ -18,6 +19,7 @@ libipa_sources = files([\n> > 'exposure_mode_helper.cpp',\n> > 'fc_queue.cpp',\n> > 'histogram.cpp',\n> > + 'matrix.cpp',\n> > 'module.cpp',\n> > 'pwl.cpp'\n> > ])\n> > -- \n> > 2.39.2\n> >","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 4B9EFC3220\n\tfor ;\n\tThu, 2 May 2024 09:38:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EA8046340B;\n\tThu, 2 May 2024 11:38:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9728161A89\n\tfor ;\n\tThu, 2 May 2024 11:38:55 +0200 (CEST)","from pyrite.rasen.tech (fp76f176b6.tkyc001.ap.nuro.jp\n\t[118.241.118.182])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 22B3EBC8;\n\tThu, 2 May 2024 11:37:56 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"VhRxn6+F\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1714642678;\n\tbh=5/ErytUme1b1ClR104jw+oMjcH6lxXYf1VcUNHA3WuM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=VhRxn6+FB5OkklEyA4lL0nvcIiSGzlrMywHVARw7C/EFY6EfwuFcOVuia8eXvAWvJ\n\tZCQbnVdNF09fYCwKnjDQ5nUnsKFcj6g0f+akO2Deeq01YjEJWJekNgcaz0FKxNEYVu\n\thY2NPOLlrvdIInUi8gVzlCMGNc7PudKTERsOBIpI=","Date":"Thu, 2 May 2024 18:38:48 +0900","From":"Paul Elder ","To":"Stefan Klug ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH v2 1/3] ipa: libipa: Add Matrix class","Message-ID":"","References":"<20240419071819.1325791-1-paul.elder@ideasonboard.com>\n\t<20240419071819.1325791-2-paul.elder@ideasonboard.com>\n\t<20240422191606.62gck644lw6bbbhg@jasper>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240422191606.62gck644lw6bbbhg@jasper>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]