[{"id":29274,"web_url":"https://patchwork.libcamera.org/comment/29274/","msgid":"<20240419082955.GI31776@pendragon.ideasonboard.com>","date":"2024-04-19T08:29:55","subject":"Re: [PATCH] libcamera: device_enumerator: Fix spell error","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Fri, Apr 19, 2024 at 12:07:59PM +0530, Umang Jain wrote:\n> In the description of DeviceMatch, the word 'appropriate' is\n> spelled incorrectly as 'appropriare'. Fix it.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> src/libcamera/device_enumerator.cpp | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> index 42b5ba6c..fbbf0559 100644\n> --- a/src/libcamera/device_enumerator.cpp\n> +++ b/src/libcamera/device_enumerator.cpp\n> @@ -56,7 +56,7 @@ LOG_DEFINE_CATEGORY(DeviceEnumerator)\n> * names can be added as match criteria.\n> *\n> * Pipeline handlers are recommended to add entities to DeviceMatch as\n> - * appropriare to ensure that the media device they need can be uniquely\n> + * appropriate to ensure that the media device they need can be uniquely\n> * identified. This is useful when the corresponding kernel driver can produce\n> * different graphs, for instance as a result of different driver versions or\n> * hardware configurations, and not all those graphs are suitable for a pipeline","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 382FDBE08B\n\tfor ;\n\tFri, 19 Apr 2024 08:30:06 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 2FA4E633F3;\n\tFri, 19 Apr 2024 10:30:05 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 8F9EB61B3D\n\tfor ;\n\tFri, 19 Apr 2024 10:30:03 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 265FD2E7;\n\tFri, 19 Apr 2024 10:29:15 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"TGI6Smoh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713515355;\n\tbh=fwFiYwxcY10S+v8/JQlj2Hn0uESfvDDrhtAs+fji/NQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=TGI6SmohWoGj1BcbwLXlqAc9Oedk5F6JbREhDog9uvxNE1Lzk50UAvU8YkhP8LK2i\n\tGeZ+1iN7nxIVpHQVIStg4l7XojsljE6u5M0cb6i7fA862wZAyuvx7A1v1emVh0z/Qq\n\tddacB7L7m5vvWBHpBEJdSj9Uz38E7w5kR9Pm3Hyo=","Date":"Fri, 19 Apr 2024 11:29:55 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH] libcamera: device_enumerator: Fix spell error","Message-ID":"<20240419082955.GI31776@pendragon.ideasonboard.com>","References":"<20240419063759.120905-1-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240419063759.120905-1-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29281,"web_url":"https://patchwork.libcamera.org/comment/29281/","msgid":"<171357216591.342316.10019390806919092179@ping.linuxembedded.co.uk>","date":"2024-04-20T00:16:05","subject":"Re: [PATCH] libcamera: device_enumerator: Fix spell error","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-04-19 09:29:55)\n> On Fri, Apr 19, 2024 at 12:07:59PM +0530, Umang Jain wrote:\n> > In the description of DeviceMatch, the word 'appropriate' is\n> > spelled incorrectly as 'appropriare'. Fix it.\n> > \n> > Signed-off-by: Umang Jain \n> \n> Reviewed-by: Laurent Pinchart \n\n\nReviewed-by: Kieran Bingham \n\n> \n> > ---\n> > src/libcamera/device_enumerator.cpp | 2 +-\n> > 1 file changed, 1 insertion(+), 1 deletion(-)\n> > \n> > diff --git a/src/libcamera/device_enumerator.cpp b/src/libcamera/device_enumerator.cpp\n> > index 42b5ba6c..fbbf0559 100644\n> > --- a/src/libcamera/device_enumerator.cpp\n> > +++ b/src/libcamera/device_enumerator.cpp\n> > @@ -56,7 +56,7 @@ LOG_DEFINE_CATEGORY(DeviceEnumerator)\n> > * names can be added as match criteria.\n> > *\n> > * Pipeline handlers are recommended to add entities to DeviceMatch as\n> > - * appropriare to ensure that the media device they need can be uniquely\n> > + * appropriate to ensure that the media device they need can be uniquely\n> > * identified. This is useful when the corresponding kernel driver can produce\n> > * different graphs, for instance as a result of different driver versions or\n> > * hardware configurations, and not all those graphs are suitable for a pipeline\n> \n> -- \n> Regards,\n> \n> Laurent Pinchart","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EA313C3200\n\tfor ;\n\tSat, 20 Apr 2024 00:16:13 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BC7CB633F3;\n\tSat, 20 Apr 2024 02:16:12 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F408B61B14\n\tfor ;\n\tSat, 20 Apr 2024 02:16:08 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id F3DC42BC;\n\tSat, 20 Apr 2024 02:15:19 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"S3HUJrBV\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713572120;\n\tbh=WXTv9mzxG+eAzcaEVu52lRuBZtBSJWooOA4fWyhp/54=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=S3HUJrBVbIJUjA1GYXDs3E6RiDiLM3DI5GHhZLwgvU5x+FwHIJ7jCVpXgDgq5DtVi\n\tqJk1uhbowg6CdH6wIziJtjVJz46Da7oobBB9RNvimx5oPrqv2dfFRrHftgNWACkz2U\n\tGG7hXUBLBxeAD+nLbtjCr9HZXCTucb4dXDiPD6hQ=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240419082955.GI31776@pendragon.ideasonboard.com>","References":"<20240419063759.120905-1-umang.jain@ideasonboard.com>\n\t<20240419082955.GI31776@pendragon.ideasonboard.com>","Subject":"Re: [PATCH] libcamera: device_enumerator: Fix spell error","From":"Kieran Bingham ","Cc":"libcamera-devel@lists.libcamera.org","To":"Laurent Pinchart ,\n\tUmang Jain ","Date":"Sat, 20 Apr 2024 01:16:05 +0100","Message-ID":"<171357216591.342316.10019390806919092179@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]