[{"id":2675,"web_url":"https://patchwork.libcamera.org/comment/2675/","msgid":"<20190919131651.GA5094@pendragon.ideasonboard.com>","date":"2019-09-19T13:16:51","subject":"Re: [libcamera-devel] [PATCH] package/libcamera: bump to version\n\t448393f77ec9e37cb807e8e8d35c1a4877d253d4","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Thu, Sep 19, 2019 at 11:25:53AM +0100, Kieran Bingham wrote:\n> Update to the latest version of libcamera, including a fix for toolchains\n> which require libatomic to be linked manually.\n> \n> The patch which handles this locally is therefore removed.\n> \n> Since the last version update, the option to disable building of the\n> unit tests has been renamed from '-Dtests=' to '-Dtest='\n> \n> This is updated accordingly.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n\nReviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>\n\n> ---\n> \n> This update has been run through a full compiler test, now with the following results:\n> \n>                              andes-nds32 [ 1/44]: SKIPPED\n>                              arm-aarch64 [ 2/44]: OK\n>                         br-aarch64-glibc [ 3/44]: OK\n>                            br-arcle-hs38 [ 4/44]: OK\n>                             br-arm-basic [ 5/44]: SKIPPED\n>                   br-arm-cortex-a9-glibc [ 6/44]: OK\n>                    br-arm-cortex-a9-musl [ 7/44]: OK\n>                    br-arm-cortex-m4-full [ 8/44]: SKIPPED\n>                              br-arm-full [ 9/44]: SKIPPED\n>                     br-arm-full-nothread [10/44]: SKIPPED\n>                       br-arm-full-static [11/44]: SKIPPED\n>                    br-i386-pentium4-full [12/44]: OK\n>                 br-i386-pentium-mmx-musl [13/44]: OK\n>                        br-m68k-5208-full [14/44]: SKIPPED\n>                       br-m68k-68040-full [15/44]: SKIPPED\n>                     br-microblazeel-full [16/44]: OK\n>                  br-mips32r6-el-hf-glibc [17/44]: OK\n>                       br-mips64-n64-full [18/44]: OK\n>                  br-mips64r6-el-hf-glibc [19/44]: OK\n>                       br-mipsel-o32-full [20/44]: OK\n>                           br-nios2-glibc [21/44]: OK\n>                       br-openrisc-uclibc [22/44]: OK\n>                br-powerpc-603e-basic-cpp [23/44]: SKIPPED\n>              br-powerpc64le-power8-glibc [24/44]: OK\n>                br-powerpc64-power7-glibc [25/44]: OK\n>                   br-powerpc-e500mc-full [26/44]: OK\n>                               br-riscv32 [27/44]: OK\n>                               br-riscv64 [28/44]: OK\n>                              br-sh4-full [29/44]: OK\n>                         br-sparc64-glibc [30/44]: OK\n>                          br-sparc-uclibc [31/44]: OK\n>                     br-x86-64-core2-full [32/44]: OK\n>                           br-x86-64-musl [33/44]: OK\n>                           br-xtensa-full [34/44]: OK\n>                        linaro-aarch64-be [35/44]: OK\n>                           linaro-aarch64 [36/44]: OK\n>                               linaro-arm [37/44]: OK\n>                      sourcery-arm-armv4t [38/44]: SKIPPED\n>                             sourcery-arm [39/44]: SKIPPED\n>                      sourcery-arm-thumb2 [40/44]: SKIPPED\n>                          sourcery-mips64 [41/44]: OK\n>                            sourcery-mips [42/44]: OK\n>                           sourcery-nios2 [43/44]: OK\n>                          sourcery-x86-64 [44/44]: OK\n> 44 builds, 12 skipped, 0 build failed, 0 legal-info failed\n> \n>  ...son.build-link-with-atomic-when-need.patch | 28 -------------------\n>  package/libcamera/libcamera.hash              |  2 +-\n>  package/libcamera/libcamera.mk                |  4 +--\n>  3 files changed, 3 insertions(+), 31 deletions(-)\n>  delete mode 100644 package/libcamera/0001-src-libcamera-meson.build-link-with-atomic-when-need.patch\n> \n> diff --git a/package/libcamera/0001-src-libcamera-meson.build-link-with-atomic-when-need.patch b/package/libcamera/0001-src-libcamera-meson.build-link-with-atomic-when-need.patch\n> deleted file mode 100644\n> index 8c34497db4f9..000000000000\n> --- a/package/libcamera/0001-src-libcamera-meson.build-link-with-atomic-when-need.patch\n> +++ /dev/null\n> @@ -1,28 +0,0 @@\n> -From 85b7aeef3c7765c5ba7e525c63a4c0f807f0bfc8 Mon Sep 17 00:00:00 2001\n> -From: Fabrice Fontaine <fontaine.fabrice@gmail.com>\n> -Date: Thu, 5 Sep 2019 10:24:31 +0200\n> -Subject: [PATCH] src/libcamera/meson.build: link with atomic when needed\n> -\n> -Fixes:\n> - - http://autobuild.buildroot.org/results/1f0b8338f5f39aa86b9d432598dae2f53c5f7c84\n> -\n> -Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>\n> ----\n> - src/libcamera/meson.build | 1 +\n> - 1 file changed, 1 insertion(+)\n> -\n> -diff --git a/src/libcamera/meson.build b/src/libcamera/meson.build\n> -index c5d8f11..0706a08 100644\n> ---- a/src/libcamera/meson.build\n> -+++ b/src/libcamera/meson.build\n> -@@ -99,6 +99,7 @@ version_cpp = vcs_tag(command : [gen_version, meson.build_root()],\n> - libcamera_sources += version_cpp\n> - \n> - libcamera_deps = [\n> -+    cc.find_library('atomic', required: false),\n> -     cc.find_library('dl'),\n> -     libudev,\n> -     dependency('threads'),\n> --- \n> -2.23.0.rc1\n> -\n> diff --git a/package/libcamera/libcamera.hash b/package/libcamera/libcamera.hash\n> index fc0a21670ef9..6f721d87eee4 100644\n> --- a/package/libcamera/libcamera.hash\n> +++ b/package/libcamera/libcamera.hash\n> @@ -1,3 +1,3 @@\n> -sha256 4073ee3429a28b19f65f1df107b87df9ee01e58dc3372fcc0fcafd3350a31c23  libcamera-caf25dc5cfd11b965316f02610d49ae3d886716b.tar.gz\n> +sha256 cbaa7e06059717f71b57f9c20135c86d5f121d9aab10bfc20513ba5d04478756  libcamera-448393f77ec9e37cb807e8e8d35c1a4877d253d4.tar.gz\n>  sha256 8177f97513213526df2cf6184d8ff986c675afb514d4e68a404010521b880643  licenses/gnu-gpl-2.0.txt\n>  sha256 592987e8510228d546540b84a22444bde98e48d03078d3b2eefcd889bec5ce8c  licenses/gnu-lgpl-2.1.txt\n> diff --git a/package/libcamera/libcamera.mk b/package/libcamera/libcamera.mk\n> index 62c48607d4ff..d209a38df3a9 100644\n> --- a/package/libcamera/libcamera.mk\n> +++ b/package/libcamera/libcamera.mk\n> @@ -5,10 +5,10 @@\n>  ################################################################################\n>  \n>  LIBCAMERA_SITE = https://git.linuxtv.org/libcamera.git\n> -LIBCAMERA_VERSION = caf25dc5cfd11b965316f02610d49ae3d886716b\n> +LIBCAMERA_VERSION = 448393f77ec9e37cb807e8e8d35c1a4877d253d4\n>  LIBCAMERA_SITE_METHOD = git\n>  LIBCAMERA_DEPENDENCIES = udev\n> -LIBCAMERA_CONF_OPTS = -Dtests=false -Ddocumentation=false\n> +LIBCAMERA_CONF_OPTS = -Dtest=false -Ddocumentation=false\n>  LIBCAMERA_INSTALL_STAGING = yes\n>  LIBCAMERA_LICENSE = LGPL-2.1+ (library), GPL-2.0+ (utils)\n>  LIBCAMERA_LICENSE_FILES = \\","headers":{"Return-Path":"<laurent.pinchart@ideasonboard.com>","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D4C1A60BF1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Sep 2019 15:17:01 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(dfj612yhrgyx302h3jwwy-3.rev.dnainternet.fi\n\t[IPv6:2001:14ba:21f5:5b00:ce28:277f:58d7:3ca4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2B649325;\n\tThu, 19 Sep 2019 15:17:01 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1568899021;\n\tbh=CoMAU7/9AUYB8xT3rCgqrkDUi5HEDFnP597znveTN3Q=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=mgq3hN9FIL8lwdlw2oluIXohPr10qs+K5z1/cakBbL6dfzfaNBLscZYXLCVWiFCEw\n\t49v7Xl/x/EEUM54DF7Io9KkRmGzjnQ/8N583UQEDPTu9n+Axr6RQN9ZimJnKZeslDK\n\tT8ELKkFE+FDCxfWla+SEzo7iw4/sL3CRG9S4HQOk=","Date":"Thu, 19 Sep 2019 16:16:51 +0300","From":"Laurent Pinchart <laurent.pinchart@ideasonboard.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"buildroot@buildroot.org,\n\tLibCamera Devel <libcamera-devel@lists.libcamera.org>,\n\tFabrice Fontaine <fontaine.fabrice@gmail.com>","Message-ID":"<20190919131651.GA5094@pendragon.ideasonboard.com>","References":"<20190919102553.32451-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20190919102553.32451-1-kieran.bingham@ideasonboard.com>","User-Agent":"Mutt/1.10.1 (2018-07-13)","Subject":"Re: [libcamera-devel] [PATCH] package/libcamera: bump to version\n\t448393f77ec9e37cb807e8e8d35c1a4877d253d4","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 19 Sep 2019 13:17:02 -0000"}},{"id":2676,"web_url":"https://patchwork.libcamera.org/comment/2676/","msgid":"<20190919222249.7421c42f@windsurf>","date":"2019-09-19T20:22:49","subject":"Re: [libcamera-devel] [Buildroot] [PATCH] package/libcamera: bump\n\tto version 448393f77ec9e37cb807e8e8d35c1a4877d253d4","submitter":{"id":13,"url":"https://patchwork.libcamera.org/api/people/13/","name":"Thomas Petazzoni","email":"thomas.petazzoni@bootlin.com"},"content":"On Thu, 19 Sep 2019 11:25:53 +0100\nKieran Bingham <kieran.bingham@ideasonboard.com> wrote:\n\n> Update to the latest version of libcamera, including a fix for toolchains\n> which require libatomic to be linked manually.\n> \n> The patch which handles this locally is therefore removed.\n> \n> Since the last version update, the option to disable building of the\n> unit tests has been renamed from '-Dtests=' to '-Dtest='\n> \n> This is updated accordingly.\n> \n> Signed-off-by: Kieran Bingham <kieran.bingham@ideasonboard.com>\n> ---\n\nApplied to master, thanks.\n\nThomas","headers":{"Return-Path":"<thomas.petazzoni@bootlin.com>","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9B18260BF1\n\tfor <libcamera-devel@lists.libcamera.org>;\n\tThu, 19 Sep 2019 22:22:51 +0200 (CEST)","from windsurf (lfbn-1-2159-45.w90-76.abo.wanadoo.fr [90.76.216.45])\n\t(Authenticated sender: thomas.petazzoni@bootlin.com)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id D2ED7FF805;\n\tThu, 19 Sep 2019 20:22:50 +0000 (UTC)"],"X-Originating-IP":"90.76.216.45","Date":"Thu, 19 Sep 2019 22:22:49 +0200","From":"Thomas Petazzoni <thomas.petazzoni@bootlin.com>","To":"Kieran Bingham <kieran.bingham@ideasonboard.com>","Cc":"buildroot@buildroot.org, LibCamera Devel\n\t<libcamera-devel@lists.libcamera.org>, Fabrice Fontaine\n\t<fontaine.fabrice@gmail.com>","Message-ID":"<20190919222249.7421c42f@windsurf>","In-Reply-To":"<20190919102553.32451-1-kieran.bingham@ideasonboard.com>","References":"<20190919102553.32451-1-kieran.bingham@ideasonboard.com>","Organization":"Bootlin","X-Mailer":"Claws Mail 3.17.3 (GTK+ 2.24.32; x86_64-redhat-linux-gnu)","MIME-Version":"1.0","Content-Type":"text/plain; charset=US-ASCII","Content-Transfer-Encoding":"7bit","X-Mailman-Approved-At":"Fri, 20 Sep 2019 10:53:10 +0200","Subject":"Re: [libcamera-devel] [Buildroot] [PATCH] package/libcamera: bump\n\tto version 448393f77ec9e37cb807e8e8d35c1a4877d253d4","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"<libcamera-devel.lists.libcamera.org>","List-Unsubscribe":"<https://lists.libcamera.org/options/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=unsubscribe>","List-Archive":"<https://lists.libcamera.org/pipermail/libcamera-devel/>","List-Post":"<mailto:libcamera-devel@lists.libcamera.org>","List-Help":"<mailto:libcamera-devel-request@lists.libcamera.org?subject=help>","List-Subscribe":"<https://lists.libcamera.org/listinfo/libcamera-devel>,\n\t<mailto:libcamera-devel-request@lists.libcamera.org?subject=subscribe>","X-List-Received-Date":"Thu, 19 Sep 2019 20:22:51 -0000"}}]