[{"id":29253,"web_url":"https://patchwork.libcamera.org/comment/29253/","msgid":"<171343446328.342316.14371270614224572785@ping.linuxembedded.co.uk>","date":"2024-04-18T10:01:03","subject":"Re: [PATCH 2/2] libcamera: Fix output spelling error","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Umang Jain (2024-04-18 08:49:45)\n> There are two places where \"output\" is spelled as \"ouput\".\n> Fix it.\n> \n> Signed-off-by: Umang Jain \n\n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/converter/converter_v4l2_m2m.h | 2 +-\n> utils/raspberrypi/ctt/ctt.py | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> index 815916d0..84fb485f 100644\n> --- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> +++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> @@ -47,7 +47,7 @@ public:\n> \n> int configure(const StreamConfiguration &inputCfg,\n> const std::vector> &outputCfg);\n> - int exportBuffers(unsigned int ouput, unsigned int count,\n> + int exportBuffers(unsigned int output, unsigned int count,\n> std::vector> *buffers);\n> \n> int start();\n> diff --git a/utils/raspberrypi/ctt/ctt.py b/utils/raspberrypi/ctt/ctt.py\n> index cd89f177..89159e63 100755\n> --- a/utils/raspberrypi/ctt/ctt.py\n> +++ b/utils/raspberrypi/ctt/ctt.py\n> @@ -350,7 +350,7 @@ class Camera:\n> alsc_out = alsc_all(self, do_alsc_colour, plot)\n> cal_cr_list, cal_cb_list, luminance_lut, av_corn = alsc_out\n> \"\"\"\n> - write ouput to json and finish if not do_alsc_colour\n> + write output to json and finish if not do_alsc_colour\n> \"\"\"\n> if not do_alsc_colour:\n> self.json['rpi.alsc']['luminance_lut'] = luminance_lut\n> -- \n> 2.44.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87F64BE08B\n\tfor ;\n\tThu, 18 Apr 2024 10:01:08 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 3A5936334D;\n\tThu, 18 Apr 2024 12:01:08 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id F18A761B4F\n\tfor ;\n\tThu, 18 Apr 2024 12:01:05 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 42579802;\n\tThu, 18 Apr 2024 12:00:18 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mtDZtWE6\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713434418;\n\tbh=VAH10rkGziQILlf3qvW15E6PhfU9pyvHXRQeiElT82w=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=mtDZtWE6yzsa2Mn/uub6M4iE5bmHIVHxFSDf9q7Z0yw9JVHVRCafBGPkiRDJxS+s8\n\tuxMD44AcNjR4hVqkGuIDkihK0uCv8Jivklxkd2nsD6jiymuTKO+eNMaGUWZxOUeb80\n\t11SUchIRu9qjADPl0dx797fhywq/oHuIVyYeQO3w=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240418074945.47349-3-umang.jain@ideasonboard.com>","References":"<20240418074945.47349-1-umang.jain@ideasonboard.com>\n\t<20240418074945.47349-3-umang.jain@ideasonboard.com>","Subject":"Re: [PATCH 2/2] libcamera: Fix output spelling error","From":"Kieran Bingham ","Cc":"Umang Jain ","To":"Umang Jain ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Thu, 18 Apr 2024 11:01:03 +0100","Message-ID":"<171343446328.342316.14371270614224572785@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29255,"web_url":"https://patchwork.libcamera.org/comment/29255/","msgid":"<20240418100926.GS12561@pendragon.ideasonboard.com>","date":"2024-04-18T10:09:26","subject":"Re: [PATCH 2/2] libcamera: Fix output spelling error","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Thu, Apr 18, 2024 at 01:19:45PM +0530, Umang Jain wrote:\n> There are two places where \"output\" is spelled as \"ouput\".\n> Fix it.\n> \n> Signed-off-by: Umang Jain \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/internal/converter/converter_v4l2_m2m.h | 2 +-\n> utils/raspberrypi/ctt/ctt.py | 2 +-\n> 2 files changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/include/libcamera/internal/converter/converter_v4l2_m2m.h b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> index 815916d0..84fb485f 100644\n> --- a/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> +++ b/include/libcamera/internal/converter/converter_v4l2_m2m.h\n> @@ -47,7 +47,7 @@ public:\n> \n> \tint configure(const StreamConfiguration &inputCfg,\n> \t\t const std::vector> &outputCfg);\n> -\tint exportBuffers(unsigned int ouput, unsigned int count,\n> +\tint exportBuffers(unsigned int output, unsigned int count,\n> \t\t\t std::vector> *buffers);\n> \n> \tint start();\n> diff --git a/utils/raspberrypi/ctt/ctt.py b/utils/raspberrypi/ctt/ctt.py\n> index cd89f177..89159e63 100755\n> --- a/utils/raspberrypi/ctt/ctt.py\n> +++ b/utils/raspberrypi/ctt/ctt.py\n> @@ -350,7 +350,7 @@ class Camera:\n> alsc_out = alsc_all(self, do_alsc_colour, plot)\n> cal_cr_list, cal_cb_list, luminance_lut, av_corn = alsc_out\n> \"\"\"\n> - write ouput to json and finish if not do_alsc_colour\n> + write output to json and finish if not do_alsc_colour\n> \"\"\"\n> if not do_alsc_colour:\n> self.json['rpi.alsc']['luminance_lut'] = luminance_lut","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id E6DF1C3213\n\tfor ;\n\tThu, 18 Apr 2024 10:09:34 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id A4C58633EE;\n\tThu, 18 Apr 2024 12:09:34 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 13C5661B4F\n\tfor ;\n\tThu, 18 Apr 2024 12:09:33 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(117.145-247-81.adsl-dyn.isp.belgacom.be [81.247.145.117])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6FF7C827;\n\tThu, 18 Apr 2024 12:08:45 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XuxAbYWt\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713434925;\n\tbh=+o4EcxUFLnmBakZCejI0ibmOpYFvRvbrF21dPKH0ZBs=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=XuxAbYWtdGK0eSoJK1CL9x3+qck4Wkei3YAvrRxhLLGWVF5ymuEKyplP0R9JunwUG\n\tRoJ2abhDM9FdYBt3Nn9a6VZFyMSne0Zlz4qR19hL6S7l6m2dv/pab2PEpCD6lX6gvg\n\tn0sWD737FUj8QUlaEfpqEqwWUNOVErCRntxET/3k=","Date":"Thu, 18 Apr 2024 13:09:26 +0300","From":"Laurent Pinchart ","To":"Umang Jain ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/2] libcamera: Fix output spelling error","Message-ID":"<20240418100926.GS12561@pendragon.ideasonboard.com>","References":"<20240418074945.47349-1-umang.jain@ideasonboard.com>\n\t<20240418074945.47349-3-umang.jain@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240418074945.47349-3-umang.jain@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]