[{"id":29241,"web_url":"https://patchwork.libcamera.org/comment/29241/","msgid":"<20240417114348.ikqg7gdqwndvuyu7@jasper>","date":"2024-04-17T11:43:48","subject":"Re: [PATCH] Documentation: coding-style: Clean up header guard style","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Kieran,\n\nthat's an easy one :-)\n\nOn Wed, Apr 17, 2024 at 10:51:12AM +0100, Kieran Bingham wrote:\n> Header guards were replaced by pragma once calls with commits\n> 0a64cf8b7645 (\"libcamera: Convert to pragma once\") through to\n> 796210ecea82 (\"v4l2: Convert to pragma once\")\n> \n> Update the coding style to reflect the updated header guard style.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> ---\n> Documentation/coding-style.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst\n> index 053fdd998351..72cb28d25189 100644\n> --- a/Documentation/coding-style.rst\n> +++ b/Documentation/coding-style.rst\n> @@ -59,7 +59,7 @@ document:\n> underscores in between\n> * All formatting rules specified in the selected sections of the Linux kernel\n> Code Style for indentation, braces, spacing, etc\n> -* Header guards are formatted as '__LIBCAMERA_FILE_NAME_H__'\n> +* Headers are guarded by the use of '#pragma once'\n> \n> Order of Includes\n> ~~~~~~~~~~~~~~~~~\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 7E256C3213\n\tfor ;\n\tWed, 17 Apr 2024 11:43:54 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 7CAAB61B54;\n\tWed, 17 Apr 2024 13:43:53 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C1A5161B54\n\tfor ;\n\tWed, 17 Apr 2024 13:43:51 +0200 (CEST)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:af82:b928:4f67:4a9d])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 8D29B132;\n\tWed, 17 Apr 2024 13:43:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"pcu2dGBT\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713354184;\n\tbh=+tBgx56hx4SAS1gC5caaGbwFDNh2f8xkTluDWA9JqQQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=pcu2dGBT9kmSZTAuJxJcHAAskcZ5MnRXh5VlhXSRv5/PM0XU/lj4NejAV+HIfNCQ+\n\ttvL0j6/F/BKwst+kN97b0EEUSi5Q/1ehy+8R9F3/pr04bjn7JWwcfaBGUWQNm1u+Y2\n\tw+ek910cnnzFnaLwlyUcDEjhz51mrgHBwDvBw9tg=","Date":"Wed, 17 Apr 2024 13:43:48 +0200","From":"Stefan Klug ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH] Documentation: coding-style: Clean up header guard style","Message-ID":"<20240417114348.ikqg7gdqwndvuyu7@jasper>","References":"<20240417095112.1718987-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240417095112.1718987-1-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29242,"web_url":"https://patchwork.libcamera.org/comment/29242/","msgid":"<20240417152142.GL12561@pendragon.ideasonboard.com>","date":"2024-04-17T15:21:42","subject":"Re: [PATCH] Documentation: coding-style: Clean up header guard style","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"On Wed, Apr 17, 2024 at 10:51:12AM +0100, Kieran Bingham wrote:\n> Header guards were replaced by pragma once calls with commits\n> 0a64cf8b7645 (\"libcamera: Convert to pragma once\") through to\n> 796210ecea82 (\"v4l2: Convert to pragma once\")\n> \n> Update the coding style to reflect the updated header guard style.\n> \n> Signed-off-by: Kieran Bingham \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> Documentation/coding-style.rst | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/Documentation/coding-style.rst b/Documentation/coding-style.rst\n> index 053fdd998351..72cb28d25189 100644\n> --- a/Documentation/coding-style.rst\n> +++ b/Documentation/coding-style.rst\n> @@ -59,7 +59,7 @@ document:\n> underscores in between\n> * All formatting rules specified in the selected sections of the Linux kernel\n> Code Style for indentation, braces, spacing, etc\n> -* Header guards are formatted as '__LIBCAMERA_FILE_NAME_H__'\n> +* Headers are guarded by the use of '#pragma once'\n> \n> Order of Includes\n> ~~~~~~~~~~~~~~~~~","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 99FA7C3213\n\tfor ;\n\tWed, 17 Apr 2024 15:21:53 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9EE6663352;\n\tWed, 17 Apr 2024 17:21:52 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C7B8F61B54\n\tfor ;\n\tWed, 17 Apr 2024 17:21:51 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-15-230-nat.elisa-mobile.fi\n\t[85.76.15.230])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1C3D4DD9;\n\tWed, 17 Apr 2024 17:21:04 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"eYarR7Gp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713367264;\n\tbh=/Za0aUu990ropa6HJW/f/1HWPeR5pAo8AFMiutAJBTI=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=eYarR7Gpqq7LNPDQ3WPy5K3HqEtf8aX2Sr74D2ecchwnJGZcmu027wIDuG+JOEqNy\n\tUk2Ynoq+7LGlS7IuXjlfU1srKhKcGx9Eo1cgs0dhYkMfMaQr/9Exf3G7rhsb4YTLjm\n\tzZWwHe/Mw9yh8L0J98KZSKH0r9lzxeHnt8ks0FQs=","Date":"Wed, 17 Apr 2024 18:21:42 +0300","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH] Documentation: coding-style: Clean up header guard style","Message-ID":"<20240417152142.GL12561@pendragon.ideasonboard.com>","References":"<20240417095112.1718987-1-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240417095112.1718987-1-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]