[{"id":29231,"web_url":"https://patchwork.libcamera.org/comment/29231/","msgid":"<171326839360.2468918.739059437963831103@ping.linuxembedded.co.uk>","date":"2024-04-16T11:53:13","subject":"Re: [PATCH 1/2] utils: checkstyle.py: Use r'' strings for regular\n\texpressions","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-04-16 11:20:03)\n> It's a good practice to use r'' strings for regular expressions in\n> Python, to avoid unexpected interaction with string escape sequences.\n> Use them globally. This allows simplifying escaping in one of the\n> regular expression strings.\n> \n\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> utils/checkstyle.py | 10 +++++-----\n> 1 file changed, 5 insertions(+), 5 deletions(-)\n> \n> diff --git a/utils/checkstyle.py b/utils/checkstyle.py\n> index 84f44a422577..2ab7e50fb0b6 100755\n> --- a/utils/checkstyle.py\n> +++ b/utils/checkstyle.py\n> @@ -569,7 +569,7 @@ class IncludeChecker(StyleChecker):\n> 'limits', 'locale', 'setjmp', 'signal', 'stdarg', 'stddef',\n> 'stdint', 'stdio', 'stdlib', 'string', 'time', 'uchar', 'wchar',\n> 'wctype')\n> - include_regex = re.compile('^#include ')\n> + include_regex = re.compile(r'^#include ')\n> \n> def __init__(self, content):\n> super().__init__()\n> @@ -632,7 +632,7 @@ class MesonChecker(StyleChecker):\n> \n> class Pep8Checker(StyleChecker):\n> patterns = ('*.py',)\n> - results_regex = re.compile('stdin:([0-9]+):([0-9]+)(.*)')\n> + results_regex = re.compile(r'stdin:([0-9]+):([0-9]+)(.*)')\n> \n> def __init__(self, content):\n> super().__init__()\n> @@ -665,7 +665,7 @@ class Pep8Checker(StyleChecker):\n> \n> class ShellChecker(StyleChecker):\n> patterns = ('*.sh',)\n> - results_line_regex = re.compile('In - line ([0-9]+):')\n> + results_line_regex = re.compile(r'In - line ([0-9]+):')\n> \n> def __init__(self, content):\n> super().__init__()\n> @@ -753,7 +753,7 @@ class CLangFormatter(Formatter):\n> class DoxygenFormatter(Formatter):\n> patterns = ('*.c', '*.cpp')\n> \n> - return_regex = re.compile(' +\\\\* +\\\\\\\\return +[a-z]')\n> + return_regex = re.compile(r' +\\* +\\\\return +[a-z]')\n> \n> @classmethod\n> def format(cls, filename, data):\n> @@ -813,7 +813,7 @@ class DPointerFormatter(Formatter):\n> class IncludeOrderFormatter(Formatter):\n> patterns = ('*.cpp', '*.h')\n> \n> - include_regex = re.compile('^#include ([\"<])([^\">]*)([\">])')\n> + include_regex = re.compile(r'^#include ([\"<])([^\">]*)([\">])')\n> \n> @classmethod\n> def format(cls, filename, data):\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EE38CC3213\n\tfor ;\n\tTue, 16 Apr 2024 11:53:18 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id CB8BF63352;\n\tTue, 16 Apr 2024 13:53:17 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 72C3761B75\n\tfor ;\n\tTue, 16 Apr 2024 13:53:16 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id EE035512;\n\tTue, 16 Apr 2024 13:52:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"upQAw++s\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713268350;\n\tbh=7RJC2w1OrH5d/Tu5L/EmH1yI91wTzeFVxO5+/SmkZg0=;\n\th=In-Reply-To:References:Subject:From:To:Date:From;\n\tb=upQAw++sUv9BPMfM7EqjWy3vdvlwLnfEQ1UZzjtVL4zDbK9q7Irk5zJEkM1SACs+e\n\tgfxBDzsUEJhsvzXWEDLEhF+KTHfwn8CDmMsYryv/YMMzavt1U5ft2sbeLAhBLjfEOA\n\t/l6Lb/NiAPzc7RJvhml0e6dpE2MN8N6uBrrlCKFc=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240416102004.10617-2-laurent.pinchart@ideasonboard.com>","References":"<20240416102004.10617-1-laurent.pinchart@ideasonboard.com>\n\t<20240416102004.10617-2-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH 1/2] utils: checkstyle.py: Use r'' strings for regular\n\texpressions","From":"Kieran Bingham ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 16 Apr 2024 12:53:13 +0100","Message-ID":"<171326839360.2468918.739059437963831103@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]