{"id":19889,"url":"https://patchwork.libcamera.org/api/patches/19889/?format=json","web_url":"https://patchwork.libcamera.org/patch/19889/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240416102004.10617-2-laurent.pinchart@ideasonboard.com>","date":"2024-04-16T10:20:03","name":"[1/2] utils: checkstyle.py: Use r'' strings for regular expressions","commit_ref":"fef732d4dc7fcb012c4339585d621d6c6bf384aa","pull_url":null,"state":"accepted","archived":false,"hash":"d2704692012baeed82288dc2e0b39b36c5efb151","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19889/mbox/","series":[{"id":4258,"url":"https://patchwork.libcamera.org/api/series/4258/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4258","date":"2024-04-16T10:20:02","name":"utils: checkstyle.py: Extend Doxygen formatter","version":1,"mbox":"https://patchwork.libcamera.org/series/4258/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19889/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19889/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 87969BE08B\n\tfor ;\n\tTue, 16 Apr 2024 10:20:19 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 1FBAC63361;\n\tTue, 16 Apr 2024 12:20:19 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id BC69461B75\n\tfor ;\n\tTue, 16 Apr 2024 12:20:16 +0200 (CEST)","from pendragon.ideasonboard.com (85-76-7-196-nat.elisa-mobile.fi\n\t[85.76.7.196])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id BD180480\n\tfor ;\n\tTue, 16 Apr 2024 12:19:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"NIaQXO0V\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713262770;\n\tbh=0ysXeAsYgh/G5pscAxu49YU+UerAjSZTjeMy2os6Ucc=;\n\th=From:To:Subject:Date:In-Reply-To:References:From;\n\tb=NIaQXO0VgT1E/LJmAVp34Y4JnkXwf+1EsDrd3Z8OIsfevZn6B3vFLYm9GHaGqMK+M\n\tT/Oq5LfhoQIRZqw4c1Zig2y1OJcwfv4jj/UDt3XxWeBPQKgfaABm3qC9g6m3yZaqoc\n\tHImUot5wbBCuuT5jzhTo9vC2SLjV5yHMQcrP/ruI=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH 1/2] utils: checkstyle.py: Use r'' strings for regular\n\texpressions","Date":"Tue, 16 Apr 2024 13:20:03 +0300","Message-ID":"<20240416102004.10617-2-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.43.2","In-Reply-To":"<20240416102004.10617-1-laurent.pinchart@ideasonboard.com>","References":"<20240416102004.10617-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"It's a good practice to use r'' strings for regular expressions in\nPython, to avoid unexpected interaction with string escape sequences.\nUse them globally. This allows simplifying escaping in one of the\nregular expression strings.\n\nSigned-off-by: Laurent Pinchart \n---\n utils/checkstyle.py | 10 +++++-----\n 1 file changed, 5 insertions(+), 5 deletions(-)","diff":"diff --git a/utils/checkstyle.py b/utils/checkstyle.py\nindex 84f44a422577..2ab7e50fb0b6 100755\n--- a/utils/checkstyle.py\n+++ b/utils/checkstyle.py\n@@ -569,7 +569,7 @@ class IncludeChecker(StyleChecker):\n 'limits', 'locale', 'setjmp', 'signal', 'stdarg', 'stddef',\n 'stdint', 'stdio', 'stdlib', 'string', 'time', 'uchar', 'wchar',\n 'wctype')\n- include_regex = re.compile('^#include ')\n+ include_regex = re.compile(r'^#include ')\n \n def __init__(self, content):\n super().__init__()\n@@ -632,7 +632,7 @@ class MesonChecker(StyleChecker):\n \n class Pep8Checker(StyleChecker):\n patterns = ('*.py',)\n- results_regex = re.compile('stdin:([0-9]+):([0-9]+)(.*)')\n+ results_regex = re.compile(r'stdin:([0-9]+):([0-9]+)(.*)')\n \n def __init__(self, content):\n super().__init__()\n@@ -665,7 +665,7 @@ class Pep8Checker(StyleChecker):\n \n class ShellChecker(StyleChecker):\n patterns = ('*.sh',)\n- results_line_regex = re.compile('In - line ([0-9]+):')\n+ results_line_regex = re.compile(r'In - line ([0-9]+):')\n \n def __init__(self, content):\n super().__init__()\n@@ -753,7 +753,7 @@ class CLangFormatter(Formatter):\n class DoxygenFormatter(Formatter):\n patterns = ('*.c', '*.cpp')\n \n- return_regex = re.compile(' +\\\\* +\\\\\\\\return +[a-z]')\n+ return_regex = re.compile(r' +\\* +\\\\return +[a-z]')\n \n @classmethod\n def format(cls, filename, data):\n@@ -813,7 +813,7 @@ class DPointerFormatter(Formatter):\n class IncludeOrderFormatter(Formatter):\n patterns = ('*.cpp', '*.h')\n \n- include_regex = re.compile('^#include ([\"<])([^\">]*)([\">])')\n+ include_regex = re.compile(r'^#include ([\"<])([^\">]*)([\">])')\n \n @classmethod\n def format(cls, filename, data):\n","prefixes":["1/2"]}