[{"id":29215,"web_url":"https://patchwork.libcamera.org/comment/29215/","msgid":"<171301868013.3165863.34739916597554994@ping.linuxembedded.co.uk>","date":"2024-04-13T14:31:20","subject":"Re: [PATCH v2] utils: ipc: Fix async main interface functions with\n\tno parameters","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Laurent Pinchart (2024-04-12 15:43:31)\n> From: Paul Elder \n> \n> If an async main interface function is defined with no parameters, there\n> would be a compilation error complaining about an extra comma. Fix this.\n> \n> Signed-off-by: Paul Elder \n> Reviewed-by: Stefan Klug \n> Reviewed-by: Laurent Pinchart \n\nv2 looks like a cleaner solution than v1 indeed.\n\nReviewed-by: Kieran Bingham \n\n> Signed-off-by: Laurent Pinchart \n> ---\n> .../generators/libcamera_templates/module_ipa_proxy.cpp.tmpl | 4 ++--\n> 1 file changed, 2 insertions(+), 2 deletions(-)\n> \n> diff --git a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> index 238cf4a59435..f64c3c93bfcb 100644\n> --- a/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> +++ b/utils/ipc/generators/libcamera_templates/module_ipa_proxy.cpp.tmpl\n> @@ -175,9 +175,9 @@ void {{proxy_name}}::recvMessage(const IPCMessage &data)\n> );\n> {% elif method|is_async %}\n> ASSERT(state_ == ProxyRunning);\n> - proxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued,\n> + proxy_.invokeMethod(&ThreadProxy::{{method.mojom_name}}, ConnectionTypeQueued\n> {%- for param in method|method_param_names -%}\n> - {{param}}{{- \", \" if not loop.last}}\n> + , {{param}}\n> {%- endfor -%}\n> );\n> {%- endif %}\n> \n> base-commit: 9dc601cf7a689fe6eef23189edf0c8a9c38dcfe1\n> -- \n> Regards,\n> \n> Laurent Pinchart\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A6B3CBE08B\n\tfor ;\n\tSat, 13 Apr 2024 14:31:25 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id D4E4563340;\n\tSat, 13 Apr 2024 16:31:24 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 7D1ED61B4D\n\tfor ;\n\tSat, 13 Apr 2024 16:31:23 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 1546B735;\n\tSat, 13 Apr 2024 16:30:39 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"JLVtilI0\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713018639;\n\tbh=PalVKBjWhLxWaHyMWpVLtbCWiwM9w8WYrJIzDAMeD2U=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=JLVtilI0UHSsdARrxlSvAo5BCH+Ei7UA7r2CUWk6tSOKHJPK9fRA08WzJZln/F6Yh\n\tKhnyyddumuwRy48H9fIyS1DybyzOvfgpPWbt9FYAuHmLcmGmls7LfZSrq21yMYQcTY\n\tzXuIPU5PYYe5vCHHnN5sho++cH/8d7Z6vmY+TtMw=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240412144331.29858-1-laurent.pinchart@ideasonboard.com>","References":"<20240412144331.29858-1-laurent.pinchart@ideasonboard.com>","Subject":"Re: [PATCH v2] utils: ipc: Fix async main interface functions with\n\tno parameters","From":"Kieran Bingham ","Cc":"Paul Elder ,\n\tStefan Klug ","To":"Laurent Pinchart ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Sat, 13 Apr 2024 15:31:20 +0100","Message-ID":"<171301868013.3165863.34739916597554994@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]