[{"id":29962,"web_url":"https://patchwork.libcamera.org/comment/29962/","msgid":"<20240616223630.GC28126@pendragon.ideasonboard.com>","date":"2024-06-16T22:36:30","subject":"Re: [PATCH 3/3] ipa: rkisp1: agc: Plumb lux","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Paul,\n\nThank you for the patch.\n\nOn Fri, Apr 12, 2024 at 06:17:00PM +0900, Paul Elder wrote:\n> Now that the rkisp1 IPA has a lux algorithm module, use the lux value\n> that comes from that as opposed to hardcoding it.\n> \n> Signed-off-by: Paul Elder \n> ---\n> src/ipa/rkisp1/algorithms/agc.cpp | 3 +--\n> 1 file changed, 1 insertion(+), 2 deletions(-)\n> \n> diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\n> index ed4d6330..5371ae48 100644\n> --- a/src/ipa/rkisp1/algorithms/agc.cpp\n> +++ b/src/ipa/rkisp1/algorithms/agc.cpp\n> @@ -424,8 +424,7 @@ void Agc::process(IPAContext &context, [[maybe_unused]] const uint32_t frame,\n> \tdouble analogueGain = frameContext.sensor.gain;\n> \tutils::Duration effectiveExposureValue = exposureTime * analogueGain;\n> \n> -\t/* \\todo Plumb in the lux value. Requires a lux algo + tuning */\n> -\tdouble lux = 400;\n> +\tdouble lux = frameContext.agc.lux;\n\nI like this :-) But with the current implementation, for this to work, I\nthink you need to ensure that the Lux algorithm is instantiated in the\ntuning file before Agc. This should be documented somewhere.\n\n> \n> \tutils::Duration shutterTime;\n> \tdouble aGain, dGain;","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 56E28C3237\n\tfor ;\n\tSun, 16 Jun 2024 22:36:57 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 76A6965458;\n\tMon, 17 Jun 2024 00:36:56 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 0DA0F65458\n\tfor ;\n\tMon, 17 Jun 2024 00:36:54 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id C729C9C1;\n\tMon, 17 Jun 2024 00:36:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"M5zfrYLY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1718577397;\n\tbh=0WBYtoSx4sPmDo4WBZrWFPUENOxj+SaL9y2d6Efz9sA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=M5zfrYLYseqx/UzBOKl7ZlRnhkbhmLM4j5e6BAp3XMYLRaK8IVIK72NdBhG+oNuag\n\tNTk9FLUYMk9yBp5XaJM2AySTtzo/XiKbCbZMfq3YxPzJe5KIdrR/hfd5u4u4g+jdEg\n\tQT56zi9CIcfw40BOp7SY7o/M1NxitJju1nJ40ddw=","Date":"Mon, 17 Jun 2024 01:36:30 +0300","From":"Laurent Pinchart ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 3/3] ipa: rkisp1: agc: Plumb lux","Message-ID":"<20240616223630.GC28126@pendragon.ideasonboard.com>","References":"<20240412091700.1817754-1-paul.elder@ideasonboard.com>\n\t<20240412091700.1817754-4-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240412091700.1817754-4-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]