[{"id":29202,"web_url":"https://patchwork.libcamera.org/comment/29202/","msgid":"<20240412081233.afqmufcrem35lpcf@macbook-air.speedport.ip>","date":"2024-04-12T08:12:33","subject":"Re: [PATCH 4/5] utils: tuning: rkisp1: Add skeletal CTK to the\n\trkisp1 tuning script","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Paul,\n\nthank you for the patch.\n\nOn Fri, Apr 05, 2024 at 11:53:34PM +0900, Paul Elder wrote:\n> Add the skeletal CTK module to the rkisp1 tuning script. For now it just\n> spits out hardcoded values.\n\nSounds a bit harsh to me, but I'm not a native speaker. So I'm the wrong\none to judge here :-)\n\nOtherwise looks good to me.\n\nReviewed-by: Stefan Klug \n\nCheers,\nStefan\n\n> \n> Signed-off-by: Paul Elder \n> ---\n> utils/tuning/rkisp1.py | 4 +++-\n> 1 file changed, 3 insertions(+), 1 deletion(-)\n> \n> diff --git a/utils/tuning/rkisp1.py b/utils/tuning/rkisp1.py\n> index d42646de..e08ddf02 100755\n> --- a/utils/tuning/rkisp1.py\n> +++ b/utils/tuning/rkisp1.py\n> @@ -12,6 +12,7 @@ from libtuning.parsers import YamlParser\n> from libtuning.generators import YamlOutput\n> from libtuning.modules.lsc import LSCRkISP1\n> from libtuning.modules.agc import AGCRkISP1\n> +from libtuning.modules.ccm import CTKRkISP1\n> \n> tuner = lt.Tuner('RkISP1')\n> tuner.add(LSCRkISP1(\n> @@ -34,9 +35,10 @@ tuner.add(LSCRkISP1(\n> smoothing_function=lt.smoothing.MedianBlur(3),\n> ))\n> tuner.add(AGCRkISP1(debug=[lt.Debug.Plot], hw_rev='V10'))\n> +tuner.add(CTKRkISP1(debug=[lt.Debug.Plot]))\n> tuner.set_input_parser(YamlParser())\n> tuner.set_output_formatter(YamlOutput())\n> -tuner.set_output_order([AGCRkISP1, LSCRkISP1])\n> +tuner.set_output_order([AGCRkISP1, LSCRkISP1, CTKRkISP1])\n> \n> if __name__ == '__main__':\n> sys.exit(tuner.run(sys.argv))\n> -- \n> 2.39.2\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id C5A74BE08B\n\tfor ;\n\tFri, 12 Apr 2024 08:12:39 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EDCCB63352;\n\tFri, 12 Apr 2024 10:12:38 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id E9F896333B\n\tfor ;\n\tFri, 12 Apr 2024 10:12:36 +0200 (CEST)","from ideasonboard.com\n\t(p200300e0774af4635726ec48835ba9d7.dip0.t-ipconnect.de\n\t[IPv6:2003:e0:774a:f463:5726:ec48:835b:a9d7])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 55CF5A12;\n\tFri, 12 Apr 2024 10:11:53 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"Tcdy/Ltl\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1712909513;\n\tbh=q1UxLqEOV9wEcTNV3g+UK0V2BCABhZejOifbXlRXQ+M=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=Tcdy/LtlbdyX9yIMfNTz34ofbGllF3hQmWUUr6PC9i+PiVooU1OCAdp6OntvVThsp\n\tWhQH7J7biQPZGnPHZ73NZVx0yHyAyEjujjiW9WD6wkTDHdMhL1aOHJuRzkAjaJecyV\n\tTKYzhP3UXoI5UjOs9owphcledLVGLguVrEtoRzLQ=","Date":"Fri, 12 Apr 2024 10:12:33 +0200","From":"Stefan Klug ","To":"Paul Elder ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 4/5] utils: tuning: rkisp1: Add skeletal CTK to the\n\trkisp1 tuning script","Message-ID":"<20240412081233.afqmufcrem35lpcf@macbook-air.speedport.ip>","References":"<20240405145335.3010479-1-paul.elder@ideasonboard.com>\n\t<20240405145335.3010479-5-paul.elder@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240405145335.3010479-5-paul.elder@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]