[{"id":29151,"web_url":"https://patchwork.libcamera.org/comment/29151/","msgid":"<863b23b4-e3a5-4293-a6b3-128d78294e18@ideasonboard.com>","date":"2024-04-04T10:31:33","subject":"Re: [PATCH] android: camera_device: Always clear descriptors_ in\n\tstop()","submitter":{"id":86,"url":"https://patchwork.libcamera.org/api/people/86/","name":"Umang Jain","email":"umang.jain@ideasonboard.com"},"content":"Hi Jacopo,\n\nThanks for the patch and testing\n\nOn 04/04/24 3:48 pm, Jacopo Mondi wrote:\n> From: Anle Pan \n>\n> When flush() is called and then a new stream configuration is set, the\n> descriptors_ queue might have a chance to be not cleared in stop(), as\n> the Camera is already in Stopped state.\n>\n> This will prevent further requests from being completed in\n> sendCaptureResults() as the descriptors_ queue is not empty.\n>\n> To fix the issue, clear the descriptors_ even if the Camera State is\n> Stopped. As a drawback the libcamera::Camera::stop() function might be\n> called twice, but this is allowed by the Camera state machine, and the\n> second call is guaranteed to be a nop.\n>\n> Signed-off-by: Anle Pan \n> Signed-off-by: Fang Hui \n> Tested-by: Jacopo Mondi \n> Reviewed-by: Jacopo Mondi \n> ---\n>\n> CTS shows no regressions compared to v0.2.0\n\nI like this!\n\nReviewed-by: Umang Jain \n\n>\n> ---\n> src/android/camera_device.cpp | 2 --\n> 1 file changed, 2 deletions(-)\n>\n> diff --git a/src/android/camera_device.cpp b/src/android/camera_device.cpp\n> index d2679a9722e2..1b6f3f3a2b29 100644\n> --- a/src/android/camera_device.cpp\n> +++ b/src/android/camera_device.cpp\n> @@ -433,8 +433,6 @@ void CameraDevice::flush()\n> void CameraDevice::stop()\n> {\n> \tMutexLocker stateLock(stateMutex_);\n> -\tif (state_ == State::Stopped)\n> -\t\treturn;\n>\n> \tcamera_->stop();\n>\n> --\n> 2.44.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id CE3F9C0DA4\n\tfor ;\n\tThu, 4 Apr 2024 10:31:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 060686337D;\n\tThu, 4 Apr 2024 12:31:44 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 815C863339\n\tfor ;\n\tThu, 4 Apr 2024 12:31:41 +0200 (CEST)","from [192.168.1.105] (unknown [103.86.18.232])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id DBFC4497;\n\tThu, 4 Apr 2024 12:31:02 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"C2dxTIW9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1712226663;\n\tbh=njZSURZ5qHerpXN1JL1mRMr1mwyoaYKjr9ACLHZ9/QI=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=C2dxTIW9cWnO9x7ipEk7/J+fC4h/mMZYEEKRKaNCOLcobxvNrfjFVsoWPUFusxXyg\n\t7wqSw+YPqi7K3QdTzxPsZA6rL9EojjcgqkQn/8YFdjB+NcGuo+XxiHYDLJBdHucsIn\n\tFXmw5aA9HjBHOAaDbjrkcQEo3FBf4SKtiRpQ1KVk=","Message-ID":"<863b23b4-e3a5-4293-a6b3-128d78294e18@ideasonboard.com>","Date":"Thu, 4 Apr 2024 16:01:33 +0530","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH] android: camera_device: Always clear descriptors_ in\n\tstop()","Content-Language":"en-US","To":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Cc":"Anle Pan ","References":"<20240404101818.21484-1-jacopo.mondi@ideasonboard.com>","From":"Umang Jain ","In-Reply-To":"<20240404101818.21484-1-jacopo.mondi@ideasonboard.com>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]