{"id":19826,"url":"https://patchwork.libcamera.org/api/patches/19826/?format=json","web_url":"https://patchwork.libcamera.org/patch/19826/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240404084657.353464-6-mzamazal@redhat.com>","date":"2024-04-04T08:46:42","name":"[v7,05/18] libcamera: shared_mem_object: Rename SIZE constant to `size'","commit_ref":null,"pull_url":null,"state":"superseded","archived":false,"hash":"ef26fe1582fff4ad9606df372a489422cfcf78d3","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/?format=json","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19826/mbox/","series":[{"id":4246,"url":"https://patchwork.libcamera.org/api/series/4246/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4246","date":"2024-04-04T08:46:37","name":"libcamera: introduce Software ISP and Software IPA","version":7,"mbox":"https://patchwork.libcamera.org/series/4246/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19826/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19826/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 68D14C0DA4\n\tfor ;\n\tThu, 4 Apr 2024 08:47:44 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id F168B6337B;\n\tThu, 4 Apr 2024 10:47:43 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.129.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9016C63373\n\tfor ;\n\tThu, 4 Apr 2024 10:47:40 +0200 (CEST)","from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com\n\t[66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-683-CVJmlfMnPK63hsZmLYDSUA-1; Thu, 04 Apr 2024 04:47:34 -0400","from smtp.corp.redhat.com\n\t(int-mx05.intmail.prod.int.rdu2.redhat.com [10.11.54.5])\n\t(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)\n\tkey-exchange X25519 server-signature RSA-PSS (2048 bits)\n\tserver-digest SHA256) (No client certificate requested)\n\tby mimecast-mx02.redhat.com (Postfix) with ESMTPS id AD3F585CDF5;\n\tThu, 4 Apr 2024 08:47:33 +0000 (UTC)","from nuthatch.brq.redhat.com (unknown [10.43.17.39])\n\tby smtp.corp.redhat.com (Postfix) with ESMTP id 726858173;\n\tThu, 4 Apr 2024 08:47:32 +0000 (UTC)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Y3N5ALqi\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1712220459;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=Q/fnpole15IRJHX0kIbNArAeCIl1FNycylWyXAbXVOc=;\n\tb=Y3N5ALqiYcOzKU5UhYGiMtm5p+lksAQhkBkP1N0kCojeWO+HCHeFDzluEBKkocyTTqBpY9\n\tkHpe8Ch8/mplVITtpRtnwqihukaX5O4X1vXX7liXsMAUSTJSv9IOjccGJBHlVfdY7sffOB\n\t4iiOzKe1lXqR92gbJzwUtx7dR3gY2Og=","X-MC-Unique":"CVJmlfMnPK63hsZmLYDSUA-1","From":"Milan Zamazal ","To":"libcamera-devel@lists.libcamera.org","Cc":"Milan Zamazal ,\n\tAndrei Konovalov ,\n\tBryan O'Donoghue ,\n\tMaxime Ripard , Pavel Machek ,\n\tHans de Goede ,\n\tKieran Bingham ,\n\tLaurent Pinchart ","Subject":"[PATCH v7 05/18] libcamera: shared_mem_object: Rename SIZE constant\n\tto `size'","Date":"Thu, 4 Apr 2024 10:46:42 +0200","Message-ID":"<20240404084657.353464-6-mzamazal@redhat.com>","In-Reply-To":"<20240404084657.353464-1-mzamazal@redhat.com>","References":"<20240404084657.353464-1-mzamazal@redhat.com>","MIME-Version":"1.0","X-Scanned-By":"MIMEDefang 3.4.1 on 10.11.54.5","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Transfer-Encoding":"8bit","Content-Type":"text/plain; charset=\"US-ASCII\"; x-default=true","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Signed-off-by: Milan Zamazal \n---\n include/libcamera/internal/shared_mem_object.h | 8 ++++----\n 1 file changed, 4 insertions(+), 4 deletions(-)","diff":"diff --git a/include/libcamera/internal/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\nindex 98636b44..8f2e7120 100644\n--- a/include/libcamera/internal/shared_mem_object.h\n+++ b/include/libcamera/internal/shared_mem_object.h\n@@ -23,7 +23,7 @@ template\n class SharedMemObject\n {\n public:\n-\tstatic constexpr std::size_t SIZE = sizeof(T);\n+\tstatic constexpr std::size_t size = sizeof(T);\n \n \tSharedMemObject()\n \t\t: obj_(nullptr)\n@@ -45,11 +45,11 @@ public:\n \t\tif (!fd_.isValid())\n \t\t\treturn;\n \n-\t\tret = ftruncate(fd_.get(), SIZE);\n+\t\tret = ftruncate(fd_.get(), size);\n \t\tif (ret < 0)\n \t\t\treturn;\n \n-\t\tmem = mmap(nullptr, SIZE, PROT_READ | PROT_WRITE, MAP_SHARED,\n+\t\tmem = mmap(nullptr, size, PROT_READ | PROT_WRITE, MAP_SHARED,\n \t\t\t fd_.get(), 0);\n \t\tif (mem == MAP_FAILED)\n \t\t\treturn;\n@@ -69,7 +69,7 @@ public:\n \t{\n \t\tif (obj_) {\n \t\t\tobj_->~T();\n-\t\t\tmunmap(obj_, SIZE);\n+\t\t\tmunmap(obj_, size);\n \t\t}\n \t}\n \n","prefixes":["v7","05/18"]}