[{"id":29307,"web_url":"https://patchwork.libcamera.org/comment/29307/","msgid":"<171386273200.1272602.10614596593005488800@ping.linuxembedded.co.uk>","date":"2024-04-23T08:58:52","subject":"Re: [PATCH v3 1/2] libcamera: pipeline: Add a get factory by name\n\thelper","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Quoting Julien Vuillaumier (2024-03-27 17:27:30)\n> Add a static helper to the PipelineHandlerFactoryBase class to\n> allow retrieving a pipeline by name.\n> \n> Signed-off-by: Julien Vuillaumier \n> Reviewed-by: Jacopo Mondi \n\nReviewed-by: Kieran Bingham \n\n> ---\n> include/libcamera/internal/pipeline_handler.h | 1 +\n> src/libcamera/pipeline_handler.cpp | 22 +++++++++++++++++++\n> 2 files changed, 23 insertions(+)\n> \n> diff --git a/include/libcamera/internal/pipeline_handler.h b/include/libcamera/internal/pipeline_handler.h\n> index c96944f4..19361a40 100644\n> --- a/include/libcamera/internal/pipeline_handler.h\n> +++ b/include/libcamera/internal/pipeline_handler.h\n> @@ -114,6 +114,7 @@ public:\n> const std::string &name() const { return name_; }\n> \n> static std::vector &factories();\n> + static const PipelineHandlerFactoryBase *getFactoryByName(const std::string &name);\n> \n> private:\n> static void registerType(PipelineHandlerFactoryBase *factory);\n> diff --git a/src/libcamera/pipeline_handler.cpp b/src/libcamera/pipeline_handler.cpp\n> index 29e0c98a..c926f454 100644\n> --- a/src/libcamera/pipeline_handler.cpp\n> +++ b/src/libcamera/pipeline_handler.cpp\n> @@ -794,6 +794,28 @@ std::vector &PipelineHandlerFactoryBase::factories\n> return factories;\n> }\n> \n> +/**\n> + * \\brief Return the factory for the pipeline handler with name \\a name\n> + * \\param[in] name The pipeline handler name\n> + * \\return The factory of the pipeline with name \\a name, or nullptr if not found\n> + */\n> +const PipelineHandlerFactoryBase *PipelineHandlerFactoryBase::getFactoryByName(const std::string &name)\n> +{\n> + const std::vector &factories =\n> + PipelineHandlerFactoryBase::factories();\n> +\n> + auto iter = std::find_if(factories.begin(),\n> + factories.end(),\n> + [&name](const PipelineHandlerFactoryBase *f) {\n> + return f->name() == name;\n> + });\n> +\n> + if (iter != factories.end())\n> + return *iter;\n> +\n> + return nullptr;\n> +}\n> +\n> /**\n> * \\class PipelineHandlerFactory\n> * \\brief Registration of PipelineHandler classes and creation of instances\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 12FA6BE08B\n\tfor ;\n\tTue, 23 Apr 2024 08:58:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 0685563408;\n\tTue, 23 Apr 2024 10:58:57 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id C8C17633F5\n\tfor ;\n\tTue, 23 Apr 2024 10:58:54 +0200 (CEST)","from pendragon.ideasonboard.com\n\t(cpc89244-aztw30-2-0-cust6594.18-1.cable.virginm.net [86.31.185.195])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 7EE9B8CC;\n\tTue, 23 Apr 2024 10:58:03 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"P/6iuWk+\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1713862683;\n\tbh=sSeneqNFqsuyXIsSuXT0Z3g4HCuoD4wmFKhYz8yY+XE=;\n\th=In-Reply-To:References:Subject:From:Cc:To:Date:From;\n\tb=P/6iuWk+tOy+oleGmYKSyBLYTyLgE1YNGRwA48jDICxeW/LTdfOujad058sY1TD9i\n\tnQvPCGTDhDEKWOyPCgtF6q6n4YtDr9Is4f/Zy8lmpNhx+zzDkNmzuWdlBZbivfl5xb\n\tU/uiDE6uuXM8LdSOBQRvc7m+M+FBuqXZFEDR6i2Y=","Content-Type":"text/plain; charset=\"utf-8\"","MIME-Version":"1.0","Content-Transfer-Encoding":"quoted-printable","In-Reply-To":"<20240327172731.434048-2-julien.vuillaumier@nxp.com>","References":"<20240327172731.434048-1-julien.vuillaumier@nxp.com>\n\t<20240327172731.434048-2-julien.vuillaumier@nxp.com>","Subject":"Re: [PATCH v3 1/2] libcamera: pipeline: Add a get factory by name\n\thelper","From":"Kieran Bingham ","Cc":"julien.vuillaumier@nxp.com, Jacopo Mondi ","To":"Julien Vuillaumier ,\n\tlibcamera-devel@lists.libcamera.org","Date":"Tue, 23 Apr 2024 09:58:52 +0100","Message-ID":"<171386273200.1272602.10614596593005488800@ping.linuxembedded.co.uk>","User-Agent":"alot/0.10","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]