{"id":19816,"url":"https://patchwork.libcamera.org/api/patches/19816/?format=json","web_url":"https://patchwork.libcamera.org/patch/19816/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240327132015.22095-1-laurent.pinchart@ideasonboard.com>","date":"2024-03-27T13:20:15","name":"v4l2: meson: Keep defines sorted alphabetically","commit_ref":"48f3a25d7c5f6f4b2eef590c79d8eeaef32014d2","pull_url":null,"state":"accepted","archived":false,"hash":"d07fc5ce7602771f74ed4c21d514282d6f1ba600","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/?format=json","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19816/mbox/","series":[{"id":4244,"url":"https://patchwork.libcamera.org/api/series/4244/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4244","date":"2024-03-27T13:20:15","name":"v4l2: meson: Keep defines sorted alphabetically","version":1,"mbox":"https://patchwork.libcamera.org/series/4244/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19816/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19816/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id D831CBD160\n\tfor ;\n\tWed, 27 Mar 2024 13:20:26 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E1ABF63331;\n\tWed, 27 Mar 2024 14:20:25 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D893C61C35\n\tfor ;\n\tWed, 27 Mar 2024 14:20:24 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 4D647675\n\tfor ;\n\tWed, 27 Mar 2024 14:19:52 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"mCryHbNq\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1711545592;\n\tbh=BHNRddqIw9xfNiP0O44GbIMt+0Zwf8n6wutR0QeNIcw=;\n\th=From:To:Subject:Date:From;\n\tb=mCryHbNqluJ6debAL7pE8T0LHJtecOE0cI4Vk7nGNp0forwZihK7jQJp4T0gsHmBy\n\tG1tI1vgT5qbM8kfLKJCdexL1LG0PdnYXIcCmLqo1FlJP84BwRhr5LJDdz+Ga16tCLq\n\tnHT5ZvBso/4UAe1lcUu4lfMkL80nhFoHUzsvhd/U=","From":"Laurent Pinchart ","To":"libcamera-devel@lists.libcamera.org","Subject":"[PATCH] v4l2: meson: Keep defines sorted alphabetically","Date":"Wed, 27 Mar 2024 15:20:15 +0200","Message-ID":"<20240327132015.22095-1-laurent.pinchart@ideasonboard.com>","X-Mailer":"git-send-email 2.43.2","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Due to my mistake, commit 705601781b6a (\"v4l2: Unset _TIME_BITS in\naddition to _FILE_OFFSET_BITS\") got merged with incorrect sorting of\ndefines. Fix it.\n\nSigned-off-by: Laurent Pinchart \n---\n src/v4l2/meson.build | 2 +-\n 1 file changed, 1 insertion(+), 1 deletion(-)\n\n\nbase-commit: 705601781b6ab4f3035719ddaf1e442f4a5e8737","diff":"diff --git a/src/v4l2/meson.build b/src/v4l2/meson.build\nindex 12d1e2a4c3c0..58f53bf3d0f4 100644\n--- a/src/v4l2/meson.build\n+++ b/src/v4l2/meson.build\n@@ -23,8 +23,8 @@ v4l2_compat_cpp_args = [\n # file operations, disable transparent large file support.\n '-U_FILE_OFFSET_BITS',\n '-D_FILE_OFFSET_BITS=32',\n- '-U_TIME_BITS',\n '-D_LARGEFILE64_SOURCE',\n+ '-U_TIME_BITS',\n '-fvisibility=hidden',\n ]\n \n","prefixes":[]}