[{"id":29050,"web_url":"https://patchwork.libcamera.org/comment/29050/","msgid":"<20240325101959.4hqinpjiqsddkmh7@jasper>","date":"2024-03-25T10:19:59","subject":"Re: [PATCH 01/10] ipa: libipa: Allow creation of empty Histogram","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"content":"Hi Dan,\n\nthank you for the patch.\n\nOn Fri, Mar 22, 2024 at 01:14:42PM +0000, Daniel Scally wrote:\n> For convenience's sake allow the creation of empty Histograms so\n> they can be embedded within other Classes and filled out with\n> data at some later point in time.\n> \n> Signed-off-by: Daniel Scally \n> ---\n> src/ipa/libipa/histogram.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\n> index 05bb4b80..db13c155 100644\n> --- a/src/ipa/libipa/histogram.h\n> +++ b/src/ipa/libipa/histogram.h\n> @@ -22,6 +22,7 @@ namespace ipa {\n> class Histogram\n> {\n> public:\n> +\tHistogram() { cumulative_.push_back(0); };\n\nThe second semicolon is not necessary (CI will check that).\n\nWith that fixed:\n\nReviewed-by: Stefan Klug \n\nCheers Stefan\n\n> \tHistogram(Span data);\n> \tsize_t bins() const { return cumulative_.size() - 1; }\n> \tuint64_t total() const { return cumulative_[cumulative_.size() - 1]; }\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 01245C0DA4\n\tfor ;\n\tMon, 25 Mar 2024 10:20:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 14B75632EA;\n\tMon, 25 Mar 2024 11:20:04 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 57BFB61C40\n\tfor ;\n\tMon, 25 Mar 2024 11:20:02 +0100 (CET)","from ideasonboard.com (unknown\n\t[IPv6:2a00:6020:448c:6c00:585a:15d7:7ede:ea8c])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5D7B17E4;\n\tMon, 25 Mar 2024 11:19:31 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"q29BHBCY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1711361971;\n\tbh=SpcvYhtsucNa+P3VNBJpsi3WDWDEqA2zhGPST0YBO9Y=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=q29BHBCYDxWAoyAXJOyI91ik+4rMhX8E2ekxqHumZoUQc4UBg8e9s3lFEngNDLkCO\n\tpbgJJtkHuS4BlbQomQ5IAITH3/hLlC2EEHzXtyvJOE8hlIWSZsgJbjsrBrrygNhi8o\n\tLoUAT53tQmA1CQFT6yfCLSf/ESqk7KsZA2Q5LbVo=","Date":"Mon, 25 Mar 2024 11:19:59 +0100","From":"Stefan Klug ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 01/10] ipa: libipa: Allow creation of empty Histogram","Message-ID":"<20240325101959.4hqinpjiqsddkmh7@jasper>","References":"<20240322131451.3092931-1-dan.scally@ideasonboard.com>\n\t<20240322131451.3092931-2-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240322131451.3092931-2-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29051,"web_url":"https://patchwork.libcamera.org/comment/29051/","msgid":"<2hya5aiw2eoqoikxa4vtwf2rk3urs6bzmwumplchpubc7byusc@7t2gwhesoqrs>","date":"2024-03-25T15:45:08","subject":"Re: [PATCH 01/10] ipa: libipa: Allow creation of empty Histogram","submitter":{"id":143,"url":"https://patchwork.libcamera.org/api/people/143/","name":"Jacopo Mondi","email":"jacopo.mondi@ideasonboard.com"},"content":"Hi Dan\n\nOn Fri, Mar 22, 2024 at 01:14:42PM +0000, Daniel Scally wrote:\n> For convenience's sake allow the creation of empty Histograms so\n> they can be embedded within other Classes and filled out with\n> data at some later point in time.\n>\n\nHow are you going to add data to the Histogram since they seem to be\nexpected to be passed in at construction time ?\n\n> Signed-off-by: Daniel Scally \n> ---\n> src/ipa/libipa/histogram.h | 1 +\n> 1 file changed, 1 insertion(+)\n>\n> diff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\n> index 05bb4b80..db13c155 100644\n> --- a/src/ipa/libipa/histogram.h\n> +++ b/src/ipa/libipa/histogram.h\n> @@ -22,6 +22,7 @@ namespace ipa {\n> class Histogram\n> {\n> public:\n> +\tHistogram() { cumulative_.push_back(0); };\n> \tHistogram(Span data);\n> \tsize_t bins() const { return cumulative_.size() - 1; }\n> \tuint64_t total() const { return cumulative_[cumulative_.size() - 1]; }\n> --\n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1633FBD160\n\tfor ;\n\tMon, 25 Mar 2024 15:45:16 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 03249632EA;\n\tMon, 25 Mar 2024 16:45:15 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id D7E8963036\n\tfor ;\n\tMon, 25 Mar 2024 16:45:12 +0100 (CET)","from ideasonboard.com (93-61-96-190.ip145.fastwebnet.it\n\t[93.61.96.190])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 9FD5D7E4;\n\tMon, 25 Mar 2024 16:44:41 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"cLAf+FxA\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1711381481;\n\tbh=gcLLrP9N1I4fF+wwsCgSvXZDLiDPMw+oK7w6+T444XA=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=cLAf+FxASUdTiKt1biHajLgSNQTnjFJrrHgngPZ3WUdy3oRYT5vKGEBRLY0puQdML\n\teOPkhko43ukjfFWguC5SPweXQMiMX0kZo5e7F1mZrMYoujxm0eKHw4UWT1889qkveQ\n\tbzVkpqRnND8ZQUr3g0Nk1elVsjW2a4z/I3R02y1w=","Date":"Mon, 25 Mar 2024 16:45:08 +0100","From":"Jacopo Mondi ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 01/10] ipa: libipa: Allow creation of empty Histogram","Message-ID":"<2hya5aiw2eoqoikxa4vtwf2rk3urs6bzmwumplchpubc7byusc@7t2gwhesoqrs>","References":"<20240322131451.3092931-1-dan.scally@ideasonboard.com>\n\t<20240322131451.3092931-2-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240322131451.3092931-2-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29055,"web_url":"https://patchwork.libcamera.org/comment/29055/","msgid":"<46f3ec85-c77e-44b5-9941-7ba1f9e20285@ideasonboard.com>","date":"2024-03-25T18:42:32","subject":"Re: [PATCH 01/10] ipa: libipa: Allow creation of empty Histogram","submitter":{"id":156,"url":"https://patchwork.libcamera.org/api/people/156/","name":"Dan Scally","email":"dan.scally@ideasonboard.com"},"content":"Hi Jacopo\n\nOn 25/03/2024 15:45, Jacopo Mondi wrote:\n> Hi Dan\n>\n> On Fri, Mar 22, 2024 at 01:14:42PM +0000, Daniel Scally wrote:\n>> For convenience's sake allow the creation of empty Histograms so\n>> they can be embedded within other Classes and filled out with\n>> data at some later point in time.\n>>\n> How are you going to add data to the Histogram since they seem to be\n> expected to be passed in at construction time ?\n\n\nSee for example patch #8, with:\n\n\n+ hist_ = Histogram(Span(params->hist.hist_bins, + context.hw->numHistogramBins));\n\n>\n>> Signed-off-by: Daniel Scally \n>> ---\n>> src/ipa/libipa/histogram.h | 1 +\n>> 1 file changed, 1 insertion(+)\n>>\n>> diff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\n>> index 05bb4b80..db13c155 100644\n>> --- a/src/ipa/libipa/histogram.h\n>> +++ b/src/ipa/libipa/histogram.h\n>> @@ -22,6 +22,7 @@ namespace ipa {\n>> class Histogram\n>> {\n>> public:\n>> +\tHistogram() { cumulative_.push_back(0); };\n>> \tHistogram(Span data);\n>> \tsize_t bins() const { return cumulative_.size() - 1; }\n>> \tuint64_t total() const { return cumulative_[cumulative_.size() - 1]; }\n>> --\n>> 2.34.1\n>>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id A8383C0DA4\n\tfor ;\n\tMon, 25 Mar 2024 18:42:37 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C5A2C63036;\n\tMon, 25 Mar 2024 19:42:36 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 74EEF63036\n\tfor ;\n\tMon, 25 Mar 2024 19:42:35 +0100 (CET)","from [192.168.0.43]\n\t(cpc141996-chfd3-2-0-cust928.12-3.cable.virginm.net [86.13.91.161])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 391537E4;\n\tMon, 25 Mar 2024 19:42:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"BgTr7jaw\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1711392124;\n\tbh=PIx+X6FujZwXKs9EGxgu8S9oyVsUonaKEZKLd/Dt6MY=;\n\th=Date:Subject:To:Cc:References:From:In-Reply-To:From;\n\tb=BgTr7jawTH8vZgQ2EuT/IsiAanAXMAWv/NON3AsTR/prpJRtUbLbogYrPoffZ06uQ\n\tATffQK6RikBdxy2amXgoyYSwfe8AlHxOm6qgjTjoN2f2IWllwSpmEIGtPrBSmDfHyY\n\ttYyuOXzy96Nt0Shn+I3m8vq5X35zb7ARSxKR5Oco=","Message-ID":"<46f3ec85-c77e-44b5-9941-7ba1f9e20285@ideasonboard.com>","Date":"Mon, 25 Mar 2024 18:42:32 +0000","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH 01/10] ipa: libipa: Allow creation of empty Histogram","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20240322131451.3092931-1-dan.scally@ideasonboard.com>\n\t<20240322131451.3092931-2-dan.scally@ideasonboard.com>\n\t<2hya5aiw2eoqoikxa4vtwf2rk3urs6bzmwumplchpubc7byusc@7t2gwhesoqrs>","Content-Language":"en-US","From":"Dan Scally ","Autocrypt":"addr=dan.scally@ideasonboard.com; keydata=\n\txsFNBGLydlEBEADa5O2s0AbUguprfvXOQun/0a8y2Vk6BqkQALgeD6KnXSWwaoCULp18etYW\n\tB31bfgrdphXQ5kUQibB0ADK8DERB4wrzrUb5CMxLBFE7mQty+v5NsP0OFNK9XTaAOcmD+Ove\n\teIjYvqurAaro91jrRVrS1gBRxIFqyPgNvwwL+alMZhn3/2jU2uvBmuRrgnc/e9cHKiuT3Dtq\n\tMHGPKL2m+plk+7tjMoQFfexoQ1JKugHAjxAhJfrkXh6uS6rc01bYCyo7ybzg53m1HLFJdNGX\n\tsUKR+dQpBs3SY4s66tc1sREJqdYyTsSZf80HjIeJjU/hRunRo4NjRIJwhvnK1GyjOvvuCKVU\n\tRWpY8dNjNu5OeAfdrlvFJOxIE9M8JuYCQTMULqd1NuzbpFMjc9524U3Cngs589T7qUMPb1H1\n\tNTA81LmtJ6Y+IV5/kiTUANflpzBwhu18Ok7kGyCq2a2jsOcVmk8gZNs04gyjuj8JziYwwLbf\n\tvzABwpFVcS8aR+nHIZV1HtOzyw8CsL8OySc3K9y+Y0NRpziMRvutrppzgyMb9V+N31mK9Mxl\n\t1YkgaTl4ciNWpdfUe0yxH03OCuHi3922qhPLF4XX5LN+NaVw5Xz2o3eeWklXdouxwV7QlN33\n\tu4+u2FWzKxDqO6WLQGjxPE0mVB4Gh5Pa1Vb0ct9Ctg0qElvtGQARAQABzShEYW4gU2NhbGx5\n\tIDxkYW4uc2NhbGx5QGlkZWFzb25ib2FyZC5jb20+wsGNBBMBCAA3FiEEsdtt8OWP7+8SNfQe\n\tkiQuh/L+GMQFAmLydlIFCQWjmoACGwMECwkIBwUVCAkKCwUWAgMBAAAKCRCSJC6H8v4YxDI2\n\tEAC2Gz0iyaXJkPInyshrREEWbo0CA6v5KKf3I/HlMPqkZ48bmGoYm4mEQGFWZJAT3K4ir8bg\n\tcEfs9V54gpbrZvdwS4abXbUK4WjKwEs8HK3XJv1WXUN2bsz5oEJWZUImh9gD3naiLLI9QMMm\n\tw/aZkT+NbN5/2KvChRWhdcha7+2Te4foOY66nIM+pw2FZM6zIkInLLUik2zXOhaZtqdeJZQi\n\tHSPU9xu7TRYN4cvdZAnSpG7gQqmLm5/uGZN1/sB3kHTustQtSXKMaIcD/DMNI3JN/t+RJVS7\n\tc0Jh/ThzTmhHyhxx3DRnDIy7kwMI4CFvmhkVC2uNs9kWsj1DuX5kt8513mvfw2OcX9UnNKmZ\n\tnhNCuF6DxVrL8wjOPuIpiEj3V+K7DFF1Cxw1/yrLs8dYdYh8T8vCY2CHBMsqpESROnTazboh\n\tAiQ2xMN1cyXtX11Qwqm5U3sykpLbx2BcmUUUEAKNsM//Zn81QXKG8vOx0ZdMfnzsCaCzt8f6\n\t9dcDBBI3tJ0BI9ByiocqUoL6759LM8qm18x3FYlxvuOs4wSGPfRVaA4yh0pgI+ModVC2Pu3y\n\tejE/IxeatGqJHh6Y+iJzskdi27uFkRixl7YJZvPJAbEn7kzSi98u/5ReEA8Qhc8KO/B7wprj\n\txjNMZNYd0Eth8+WkixHYj752NT5qshKJXcyUU87BTQRi8nZSARAAx0BJayh1Fhwbf4zoY56x\n\txHEpT6DwdTAYAetd3yiKClLVJadYxOpuqyWa1bdfQWPb+h4MeXbWw/53PBgn7gI2EA7ebIRC\n\tPJJhAIkeym7hHZoxqDQTGDJjxFEL11qF+U3rhWiL2Zt0Pl+zFq0eWYYVNiXjsIS4FI2+4m16\n\ttPbDWZFJnSZ828VGtRDQdhXfx3zyVX21lVx1bX4/OZvIET7sVUufkE4hrbqrrufre7wsjD1t\n\t8MQKSapVrr1RltpzPpScdoxknOSBRwOvpp57pJJe5A0L7+WxJ+vQoQXj0j+5tmIWOAV1qBQp\n\thyoyUk9JpPfntk2EKnZHWaApFp5TcL6c5LhUvV7F6XwOjGPuGlZQCWXee9dr7zym8iR3irWT\n\t+49bIh5PMlqSLXJDYbuyFQHFxoiNdVvvf7etvGfqFYVMPVjipqfEQ38ST2nkzx+KBICz7uwj\n\tJwLBdTXzGFKHQNckGMl7F5QdO/35An/QcxBnHVMXqaSd12tkJmoRVWduwuuoFfkTY5mUV3uX\n\txGj3iVCK4V+ezOYA7c2YolfRCNMTza6vcK/P4tDjjsyBBZrCCzhBvd4VVsnnlZhVaIxoky4K\n\taL+AP+zcQrUZmXmgZjXOLryGnsaeoVrIFyrU6ly90s1y3KLoPsDaTBMtnOdwxPmo1xisH8oL\n\ta/VRgpFBfojLPxMAEQEAAcLBfAQYAQgAJhYhBLHbbfDlj+/vEjX0HpIkLofy/hjEBQJi8nZT\n\tBQkFo5qAAhsMAAoJEJIkLofy/hjEXPcQAMIPNqiWiz/HKu9W4QIf1OMUpKn3YkVIj3p3gvfM\n\tRes4fGX94Ji599uLNrPoxKyaytC4R6BTxVriTJjWK8mbo9jZIRM4vkwkZZ2bu98EweSucxbp\n\tvjESsvMXGgxniqV/RQ/3T7LABYRoIUutARYq58p5HwSP0frF0fdFHYdTa2g7MYZl1ur2JzOC\n\tFHRpGadlNzKDE3fEdoMobxHB3Lm6FDml5GyBAA8+dQYVI0oDwJ3gpZPZ0J5Vx9RbqXe8RDuR\n\tdu90hvCJkq7/tzSQ0GeD3BwXb9/R/A4dVXhaDd91Q1qQXidI+2jwhx8iqiYxbT+DoAUkQRQy\n\txBtoCM1CxH7u45URUgD//fxYr3D4B1SlonA6vdaEdHZOGwECnDpTxecENMbz/Bx7qfrmd901\n\tD+N9SjIwrbVhhSyUXYnSUb8F+9g2RDY42Sk7GcYxIeON4VzKqWM7hpkXZ47pkK0YodO+dRKM\n\tyMcoUWrTK0Uz6UzUGKoJVbxmSW/EJLEGoI5p3NWxWtScEVv8mO49gqQdrRIOheZycDmHnItt\n\t9Qjv00uFhEwv2YfiyGk6iGF2W40s2pH2t6oeuGgmiZ7g6d0MEK8Ql/4zPItvr1c1rpwpXUC1\n\tu1kQWgtnNjFHX3KiYdqjcZeRBiry1X0zY+4Y24wUU0KsEewJwjhmCKAsju1RpdlPg2kC","In-Reply-To":"<2hya5aiw2eoqoikxa4vtwf2rk3urs6bzmwumplchpubc7byusc@7t2gwhesoqrs>","Content-Type":"text/plain; charset=UTF-8; format=flowed","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29162,"web_url":"https://patchwork.libcamera.org/comment/29162/","msgid":"<20240405213003.GH12507@pendragon.ideasonboard.com>","date":"2024-04-05T21:30:03","subject":"Re: [PATCH 01/10] ipa: libipa: Allow creation of empty Histogram","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Dan,\n\nThank you for the patch.\n\nOn Mon, Mar 25, 2024 at 06:42:32PM +0000, Daniel Scally wrote:\n> On 25/03/2024 15:45, Jacopo Mondi wrote:\n> > On Fri, Mar 22, 2024 at 01:14:42PM +0000, Daniel Scally wrote:\n> >> For convenience's sake allow the creation of empty Histograms so\n> >> they can be embedded within other Classes and filled out with\n> >> data at some later point in time.\n> >>\n> > How are you going to add data to the Histogram since they seem to be\n> > expected to be passed in at construction time ?\n> \n> See for example patch #8, with:\n> \n> + hist_ = Histogram(Span(params->hist.hist_bins, + context.hw->numHistogramBins));\n> \n> >> Signed-off-by: Daniel Scally \n> >> ---\n> >> src/ipa/libipa/histogram.h | 1 +\n> >> 1 file changed, 1 insertion(+)\n> >>\n> >> diff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\n> >> index 05bb4b80..db13c155 100644\n> >> --- a/src/ipa/libipa/histogram.h\n> >> +++ b/src/ipa/libipa/histogram.h\n> >> @@ -22,6 +22,7 @@ namespace ipa {\n> >> class Histogram\n> >> {\n> >> public:\n> >> +\tHistogram() { cumulative_.push_back(0); };\n\nApart from the missing documentation, this looks OK.\n\n> >> \tHistogram(Span data);\n> >> \tsize_t bins() const { return cumulative_.size() - 1; }\n> >> \tuint64_t total() const { return cumulative_[cumulative_.size() - 1]; }","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 638D4C0DA4\n\tfor ;\n\tFri, 5 Apr 2024 21:30:17 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 9B53C61C2F;\n\tFri, 5 Apr 2024 23:30:16 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DC86861C29\n\tfor ;\n\tFri, 5 Apr 2024 23:30:14 +0200 (CEST)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id A9E78ACB;\n\tFri, 5 Apr 2024 23:29:35 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"azur+5s9\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1712352575;\n\tbh=paiulHQpvIuSe+Qm1CrHUSgea6xZfFvisET1DgzkCWw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=azur+5s9gUHZJ/5H/XLwdPdNqNkiOul2kEvtY4psyqadYcBW7XiJkqD+WNZ4ZHdRp\n\tmqi0z9p+HAJokohMd+8J56iFmKDC9fGPEz8lMNUW0QuV1rCDuyM3V7A3uPX2QPHt3a\n\t6uoNzZSS3w/0Fc9D177JC8o4laRXGEyOpaS5W0FM=","Date":"Sat, 6 Apr 2024 00:30:03 +0300","From":"Laurent Pinchart ","To":"Dan Scally ","Cc":"Jacopo Mondi ,\n\tlibcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 01/10] ipa: libipa: Allow creation of empty Histogram","Message-ID":"<20240405213003.GH12507@pendragon.ideasonboard.com>","References":"<20240322131451.3092931-1-dan.scally@ideasonboard.com>\n\t<20240322131451.3092931-2-dan.scally@ideasonboard.com>\n\t<2hya5aiw2eoqoikxa4vtwf2rk3urs6bzmwumplchpubc7byusc@7t2gwhesoqrs>\n\t<46f3ec85-c77e-44b5-9941-7ba1f9e20285@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<46f3ec85-c77e-44b5-9941-7ba1f9e20285@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29174,"web_url":"https://patchwork.libcamera.org/comment/29174/","msgid":"","date":"2024-04-08T07:04:03","subject":"Re: [PATCH 01/10] ipa: libipa: Allow creation of empty Histogram","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"Hi Dan,\n\nOn Fri, Mar 22, 2024 at 01:14:42PM +0000, Daniel Scally wrote:\n> For convenience's sake allow the creation of empty Histograms so\n> they can be embedded within other Classes and filled out with\n> data at some later point in time.\n> \n> Signed-off-by: Daniel Scally \n\nReviewed-by: Paul Elder \n\n> ---\n> src/ipa/libipa/histogram.h | 1 +\n> 1 file changed, 1 insertion(+)\n> \n> diff --git a/src/ipa/libipa/histogram.h b/src/ipa/libipa/histogram.h\n> index 05bb4b80..db13c155 100644\n> --- a/src/ipa/libipa/histogram.h\n> +++ b/src/ipa/libipa/histogram.h\n> @@ -22,6 +22,7 @@ namespace ipa {\n> class Histogram\n> {\n> public:\n> +\tHistogram() { cumulative_.push_back(0); };\n> \tHistogram(Span data);\n> \tsize_t bins() const { return cumulative_.size() - 1; }\n> \tuint64_t total() const { return cumulative_[cumulative_.size() - 1]; }\n> -- \n> 2.34.1\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 65C94BE08B\n\tfor ;\n\tMon, 8 Apr 2024 07:04:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 625D363352;\n\tMon, 8 Apr 2024 09:04:14 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id DBD4E63339\n\tfor ;\n\tMon, 8 Apr 2024 09:04:11 +0200 (CEST)","from pyrite.rasen.tech (h175-177-049-156.catv02.itscom.jp\n\t[175.177.49.156])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id ED740231;\n\tMon, 8 Apr 2024 09:03:29 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"wVO+F88S\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1712559811;\n\tbh=9xejXRCyHGSBtL5uFrT7QoNGfbtfCUMLlhwqJVZW7EM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=wVO+F88Shoasu1buCvYaiWClmvjLCoImqBt4PmQoSx0/KhGTnvu7e+ZtoZ0IMmD0D\n\tFU6c9+44fqG9rR2Qcb5RZBRCxS0jmx6MPCpE4PGw37fND0xhvPzM5jOqKs2ksxiPDl\n\tXwJ7tcH1OmFJA5G4m9Lfjmxy1388cjr1b/FSq6ig=","Date":"Mon, 8 Apr 2024 16:04:03 +0900","From":"Paul Elder ","To":"Daniel Scally ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 01/10] ipa: libipa: Allow creation of empty Histogram","Message-ID":"","References":"<20240322131451.3092931-1-dan.scally@ideasonboard.com>\n\t<20240322131451.3092931-2-dan.scally@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240322131451.3092931-2-dan.scally@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]