[{"id":34137,"web_url":"https://patchwork.libcamera.org/comment/34137/","msgid":"","date":"2025-05-07T14:57:43","subject":"Re: [PATCH 2/4] apps: lc-compliance: Test for mandatory controls","submitter":{"id":17,"url":"https://patchwork.libcamera.org/api/people/17/","name":"Paul Elder","email":"paul.elder@ideasonboard.com"},"content":"On Wed, Mar 20, 2024 at 11:16:49AM +0100, Jacopo Mondi wrote:\n> Test for mandatory controls and properties to be supported by\n> a Camera.\n> \n> Signed-off-by: Jacopo Mondi \n\nReviewed-by: Paul Elder \n\n> ---\n> src/apps/lc-compliance/meson.build | 1 +\n> .../lc-compliance/tests/controls_test.cpp | 98 +++++++++++++++++++\n> 2 files changed, 99 insertions(+)\n> create mode 100644 src/apps/lc-compliance/tests/controls_test.cpp\n> \n> diff --git a/src/apps/lc-compliance/meson.build b/src/apps/lc-compliance/meson.build\n> index b1f605f3392a..09f068628d53 100644\n> --- a/src/apps/lc-compliance/meson.build\n> +++ b/src/apps/lc-compliance/meson.build\n> @@ -16,6 +16,7 @@ lc_compliance_sources = files([\n> 'helpers/capture.cpp',\n> 'main.cpp',\n> 'tests/capture_test.cpp',\n> + 'tests/controls_test.cpp'\n> ])\n> \n> lc_compliance_includes = ([\n> diff --git a/src/apps/lc-compliance/tests/controls_test.cpp b/src/apps/lc-compliance/tests/controls_test.cpp\n> new file mode 100644\n> index 000000000000..ff594fbe672a\n> --- /dev/null\n> +++ b/src/apps/lc-compliance/tests/controls_test.cpp\n> @@ -0,0 +1,98 @@\n> +/* SPDX-License-Identifier: GPL-2.0-or-later */\n> +/*\n> + * Copyright (C) 2023, Ideas On Board Oy\n> + *\n> + * controls_test.cpp - Test controls and properties\n> + */\n> +\n> +#include \n> +#include \n> +\n> +#include \n> +#include \n> +#include \n> +\n> +#include \n> +\n> +#include \"environment.h\"\n> +\n> +using namespace libcamera;\n> +\n> +std::array controlMaps = {\n> +\t&controls::controls,\n> +\t&properties::properties,\n> +};\n> +\n> +class ControlTest : public testing::TestWithParam\n> +{\n> +public:\n> +\tstatic std::string nameParameters(const testing::TestParamInfo &info);\n> +\n> +protected:\n> +\tvoid SetUp() override;\n> +\tvoid TearDown() override;\n> +\n> +\tstd::shared_ptr camera_;\n> +};\n> +\n> +void ControlTest::SetUp()\n> +{\n> +\tEnvironment *env = Environment::get();\n> +\n> +\tcamera_ = env->cm()->get(env->cameraId());\n> +\n> +\tASSERT_EQ(camera_->acquire(), 0);\n> +}\n> +\n> +void ControlTest::TearDown()\n> +{\n> +\tif (!camera_)\n> +\t\treturn;\n> +\n> +\tcamera_->release();\n> +\tcamera_.reset();\n> +}\n> +\n> +std::string ControlTest::nameParameters(const testing::TestParamInfo &info)\n> +{\n> +\tconst ControlIdMap *idMap = info.param;\n> +\tif (idMap == &controls::controls)\n> +\t\treturn \"controls\";\n> +\telse if (idMap == &properties::properties)\n> +\t\treturn \"properties\";\n> +\n> +\treturn \"vendor\";\n> +}\n> +\n> +/* Test that mandatory controls and properties are supported by a camera. */\n> +TEST_P(ControlTest, RequiredControls)\n> +{\n> +\tauto controlMap = GetParam();\n> +\n> +\tfor (const auto &[id, ctrl] : *controlMap) {\n> +\t\tif (!ctrl->required())\n> +\t\t\tcontinue;\n> +\n> +\t\tif (controlMap == &controls::controls) {\n> +\t\t\tconst auto it = camera_->controls().find(ctrl);\n> +\n> +\t\t\tif (it == camera_->controls().end())\n> +\t\t\t\tFAIL() << \"Mandatory control \\\"\" << ctrl->name()\n> +\t\t\t\t << \"\\\" not supported\" << std::endl;\n> +\t\t} else if (controlMap == &properties::properties) {\n> +\t\t\tbool found = camera_->properties().contains(id);\n> +\n> +\t\t\tif (!found)\n> +\t\t\t\tFAIL() << \"Mandatory property \\\"\" << ctrl->name()\n> +\t\t\t\t << \"\\\" not supported\" << std::endl;\n> +\t\t}\n> +\t}\n> +}\n> +\n> +/*\n> + * Use a Value-Parametrized Test case so that vendors can easily test vendor\n> + * control lists by expanding 'controlMaps'.\n> + */\n> +INSTANTIATE_TEST_SUITE_P(ControlsTest, ControlTest,\n> +\t\t\t testing::ValuesIn(controlMaps),\n> +\t\t\t ControlTest::nameParameters);\n> -- \n> 2.44.0\n>","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 55E38C3200\n\tfor ;\n\tWed, 7 May 2025 14:57:50 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 65FA968B30;\n\tWed, 7 May 2025 16:57:49 +0200 (CEST)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 89EEF68AD8\n\tfor ;\n\tWed, 7 May 2025 16:57:47 +0200 (CEST)","from pyrite.rasen.tech (unknown\n\t[IPv6:2001:861:3a80:3300:4f2f:8c2c:b3ef:17d4])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 387316D5;\n\tWed, 7 May 2025 16:57:36 +0200 (CEST)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"RjdNHePI\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1746629856;\n\tbh=g6iEhLQYtKa6VblOsReWkb94uo5bi13PVTTcKI1/Loo=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=RjdNHePIIhnUeCj/exQtVznRgjLjPCKkU1rKLfdVsXzgYnItEALoQ6+kZkIrPA+Im\n\tuvoVIVVp39peuHLeCsjIPYHNW9YZe9EigbSIn7M6yKq2cYiEMLAevChF5y1/0xqciV\n\tIboXz+B+LisRzMqJIjxBJEtPzCNaXNTZ1Wn6jRnk=","Date":"Wed, 7 May 2025 16:57:43 +0200","From":"Paul Elder ","To":"Jacopo Mondi ","Cc":"libcamera-devel@lists.libcamera.org","Subject":"Re: [PATCH 2/4] apps: lc-compliance: Test for mandatory controls","Message-ID":"","References":"<20240320101652.12873-1-jacopo.mondi@ideasonboard.com>\n\t<20240320101652.12873-3-jacopo.mondi@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=us-ascii","Content-Disposition":"inline","In-Reply-To":"<20240320101652.12873-3-jacopo.mondi@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]