[{"id":29006,"web_url":"https://patchwork.libcamera.org/comment/29006/","msgid":"<20240319213553.GA8501@pendragon.ideasonboard.com>","date":"2024-03-19T21:35:53","subject":"Re: [PATCH 1/2] libcamera: libipa: camera_sensor: Add Sony IMX283\n\tsensor properties","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Kieran,\n\nThank you for the patch.\n\nOn Tue, Mar 19, 2024 at 03:11:20PM +0000, Kieran Bingham wrote:\n> Provide the IMX283 camera sensor properties and registration\n> with libipa for the gain code helpers.\n> \n> The test patterns exposed by the IMX283 do not map well to the current\n> set of test pattern controls supplied by libcamera. These are left\n> inentionally unimplemented.\n\nintentionally\n\nReviewed-by: Laurent Pinchart \n\n> Signed-off-by: Kieran Bingham \n> ---\n> src/ipa/libipa/camera_sensor_helper.cpp | 11 +++++++++++\n> src/libcamera/sensor/camera_sensor_properties.cpp | 4 ++++\n> 2 files changed, 15 insertions(+)\n> \n> diff --git a/src/ipa/libipa/camera_sensor_helper.cpp b/src/ipa/libipa/camera_sensor_helper.cpp\n> index ce29f423e712..f70d898fa94d 100644\n> --- a/src/ipa/libipa/camera_sensor_helper.cpp\n> +++ b/src/ipa/libipa/camera_sensor_helper.cpp\n> @@ -417,6 +417,17 @@ public:\n> };\n> REGISTER_CAMERA_SENSOR_HELPER(\"imx258\", CameraSensorHelperImx258)\n> \n> +class CameraSensorHelperImx283 : public CameraSensorHelper\n> +{\n> +public:\n> +\tCameraSensorHelperImx283()\n> +\t{\n> +\t\tgainType_ = AnalogueGainLinear;\n> +\t\tgainConstants_.linear = { 0, 2048, -1, 2048 };\n> +\t}\n> +};\n> +REGISTER_CAMERA_SENSOR_HELPER(\"imx283\", CameraSensorHelperImx283)\n> +\n> class CameraSensorHelperImx290 : public CameraSensorHelper\n> {\n> public:\n> diff --git a/src/libcamera/sensor/camera_sensor_properties.cpp b/src/libcamera/sensor/camera_sensor_properties.cpp\n> index 6e28b09e6655..4eabbbdae585 100644\n> --- a/src/libcamera/sensor/camera_sensor_properties.cpp\n> +++ b/src/libcamera/sensor/camera_sensor_properties.cpp\n> @@ -99,6 +99,10 @@ const CameraSensorProperties *CameraSensorProperties::get(const std::string &sen\n> \t\t\t\t{ controls::draft::TestPatternModePn9, 4 },\n> \t\t\t},\n> \t\t} },\n> +\t\t{ \"imx283\", {\n> +\t\t\t.unitCellSize = { 2400, 2400 },\n> +\t\t\t.testPatternModes = {},\n> +\t\t} },\n> \t\t{ \"imx290\", {\n> \t\t\t.unitCellSize = { 2900, 2900 },\n> \t\t\t.testPatternModes = {},","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 8E561BD160\n\tfor ;\n\tTue, 19 Mar 2024 21:35:58 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id C2DF262CA8;\n\tTue, 19 Mar 2024 22:35:57 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id AE421616EE\n\tfor ;\n\tTue, 19 Mar 2024 22:35:56 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 6DB047E9;\n\tTue, 19 Mar 2024 22:35:29 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"n4NCualh\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710884129;\n\tbh=QB1F3vJvvwSIJVTgz/Est6qvAg5ELLsl+92phzsf7kw=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=n4NCualhRIZ6cSYRl7c7Gdc5kV8EJvV4mhyWn5DYIhoM7Rfja6RNEvv6G3s+8hMMP\n\tY7weCBR+3HJr6fU7U6cPiXzq9b0ipRbzIsLkFoUq+qGTGZGtdum/lLodWYsAJdFwz0\n\tPULLwWN1rVqv6FkJLxDbPRgjw++446TgzYGKDm14=","Date":"Tue, 19 Mar 2024 23:35:53 +0200","From":"Laurent Pinchart ","To":"Kieran Bingham ","Cc":"libcamera devel ","Subject":"Re: [PATCH 1/2] libcamera: libipa: camera_sensor: Add Sony IMX283\n\tsensor properties","Message-ID":"<20240319213553.GA8501@pendragon.ideasonboard.com>","References":"<20240319151121.561588-1-kieran.bingham@ideasonboard.com>\n\t<20240319151121.561588-2-kieran.bingham@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240319151121.561588-2-kieran.bingham@ideasonboard.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]