[{"id":29084,"web_url":"https://patchwork.libcamera.org/comment/29084/","msgid":"<20240327140051.GE4721@pendragon.ideasonboard.com>","date":"2024-03-27T14:00:51","subject":"Re: [PATCH v6 07/18] libcamera: software_isp: Add Debayer base class","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan and Hans,\n\nThank you for the patch.\n\nOn Tue, Mar 19, 2024 at 01:35:54PM +0100, Milan Zamazal wrote:\n> From: Hans de Goede \n> \n> Add a base class for debayer implementations. This is intended to be\n> suitable for both GPU (or otherwise) accelerated debayer implementations\n> as well as CPU based debayering.\n> \n> Doxygen documentation by Dennis Bonke.\n> \n> Tested-by: Bryan O'Donoghue # sc8280xp Lenovo x13s\n> Tested-by: Pavel Machek \n> Reviewed-by: Pavel Machek \n> Reviewed-by: Milan Zamazal \n> Co-developed-by: Dennis Bonke \n> Signed-off-by: Dennis Bonke \n> Co-developed-by: Andrey Konovalov \n> Signed-off-by: Andrey Konovalov \n> Signed-off-by: Hans de Goede \n> ---\n> .../internal/software_isp/debayer_params.h | 48 ++++++++\n> .../internal/software_isp/meson.build | 1 +\n> src/libcamera/software_isp/debayer.cpp | 29 +++++\n> src/libcamera/software_isp/debayer.h | 104 ++++++++++++++++++\n> src/libcamera/software_isp/meson.build | 1 +\n> 5 files changed, 183 insertions(+)\n> create mode 100644 include/libcamera/internal/software_isp/debayer_params.h\n> create mode 100644 src/libcamera/software_isp/debayer.cpp\n> create mode 100644 src/libcamera/software_isp/debayer.h\n> \n> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\n> new file mode 100644\n> index 00000000..98965fa1\n> --- /dev/null\n> +++ b/include/libcamera/internal/software_isp/debayer_params.h\n> @@ -0,0 +1,48 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2023, Red Hat Inc.\n> + *\n> + * Authors:\n> + * Hans de Goede \n> + *\n> + * debayer_params.h - DebayerParams header\n> + */\n> +\n> +#pragma once\n> +\n> +namespace libcamera {\n> +\n> +/**\n> + * \\brief Struct to hold the debayer parameters.\n> + */\n\nDocumentation in .cpp files.\n\n> +struct DebayerParams {\n> +\t/**\n> +\t * \\brief const value for 1.0 gain\n> +\t */\n> +\tstatic constexpr unsigned int kGain10 = 256;\n\nForcing the caller to deal with the internal representation of gains\nisn't nice, especially given that it precludes implementing gains of\ndifferent precisions in different backend. Wouldn't it be better to pass\nthe values as floating point numbers, and convert them to the internal\nrepresentation in the implementation of process() before using them ?\n\n> +\n> +\t/**\n> +\t * \\brief Red Gain\n> +\t *\n> +\t * 128 = 0.5, 256 = 1.0, 512 = 2.0, etc.\n> +\t */\n> +\tunsigned int gainR;\n> +\t/**\n> +\t * \\brief Green Gain\n> +\t *\n> +\t * 128 = 0.5, 256 = 1.0, 512 = 2.0, etc.\n> +\t */\n> +\tunsigned int gainG;\n> +\t/**\n> +\t * \\brief Blue Gain\n> +\t *\n> +\t * 128 = 0.5, 256 = 1.0, 512 = 2.0, etc.\n> +\t */\n> +\tunsigned int gainB;\n> +\t/**\n> +\t * \\brief Gamma correction, 1.0 is no correction\n> +\t */\n> +\tfloat gamma;\n> +};\n> +\n> +} /* namespace libcamera */\n> diff --git a/include/libcamera/internal/software_isp/meson.build b/include/libcamera/internal/software_isp/meson.build\n> index 66c9c3fb..a620e16d 100644\n> --- a/include/libcamera/internal/software_isp/meson.build\n> +++ b/include/libcamera/internal/software_isp/meson.build\n> @@ -1,5 +1,6 @@\n> # SPDX-License-Identifier: CC0-1.0\n> \n> libcamera_internal_headers += files([\n> + 'debayer_params.h',\n> 'swisp_stats.h',\n> ])\n> diff --git a/src/libcamera/software_isp/debayer.cpp b/src/libcamera/software_isp/debayer.cpp\n> new file mode 100644\n> index 00000000..64f0b5a0\n> --- /dev/null\n> +++ b/src/libcamera/software_isp/debayer.cpp\n> @@ -0,0 +1,29 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2023, Linaro Ltd\n> + * Copyright (C) 2023, Red Hat Inc.\n> + *\n> + * Authors:\n> + * Hans de Goede \n> + *\n> + * debayer.cpp - debayer base class\n> + */\n> +\n> +#include \"debayer.h\"\n> +\n> +namespace libcamera {\n> +\n> +/**\n> + * \\class Debayer\n> + * \\brief Base debayering class\n> + *\n> + * Base class that provides functions for setting up the debayering process.\n> + */\n> +\n> +LOG_DEFINE_CATEGORY(Debayer)\n> +\n> +Debayer::~Debayer()\n> +{\n> +}\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/software_isp/debayer.h b/src/libcamera/software_isp/debayer.h\n> new file mode 100644\n> index 00000000..8880ff99\n> --- /dev/null\n> +++ b/src/libcamera/software_isp/debayer.h\n> @@ -0,0 +1,104 @@\n> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> +/*\n> + * Copyright (C) 2023, Linaro Ltd\n> + * Copyright (C) 2023, Red Hat Inc.\n> + *\n> + * Authors:\n> + * Hans de Goede \n> + *\n> + * debayer.h - debayering base class\n> + */\n> +\n> +#pragma once\n> +\n> +#include \n> +\n> +#include \n> +#include \n> +\n> +#include \n> +#include \n> +\n> +#include \"libcamera/internal/software_isp/debayer_params.h\"\n> +\n> +namespace libcamera {\n> +\n> +class FrameBuffer;\n> +\n> +LOG_DECLARE_CATEGORY(Debayer)\n> +\n> +class Debayer\n> +{\n> +public:\n> +\tvirtual ~Debayer() = 0;\n> +\n> +\t/**\n> +\t * \\brief Configure the debayer object according to the passed in parameters.\n> +\t * \\param[in] inputCfg The input configuration.\n> +\t * \\param[in] outputCfgs The output configurations.\n> +\t *\n> +\t * \\return 0 on success, a negative errno on failure.\n> +\t */\n\nDocumentation in .cpp files.\n\n> +\tvirtual int configure(const StreamConfiguration &inputCfg,\n> +\t\t\t const std::vector> &outputCfgs) = 0;\n> +\n> +\t/**\n> +\t * \\brief Get the width and height at which the bayer pattern repeats.\n> +\t * \\param[in] inputFormat The input format.\n> +\t *\n> +\t * Valid sizes are: 2x2, 4x2 or 4x4.\n> +\t *\n> +\t * \\return pattern size or an empty size for unsupported inputFormats.\n> +\t */\n> +\tvirtual Size patternSize(PixelFormat inputFormat) = 0;\n\nUnless I'm mistaken, this is used internally in the DebayerCpu class\nonly. I think you can drop the function from the interface, and make it\nprivate.\n\n> +\n> +\t/**\n> +\t * \\brief Get the supported output formats.\n> +\t * \\param[in] inputFormat The input format.\n> +\t *\n> +\t * \\return all supported output formats or an empty vector if there are none.\n> +\t */\n> +\tvirtual std::vector formats(PixelFormat inputFormat) = 0;\n> +\n> +\t/**\n> +\t * \\brief Get the stride and the frame size.\n> +\t * \\param[in] outputFormat The output format.\n> +\t * \\param[in] size The output size.\n> +\t *\n> +\t * \\return a tuple of the stride and the frame size, or a tuple with 0,0 if there is no valid output config.\n\nLine wrap.\n\n> +\t */\n> +\tvirtual std::tuple\n> +\tstrideAndFrameSize(const PixelFormat &outputFormat, const Size &size) = 0;\n> +\n> +\t/**\n> +\t * \\brief Process the bayer data into the requested format.\n> +\t * \\param[in] input The input buffer.\n> +\t * \\param[in] output The output buffer.\n> +\t * \\param[in] params The parameters to be used in debayering.\n> +\t *\n> +\t * \\note DebayerParams is passed by value deliberately so that a copy is passed\n> +\t * when this is run in another thread by invokeMethod().\n\nPossibly something to address later, by storing ISP parameters in\nper-frame buffers like we do for hardware ISPs.\n\n> +\t */\n> +\tvirtual void process(FrameBuffer *input, FrameBuffer *output, DebayerParams params) = 0;\n> +\n> +\t/**\n> +\t * \\brief Get the supported output sizes for the given input format and size.\n> +\t * \\param[in] inputFormat The input format.\n> +\t * \\param[in] inputSize The input size.\n> +\t *\n> +\t * \\return The valid size ranges or an empty range if there are none.\n> +\t */\n> +\tvirtual SizeRange sizes(PixelFormat inputFormat, const Size &inputSize) = 0;\n> +\n> +\t/**\n> +\t * \\brief Signals when the input buffer is ready.\n> +\t */\n> +\tSignal inputBufferReady;\n> +\n> +\t/**\n> +\t * \\brief Signals when the output buffer is ready.\n> +\t */\n> +\tSignal outputBufferReady;\n\nDo you envision that we would have backends that could emit those\nsignals at different times ? If not you could combine them into a single\nsignal, that would be more efficient.\n\n> +};\n> +\n> +} /* namespace libcamera */\n> diff --git a/src/libcamera/software_isp/meson.build b/src/libcamera/software_isp/meson.build\n> index fcfff74a..62095f61 100644\n> --- a/src/libcamera/software_isp/meson.build\n> +++ b/src/libcamera/software_isp/meson.build\n> @@ -8,5 +8,6 @@ if not (softisp_enabled)\n> endif\n> \n> libcamera_sources += files([\n> + 'debayer.cpp',\n> 'swstats_cpu.cpp',\n> ])","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 30D28BD160\n\tfor ;\n\tWed, 27 Mar 2024 14:01:04 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id E5C7A6333B;\n\tWed, 27 Mar 2024 15:01:02 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 6434A6308D\n\tfor ;\n\tWed, 27 Mar 2024 15:01:01 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 91F521890;\n\tWed, 27 Mar 2024 15:00:28 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"CJK3gAJE\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1711548028;\n\tbh=ptT01paNg+R1x8Vb3eTv7q9B/EImCoGZCiWZJ0ob1bM=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=CJK3gAJEY7lAkQKKOKA9X7B3NM7GNvHdrQa2VPHJ+Bs4j8q4ZL7OYlKw5UXjGK1xg\n\t2rjgErF6wAzecqBthV6omHM06NC8dD42aB2YQ9VzAaRMZKkKe7MTjC2u0aYaKg/TGA\n\tTI2MNvVIwEfF3WDaR+KRk7ccbmubah2LbtWQu4rM=","Date":"Wed, 27 Mar 2024 16:00:51 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org, Hans de Goede ,\n\tAndrey Konovalov ,\n\tBryan O'Donoghue ,\n\tMaxime Ripard , Pavel Machek ,\n\tKieran Bingham ,\n\tDennis Bonke ,\n\tAndrey Konovalov ","Subject":"Re: [PATCH v6 07/18] libcamera: software_isp: Add Debayer base class","Message-ID":"<20240327140051.GE4721@pendragon.ideasonboard.com>","References":"<20240319123622.675599-1-mzamazal@redhat.com>\n\t<20240319123622.675599-8-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240319123622.675599-8-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29093,"web_url":"https://patchwork.libcamera.org/comment/29093/","msgid":"<0412b1fd-53dc-4f47-9ef7-39b15610b829@redhat.com>","date":"2024-03-27T15:29:05","subject":"Re: [PATCH v6 07/18] libcamera: software_isp: Add Debayer base class","submitter":{"id":102,"url":"https://patchwork.libcamera.org/api/people/102/","name":"Hans de Goede","email":"hdegoede@redhat.com"},"content":"Hi Laurent,\n\nOn 3/27/24 3:00 PM, Laurent Pinchart wrote:\n> Hi Milan and Hans,\n> \n> Thank you for the patch.\n\nSame as with the previous review: Thank you for the review.\n\nMilan is going to prepare a v7 of this series, so I'm going to \nall the trivial remarks and only comment on the remaining remarks.\n\n> On Tue, Mar 19, 2024 at 01:35:54PM +0100, Milan Zamazal wrote:\n>> From: Hans de Goede \n>>\n>> Add a base class for debayer implementations. This is intended to be\n>> suitable for both GPU (or otherwise) accelerated debayer implementations\n>> as well as CPU based debayering.\n>>\n>> Doxygen documentation by Dennis Bonke.\n>>\n>> Tested-by: Bryan O'Donoghue # sc8280xp Lenovo x13s\n>> Tested-by: Pavel Machek \n>> Reviewed-by: Pavel Machek \n>> Reviewed-by: Milan Zamazal \n>> Co-developed-by: Dennis Bonke \n>> Signed-off-by: Dennis Bonke \n>> Co-developed-by: Andrey Konovalov \n>> Signed-off-by: Andrey Konovalov \n>> Signed-off-by: Hans de Goede \n>> ---\n>> .../internal/software_isp/debayer_params.h | 48 ++++++++\n>> .../internal/software_isp/meson.build | 1 +\n>> src/libcamera/software_isp/debayer.cpp | 29 +++++\n>> src/libcamera/software_isp/debayer.h | 104 ++++++++++++++++++\n>> src/libcamera/software_isp/meson.build | 1 +\n>> 5 files changed, 183 insertions(+)\n>> create mode 100644 include/libcamera/internal/software_isp/debayer_params.h\n>> create mode 100644 src/libcamera/software_isp/debayer.cpp\n>> create mode 100644 src/libcamera/software_isp/debayer.h\n>>\n>> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\n>> new file mode 100644\n>> index 00000000..98965fa1\n>> --- /dev/null\n>> +++ b/include/libcamera/internal/software_isp/debayer_params.h\n>> @@ -0,0 +1,48 @@\n>> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n>> +/*\n>> + * Copyright (C) 2023, Red Hat Inc.\n>> + *\n>> + * Authors:\n>> + * Hans de Goede \n>> + *\n>> + * debayer_params.h - DebayerParams header\n>> + */\n>> +\n>> +#pragma once\n>> +\n>> +namespace libcamera {\n>> +\n>> +/**\n>> + * \\brief Struct to hold the debayer parameters.\n>> + */\n> \n> Documentation in .cpp files.\n> \n>> +struct DebayerParams {\n>> +\t/**\n>> +\t * \\brief const value for 1.0 gain\n>> +\t */\n>> +\tstatic constexpr unsigned int kGain10 = 256;\n> \n> Forcing the caller to deal with the internal representation of gains\n> isn't nice, especially given that it precludes implementing gains of\n> different precisions in different backend. Wouldn't it be better to pass\n> the values as floating point numbers, and convert them to the internal\n> representation in the implementation of process() before using them ?\n\nThat is a good idea. Is it ok if we put this at the top of\nthe SoftwareISP-TODO doc as low hanging fruit and then tackle\nthis soon after the current version is merged ?\n\nThe current version has seen a lot of testing so I would prefer\nto not make any non trivial changes for the initial merge.\n\nBut this definitely is something which we can tackle soon\nafter merging.\n\n\n\n>> +\tvirtual int configure(const StreamConfiguration &inputCfg,\n>> +\t\t\t const std::vector> &outputCfgs) = 0;\n>> +\n>> +\t/**\n>> +\t * \\brief Get the width and height at which the bayer pattern repeats.\n>> +\t * \\param[in] inputFormat The input format.\n>> +\t *\n>> +\t * Valid sizes are: 2x2, 4x2 or 4x4.\n>> +\t *\n>> +\t * \\return pattern size or an empty size for unsupported inputFormats.\n>> +\t */\n>> +\tvirtual Size patternSize(PixelFormat inputFormat) = 0;\n> \n> Unless I'm mistaken, this is used internally in the DebayerCpu class\n> only. I think you can drop the function from the interface, and make it\n> private.\n\nAck.\n\nNote that the whole base + CPU class split is still somewhat in flux,\nunlike for the swstats code where I've squashed the 2 into 1 class this\nhas been left split for now in anticipation of the GPU accelerated debayering\nBryan is working on.\n\nI think that a lot of your overal API design questions will come more into\nfocus once we have an initial MVP / POC from Bryan. We might even end up\njust squashing the 2 classes into 1 then, but Bryan has said that he sees\npotential for code sharing in the base class.\n\n> \n>> +\n>> +\t/**\n>> +\t * \\brief Get the supported output formats.\n>> +\t * \\param[in] inputFormat The input format.\n>> +\t *\n>> +\t * \\return all supported output formats or an empty vector if there are none.\n>> +\t */\n>> +\tvirtual std::vector formats(PixelFormat inputFormat) = 0;\n>> +\n>> +\t/**\n>> +\t * \\brief Get the stride and the frame size.\n>> +\t * \\param[in] outputFormat The output format.\n>> +\t * \\param[in] size The output size.\n>> +\t *\n>> +\t * \\return a tuple of the stride and the frame size, or a tuple with 0,0 if there is no valid output config.\n> \n> Line wrap.\n> \n>> +\t */\n>> +\tvirtual std::tuple\n>> +\tstrideAndFrameSize(const PixelFormat &outputFormat, const Size &size) = 0;\n>> +\n>> +\t/**\n>> +\t * \\brief Process the bayer data into the requested format.\n>> +\t * \\param[in] input The input buffer.\n>> +\t * \\param[in] output The output buffer.\n>> +\t * \\param[in] params The parameters to be used in debayering.\n>> +\t *\n>> +\t * \\note DebayerParams is passed by value deliberately so that a copy is passed\n>> +\t * when this is run in another thread by invokeMethod().\n> \n> Possibly something to address later, by storing ISP parameters in\n> per-frame buffers like we do for hardware ISPs.\n\nRight, I guess this is another item to add to the SoftwareISP-TODO doc.\n\n> \n>> +\t */\n>> +\tvirtual void process(FrameBuffer *input, FrameBuffer *output, DebayerParams params) = 0;\n>> +\n>> +\t/**\n>> +\t * \\brief Get the supported output sizes for the given input format and size.\n>> +\t * \\param[in] inputFormat The input format.\n>> +\t * \\param[in] inputSize The input size.\n>> +\t *\n>> +\t * \\return The valid size ranges or an empty range if there are none.\n>> +\t */\n>> +\tvirtual SizeRange sizes(PixelFormat inputFormat, const Size &inputSize) = 0;\n>> +\n>> +\t/**\n>> +\t * \\brief Signals when the input buffer is ready.\n>> +\t */\n>> +\tSignal inputBufferReady;\n>> +\n>> +\t/**\n>> +\t * \\brief Signals when the output buffer is ready.\n>> +\t */\n>> +\tSignal outputBufferReady;\n> \n> Do you envision that we would have backends that could emit those\n> signals at different times ? If not you could combine them into a single\n> signal, that would be more efficient.\n\nThis is modeled after the converter class. I think it would be good\nto keep these. If we get a more advanced pipeline with e.g. using the\nVPU for denoising (I recently learned at least Intel VPU s can do this)\nthen I can see the pipeline using an intermediate buffer and us releasing\nthe input buffer after debayering while the output buffer will not\nbe ready until the VPU is done.\n\nRegards,\n\nHans","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id BAAE6BD160\n\tfor ;\n\tWed, 27 Mar 2024 15:29:15 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id B0D646334D;\n\tWed, 27 Mar 2024 16:29:14 +0100 (CET)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 77AB86308D\n\tfor ;\n\tWed, 27 Mar 2024 16:29:13 +0100 (CET)","from mail-ed1-f71.google.com (mail-ed1-f71.google.com\n\t[209.85.208.71]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-14-jHVKPvG1MPy8HSVjsHkH4w-1; Wed, 27 Mar 2024 11:29:08 -0400","by mail-ed1-f71.google.com with SMTP id\n\t4fb4d7f45d1cf-56c3dc8d331so446793a12.2\n\tfor ;\n\tWed, 27 Mar 2024 08:29:08 -0700 (PDT)","from ?IPV6:2001:1c00:c32:7800:5bfa:a036:83f0:f9ec?\n\t(2001-1c00-0c32-7800-5bfa-a036-83f0-f9ec.cable.dynamic.v6.ziggo.nl.\n\t[2001:1c00:c32:7800:5bfa:a036:83f0:f9ec])\n\tby smtp.gmail.com with ESMTPSA id\n\tr1-20020aa7cb81000000b0056c052f9fafsm4584526edt.53.2024.03.27.08.29.06\n\t(version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128);\n\tWed, 27 Mar 2024 08:29:06 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"T+DrlmAY\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1711553352;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tcontent-transfer-encoding:content-transfer-encoding:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=aySjZTNMGxHdDUG8lJ+FCDVQ3FxyfAvOQr8ZLG/G/3c=;\n\tb=T+DrlmAYUd3isHxt9Lb2bTgIjdAYBianGisSernU0shF1mUDOCrxs6GV0CO8mx1F+7eewZ\n\t2Ps858hNRQovwyvBImpu9RunKkiKkeVL3c/CiQDt8Cx/OsFlv1u2sA49HZhXs1neZPtFd5\n\tosZf5izXpxKkq5iscpHe1Yc8ptjf4b8=","X-MC-Unique":"jHVKPvG1MPy8HSVjsHkH4w-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1711553347; x=1712158147;\n\th=content-transfer-encoding:in-reply-to:from:references:cc:to\n\t:content-language:subject:user-agent:mime-version:date:message-id\n\t:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to;\n\tbh=aySjZTNMGxHdDUG8lJ+FCDVQ3FxyfAvOQr8ZLG/G/3c=;\n\tb=fJOFRLMCirga2kSElYxtUpigigLWL5TUq9i2JqumWjmmVtZTSE70KSVOF/X2spiRJU\n\tglYzleixznGSyvN35C9WOFqTVnrPlKr1Ff1VHU5tN4n5UGYpSyo5ivkoqr1005ggwray\n\tzFrdNQNPNTTWLjR7nwMlmWatBmhvC/Jkmj+oN8VgOkQVjvqNNB8Z1Lupbl/Hngdm0O6M\n\txmDtHSu1ziKVtxoY0GjxkU5+4+g6E6d5RE09Fu7sMRw/ngydO0iNJ90AHvvczC7k1olb\n\t3tjL+p+Nwj9RZWGjjIBUuf4/tF3r1rbo/UXI/rGjCL7v2NyzJKbUeX3qhFeywETl63nO\n\tYoMw==","X-Gm-Message-State":"AOJu0YwS8HrbuciX82dE5Rs7c2Aop/P+v1cVocJPVdgaz6XTyTPwtQXM\n\tBoUG62fnui33ToYiYESdfFYiKUR6dG14Yk2l8VEfZJbinMzOQM3I6dcyl8QTFLtxjGom9K+S6zt\n\tXwzIuxYI7PCWJwPAYqfMZw8JVKBdMx/KLcA3m9dxq/a6FSMKjYkZhgxnJ2tBxaEb88SIbEEo=","X-Received":["by 2002:a50:8750:0:b0:565:9c76:73c3 with SMTP id\n\t16-20020a508750000000b005659c7673c3mr89215edv.29.1711553347432; \n\tWed, 27 Mar 2024 08:29:07 -0700 (PDT)","by 2002:a50:8750:0:b0:565:9c76:73c3 with SMTP id\n\t16-20020a508750000000b005659c7673c3mr89202edv.29.1711553346968; \n\tWed, 27 Mar 2024 08:29:06 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IEWajEERZbeIQ8f4ktr4MCk+lHZRClw0RUWJrn9jftqNbN8TYh8s4IaaMbuI/YLYWaJGNlNCw==","Message-ID":"<0412b1fd-53dc-4f47-9ef7-39b15610b829@redhat.com>","Date":"Wed, 27 Mar 2024 16:29:05 +0100","MIME-Version":"1.0","User-Agent":"Mozilla Thunderbird","Subject":"Re: [PATCH v6 07/18] libcamera: software_isp: Add Debayer base class","To":"Laurent Pinchart ,\n\tMilan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org,\n\tAndrey Konovalov ,\n\tBryan O'Donoghue ,\n\tMaxime Ripard , Pavel Machek ,\n\tKieran Bingham ,\n\tDennis Bonke ,\n\tAndrey Konovalov ","References":"<20240319123622.675599-1-mzamazal@redhat.com>\n\t<20240319123622.675599-8-mzamazal@redhat.com>\n\t<20240327140051.GE4721@pendragon.ideasonboard.com>","From":"Hans de Goede ","In-Reply-To":"<20240327140051.GE4721@pendragon.ideasonboard.com>","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Language":"en-US, nl","Content-Type":"text/plain; charset=UTF-8","Content-Transfer-Encoding":"7bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29112,"web_url":"https://patchwork.libcamera.org/comment/29112/","msgid":"<20240327192910.GR4721@pendragon.ideasonboard.com>","date":"2024-03-27T19:29:10","subject":"Re: [PATCH v6 07/18] libcamera: software_isp: Add Debayer base class","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Hans,\n\nOn Wed, Mar 27, 2024 at 04:29:05PM +0100, Hans de Goede wrote:\n> On 3/27/24 3:00 PM, Laurent Pinchart wrote:\n> > Hi Milan and Hans,\n> > \n> > Thank you for the patch.\n> \n> Same as with the previous review: Thank you for the review.\n\nSorry for taking so long to review the whole series, I should have done\nso earlier.\n\n> Milan is going to prepare a v7 of this series, so I'm going to \n> all the trivial remarks and only comment on the remaining remarks.\n> \n> > On Tue, Mar 19, 2024 at 01:35:54PM +0100, Milan Zamazal wrote:\n> >> From: Hans de Goede \n> >>\n> >> Add a base class for debayer implementations. This is intended to be\n> >> suitable for both GPU (or otherwise) accelerated debayer implementations\n> >> as well as CPU based debayering.\n> >>\n> >> Doxygen documentation by Dennis Bonke.\n> >>\n> >> Tested-by: Bryan O'Donoghue # sc8280xp Lenovo x13s\n> >> Tested-by: Pavel Machek \n> >> Reviewed-by: Pavel Machek \n> >> Reviewed-by: Milan Zamazal \n> >> Co-developed-by: Dennis Bonke \n> >> Signed-off-by: Dennis Bonke \n> >> Co-developed-by: Andrey Konovalov \n> >> Signed-off-by: Andrey Konovalov \n> >> Signed-off-by: Hans de Goede \n> >> ---\n> >> .../internal/software_isp/debayer_params.h | 48 ++++++++\n> >> .../internal/software_isp/meson.build | 1 +\n> >> src/libcamera/software_isp/debayer.cpp | 29 +++++\n> >> src/libcamera/software_isp/debayer.h | 104 ++++++++++++++++++\n> >> src/libcamera/software_isp/meson.build | 1 +\n> >> 5 files changed, 183 insertions(+)\n> >> create mode 100644 include/libcamera/internal/software_isp/debayer_params.h\n> >> create mode 100644 src/libcamera/software_isp/debayer.cpp\n> >> create mode 100644 src/libcamera/software_isp/debayer.h\n> >>\n> >> diff --git a/include/libcamera/internal/software_isp/debayer_params.h b/include/libcamera/internal/software_isp/debayer_params.h\n> >> new file mode 100644\n> >> index 00000000..98965fa1\n> >> --- /dev/null\n> >> +++ b/include/libcamera/internal/software_isp/debayer_params.h\n> >> @@ -0,0 +1,48 @@\n> >> +/* SPDX-License-Identifier: LGPL-2.1-or-later */\n> >> +/*\n> >> + * Copyright (C) 2023, Red Hat Inc.\n> >> + *\n> >> + * Authors:\n> >> + * Hans de Goede \n> >> + *\n> >> + * debayer_params.h - DebayerParams header\n> >> + */\n> >> +\n> >> +#pragma once\n> >> +\n> >> +namespace libcamera {\n> >> +\n> >> +/**\n> >> + * \\brief Struct to hold the debayer parameters.\n> >> + */\n> > \n> > Documentation in .cpp files.\n> > \n> >> +struct DebayerParams {\n> >> +\t/**\n> >> +\t * \\brief const value for 1.0 gain\n> >> +\t */\n> >> +\tstatic constexpr unsigned int kGain10 = 256;\n> > \n> > Forcing the caller to deal with the internal representation of gains\n> > isn't nice, especially given that it precludes implementing gains of\n> > different precisions in different backend. Wouldn't it be better to pass\n> > the values as floating point numbers, and convert them to the internal\n> > representation in the implementation of process() before using them ?\n> \n> That is a good idea. Is it ok if we put this at the top of\n> the SoftwareISP-TODO doc as low hanging fruit and then tackle\n> this soon after the current version is merged ?\n\nI'm OK with that. Let's get this merged, and then start tackling some of\nthe technical debt before adding more advanced features.\n\n> The current version has seen a lot of testing so I would prefer\n> to not make any non trivial changes for the initial merge.\n> \n> But this definitely is something which we can tackle soon\n> after merging.\n> \n> \n> \n> >> +\tvirtual int configure(const StreamConfiguration &inputCfg,\n> >> +\t\t\t const std::vector> &outputCfgs) = 0;\n> >> +\n> >> +\t/**\n> >> +\t * \\brief Get the width and height at which the bayer pattern repeats.\n> >> +\t * \\param[in] inputFormat The input format.\n> >> +\t *\n> >> +\t * Valid sizes are: 2x2, 4x2 or 4x4.\n> >> +\t *\n> >> +\t * \\return pattern size or an empty size for unsupported inputFormats.\n> >> +\t */\n> >> +\tvirtual Size patternSize(PixelFormat inputFormat) = 0;\n> > \n> > Unless I'm mistaken, this is used internally in the DebayerCpu class\n> > only. I think you can drop the function from the interface, and make it\n> > private.\n> \n> Ack.\n> \n> Note that the whole base + CPU class split is still somewhat in flux,\n> unlike for the swstats code where I've squashed the 2 into 1 class this\n> has been left split for now in anticipation of the GPU accelerated debayering\n> Bryan is working on.\n> \n> I think that a lot of your overal API design questions will come more into\n> focus once we have an initial MVP / POC from Bryan. We might even end up\n> just squashing the 2 classes into 1 then, but Bryan has said that he sees\n> potential for code sharing in the base class.\n\nI was thinking the same, we'll have a better view of the design once\nBryan will have a second user of the base class.\n\n> >> +\n> >> +\t/**\n> >> +\t * \\brief Get the supported output formats.\n> >> +\t * \\param[in] inputFormat The input format.\n> >> +\t *\n> >> +\t * \\return all supported output formats or an empty vector if there are none.\n> >> +\t */\n> >> +\tvirtual std::vector formats(PixelFormat inputFormat) = 0;\n> >> +\n> >> +\t/**\n> >> +\t * \\brief Get the stride and the frame size.\n> >> +\t * \\param[in] outputFormat The output format.\n> >> +\t * \\param[in] size The output size.\n> >> +\t *\n> >> +\t * \\return a tuple of the stride and the frame size, or a tuple with 0,0 if there is no valid output config.\n> > \n> > Line wrap.\n> > \n> >> +\t */\n> >> +\tvirtual std::tuple\n> >> +\tstrideAndFrameSize(const PixelFormat &outputFormat, const Size &size) = 0;\n> >> +\n> >> +\t/**\n> >> +\t * \\brief Process the bayer data into the requested format.\n> >> +\t * \\param[in] input The input buffer.\n> >> +\t * \\param[in] output The output buffer.\n> >> +\t * \\param[in] params The parameters to be used in debayering.\n> >> +\t *\n> >> +\t * \\note DebayerParams is passed by value deliberately so that a copy is passed\n> >> +\t * when this is run in another thread by invokeMethod().\n> > \n> > Possibly something to address later, by storing ISP parameters in\n> > per-frame buffers like we do for hardware ISPs.\n> \n> Right, I guess this is another item to add to the SoftwareISP-TODO doc.\n\nI think this will be part of the refactoring needed to have per-frame\nstats and params.\n\n> >> +\t */\n> >> +\tvirtual void process(FrameBuffer *input, FrameBuffer *output, DebayerParams params) = 0;\n> >> +\n> >> +\t/**\n> >> +\t * \\brief Get the supported output sizes for the given input format and size.\n> >> +\t * \\param[in] inputFormat The input format.\n> >> +\t * \\param[in] inputSize The input size.\n> >> +\t *\n> >> +\t * \\return The valid size ranges or an empty range if there are none.\n> >> +\t */\n> >> +\tvirtual SizeRange sizes(PixelFormat inputFormat, const Size &inputSize) = 0;\n> >> +\n> >> +\t/**\n> >> +\t * \\brief Signals when the input buffer is ready.\n> >> +\t */\n> >> +\tSignal inputBufferReady;\n> >> +\n> >> +\t/**\n> >> +\t * \\brief Signals when the output buffer is ready.\n> >> +\t */\n> >> +\tSignal outputBufferReady;\n> > \n> > Do you envision that we would have backends that could emit those\n> > signals at different times ? If not you could combine them into a single\n> > signal, that would be more efficient.\n> \n> This is modeled after the converter class. I think it would be good\n> to keep these. If we get a more advanced pipeline with e.g. using the\n> VPU for denoising (I recently learned at least Intel VPU s can do this)\n> then I can see the pipeline using an intermediate buffer and us releasing\n> the input buffer after debayering while the output buffer will not\n> be ready until the VPU is done.\n\nLet's keep this as-is for now, we can always change it later.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 03CB9BD160\n\tfor ;\n\tWed, 27 Mar 2024 19:29:21 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 4269463362;\n\tWed, 27 Mar 2024 20:29:21 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 32C7B6308D\n\tfor ;\n\tWed, 27 Mar 2024 20:29:19 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 2A0A6899;\n\tWed, 27 Mar 2024 20:28:46 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"asl7pSo3\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1711567726;\n\tbh=3xqIxZOQfbduQ8ujg4uJRBO3JaltSHu5dHioaCv76m0=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=asl7pSo3apqcY7sQujjeL5Rw5HAHtOuWws/obz5nhiDZAmYDSZ2S99p7Zs75uCYLG\n\tn6f+J17sDcas3cUVu3BvL/SsGtk0x1FoDDRnObk4kf3ciDAc9upXrkUFrmCKY9KqA8\n\tDYUDuFXPB2Hgqzqddw2qF8On47i/j02Bgu+WoiBI=","Date":"Wed, 27 Mar 2024 21:29:10 +0200","From":"Laurent Pinchart ","To":"Hans de Goede ","Cc":"Milan Zamazal , libcamera-devel@lists.libcamera.org,\n\tAndrey Konovalov ,\n\tBryan O'Donoghue ,\n\tMaxime Ripard , Pavel Machek ,\n\tKieran Bingham ,\n\tDennis Bonke ,\n\tAndrey Konovalov ","Subject":"Re: [PATCH v6 07/18] libcamera: software_isp: Add Debayer base class","Message-ID":"<20240327192910.GR4721@pendragon.ideasonboard.com>","References":"<20240319123622.675599-1-mzamazal@redhat.com>\n\t<20240319123622.675599-8-mzamazal@redhat.com>\n\t<20240327140051.GE4721@pendragon.ideasonboard.com>\n\t<0412b1fd-53dc-4f47-9ef7-39b15610b829@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<0412b1fd-53dc-4f47-9ef7-39b15610b829@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}},{"id":29133,"web_url":"https://patchwork.libcamera.org/comment/29133/","msgid":"<87zfubh8k1.fsf@redhat.com>","date":"2024-04-02T19:24:30","subject":"Re: [PATCH v6 07/18] libcamera: software_isp: Add Debayer base class","submitter":{"id":177,"url":"https://patchwork.libcamera.org/api/people/177/","name":"Milan Zamazal","email":"mzamazal@redhat.com"},"content":"Laurent Pinchart writes:\n> On Wed, Mar 27, 2024 at 04:29:05PM +0100, Hans de Goede wrote:\n\n[...]\n\n>> That is a good idea. Is it ok if we put this at the top of\n>> the SoftwareISP-TODO doc as low hanging fruit and then tackle\n>> this soon after the current version is merged ?\n>\n> I'm OK with that. Let's get this merged, and then start tackling some of\n> the technical debt before adding more advanced features.\n\nOK, I added all such to-do stuff to src/libcamera/software_isp/TODO. If anybody\nhas an idea for a better location (I don't think it belongs to Documentation/ as\nit's not exactly documentation) before I post v7, please tell me.","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id EF703C0DA4\n\tfor ;\n\tTue, 2 Apr 2024 19:24:38 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id EDB6D63354;\n\tTue, 2 Apr 2024 21:24:37 +0200 (CEST)","from us-smtp-delivery-124.mimecast.com\n\t(us-smtp-delivery-124.mimecast.com [170.10.133.124])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id EEECC6308D\n\tfor ;\n\tTue, 2 Apr 2024 21:24:35 +0200 (CEST)","from mail-lj1-f200.google.com (mail-lj1-f200.google.com\n\t[209.85.208.200]) by relay.mimecast.com with ESMTP with STARTTLS\n\t(version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id\n\tus-mta-372-CcpZb6CCOA2gns2bgGFNjw-1; Tue, 02 Apr 2024 15:24:33 -0400","by mail-lj1-f200.google.com with SMTP id\n\t38308e7fff4ca-2d6c8f170e2so55708801fa.3\n\tfor ;\n\tTue, 02 Apr 2024 12:24:33 -0700 (PDT)","from nuthatch (ip-77-48-47-2.net.vodafone.cz. [77.48.47.2])\n\tby smtp.gmail.com with ESMTPSA id\n\tn9-20020a1709062bc900b00a469d3df3c1sm6876202ejg.96.2024.04.02.12.24.30\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 02 Apr 2024 12:24:31 -0700 (PDT)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=redhat.com header.i=@redhat.com\n\theader.b=\"Dum5kaeO\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;\n\ts=mimecast20190719; t=1712085874;\n\th=from:from:reply-to:subject:subject:date:date:message-id:message-id:\n\tto:to:cc:cc:mime-version:mime-version:content-type:content-type:\n\tin-reply-to:in-reply-to:references:references;\n\tbh=GqbjoWNuTPcQI9xwGzcytNcU4l01ueFqoeZSn7wycMg=;\n\tb=Dum5kaeOkYkfv5Kbzlo3DIXwTPmENhG4RVNxVf5/aOhXZ9DSh5rsSIDz98JcAkDt83TjtM\n\tRvgB+6RP0nETiogrsuSuHnICGWrdQKooNCaVlpiGsO+IMoZk57Vx0xaxZ6NCNfS9qehLM6\n\tlrZ0/eXonfodpgHTFUFJ49eKOccYH+c=","X-MC-Unique":"CcpZb6CCOA2gns2bgGFNjw-1","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20230601; t=1712085872; x=1712690672;\n\th=mime-version:user-agent:message-id:date:references:in-reply-to\n\t:subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date\n\t:message-id:reply-to;\n\tbh=GqbjoWNuTPcQI9xwGzcytNcU4l01ueFqoeZSn7wycMg=;\n\tb=o51umxXnAkheS63+34AmvR6wEKJ14ylI6S6c7rZLXu9B+cUmSozTgs6SJrm/fPBo1H\n\tPPV4GZe8Y6wCYoqHC3oMkCn0rgpRGl1YmbUSp4f2MmRgpJx/AEivomFDMoTIi06tm9Fw\n\tKDS2/hqlk/A7pZYLahKNh8E2BZPyMLOs4vQkfD3PYr9K72Yd1wuXaALcimWeln/k+glj\n\tpx/MCF9oRDkpiDLmjba7rs7j7eoFBCEvdoiCxiSJj18mQA+4YezL84Z9e2gRQwye7TZs\n\tdmhx6GAfXiMhsW8CZScfXCnmwjhqPX6Ez7Ua8JfsN86IueUqW8T7In62Bw6x4OLgcH1R\n\tkoCA==","X-Forwarded-Encrypted":"i=1;\n\tAJvYcCVZ873SqfPlfd2Eg+JquBlGcDgpS7eIBCbxSU3l5ZhTuT7Z6mD2WGHW+g8LoFzezaj9cqJTK3I++4KgLrwq5z7uJFr0k9M0rvHzWc/zc21+HrKgkA==","X-Gm-Message-State":"AOJu0YxMUi/sVyjnK9q386Z6IuzGy3E5rIqzuYEEIdu59HjR81Kh6Pnb\n\tNspizzPq5zR2viocvuqnh+fW9gN0aPQcU9GQf1CwWGN/uTWSTxXXFDvgVRNtcmpQUNzS61+l4lh\n\tg66wQHsfr/ECvrElX+PSnJojXld1cl0+F94HjHo9m0+icYTTrmv/CFmxgmtNZt6fgPs/Y76I=","X-Received":["by 2002:a05:651c:1256:b0:2d4:6893:24e1 with SMTP id\n\th22-20020a05651c125600b002d4689324e1mr1796016ljh.50.1712085872062; \n\tTue, 02 Apr 2024 12:24:32 -0700 (PDT)","by 2002:a05:651c:1256:b0:2d4:6893:24e1 with SMTP id\n\th22-20020a05651c125600b002d4689324e1mr1796004ljh.50.1712085871711; \n\tTue, 02 Apr 2024 12:24:31 -0700 (PDT)"],"X-Google-Smtp-Source":"AGHT+IFM9RwPFQtEU9pgCOEShOwN7rrP1bxCmDmnt4N9XIbvov48ii7wcqQ2i/pMiL2LLYeg6zXH5w==","From":"Milan Zamazal ","To":"Laurent Pinchart ","Cc":"Hans de Goede ,\n\tlibcamera-devel@lists.libcamera.org, Andrey Konovalov\n\t, Bryan O'Donoghue\n\t, Maxime Ripard , Pavel\n\tMachek , Kieran Bingham , \n\tDennis Bonke , Andrey Konovalov\n\t","Subject":"Re: [PATCH v6 07/18] libcamera: software_isp: Add Debayer base class","In-Reply-To":"<20240327192910.GR4721@pendragon.ideasonboard.com> (Laurent\n\tPinchart's message of \"Wed, 27 Mar 2024 21:29:10 +0200\")","References":"<20240319123622.675599-1-mzamazal@redhat.com>\n\t<20240319123622.675599-8-mzamazal@redhat.com>\n\t<20240327140051.GE4721@pendragon.ideasonboard.com>\n\t<0412b1fd-53dc-4f47-9ef7-39b15610b829@redhat.com>\n\t<20240327192910.GR4721@pendragon.ideasonboard.com>","Date":"Tue, 02 Apr 2024 21:24:30 +0200","Message-ID":"<87zfubh8k1.fsf@redhat.com>","User-Agent":"Gnus/5.13 (Gnus v5.13)","MIME-Version":"1.0","X-Mimecast-Spam-Score":"0","X-Mimecast-Originator":"redhat.com","Content-Type":"text/plain","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]