[{"id":29078,"web_url":"https://patchwork.libcamera.org/comment/29078/","msgid":"<20240327103528.GC8623@pendragon.ideasonboard.com>","date":"2024-03-27T10:35:28","subject":"Re: [PATCH v6 04/18] libcamera: internal: Move SharedMemObject class\n\tto a common directory","submitter":{"id":2,"url":"https://patchwork.libcamera.org/api/people/2/","name":"Laurent Pinchart","email":"laurent.pinchart@ideasonboard.com"},"content":"Hi Milan and Andrey,\n\nThank you for the patch.\n\nOn Tue, Mar 19, 2024 at 01:35:51PM +0100, Milan Zamazal wrote:\n> From: Andrey Konovalov \n> \n> Move SharedMemObject class out of RPi namespace and put it into\n> include/libcamera/internal so that everyone could use it.\n> \n> Tested-by: Bryan O'Donoghue # sc8280xp Lenovo x13s\n> Tested-by: Pavel Machek \n> Reviewed-by: Pavel Machek \n> Signed-off-by: Andrey Konovalov \n> Signed-off-by: Hans de Goede \n> Reviewed-by: Milan Zamazal \n\nReviewed-by: Laurent Pinchart \n\n> ---\n> include/libcamera/internal/meson.build | 1 +\n> .../libcamera/internal}/shared_mem_object.h | 6 +-----\n> 2 files changed, 2 insertions(+), 5 deletions(-)\n> rename {src/libcamera/pipeline/rpi/common => include/libcamera/internal}/shared_mem_object.h (97%)\n> \n> diff --git a/include/libcamera/internal/meson.build b/include/libcamera/internal/meson.build\n> index 33eb0fb3..5807dfd9 100644\n> --- a/include/libcamera/internal/meson.build\n> +++ b/include/libcamera/internal/meson.build\n> @@ -39,6 +39,7 @@ libcamera_internal_headers = files([\n> 'process.h',\n> 'pub_key.h',\n> 'request.h',\n> + 'shared_mem_object.h',\n> 'source_paths.h',\n> 'sysfs.h',\n> 'v4l2_device.h',\n> diff --git a/src/libcamera/pipeline/rpi/common/shared_mem_object.h b/include/libcamera/internal/shared_mem_object.h\n> similarity index 97%\n> rename from src/libcamera/pipeline/rpi/common/shared_mem_object.h\n> rename to include/libcamera/internal/shared_mem_object.h\n> index aa56c220..98636b44 100644\n> --- a/src/libcamera/pipeline/rpi/common/shared_mem_object.h\n> +++ b/include/libcamera/internal/shared_mem_object.h\n> @@ -6,8 +6,8 @@\n> */\n> #pragma once\n> \n> -#include \n> #include \n> +#include \n> #include \n> #include \n> #include \n> @@ -19,8 +19,6 @@\n> \n> namespace libcamera {\n> \n> -namespace RPi {\n> -\n> template\n> class SharedMemObject\n> {\n> @@ -123,6 +121,4 @@ private:\n> \tT *obj_;\n> };\n> \n> -} /* namespace RPi */\n> -\n> } /* namespace libcamera */","headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id 1BFEDC0DA4\n\tfor ;\n\tWed, 27 Mar 2024 10:35:41 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id BCBF363339;\n\tWed, 27 Mar 2024 11:35:40 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 467FB62CA2\n\tfor ;\n\tWed, 27 Mar 2024 11:35:39 +0100 (CET)","from pendragon.ideasonboard.com (81-175-209-231.bb.dnainternet.fi\n\t[81.175.209.231])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id AF973675;\n\tWed, 27 Mar 2024 11:35:06 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"sjYP2prp\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1711535706;\n\tbh=KeV+3AAUn/2eeM62FtTF8Meb2SyppaKy80dBrJaYBoQ=;\n\th=Date:From:To:Cc:Subject:References:In-Reply-To:From;\n\tb=sjYP2prpwLyZCQyRS3PI1JZfTP0UaMtc+iidZcRYg9gyXsIzbKa2SKquAyAR8XEW/\n\tNk1V48EW1aX9uBOyxZzDqQIYb+Z5ivgpOgpg32U3x8R2E/XvYS+CE5h/GqLdFOI8Jr\n\t58DbYIRvMY5bvMyQI2SFseaSanVDGCwdPWuv3PMI=","Date":"Wed, 27 Mar 2024 12:35:28 +0200","From":"Laurent Pinchart ","To":"Milan Zamazal ","Cc":"libcamera-devel@lists.libcamera.org,\n\tAndrey Konovalov ,\n\tBryan O'Donoghue ,\n\tMaxime Ripard , Pavel Machek ,\n\tHans de Goede ,\n\tKieran Bingham ","Subject":"Re: [PATCH v6 04/18] libcamera: internal: Move SharedMemObject class\n\tto a common directory","Message-ID":"<20240327103528.GC8623@pendragon.ideasonboard.com>","References":"<20240319123622.675599-1-mzamazal@redhat.com>\n\t<20240319123622.675599-5-mzamazal@redhat.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=utf-8","Content-Disposition":"inline","In-Reply-To":"<20240319123622.675599-5-mzamazal@redhat.com>","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "}}]