[{"id":2664,"web_url":"https://patchwork.libcamera.org/comment/2664/","msgid":"<20190916202442.mmzagzqrtw66ufsw@uno.localdomain>","date":"2019-09-16T20:24:42","subject":"Re: [libcamera-devel] [PATCH] clang-format: Don't indent namespaces","submitter":{"id":3,"url":"https://patchwork.libcamera.org/api/people/3/","name":"Jacopo Mondi","email":"jacopo@jmondi.org"},"content":"Hi Laurent,\n\nOn Mon, Sep 16, 2019 at 11:14:35PM +0300, Laurent Pinchart wrote:\n> Our coding style don't indent namespace contents. Update .clang-format\n> accordingly.\n>\n> Signed-off-by: Laurent Pinchart \n> ---\n> .clang-format | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n>\n> diff --git a/.clang-format b/.clang-format\n> index 7c5f7b00b3ee..0f4d2b52e848 100644\n> --- a/.clang-format\n> +++ b/.clang-format\n> @@ -80,7 +80,7 @@ KeepEmptyLinesAtTheStartOfBlocks: false\n> MacroBlockBegin: ''\n> MacroBlockEnd: ''\n> MaxEmptyLinesToKeep: 1\n> -NamespaceIndentation: Inner\n> +NamespaceIndentation: None\n> #ObjCBinPackProtocolList: Auto # Unknown to clang-format-5.0\n> ObjCBlockIndentWidth: 8\n> ObjCSpaceAfterProperty: true\n\nNice\nReviewed-by: Jacopo Mondi \n\n> --\n> Regards,\n>\n> Laurent Pinchart\n>\n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from relay9-d.mail.gandi.net (relay9-d.mail.gandi.net\n\t[217.70.183.199])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 1FF2460BED\n\tfor ;\n\tMon, 16 Sep 2019 22:23:11 +0200 (CEST)","from uno.localdomain (bl10-204-24.dsl.telepac.pt [85.243.204.24])\n\t(Authenticated sender: jacopo@jmondi.org)\n\tby relay9-d.mail.gandi.net (Postfix) with ESMTPSA id 501A5FF80C;\n\tMon, 16 Sep 2019 20:23:10 +0000 (UTC)"],"X-Originating-IP":"85.243.204.24","Date":"Mon, 16 Sep 2019 22:24:42 +0200","From":"Jacopo Mondi ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190916202442.mmzagzqrtw66ufsw@uno.localdomain>","References":"<20190916201435.29329-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"multipart/signed; micalg=pgp-sha256;\n\tprotocol=\"application/pgp-signature\"; boundary=\"wco73k6fsve7ufag\"","Content-Disposition":"inline","In-Reply-To":"<20190916201435.29329-1-laurent.pinchart@ideasonboard.com>","User-Agent":"NeoMutt/20180716","Subject":"Re: [libcamera-devel] [PATCH] clang-format: Don't indent namespaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Mon, 16 Sep 2019 20:23:11 -0000"}},{"id":2668,"web_url":"https://patchwork.libcamera.org/comment/2668/","msgid":"<20190917093818.GD15610@bigcity.dyn.berto.se>","date":"2019-09-17T09:38:18","subject":"Re: [libcamera-devel] [PATCH] clang-format: Don't indent namespaces","submitter":{"id":5,"url":"https://patchwork.libcamera.org/api/people/5/","name":"Niklas Söderlund","email":"niklas.soderlund@ragnatech.se"},"content":"Hi Laurent,\n\nThanks for your work.\n\nOn 2019-09-16 23:14:35 +0300, Laurent Pinchart wrote:\n> Our coding style don't indent namespace contents. Update .clang-format\n> accordingly.\n> \n> Signed-off-by: Laurent Pinchart \n\nReviewed-by: Niklas Söderlund \n\n> ---\n> .clang-format | 2 +-\n> 1 file changed, 1 insertion(+), 1 deletion(-)\n> \n> diff --git a/.clang-format b/.clang-format\n> index 7c5f7b00b3ee..0f4d2b52e848 100644\n> --- a/.clang-format\n> +++ b/.clang-format\n> @@ -80,7 +80,7 @@ KeepEmptyLinesAtTheStartOfBlocks: false\n> MacroBlockBegin: ''\n> MacroBlockEnd: ''\n> MaxEmptyLinesToKeep: 1\n> -NamespaceIndentation: Inner\n> +NamespaceIndentation: None\n> #ObjCBinPackProtocolList: Auto # Unknown to clang-format-5.0\n> ObjCBlockIndentWidth: 8\n> ObjCSpaceAfterProperty: true\n> -- \n> Regards,\n> \n> Laurent Pinchart\n> \n> _______________________________________________\n> libcamera-devel mailing list\n> libcamera-devel@lists.libcamera.org\n> https://lists.libcamera.org/listinfo/libcamera-devel","headers":{"Return-Path":"","Received":["from mail-lf1-x142.google.com (mail-lf1-x142.google.com\n\t[IPv6:2a00:1450:4864:20::142])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 3A38660BB0\n\tfor ;\n\tTue, 17 Sep 2019 11:38:20 +0200 (CEST)","by mail-lf1-x142.google.com with SMTP id w67so2335769lff.4\n\tfor ;\n\tTue, 17 Sep 2019 02:38:20 -0700 (PDT)","from localhost (h-93-159.A463.priv.bahnhof.se. [46.59.93.159])\n\tby smtp.gmail.com with ESMTPSA id\n\tx2sm326789ljj.94.2019.09.17.02.38.18\n\t(version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);\n\tTue, 17 Sep 2019 02:38:18 -0700 (PDT)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=ragnatech-se.20150623.gappssmtp.com; s=20150623;\n\th=date:from:to:cc:subject:message-id:references:mime-version\n\t:content-disposition:content-transfer-encoding:in-reply-to\n\t:user-agent; bh=yqPygv239o8diT8ZtScTzpmTD2ddF+dwjoM7Xh4ySdg=;\n\tb=zsVECX6u3iWCLZfPh4pQnJmVbzLprRt7pcFuM2IKBbhOREsKB2REmlSkRXHAGdgDa2\n\tZdFV4VplG+Y/OVJf1QkTeEDJh8II96T92N+9uxOizBOOTJJI3ZNq++eR1qya0QI2vJPt\n\tQbQAaRalBlKnOCQqGDoEukMc+lLtf1D0TXmtCInCIEamg/iCcPDzQMSrtF0ThcP1D+fV\n\txG8ZcOvtKiTdwzN0cqA7zsuC7eTg4EcC3/H9zlz7R1/E1kbIU2DOfhB2kBLNH3n8yG8G\n\turrAMtB/vvy3jf7g1YpHtR5n0LguhekpEi/N6xfC++eHETkUUDUbYsx/5qkodAMGARob\n\t/K6w==","X-Google-DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/relaxed;\n\td=1e100.net; s=20161025;\n\th=x-gm-message-state:date:from:to:cc:subject:message-id:references\n\t:mime-version:content-disposition:content-transfer-encoding\n\t:in-reply-to:user-agent;\n\tbh=yqPygv239o8diT8ZtScTzpmTD2ddF+dwjoM7Xh4ySdg=;\n\tb=XpTpIfsR0aHL0UCCua+fyQkL/u4f9OqctCAXXwlya6tuHyF2Ar3KExwGKPQWWrRSi6\n\tjca/uToonXzDuPIT3cbNuIhreJROMbUbbxo9R4YQuwFIBFt/1/6wv2zFquP8Qvn8tqgd\n\tYLFh3QAW6iXSkOXImjFw9Sych9IWH2qmp0wjuF06iMQGNTKRQhTJ6csTkwTsWQ7UG5L/\n\tnpun47JPG/ufr59B/ftmIeS+Q3paVbflFBiLvmJW2NojAZctNmPL7uLPGrD04n9WoVoF\n\t7Uj2Un4zjpUnG58/EtnV0m2sEn2nsZZy7rypXPWA+Zcyize0LC0lAMfeilVkUKQK3Lfy\n\tE1uw==","X-Gm-Message-State":"APjAAAVuOxg++BPfcPtQnzPmF4FmKU8KBbS1UUp3S6pNSKTA9MyLa+tF\n\tTBzpar4M5e+TOTYPFH7hV+1rHgjYQ9Q=","X-Google-Smtp-Source":"APXvYqxtgU+qHjJj5/PPZ8wTKlDTFBftoK8JT+glbG6OjAzqYzwE0K4a+uphGk2CCANvx0vvUf/WCQ==","X-Received":"by 2002:ac2:414b:: with SMTP id\n\tc11mr1515573lfi.159.1568713099414; \n\tTue, 17 Sep 2019 02:38:19 -0700 (PDT)","Date":"Tue, 17 Sep 2019 11:38:18 +0200","From":"Niklas =?iso-8859-1?q?S=F6derlund?= ","To":"Laurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","Message-ID":"<20190917093818.GD15610@bigcity.dyn.berto.se>","References":"<20190916201435.29329-1-laurent.pinchart@ideasonboard.com>","MIME-Version":"1.0","Content-Type":"text/plain; charset=iso-8859-1","Content-Disposition":"inline","Content-Transfer-Encoding":"8bit","In-Reply-To":"<20190916201435.29329-1-laurent.pinchart@ideasonboard.com>","User-Agent":"Mutt/1.12.1 (2019-06-15)","Subject":"Re: [libcamera-devel] [PATCH] clang-format: Don't indent namespaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 17 Sep 2019 09:38:20 -0000"}},{"id":2669,"web_url":"https://patchwork.libcamera.org/comment/2669/","msgid":"","date":"2019-09-17T11:52:37","subject":"Re: [libcamera-devel] [PATCH] clang-format: Don't indent namespaces","submitter":{"id":4,"url":"https://patchwork.libcamera.org/api/people/4/","name":"Kieran Bingham","email":"kieran.bingham@ideasonboard.com"},"content":"Hi Laurent,\n\nOn 17/09/2019 10:38, Niklas Söderlund wrote:\n> Hi Laurent,\n> \n> Thanks for your work.\n> \n> On 2019-09-16 23:14:35 +0300, Laurent Pinchart wrote:\n>> Our coding style don't indent namespace contents. Update .clang-format\n\ns/don't/doesn't/\n\n>> accordingly.\n>>\n>> Signed-off-by: Laurent Pinchart \n> \n> Reviewed-by: Niklas Söderlund \n\n\nThis one gets an extra \\o/ !\n\n\\o/-by: Kieran Bingham \n\n\n> \n>> ---\n>> .clang-format | 2 +-\n>> 1 file changed, 1 insertion(+), 1 deletion(-)\n>>\n>> diff --git a/.clang-format b/.clang-format\n>> index 7c5f7b00b3ee..0f4d2b52e848 100644\n>> --- a/.clang-format\n>> +++ b/.clang-format\n>> @@ -80,7 +80,7 @@ KeepEmptyLinesAtTheStartOfBlocks: false\n>> MacroBlockBegin: ''\n>> MacroBlockEnd: ''\n>> MaxEmptyLinesToKeep: 1\n>> -NamespaceIndentation: Inner\n>> +NamespaceIndentation: None\n>> #ObjCBinPackProtocolList: Auto # Unknown to clang-format-5.0\n>> ObjCBlockIndentWidth: 8\n>> ObjCSpaceAfterProperty: true\n>> -- \n>> Regards,\n>>\n>> Laurent Pinchart\n>>\n>> _______________________________________________\n>> libcamera-devel mailing list\n>> libcamera-devel@lists.libcamera.org\n>> https://lists.libcamera.org/listinfo/libcamera-devel\n>","headers":{"Return-Path":"","Received":["from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[IPv6:2001:4b98:dc2:55:216:3eff:fef7:d647])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 9CD9860BB2\n\tfor ;\n\tTue, 17 Sep 2019 13:52:40 +0200 (CEST)","from [192.168.0.20]\n\t(cpc89242-aztw30-2-0-cust488.18-1.cable.virginm.net [86.31.129.233])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 03900528;\n\tTue, 17 Sep 2019 13:52:39 +0200 (CEST)"],"DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1568721160;\n\tbh=poCin3mxDex1c5thruDFqOxSc1bBCFa9pVxBuuWrp4g=;\n\th=Reply-To:Subject:To:Cc:References:From:Date:In-Reply-To:From;\n\tb=YJZCTdCThw+/yqMe+KwCDIAfwxUSna6eUh/UrF6eeh8hXB7hTAns2q3vgwVzLjzMd\n\tWP6UpzZ6jsev/XuBBPOq0WXDO4paVnPWOLcktlBgKO/gJO15cIbDbfqfdeDtBZNVk2\n\tBPZENlpD+HK5+4e6IZgn65/dbV6tG+XZOJVkHzH8=","Reply-To":"kieran.bingham@ideasonboard.com","To":"=?utf-8?q?Niklas_S=C3=B6derlund?= ,\n\tLaurent Pinchart ","Cc":"libcamera-devel@lists.libcamera.org","References":"<20190916201435.29329-1-laurent.pinchart@ideasonboard.com>\n\t<20190917093818.GD15610@bigcity.dyn.berto.se>","From":"Kieran Bingham ","Openpgp":"preference=signencrypt","Autocrypt":"addr=kieran.bingham@ideasonboard.com; keydata=\n\tmQINBFYE/WYBEACs1PwjMD9rgCu1hlIiUA1AXR4rv2v+BCLUq//vrX5S5bjzxKAryRf0uHat\n\tV/zwz6hiDrZuHUACDB7X8OaQcwhLaVlq6byfoBr25+hbZG7G3+5EUl9cQ7dQEdvNj6V6y/SC\n\trRanWfelwQThCHckbobWiQJfK9n7rYNcPMq9B8e9F020LFH7Kj6YmO95ewJGgLm+idg1Kb3C\n\tpotzWkXc1xmPzcQ1fvQMOfMwdS+4SNw4rY9f07Xb2K99rjMwZVDgESKIzhsDB5GY465sCsiQ\n\tcSAZRxqE49RTBq2+EQsbrQpIc8XiffAB8qexh5/QPzCmR4kJgCGeHIXBtgRj+nIkCJPZvZtf\n\tKr2EAbc6tgg6DkAEHJb+1okosV09+0+TXywYvtEop/WUOWQ+zo+Y/OBd+8Ptgt1pDRyOBzL8\n\tRXa8ZqRf0Mwg75D+dKntZeJHzPRJyrlfQokngAAs4PaFt6UfS+ypMAF37T6CeDArQC41V3ko\n\tlPn1yMsVD0p+6i3DPvA/GPIksDC4owjnzVX9kM8Zc5Cx+XoAN0w5Eqo4t6qEVbuettxx55gq\n\t8K8FieAjgjMSxngo/HST8TpFeqI5nVeq0/lqtBRQKumuIqDg+Bkr4L1V/PSB6XgQcOdhtd36\n\tOe9X9dXB8YSNt7VjOcO7BTmFn/Z8r92mSAfHXpb07YJWJosQOQARAQABtDBLaWVyYW4gQmlu\n\tZ2hhbSA8a2llcmFuLmJpbmdoYW1AaWRlYXNvbmJvYXJkLmNvbT6JAlcEEwEKAEECGwMFCwkI\n\tBwIGFQgJCgsCBBYCAwECHgECF4ACGQEWIQSQLdeYP70o/eNy1HqhHkZyEKRh/QUCXWTtygUJ\n\tCyJXZAAKCRChHkZyEKRh/f8dEACTDsbLN2nioNZMwyLuQRUAFcXNolDX48xcUXsWS2QjxaPm\n\tVsJx8Uy8aYkS85mdPBh0C83OovQR/OVbr8AxhGvYqBs3nQvbWuTl/+4od7DfK2VZOoKBAu5S\n\tQK2FYuUcikDqYcFWJ8DQnubxfE8dvzojHEkXw0sA4igINHDDFX3HJGZtLio+WpEFQtCbfTAG\n\tYZslasz1YZRbwEdSsmO3/kqy5eMnczlm8a21A3fKUo3g8oAZEFM+f4DUNzqIltg31OAB/kZS\n\tenKZQ/SWC8PmLg/ZXBrReYakxXtkP6w3FwMlzOlhGxqhIRNiAJfXJBaRhuUWzPOpEDE9q5YJ\n\tBmqQL2WJm1VSNNVxbXJHpaWMH1sA2R00vmvRrPXGwyIO0IPYeUYQa3gsy6k+En/aMQJd27dp\n\taScf9am9PFICPY5T4ppneeJLif2lyLojo0mcHOV+uyrds9XkLpp14GfTkeKPdPMrLLTsHRfH\n\tfA4I4OBpRrEPiGIZB/0im98MkGY/Mu6qxeZmYLCcgD6qz4idOvfgVOrNh+aA8HzIVR+RMW8H\n\tQGBN9f0E3kfwxuhl3omo6V7lDw8XOdmuWZNC9zPq1UfryVHANYbLGz9KJ4Aw6M+OgBC2JpkD\n\thXMdHUkC+d20dwXrwHTlrJi1YNp6rBc+xald3wsUPOZ5z8moTHUX/uPA/qhGsbkCDQRWBP1m\n\tARAAzijkb+Sau4hAncr1JjOY+KyFEdUNxRy+hqTJdJfaYihxyaj0Ee0P0zEi35CbE6lgU0Uz\n\ttih9fiUbSV3wfsWqg1Ut3/5rTKu7kLFp15kF7eqvV4uezXRD3Qu4yjv/rMmEJbbD4cTvGCYI\n\td6MDC417f7vK3hCbCVIZSp3GXxyC1LU+UQr3fFcOyCwmP9vDUR9JV0BSqHHxRDdpUXE26Dk6\n\tmhf0V1YkspE5St814ETXpEus2urZE5yJIUROlWPIL+hm3NEWfAP06vsQUyLvr/GtbOT79vXl\n\tEn1aulcYyu20dRRxhkQ6iILaURcxIAVJJKPi8dsoMnS8pB0QW12AHWuirPF0g6DiuUfPmrA5\n\tPKe56IGlpkjc8cO51lIxHkWTpCMWigRdPDexKX+Sb+W9QWK/0JjIc4t3KBaiG8O4yRX8ml2R\n\t+rxfAVKM6V769P/hWoRGdgUMgYHFpHGSgEt80OKK5HeUPy2cngDUXzwrqiM5Sz6Od0qw5pCk\n\tNlXqI0W/who0iSVM+8+RmyY0OEkxEcci7rRLsGnM15B5PjLJjh1f2ULYkv8s4SnDwMZ/kE04\n\t/UqCMK/KnX8pwXEMCjz0h6qWNpGwJ0/tYIgQJZh6bqkvBrDogAvuhf60Sogw+mH8b+PBlx1L\n\toeTK396wc+4c3BfiC6pNtUS5GpsPMMjYMk7kVvEAEQEAAYkCJQQYAQoADwIbDAUCWcOUawUJ\n\tB4D+AgAKCRChHkZyEKRh/XJhEACr5iidt/0MZ0rWRMCbZFMWD7D2g6nZeOp+F2zY8CEUW+sd\n\tCDVd9BH9QX9KN5SZo6YtJzMzSzpcx45VwTvtQW0n/6Eujg9EUqblfU9xqvqDmbjEapr5d/OL\n\t21GTALb0owKhA5qDUGEcKGCphpQffKhTNo/BP99jvmJUj7IPSKH97qPypi8/ym8bAxB+uY31\n\tgHTMHf1jMJJ1pRo2tYYPeIIHGDqXBI4sp5GHHF+JcIhgR/e/A6w/dgzHYmQPl2ix5eZYEZbV\n\tTRP+gkX4NV8oHqa/lR+xPOlWElGB57viOSOoWriqxQbFy8XbG1GR8cWlkNtGBGVWaJaSoORP\n\tiowD7irXL91bCyFIqL+7BVk3Jy4uzP744PzE80KwxOp5SQAp9sPzFbgsJrLev90PZySjFHG0\n\twP144DK7nBjOj/J0g9OHVASP1JjK+nw7SDoKnETDIdRC0XmiHXk7TXzPdkvO0UkpHdEPjZUp\n\tWyuc0MqehjR/hTTPt4m/Y14XzEcy6JREIjOrFfUZVho2QpOdv9CNryGdieRTNjUtz463CIaZ\n\tdPBiw9mOMBoNffkn9FIoCjLnAaj9gUAnEHWBZOEviQ5NuyqpeP0YtzI4iaRbSUkYZHej99X3\n\tVmHrdLlMqd/ZgYYbPGSL4AN3FVACb5CxuxEHwo029VcE5U3CSjzqtCoX12tm7A==","Organization":"Ideas on Board","Message-ID":"","Date":"Tue, 17 Sep 2019 12:52:37 +0100","User-Agent":"Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101\n\tThunderbird/60.8.0","MIME-Version":"1.0","In-Reply-To":"<20190917093818.GD15610@bigcity.dyn.berto.se>","Content-Type":"text/plain; charset=utf-8","Content-Language":"en-GB","Content-Transfer-Encoding":"8bit","Subject":"Re: [libcamera-devel] [PATCH] clang-format: Don't indent namespaces","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.23","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","X-List-Received-Date":"Tue, 17 Sep 2019 11:52:40 -0000"}}]