{"id":19755,"url":"https://patchwork.libcamera.org/api/patches/19755/?format=json","web_url":"https://patchwork.libcamera.org/patch/19755/","project":{"id":1,"url":"https://patchwork.libcamera.org/api/projects/1/?format=json","name":"libcamera","link_name":"libcamera","list_id":"libcamera_core","list_email":"libcamera-devel@lists.libcamera.org","web_url":"","scm_url":"","webscm_url":""},"msgid":"<20240319120517.362082-15-stefan.klug@ideasonboard.com>","date":"2024-03-19T12:05:15","name":"[v3,14/16] pipeline: rkisp1: Add more debug logging","commit_ref":null,"pull_url":null,"state":"new","archived":false,"hash":"017324b6b2f923faa8e29ebda4962c889396ad8e","submitter":{"id":184,"url":"https://patchwork.libcamera.org/api/people/184/?format=json","name":"Stefan Klug","email":"stefan.klug@ideasonboard.com"},"delegate":null,"mbox":"https://patchwork.libcamera.org/patch/19755/mbox/","series":[{"id":4230,"url":"https://patchwork.libcamera.org/api/series/4230/?format=json","web_url":"https://patchwork.libcamera.org/project/libcamera/list/?series=4230","date":"2024-03-19T12:05:01","name":"Preparation for per-frame-controls and initial tests","version":3,"mbox":"https://patchwork.libcamera.org/series/4230/mbox/"}],"comments":"https://patchwork.libcamera.org/api/patches/19755/comments/","check":"pending","checks":"https://patchwork.libcamera.org/api/patches/19755/checks/","tags":{},"headers":{"Return-Path":"","X-Original-To":"parsemail@patchwork.libcamera.org","Delivered-To":"parsemail@patchwork.libcamera.org","Received":["from lancelot.ideasonboard.com (lancelot.ideasonboard.com\n\t[92.243.16.209])\n\tby patchwork.libcamera.org (Postfix) with ESMTPS id AE95DC32CA\n\tfor ;\n\tTue, 19 Mar 2024 12:05:47 +0000 (UTC)","from lancelot.ideasonboard.com (localhost [IPv6:::1])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTP id 6E5F263055;\n\tTue, 19 Mar 2024 13:05:47 +0100 (CET)","from perceval.ideasonboard.com (perceval.ideasonboard.com\n\t[213.167.242.64])\n\tby lancelot.ideasonboard.com (Postfix) with ESMTPS id 02AA962D33\n\tfor ;\n\tTue, 19 Mar 2024 13:05:31 +0100 (CET)","from jasper.fritz.box (unknown\n\t[IPv6:2a00:6020:448c:6c00:1478:344b:8fcb:baf5])\n\tby perceval.ideasonboard.com (Postfix) with ESMTPSA id 5160DF02;\n\tTue, 19 Mar 2024 13:05:04 +0100 (CET)"],"Authentication-Results":"lancelot.ideasonboard.com; dkim=pass (1024-bit key;\n\tunprotected) header.d=ideasonboard.com header.i=@ideasonboard.com\n\theader.b=\"XvbGxiUG\"; dkim-atps=neutral","DKIM-Signature":"v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com;\n\ts=mail; t=1710849904;\n\tbh=TN69nrXh+FZ9LrbBYsdiBRy2H8uwrQH5cjkM8gmFPA8=;\n\th=From:To:Cc:Subject:Date:In-Reply-To:References:From;\n\tb=XvbGxiUGv5r6Qm4wlifW/heLrL1DWEAitRGeiyt7BjkU/sXRolgVG/3A2+AcFwhi6\n\tIcJl1vIB0vPCf5EnG9bkiFUgte5U8JSgNC5Qf6VtgrRJeE+4b2qzdhbWLjIMp0yiHI\n\tpUeoefEHpHkoNGHouO5RieM9ql8q7dz2Dk/yiQ6Y=","From":"Stefan Klug ","To":"libcamera-devel@lists.libcamera.org","Cc":"Stefan Klug ","Subject":"[PATCH v3 14/16] pipeline: rkisp1: Add more debug logging","Date":"Tue, 19 Mar 2024 13:05:15 +0100","Message-Id":"<20240319120517.362082-15-stefan.klug@ideasonboard.com>","X-Mailer":"git-send-email 2.40.1","In-Reply-To":"<20240319120517.362082-1-stefan.klug@ideasonboard.com>","References":"<20240319120517.362082-1-stefan.klug@ideasonboard.com>","MIME-Version":"1.0","Content-Transfer-Encoding":"8bit","X-BeenThere":"libcamera-devel@lists.libcamera.org","X-Mailman-Version":"2.1.29","Precedence":"list","List-Id":"","List-Unsubscribe":",\n\t","List-Archive":"","List-Post":"","List-Help":"","List-Subscribe":",\n\t","Errors-To":"libcamera-devel-bounces@lists.libcamera.org","Sender":"\"libcamera-devel\" "},"content":"Signed-off-by: Stefan Klug \n---\n src/ipa/rkisp1/algorithms/agc.cpp | 4 ++--\n src/ipa/rkisp1/rkisp1.cpp | 2 ++\n 2 files changed, 4 insertions(+), 2 deletions(-)","diff":"diff --git a/src/ipa/rkisp1/algorithms/agc.cpp b/src/ipa/rkisp1/algorithms/agc.cpp\nindex 47a6f7b2..f737ba92 100644\n--- a/src/ipa/rkisp1/algorithms/agc.cpp\n+++ b/src/ipa/rkisp1/algorithms/agc.cpp\n@@ -125,14 +125,14 @@ void Agc::queueRequest(IPAContext &context,\n \t\t\t\t / context.configuration.sensor.lineDuration;\n \n \t\tLOG(RkISP1Agc, Debug)\n-\t\t\t<< \"Set exposure to \" << agc.manual.exposure;\n+\t\t\t<< \"Set manual exposure to \" << agc.manual.exposure;\n \t}\n \n \tconst auto &gain = controls.get(controls::AnalogueGain);\n \tif (gain && !agc.autoEnabled) {\n \t\tagc.manual.gain = *gain;\n \n-\t\tLOG(RkISP1Agc, Debug) << \"Set gain to \" << agc.manual.gain;\n+\t\tLOG(RkISP1Agc, Debug) << \"Set manual gain to \" << agc.manual.gain;\n \t}\n \n \tframeContext.agc.autoEnabled = agc.autoEnabled;\ndiff --git a/src/ipa/rkisp1/rkisp1.cpp b/src/ipa/rkisp1/rkisp1.cpp\nindex 44d03eb8..6bc09198 100644\n--- a/src/ipa/rkisp1/rkisp1.cpp\n+++ b/src/ipa/rkisp1/rkisp1.cpp\n@@ -314,6 +314,7 @@ void IPARkISP1::unmapBuffers(const std::vector &ids)\n void IPARkISP1::queueRequest(const uint32_t frame, const ControlList &controls)\n {\n \tIPAFrameContext &frameContext = context_.frameContexts.alloc(frame);\n+\tLOG(IPARkISP1, Debug) << \"queueRequest: \" << frame;\n \n \tfor (auto const &a : algorithms()) {\n \t\tAlgorithm *algo = static_cast(a.get());\n@@ -354,6 +355,7 @@ void IPARkISP1::processStatsBuffer(const uint32_t frame, const uint32_t bufferId\n \t\tstats = reinterpret_cast(\n \t\t\tmappedBuffers_.at(bufferId).planes()[0].data());\n \n+\tLOG(IPARkISP1, Debug) << \"processStatsBuffer for frame \" << frame;\n \tframeContext.sensor.exposure =\n \t\tsensorControls.get(V4L2_CID_EXPOSURE).get();\n \tframeContext.sensor.gain =\n","prefixes":["v3","14/16"]}